[Koha-bugs] [Bug 37309] Improve Delete and Modify items links on the biblio detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37309 Pedro Amorim changed: What|Removed |Added Attachment #168844|0 |1 is obsolete|| --- Comment #12 from Pedro Amorim --- Created attachment 168848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168848=edit Bug 37309: Clear itemnumbers array before 'select all' Otherwise the same itemnumber can appear several times in the array. It could be moved to its own bug but this is only code cleaning it seems, there is no impact on the UX Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37309] Improve Delete and Modify items links on the biblio detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37309 Pedro Amorim changed: What|Removed |Added Attachment #168799|0 |1 is obsolete|| --- Comment #11 from Pedro Amorim --- Created attachment 168847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168847=edit Bug 37309: Fix behaviour when SeparateHoldings is in use Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37309] Improve Delete and Modify items links on the biblio detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37309 Pedro Amorim changed: What|Removed |Added Attachment #168798|0 |1 is obsolete|| --- Comment #10 from Pedro Amorim --- Created attachment 168846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168846=edit Bug 37309: (follow-up) Adjust appearance of controls This patch makes an adjustment to the style of .btn-link controls associated with the holdings table. I've also updated the markup of the other controls so that they match the updated batch controls. Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37309] Improve Delete and Modify items links on the biblio detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37309
Pedro Amorim changed:
What|Removed |Added
Attachment #168797|0 |1
is obsolete||
--- Comment #9 from Pedro Amorim ---
Created attachment 168845
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168845=edit
Bug 37309: Improve Delete and Modify items links on the biblio detail page
The way the "Delete selected items" and "Modify selected items" links
are build on the bibliographic detail page is not nice. We could do
better, for instance using a proper form element instead of building an
URL.
Test plan:
Go to the detail page of a bibliographic record which has several items.
In the items table check some checkboxes and play with "select all",
"clear all" and the action buttons.
Notice that everything works as before.
Minor UI regression that must be fixed: there are CSS rules that cause
problem. When the action links are displayed or hidden the table is
moving up and down.
I think the problematic rules are:
.btn {
padding: 6px 12px;
font-size: 12px;
}
It makes the UI better if I remove them but still get the bumping
issue.
Signed-off-by: Owen Leonard
Signed-off-by: Pedro Amorim
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37309] Improve Delete and Modify items links on the biblio detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37309 Pedro Amorim changed: What|Removed |Added Attachment #168802|0 |1 is obsolete|| --- Comment #8 from Pedro Amorim --- Created attachment 168844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168844=edit Bug 37309: Clear itemnumbers array before 'select all' Otherwise the same itemnumber can appear several times in the array. It could be moved to its own bug but this is only code cleaning it seems, there is no impact on the UX Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37309] Improve Delete and Modify items links on the biblio detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37309 Pedro Amorim changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37309] Improve Delete and Modify items links on the biblio detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37309 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37309] Improve Delete and Modify items links on the biblio detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37309 --- Comment #7 from Jonathan Druart --- Created attachment 168802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168802=edit Bug 37309: Clear itemnumbers array before 'select all' Otherwise the same itemnumber can appear several times in the array. It could be moved to its own bug but this is only code cleaning it seems, there is no impact on the UX -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37309] Improve Delete and Modify items links on the biblio detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37309 --- Comment #6 from Jonathan Druart --- Created attachment 168799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168799=edit Bug 37309: Fix behaviour when SeparateHoldings is in use -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37309] Improve Delete and Modify items links on the biblio detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37309 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #5 from Jonathan Druart --- Thanks a lot, Owen. I found some bugs retesting this however. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37309] Improve Delete and Modify items links on the biblio detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37309 --- Comment #4 from Owen Leonard --- Created attachment 168798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168798=edit Bug 37309: (follow-up) Adjust appearance of controls This patch makes an adjustment to the style of .btn-link controls associated with the holdings table. I've also updated the markup of the other controls so that they match the updated batch controls. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37309] Improve Delete and Modify items links on the biblio detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37309
Owen Leonard changed:
What|Removed |Added
Attachment #168777|0 |1
is obsolete||
--- Comment #3 from Owen Leonard ---
Created attachment 168797
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168797=edit
Bug 37309: Improve Delete and Modify items links on the biblio detail page
The way the "Delete selected items" and "Modify selected items" links
are build on the bibliographic detail page is not nice. We could do
better, for instance using a proper form element instead of building an
URL.
Test plan:
Go to the detail page of a bibliographic record which has several items.
In the items table check some checkboxes and play with "select all",
"clear all" and the action buttons.
Notice that everything works as before.
Minor UI regression that must be fixed: there are CSS rules that cause
problem. When the action links are displayed or hidden the table is
moving up and down.
I think the problematic rules are:
.btn {
padding: 6px 12px;
font-size: 12px;
}
It makes the UI better if I remove them but still get the bumping
issue.
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37309] Improve Delete and Modify items links on the biblio detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37309 Jonathan Druart changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com, oleon...@myacpl.org --- Comment #2 from Jonathan Druart --- Owen, can I get some help to fix the UI glitches? See the commit message. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37309] Improve Delete and Modify items links on the biblio detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37309
--- Comment #1 from Jonathan Druart ---
Created attachment 168777
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168777=edit
Bug 37309: Improve Delete and Modify items links on the biblio detail page
The way the "Delete selected items" and "Modify selected items" links are build
on the bibliographic detail page is not nice. We could do better, for instance
using a proper form element instead of building an URL.
Test plan:
Go to the detail page of a bibliographic record which has several items.
In the items table check some checkboxes and play with "select all",
"clear all" and the action buttons.
Notice that everything works as before.
Minor UI regression that must be fixed: there are CSS rules that cause
problem. When the action links are displayed or hidden the table is
moving up and down.
I think the problematic rules are:
.btn {
padding: 6px 12px;
font-size: 12px;
}
It makes the UI better if I remove them but still get the bumping
issue.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37309] Improve Delete and Modify items links on the biblio detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37309 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37309] Improve Delete and Modify items links on the biblio detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37309 Phil Ringnalda changed: What|Removed |Added CC||p...@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37309] Improve Delete and Modify items links on the biblio detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37309 Pedro Amorim changed: What|Removed |Added CC||pedro.amo...@ptfs-europe.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
