[Koha-bugs] [Bug 37333] Search filters using OR are not correctly grouped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37333 Martin Renvoize changed: What|Removed |Added Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37333] Search filters using OR are not correctly grouped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37333 Martin Renvoize changed: What|Removed |Added CC|martin.renvoize@ptfs-europe | |.com| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37333] Search filters using OR are not correctly grouped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37333 --- Comment #11 from Martin Renvoize --- Created attachment 169308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169308&action=edit Bug 37333: (follow-up) Update existing tests We add a level of bracket nesting. I checked with Nick that this shouldn't cause any issues in the queries and we agreed it made sense so I've gone ahead and updated the tests to reflect the change. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37333] Search filters using OR are not correctly grouped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37333 --- Comment #10 from Janusz Kaczmarek --- (In reply to Martin Renvoize from comment #9) > My hunch is that it's OK and we just need to update the tests, but i wanted > him to confirm that before I went ahead and did that. Yes, I agree, this is probably just about updating the test patterns. Now this stops my playing around with QueryBuilder.t ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37333] Search filters using OR are not correctly grouped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37333 Martin Renvoize changed: What|Removed |Added Keywords||additional_work_needed --- Comment #9 from Martin Renvoize --- Correct; I've already asked Nick to take a look. My hunch is that it's OK and we just need to update the tests, but i wanted him to confirm that before I went ahead and did that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37333] Search filters using OR are not correctly grouped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37333 Janusz Kaczmarek changed: What|Removed |Added CC||janus...@gmail.com --- Comment #8 from Janusz Kaczmarek --- It seems that after applying this patch the test: t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t fails :( The patch adds an additional level of parentheses which in turn makes "Handle search filters" section fail in 4 subtests. Could you confirm this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37333] Search filters using OR are not correctly grouped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37333 --- Comment #7 from Katrin Fischer --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37333] Search filters using OR are not correctly grouped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37333 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||24.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37333] Search filters using OR are not correctly grouped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37333 --- Comment #6 from Katrin Fischer --- Unit tests! \o/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37333] Search filters using OR are not correctly grouped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37333 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize --- Thanks Nick, patch I see is trivial, but it's great to see the mammoth set to unit tests to go with it. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37333] Search filters using OR are not correctly grouped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37333 Martin Renvoize changed: What|Removed |Added Attachment #168894|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 169099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169099&action=edit Bug 37333: Group search terms in a saved filter This patch surrounds the expanded query of a search filter in parnetheses to correctly group the terms when searching To test: 1 - Enable system preference SavedSearchFilters 2 - In staff client, perform an advanced search for: subject:internet OR subject:programming 3 - Note results 4 - Save search as filter, enabled in staff client and opac 5 - Search for 'a' 6 - Apply filter from top of facets on left hand side 7 - Note results didn't change 8 - Apply patch, restart all 9 - Reload search, it now limits correctly 10 - Test on OPAC 11 - Test on both Zebra and Elastic 12 - Sign off :-) Signed-off-by: Jake Deery Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37333] Search filters using OR are not correctly grouped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37333 Jake Deery changed: What|Removed |Added CC||jake.de...@ptfs-europe.com Status|Needs Signoff |Signed Off --- Comment #3 from Jake Deery --- Hi Nick, All looks good to me. I can see before vs. after on the results page: - 11 result(s) found for 'kw,wrdl: a' with limit(s): 'and su=(internet) OR su=(programming)'. + 11 result(s) found for 'kw,wrdl: a' with limit(s): 'and (su=(internet) OR su=(programming))'. … and the results do change, now closer to what I think is correct, and definitely in a more concice order. Probably need a search nerd to QA this, but for now, here is my sign-off, with thanks! Jake -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37333] Search filters using OR are not correctly grouped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37333 Jake Deery changed: What|Removed |Added Attachment #168864|0 |1 is obsolete|| --- Comment #2 from Jake Deery --- Created attachment 168894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168894&action=edit Bug 37333: Group search terms in a saved filter This patch surrounds the expanded query of a search filter in parnetheses to correctly group the terms when searching To test: 1 - Enable system preference SavedSearchFilters 2 - In staff client, perform an advanced search for: subject:internet OR subject:programming 3 - Note results 4 - Save search as filter, enabled in staff client and opac 5 - Search for 'a' 6 - Apply filter from top of facets on left hand side 7 - Note results didn't change 8 - Apply patch, restart all 9 - Reload search, it now limits correctly 10 - Test on OPAC 11 - Test on both Zebra and Elastic 12 - Sign off :-) Signed-off-by: Jake Deery -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37333] Search filters using OR are not correctly grouped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37333 Nick Clemens (kidclamp) changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37333] Search filters using OR are not correctly grouped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37333 --- Comment #1 from Nick Clemens (kidclamp) --- Created attachment 168864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168864&action=edit Bug 37333: Group search terms in a saved filter This patch surrounds the expanded query of a search filter in parnetheses to correctly group the terms when searching To test: 1 - Enable system preference SavedSearchFilters 2 - In staff client, perform an advanced search for: subject:internet OR subject:programming 3 - Note results 4 - Save search as filter, enabled in staff client and opac 5 - Search for 'a' 6 - Apply filter from top of facets on left hand side 7 - Note results didn't change 8 - Apply patch, restart all 9 - Reload search, it now limits correctly 10 - Test on OPAC 11 - Test on both Zebra and Elastic 12 - Sign off :-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37333] Search filters using OR are not correctly grouped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37333 Nick Clemens (kidclamp) changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
