[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitai...@ccsr.qc.
   ||ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #18162|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |RESOLVED
 Resolution|--- |FIXED

--- Comment #34 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I have opened bug 10266 for the new patch and passed QA on the patch there. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

--- Comment #33 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Liz, I think it's still better to open a new bug when a new problem arises
and link it to the old one. If Rafal doesn't beat me to it, I will do it later
when doing QA.

My reasoning is that this has been pushed to a long released version of Koha
and it takes a lot of time to process bugs like this when you are testing
because there are so many comments and other things to look for. Also we have
many different people working on this, a new bug is really cleaner.

If the same patch works on master I would say we should use it for now. It
looks like an easy fix to a longer existing problem and we shouldn't force
people to rewrite lots of code in that case.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Depends on||10266

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

--- Comment #26 from Rafal r...@poczta.onet.pl ---
Created attachment 18158
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18158action=edit
Proposed fix

This path should fix display Statuses in OPAC.
Patch is for master, but bug appear in all versions from 3.8+.

Thi is my first patch so let me know if something's wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

--- Comment #27 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
(In reply to comment #26)
 Created attachment 18158 [details] [review]
I think this is a new bug.
And it should use KohaAuthorisedValues template plugin on restricted data.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #28 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Rafal,

thank you for your patch! We are always very happy about new developers.

Let me try to help you to get this into Koha :)

This bug has the status pushed to stable which means it's basically done and
resolved. If it has a 'Pushed...' status it's always better to file a new bug.

The new bug should have a good description and ideally a test plan that shows
people how to reproduce the problem you are trying to fix. The version should
be set to master, if it's not a problem that's specific to an older version.
Make sure you assign (Assiged to:) the bug to yourself and that you switch the
bug status to 'Needs Signoff', which means it's waiting for someone to test.

You can find some information about a bug's life cycle and the different status
here: http://wiki.koha-community.org/wiki/Bug-enhancement-patch_Workflow

If you have questions, or need some pointers, or just want to get to know us, I
would recommend jumping into the IRC channel. There is almost always someone
around willing to help.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

Liz Rea l...@catalyst.net.nz changed:

   What|Removed |Added

 Status|Pushed to Stable|ASSIGNED

--- Comment #29 from Liz Rea l...@catalyst.net.nz ---
It does say patch pushed, but I have observed this still not working correctly
- so I'm going to test this patch anyway, and will upload one with the
requirements as an example if it fixes the issue.

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

Liz Rea l...@catalyst.net.nz changed:

   What|Removed |Added

  Attachment #11132|0   |1
is obsolete||
  Attachment #11135|0   |1
is obsolete||
  Attachment #12010|0   |1
is obsolete||
  Attachment #18158|0   |1
is obsolete||

--- Comment #30 from Liz Rea l...@catalyst.net.nz ---
Created attachment 18161
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18161action=edit
Bug 4173 - Statuses not appearing in the OPAC Simply revert order of 2 lines in
Items.pm. Previous line write to variable used in next line as function
argument.

To Test:

Give an item a special restricted value, define one if you have to in the
authorised values.
Observe that, without this patch, statuses are not shown in the OPAC in
parentheses. My example was an item that had a restricted value of Library
Staff Only
It should have been shown under status on the detail page of the OPAC, but was
not.

Apply the patch, observe that restricted values are now shown for your item,
for example:
Available (Library Staff Only) in the status column.

Signed-off-by: Liz Rea l...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

Liz Rea l...@catalyst.net.nz changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

Liz Rea l...@catalyst.net.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

--- Comment #31 from Liz Rea l...@catalyst.net.nz ---
This last patch is going to be for 3.8 only, as 3.10+ have the plugin.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

Liz Rea l...@catalyst.net.nz changed:

   What|Removed |Added

  Attachment #18161|0   |1
is obsolete||

--- Comment #32 from Liz Rea l...@catalyst.net.nz ---
Created attachment 18162
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18162action=edit
[3.8.x] Bug 4173 - Statuses not appearing in the OPAC Simply revert order of 2
lines in Items.pm. Previous line write to variable used in next line as
function argument.

To Test:

Give an item a special restricted value, define one if you have to in the
authorised values.
Observe that, without this patch, statuses are not shown in the OPAC in
parentheses. My example was an item that had a restricted value of Library
Staff Only
It should have been shown under status on the detail page of the OPAC, but was
not.

Apply the patch, observe that restricted values are now shown for your item,
for example:
Available (Library Staff Only) in the status column.

Signed-off-by: Liz Rea l...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

Liz Rea l...@catalyst.net.nz changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #25 from Liz Rea l...@catalyst.net.nz ---
It looks like restricted statuses are still not shown. 

I actually have a use case for them now - 

A library wants to show that an item is ask a librarian - it's not lost, it's
not not for loan, they just want to indicate that it is restricted access,
and they use the restricted authorised value to show that. People also use it
to denote on order in combination with Not for loan. 

Anyway, I think we have someone willing to sponsor a fix for the restricted
status display - so will file a new bug if that comes to pass.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #24 from Chris Cormack ch...@bigballofwax.co.nz ---
Pushed to 3.8.x will be in 3.8.6

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

--- Comment #23 from Chris Cormack ch...@bigballofwax.co.nz ---
String changes, held until after the string freeze

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||m...@kohaaloha.com

--- Comment #21 from Mason James m...@kohaaloha.com ---
(In reply to comment #18)
 QA comment : I like very much the idea of
 Koha/Template/Plugin/KohaAuthorisedValues.pm
 ... BUT it has no doc at all.
 
 Failing QA for this reason, please provide a follow-up with some doc (it
 will be trivial, I agree, but it's needed)


Kyle has added the needed POD, passing QA on this...

$ koha-qa.pl -c 3

testing 3 commit(s) (applied to commit 60790d0)
 * 8c7b14c Bug 4173: Followup: Document KohaAuthorisedValues plugin
  Koha/Template/Plugin/KohaAuthorisedValues.pm

 * b43f0b9 Bug 4173: Followup: put the lib into a variable
  koha-tmpl/opac-tmpl/prog/en/includes/item-status.inc

 * 1308299 Bug 4173 - Statuses not appearing in the OPAC
  C4/Koha.pm
  Koha/Template/Plugin/KohaAuthorisedValues.pm
  koha-tmpl/opac-tmpl/prog/en/includes/item-status.inc

* Koha/Template/Plugin/KohaAuthorisedValues.pm OK
* C4/Koha.pm   OK
* koha-tmpl/opac-tmpl/prog/en/includes/item-status.inc OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
Version|master  |rel_3_8

--- Comment #22 from Paul Poulain paul.poul...@biblibre.com ---
Patch pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

--- Comment #19 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 12009
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12009action=edit
Bug 4173: Followup: Document KohaAuthorisedValues plugin

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #12009|0   |1
is obsolete||

--- Comment #20 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 12010
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12010action=edit
Bug 4173: Followup: Document KohaAuthorisedValues plugin

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA
 CC||paul.poul...@biblibre.com

--- Comment #18 from Paul Poulain paul.poul...@biblibre.com ---
QA comment : I like very much the idea of
Koha/Template/Plugin/KohaAuthorisedValues.pm
... BUT it has no doc at all.

Failing QA for this reason, please provide a follow-up with some doc (it will
be trivial, I agree, but it's needed)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Priority|PATCH-Sent (DO NOT USE) |P3
 Status|Signed Off  |Passed QA
 CC||m.de.r...@rijksmuseum.nl
 QA Contact|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |

--- Comment #17 from M. de Rooy m.de.r...@rijksmuseum.nl ---
QA Comment:
Code looks good to me. 
Passed QA

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 CC||fridolyn.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #10798|0   |1
is obsolete||

--- Comment #13 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 11132
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11132action=edit
Bug 4173 - Statuses not appearing in the OPAC

For the authorised values LOST and DAMAGED, if an OPAC description
is defined for the given value, display that description in the OPAC
rather than the generic description.

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

--- Comment #14 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 11133
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11133action=edit
Bug 4173: Followup: put the lib into a variable

Kyle,

Could you have a look at this patch please ?
I think if we put the result into a T::T variable, we do just 1 call to
GetAuthorisedValueByCode (instead of 2)

Switch back to needs SO

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #11133|0   |1
is obsolete||

--- Comment #15 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 11135
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11135action=edit
Bug 4173: Followup: put the lib into a variable

Prevent 2 calls instead of 1

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #16 from Kyle M Hall k...@bywatersolutions.com ---
(In reply to comment #14)
 Created attachment 11133 [details]
 Bug 4173: Followup: put the lib into a variable
 
 Kyle,
 
 Could you have a look at this patch please ?
 I think if we put the result into a T::T variable, we do just 1 call to
 GetAuthorisedValueByCode (instead of 2)

A good idea. Every small efficiency helps!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

kyle.m.h...@gmail.com k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|REOPENED|Needs Signoff
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

Melia Meggs me...@bywatersolutions.com changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 CC||me...@bywatersolutions.com
 Resolution|FIXED   |---

--- Comment #10 from Melia Meggs me...@bywatersolutions.com ---
Reopening at Owen's suggestion.

In authorized values, there is a column for Description(OPAC) for Lost, but
even when you fill in the OPAC description column, the item still shows in the
OPAC simply as lost rather than what you write for the description.

I know that for Lost in particular many libraries do not want all of the
different 
lost statuses to show up in the OPAC (for example, the patron doesn't care if
it's long ovedue (lost) or lost - either way they can't have it).

But some libraries that go to the effort of filling in the Description(OPAC)
column would prefer to see the description that they've written.  It seems that
if there is an OPAC description column in the authorized value list, then that
is what you should see in the OPAC.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

--- Comment #11 from Melia Meggs me...@bywatersolutions.com ---
*** Bug 8093 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

Bug 4173 depends on bug 4237, which changed state.

Bug 4237 Summary: Add other item statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4237

   What|Old Value   |New Value

 Status|ASSIGNED|Patch doesn't apply
 Status|Patch doesn't apply |RESOLVED
 Resolution||WONTFIX

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

Mark Gavillet mark.gavil...@ptfs-europe.com changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 CC||mark.gavillet@ptfs-europe.c
   ||om
 Resolution||FIXED

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/