[Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437 --- Comment #20 from Paul Derscheid --- > If I create a new order which exceeds the fund shouldn't I get a JS error on > the page? Did you mean this? https://snipboard.io/KLUjyw.jpg -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437 --- Comment #19 from Paul Derscheid --- Hey oleonard, do you understand what the getAuthValueDropbox fn is even supposed to do? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437 Paul Derscheid changed: What|Removed |Added CC||paul.dersch...@lmscloud.de --- Comment #18 from Paul Derscheid --- You're right! Strange that it didn't show up when I searched for references. I will find out and add to the existing test plan. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #17 from Owen Leonard --- > I deleted the getAuthValueDropbox function It's used in newordertempty.tt, which I don't think is working as it should even if I restore the function. If I create a new order which exceeds the fund shouldn't I get a JS error on the page? Instead I'm redirected to a page with an error message, and if I click the back button the form is empty again. And I don't think I understand how to test checkBudgetParent -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437 Paul Derscheid changed: What|Removed |Added Attachment #63756|0 |1 is obsolete|| --- Comment #16 from Paul Derscheid --- Created attachment 152859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152859&action=edit Bug 4437: acq.js uses XMLHttpRequest() directly; should use jQuery I was too lazy to resolve the merge conflicts so I just rewrote the previous patch. The functions should be functionally equivalent to the ones using XMLHttpRequest, so they should still work as intended in their consumers. I deleted the getAuthValueDropbox function as I couldn't find a single reference in the entire codebase. Correct me if I'm wrong. I also ran the configured formatter on the whole file to clean up the mess. Actual changes in implementation are just in these functions - totalExceedsBudget - budgetExceedsParent - checkBudgetParent We could pontentially follow this up by making async requests instead to prevent blocking behaviour. But this would mean that we need to change the consumers as well. To test: Testing budgetExceedsParent (without patch): 1) Go to Home > Administration > Budgets administration 2) Create a Budget 'Testbudget', give it a value of 100, make it active 3) Add a fund 'Testfund 1', give it a value of 90, save 4) Add a fund 'Testfund 2', give it a value of 20 (exceeds budget), save Result OK: Message box --- Form not submitted because of the following problem(s) --- - Fund amount exceeds period allocation --- Testing budgetExceedsParent (with patch): a) Clear browser cache, restart memcached, plack b) Make sure page is reloaded, repeat step 4) above Result: Not OK, no message box, form saves, period allocated is 100, total available is 110 (should not) 5) Test the other consumers in a similar manor. 6) Sign off. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437 Paul Derscheid changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437 Katrin Fischer changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437 Katrin Fischer changed: What|Removed |Added Status|Failed QA |ASSIGNED Assignee|h...@davenport.net.nz |koha-b...@lists.koha-commun ||ity.org --- Comment #15 from Katrin Fischer --- acq.js appears to be the non-external library that still uses XMLHttpRequest: koha-tmpl/intranet-tmpl/prog/js/acq.js In: totalExceedsBudget() budgetExceedsParent() checkBudgetParent() The others are: koha-tmpl/opac-tmpl/bootstrap/js/Gettext.js koha-tmpl/opac-tmpl/bootstrap/lib/greybox/GreyBox_v5_5/greybox_source/base/AJS.js koha-tmpl/opac-tmpl/bootstrap/lib/jquery/jquery-3.6.0.min.js koha-tmpl/opac-tmpl/lib/verovio/000_acoustic_grand_piano.js koha-tmpl/opac-tmpl/lib/verovio/verovio-toolkit.js I am resetting assignee since this hasn't had an update in several years. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #14 from Marc Véron --- > The budgetExceedsParent is triggered by Check in > koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt Testing budgetExceedsParent (without patch): 1) Go to Home > Administration > Budgets administration 2) Create a Budget 'Testbudget', give it a value of 100, make it active 3) Add a fund 'Testfund 1', give it a value of 90, save 4) Add a fund 'Testfund 2', give it a value of 20 (exceeds budget), save Result OK: Message box --- Form not submitted because of the following problem(s) --- - Fund amount exceeds period allocation --- Testing budgetExceedsParent (with patch): a) Clear browser cache, restart memcached, plack b) Make sure page is reloaded, repeat step 4) above Result: Not OK, no message box, form saves, period allocated is 100, total available is 110 (should not) (Other functions not yet tested) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437 M. Tompsett changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #13 from M. Tompsett --- The totalExceedsBudget is triggered by Check in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt The budgetExceedsParent is triggered by Check in koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt The checkBudgetParent is triggered by Check in koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt NOTE: I have not checked this myself, but should someone write a test plan for novice libarian techies, I will check. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437 M. Tompsett changed: What|Removed |Added Attachment #14649|0 |1 is obsolete|| --- Comment #12 from M. Tompsett --- Created attachment 63756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63756&action=edit Bug 4437: acq.js uses XMLHttpRequest() directly; should use jQuery The acq.js file used a few calls to XMLHttpRequest, which have been changed to use jQuery.ajax instead. The fetchSortDropbox no longer exists, which is why this patch did not apply. However, the other three functions still had direct XMLHttpRequest calls: - totalExceedsBudget - budgetExceedsParent - checkBudgetParent A test plan would require triggering these three javascript functions. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437 --- Comment #11 from M. Tompsett --- Doesn't apply because fetchSortDropbox no longer exists. The other three functional changes should still be possible. Attempting resurrection. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437 --- Comment #10 from M. Tompsett --- (In reply to Marc Véron from comment #9) > Sill valid? Yes. $ git grep -l XMLHttpRequest | grep acq -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch --- Comment #9 from Marc Véron --- Sill valid? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437 --- Comment #8 from Owen Leonard --- A test plan is a simple description of the steps one would take to confirm that a patch works. Usually this means confirming that a patch fixes a particular problem and doesn't cause other problems. Is there a real-world case where this fixes a browser error? If not, you should describe how to test each affected page/action to confirm that the patch hasn't caused any problems. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437 --- Comment #7 from Hugh Davenport --- Hey Owen, What would the format of a test plan be? Cheers, Hugh -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437 Hugh Davenport changed: What|Removed |Added Blocks||9412 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #6 from Owen Leonard --- Can you please add a test plan for this? acq.js is modified in several places, so I assume several different functions are being affected. A test plan will ensure that we test all the changes properly. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437 Hugh Davenport changed: What|Removed |Added Attachment #14646|0 |1 is obsolete|| --- Comment #5 from Hugh Davenport --- Created attachment 14649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14649&action=edit bug 4437 Change XMLHttpRequest calls to jQuery.ajax The acq.js file used a few calls to XMLHttpRequest, which have been changed to use jQuery.ajax instead Signed-off-by: Hugh Davenport -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437 --- Comment #4 from Hugh Davenport --- That file also has a lot of other chunks of code using generic javascript, which should use jQuery when possible, so I reckon this bug should be kept open for that purpose. Cheers, Hugh -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437 --- Comment #3 from Hugh Davenport --- Created attachment 14646 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14646&action=edit bug 4437 Change XMLHttpRequest calls to jQuery.ajax The acq.js file used a few calls to XMLHttpRequest, which have been changed to use jQuery.ajax instead Signed-off-by: Hugh Davenport -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437 Hugh Davenport changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437 Hugh Davenport changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437 Hugh Davenport changed: What|Removed |Added Status|NEW |ASSIGNED CC||h...@davenport.net.nz Assignee|koha-b...@lists.koha-commun |h...@davenport.net.nz |ity.org | --- Comment #2 from Hugh Davenport --- I'm working on this now -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437 Owen Leonard changed: What|Removed |Added Hardware|PC |All Assignee|henridam...@koha-fr.org |koha-b...@lists.koha-commun ||ity.org --- Comment #1 from Owen Leonard --- Issue still exists in master. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
