[Koha-bugs] [Bug 4530] Circulation & fines rules aren't always applied from most specific to less specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4530

Liz Rea  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|In Discussion   |RESOLVED

--- Comment #26 from Liz Rea  ---
This seems to be working now.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4530] Circulation & fines rules aren't always applied from most specific to less specific

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4530

--- Comment #25 from Marc Véron  ---
Still valid?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4530] Circulation fines rules aren't always applied from most specific to less specific

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4530

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4530] Circulation fines rules aren't always applied from most specific to less specific

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4530

mathieu saby mathieu.s...@univ-rennes2.fr changed:

   What|Removed |Added

 CC||mathieu.saby@univ-rennes2.f
   ||r

--- Comment #24 from mathieu saby mathieu.s...@univ-rennes2.fr ---
Is there still a problem with the application of generic/specific circulation
rules?

M. Saby

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4530] Circulation fines rules aren't always applied from most specific to less specific

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4530

--- Comment #23 from Gaetan Boisson gaetan.bois...@biblibre.com ---
I think we really need 0 and NULL to be treated differently. It is important
for instance to define that a type of document cannot be issued to a certain
category of patrons, without falling back on a more generic rule that would
allow it.
Sometimes we also want to define that 0 books of that type can be issued to a
patron category, with a loan period of X days : if we force the loan on an
exceptional basis, the length of the loan will already be defined.

Here is my test plan so far: i have defined 8 rules, matching the 8
possibilities. For every rule i put the same value in each field:

8 for same library, same patron type, same item type
7 for same library, same patron type, all item types
6 for same library, all patron types, same item type
5 for same library, all patron types, all item types
4 for all libraries, same patron type, same item type
3 for all libraries, same patron type, all item types
2 for all libraries, all patron types, same item type
1 for all libraries, all patron types, all item types

the i tweak to put NULL (or 0 at the moment) at different places, loan some
books and see what happens.

So far one thing that turned out not to work out was the number of renewals :
it falls straight back to rule 3, and if i void rule 3 it falls back to rule 1,
ignoring rule 2.

There are a lot of possibilities to test and i am not done yet...

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4530] Circulation fines rules aren't always applied from most specific to less specific

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4530

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

   Attachment #6915|0   |1
is obsolete||

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4530] Circulation fines rules aren't always applied from most specific to less specific

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4530

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

   Priority|PATCH-Sent (DO NOT USE) |P2
 Status|Signed Off  |Failed QA
 CC||francois.charbonnier@biblib
   ||re.com,
   ||gaetan.bois...@biblibre.com
   ||, paul.poul...@biblibre.com

--- Comment #21 from Paul Poulain paul.poul...@biblibre.com 2012-02-17 
17:18:48 UTC ---
QA comments/questions

=== point 1 (and a question) ===
(In reply to comment #3)
 More comprehensive description of rule selection:
 * Rules are chosen in order of preference borrower category, item type,
 branch
 * If value for certain rule is null, next rule in order is chosen
 * 0 is treated as null

does it mean that, if I set the general rule to 7 documents for 21 days, and
set a rule for 
CHILDREN / DVD to 0 it will be treated as NULL and the general rule will be
applied ?
If yes, it's a big change in the behaviour, and, imo, a big mistake = libraries
want to define such rules.
0 should mean 0. I agree we should handle empty as rule unused at this
level

=== point 2 ===
If I understand well your code, the GetIssuingRules relies on
. order by branchcode desc, categorycode desc, itemtype desc;
and the rule returned is the result ordered 1st in this query, right.
Reading what's written on smart-rules.pl:
same library, same patron type, same item type
same library, same patron type, all item types
same library, all patron types, same item type
same library, all patron types, all item types
all libraries, same patron type, same item type
all libraries, same patron type, all item types
all libraries, all patron types, same item type
all libraries, all patron types, all item types

it's consistent with the order.

=== point 3 ===
In CanItemBeReserved, you removed the SQL that was
-   categorycode DESC, 
-   itemtype DESC, 
-   branchcode   DESC;
in favor of GetIssuingRuleRecord, that is 
. order by branchcode desc, categorycode desc, itemtype desc;

It mean that the behaviour will change depending on how you have setup your
rules, isn't it ?
I don't say I disagree, I say it must be clearly stated/advertised, and this
patch should not be pushed in 3.6.
(however, I think it's more consistent, so it's good)

=== point 4 ===
small point : SQL must have reserved words in capital
so 
. ORDER BY branchcode DESC, categorycode DESC, itemtype DESC;
and not 
. order by branchcode desc, categorycode desc, itemtype desc;

=== point 5 ===
This patch also change the fines/hold/renewal behaviour, isn't it ? More tests
must be done in this area

Conclusion:
* marking failed QA for point 4 and until point 1 is addressed. I'll also ask
in // for one of BibLibre librarians to investigate this bug/patch

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4530] Circulation fines rules aren't always applied from most specific to less specific

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4530

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 CC||prosentientsyst...@gmail.co
   ||m

--- Comment #20 from Jared Camins-Esakov jcam...@cpbibliography.com 
2012-02-10 15:03:41 UTC ---
*** Bug 6551 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4530] Circulation fines rules aren't always applied from most specific to less specific

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4530

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

 CC||kyle.m.h...@gmail.com

--- Comment #18 from Kyle M Hall kyle.m.h...@gmail.com 2012-02-07 16:00:38 
UTC ---
I've done a lot of testing on this. It appears to be working correctly. I
created a multitude of circ rules and used warns and Data::Dumper to see which
rule would be picked each time. They rule chosen was correct in each instance.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4530] Circulation fines rules aren't always applied from most specific to less specific

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4530

--- Comment #19 from Kyle M Hall kyle.m.h...@gmail.com 2012-02-07 16:02:34 
UTC ---
Created attachment 7482
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7482
bug_4530: Rework issuing rules

Use only one set of functions
Database efficient rules fetch - only one query

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4530] Circulation fines rules aren't always applied from most specific to less specific

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4530

--- Comment #14 from Melia Meggs me...@bywatersolutions.com 2011-12-30 
20:14:34 UTC ---
This patch applies, and I have attempted to test, but I need some help with
testing this one because it's pretty complicated.

Here's what I did.  (Srdjan has pointed out that this test plan is too simple,
but I thought it'd be at least a place to start).  I set up circ/fines rules to
look like this:

For Main Branch
Patron Category | Item Type | Checkouts | Fine Amt | Suspension | Renewals |
Holds
   Child All 6 .50 
 3  3 3 
   Child   Book   5  .50  
2  2 2 
   All All3   .50  
0  0 0 

For South Branch
Patron Category | Item Type | Checkouts | Fine Amt | Suspension | Renewals |
Holds
   ChildBook  4   .50 
1   1 1 


Then what I would expect to happen is: 
  -  If a child patron from the main branch tries to checkout a DVD, he can
check out up to 6, with 3 days fines suspension, 3 renewals and 3 holds. 
  -  If a child patron from the main branch tries to checkout a book, he can
check out up to 5, with 2 days fines suspension, 2 renewals and 2 holds. 
  -  If a child patron from the South branch tries to checkout a book, he can
check out up to 4, with 1 day fines suspension, 1 renewal and 1 hold. 
  -  If a child patron from the East branch tries to checkout a compact disc,
he can check out up to 3, with no fines suspension, no renewals and no holds. 

Here are my results
  -  If a child patron from the main branch tries to checkout a DVD, he can
check out up to 6 - FAIL? (I checked out 7 with no problem.)
with 3 days fines suspension - DIDN'T TEST (didn't know how to test suspension)
3 renewals - PASS
and 3 holds - NOT SURE (for some reason I couldn't place on anything while
testing, so I think something else was screwing that up... so I can't say one
way or the other about holds)
  -  If a child patron from the main branch tries to checkout a book, he can
check out up to 5 - PASS
with 2 days fines suspension - DIDN'T TEST
2 renewals - PASS
and 2 holds - NOT SURE
  -  If a child patron from the South branch tries to checkout a book, he can
check out up to 4 - FAIL? (I checked out 5 with no problem.)
with 1 day fines suspension - DIDN'T TEST
1 renewal - NOT SURE
and 1 hold - NOT SURE
  -  If a child patron from the East branch tries to checkout a compact disc,
he can check out up to 3 - FAIL? (I checked out 5 with no problem.)
with no fines suspension - DIDN'T TEST
no renewals - DIDN'T TEST
and no holds - NOT SURE

Sorry, those aren't very useful test results.  But if someone could help me fix
the holes in that test plan, I'd be happy to do more testing.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4530] Circulation fines rules aren't always applied from most specific to less specific

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4530

--- Comment #15 from Melia Meggs me...@bywatersolutions.com 2011-12-30 
20:18:47 UTC ---
I am attaching screenshots of the circ/fines rules that I used since you can't
read the previous note very easily.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4530] Circulation fines rules aren't always applied from most specific to less specific

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4530

--- Comment #16 from Melia Meggs me...@bywatersolutions.com 2011-12-30 
20:19:15 UTC ---
Created attachment 6985
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6985
Circ/Fines Rules used for Main Library

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4530] Circulation fines rules aren't always applied from most specific to less specific

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4530

--- Comment #17 from Melia Meggs me...@bywatersolutions.com 2011-12-30 
20:19:36 UTC ---
Created attachment 6986
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6986
Circ/Fines Rules used for South Branch

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4530] Circulation fines rules aren't always applied from most specific to less specific

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4530

Srdjan Jankovic srd...@catalyst.net.nz changed:

   What|Removed |Added

   Attachment #6656|0   |1
is obsolete||

--- Comment #13 from Srdjan Jankovic srd...@catalyst.net.nz 2011-12-22 
00:39:51 UTC ---
Created attachment 6915
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6915
patch

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4530] Circulation fines rules aren't always applied from most specific to less specific

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4530

Srdjan Jankovic srd...@catalyst.net.nz changed:

   What|Removed |Added

   Patch Status|Does not apply  |Needs Signoff

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4530] Circulation fines rules aren't always applied from most specific to less specific

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4530

Srdjan Jankovic srd...@catalyst.net.nz changed:

   What|Removed |Added

   Attachment #5329|0   |1
is obsolete||

--- Comment #11 from Srdjan Jankovic srd...@catalyst.net.nz 2011-12-08 
03:53:19 UTC ---
Created attachment 6656
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6656
patch

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4530] Circulation fines rules aren't always applied from most specific to less specific

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4530

Srdjan Jankovic srd...@catalyst.net.nz changed:

   What|Removed |Added

   Patch Status|Does not apply  |Needs Signoff

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4530] Circulation fines rules aren't always applied from most specific to less specific

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4530

Melia Meggs me...@bywatersolutions.com changed:

   What|Removed |Added

 CC||me...@bywatersolutions.com

--- Comment #9 from Melia Meggs me...@bywatersolutions.com 2011-12-06 
23:59:25 UTC ---
This patch doesn't apply for me.  This is what I got:

Applying: bug_4530: Rework issuing rules Use only one set of functions Database 
/home/melia/kohaclone/.git/rebase-apply/patch:150: trailing whitespace.

/home/melia/kohaclone/.git/rebase-apply/patch:289: trailing whitespace.
   FROM issues 
error: patch failed: C4/Circulation.pm:74
error: C4/Circulation.pm: patch does not apply
error: patch failed: C4/Members.pm:660
error: C4/Members.pm: patch does not apply
Patch failed at 0001 bug_4530: Rework issuing rules Use only one set of
function
e query
When you have resolved this problem run git am --resolved.
If you would prefer to skip this patch, instead run git am --skip.
To restore the original branch and stop patching run git am --abort.
Patch left in /tmp/patch-_ZG0GE.patch

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4530] Circulation fines rules aren't always applied from most specific to less specific

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4530

Melia Meggs me...@bywatersolutions.com changed:

   What|Removed |Added

   Patch Status|Needs Signoff   |Does not apply

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4530] Circulation fines rules aren't always applied from most specific to less specific

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4530

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #10 from Chris Cormack ch...@bigballofwax.co.nz 2011-12-07 
00:10:04 UTC ---
CONFLICT (content): Merge conflict in C4/Members.pm

Looks to be the problem

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4530] Circulation fines rules aren't always applied from most specific to less specific

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4530

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 CC||neng...@gmail.com

--- Comment #6 from Nicole C. Engard neng...@gmail.com 2011-11-11 14:59:04 
UTC ---
This might help:



Applying: bug_4530: Rework issuing rules Use only one set of functions Database
efficient rules fetch - only one query
/home/nengard/kohaclone/.git/rebase-apply/patch:150: trailing whitespace.

/home/nengard/kohaclone/.git/rebase-apply/patch:289: trailing whitespace.
   FROM issues 
error: patch failed: C4/Circulation.pm:2306
error: C4/Circulation.pm: patch does not apply
Patch failed at 0001 bug_4530: Rework issuing rules Use only one set of
functions Database efficient rules fetch - only one query
When you have resolved this problem run git am --resolved.
If you would prefer to skip this patch, instead run git am --skip.
To restore the original branch and stop patching run git am --abort.
Patch left in /tmp/patch-rWv_7E.patch
nengard@debian:~/kohaclone$

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4530] Circulation fines rules aren't always applied from most specific to less specific

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4530

--- Comment #7 from Nicole C. Engard neng...@gmail.com 2011-11-11 15:03:20 
UTC ---
Tried again ... is this a pass or a fail?


Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y
Applying: bug_4530: Rework issuing rules Use only one set of functions Database
efficient rules fetch - only one query
Using index info to reconstruct a base tree...
stdin:150: trailing whitespace.

stdin:289: trailing whitespace.
   FROM issues 
warning: 2 lines add whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merging C4/Circulation.pm
Auto-merging C4/Members.pm
Auto-merging C4/Overdues.pm
Auto-merging C4/Reserves.pm
Auto-merging t/db_dependent/lib/KohaTest/Circulation.pm
nengard@debian:~/kohaclone$

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4530] Circulation fines rules aren't always applied from most specific to less specific

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4530

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

   Patch Status|Does not apply  |Needs Signoff

--- Comment #8 from Nicole C. Engard neng...@gmail.com 2011-11-11 15:14:41 
UTC ---
Okay it does apply.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4530] Circulation fines rules aren't always applied from most specific to less specific

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4530

Brendan Gallagher bren...@bywatersolutions.com changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m

--- Comment #4 from Brendan Gallagher bren...@bywatersolutions.com 2011-11-04 
11:13:57 UTC ---
Unable to apply to 3.6 - got patch failed.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4530] Circulation fines rules aren't always applied from most specific to less specific

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4530

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   Patch Status|Needs Signoff   |Does not apply

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4530] Circulation fines rules aren't always applied from most specific to less specific

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4530

Srdjan Jankovic srd...@catalyst.net.nz changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|gmcha...@gmail.com  |srd...@catalyst.net.nz

--- Comment #2 from Srdjan Jankovic srd...@catalyst.net.nz 2011-09-07 
02:26:02 UTC ---
Created attachment 5329
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5329
patch

I've made a single-entry point for issuing rules. That is good.
The bad ting is that the current implementation does not store nulls for
numeric values, but 0. In those cases we have no way of knowing if 0 *is* the
value, or we should fall back to the next more generic rule.

What I have done is:
* 0 is treated as null, ie no rule
* when selecting rules order of preference is: borrower category, item type,
branch

All relevant parts of the system need to be tested. I tried Holds, Check Out
and Renewals myself.

If that is of any help, affected functions are:
CanItemBeReserved
CanBookBeIssued
GetIssuingCharges
AddIssue
GetRenewCount
CanBookBeRenewed
AddRenewal
CalcFine

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/