[Koha-bugs] [Bug 4906] Problem with grace period calculation and fine intervals >1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906 M. de Rooy changed: What|Removed |Added QA Contact|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4906] Problem with grace period calculation and fine intervals >1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906 M. de Rooy changed: What|Removed |Added Attachment #13570|0 |1 is obsolete|| Attachment #13574|0 |1 is obsolete|| --- Comment #18 from M. de Rooy --- Created attachment 15969 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15969&action=edit Bug 4906 - Problem with grace period calculation and fine intervals >1 This patch adds the system preference FinesIncludeGracePeriod which allows the library the choice to include the grace period when calculating a fine ( Koha's current behavior ) or to ingore the grace period for the purposes of fines calculation. It is set by default to preserve the current behavior. Signed-off-by: Srikanth Dhondi Rebased March 8, 2013. Included renaming pref. (marcelr) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4906] Problem with grace period calculation and fine intervals >1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906 M. de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #17 from M. de Rooy --- QA: Looking at this one now. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4906] Problem with grace period calculation and fine intervals >1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906 --- Comment #16 from Paul Poulain --- (In reply to comment #15) > I think what Paul stated is the bug Katrin described, the first fine should > be charged after due-date + graceperiod. Now it is charged after due-date + > grace + fine-interval. exactly ! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4906] Problem with grace period calculation and fine intervals >1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906 Jan Kissig changed: What|Removed |Added CC||jan.kis...@th-wildau.de --- Comment #15 from Jan Kissig --- I think what Paul stated is the bug Katrin described, the first fine should be charged after due-date + graceperiod. Now it is charged after due-date + grace + fine-interval. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4906] Problem with grace period calculation and fine intervals >1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906 Mirko Tietgen changed: What|Removed |Added CC||mi...@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4906] Problem with grace period calculation and fine intervals >1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906 Paul Poulain changed: What|Removed |Added CC||paul.poul...@biblibre.com Patch complexity|--- |Small patch --- Comment #14 from Paul Poulain --- QA comment: the QA for this patch should not be a problem, because it's a small one. BUT I think it does not solve the problem katrin described in his initial description: if you set FinesIncludeGracePeriod, then there is no change in the behaviour, and you will still have the same result. The problem Katrin pointed in his description is the fact that the fine is placed *at the end* of each fine interval, not at the beginning. Your patch is related to another feature I think. Katrin, do you agree that this patch does not solve the problem you describe (it's a valuable ENH though, but maybe in another bug ?) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4906] Problem with grace period calculation and fine intervals >1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906 --- Comment #13 from Kyle M Hall --- You are correct. Thanks for catching that! (In reply to comment #11) > I think the system preference is called "FinesForGracePeriod" not > "FinesIncludeGracePeriod". Could you confirm that? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4906] Problem with grace period calculation and fine intervals >1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906 --- Comment #12 from Kyle M Hall --- Created attachment 13574 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13574&action=edit Bug 4906 - Problem with grace period calculation and fine intervals >1 - Followup -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4906] Problem with grace period calculation and fine intervals >1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906 --- Comment #11 from Srikanth Dhondi --- I think the system preference is called "FinesForGracePeriod" not "FinesIncludeGracePeriod". Could you confirm that? (In reply to comment #8) > Created attachment 13515 [details] > Bug 4906 - Problem with grace period calculation and fine intervals >1 > > This patch adds the system preference FinesIncludeGracePeriod which > allows the library the choice to include the grace period when calculating > a fine ( Koha's current behavior ) or to ingore the grace period for > the purposes of fines calculation. It is set by default to preserve the > current behavior. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4906] Problem with grace period calculation and fine intervals >1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906 Srikanth Dhondi changed: What|Removed |Added Attachment #13515|0 |1 is obsolete|| -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4906] Problem with grace period calculation and fine intervals >1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906 Srikanth Dhondi changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4906] Problem with grace period calculation and fine intervals >1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906 --- Comment #10 from Srikanth Dhondi --- Created attachment 13570 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13570&action=edit [SIGNED-OFF]Bug 4906 - Problem with grace period calculation and fine intervals >1 This patch adds the system preference FinesIncludeGracePeriod which allows the library the choice to include the grace period when calculating a fine ( Koha's current behavior ) or to ingore the grace period for the purposes of fines calculation. It is set by default to preserve the current behavior. Signed-off-by: Srikanth Dhondi -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4906] Problem with grace period calculation and fine intervals >1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906 Srikanth Dhondi changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #9 from Srikanth Dhondi --- Applying: Bug 4906 - Problem with grace period calculation and fine intervals >1 error: patch failed: installer/data/mysql/updatedatabase.pl:6055 error: installer/data/mysql/updatedatabase.pl: patch does not apply Patch failed at 0001 Bug 4906 - Problem with grace period calculation and fine intervals >1 When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Patch left in /tmp/Bug-4906---Problem-with-grace-period-calculation-a-GyPe81.patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4906] Problem with grace period calculation and fine intervals >1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4906] Problem with grace period calculation and fine intervals >1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906 Kyle M Hall changed: What|Removed |Added Attachment #11508|0 |1 is obsolete|| --- Comment #8 from Kyle M Hall --- Created attachment 13515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13515&action=edit Bug 4906 - Problem with grace period calculation and fine intervals >1 This patch adds the system preference FinesIncludeGracePeriod which allows the library the choice to include the grace period when calculating a fine ( Koha's current behavior ) or to ingore the grace period for the purposes of fines calculation. It is set by default to preserve the current behavior. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4906] Problem with grace period calculation and fine intervals >1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906
Srikanth Dhondi changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
CC||srika...@catalyst.net.nz
--- Comment #7 from Srikanth Dhondi ---
Applying: Bug 4906 - Problem with grace period calculation and fine intervals
>1
/home/srikanth/Projects/Koha/koha/.git/rebase-apply/patch:17: trailing
whitespace.
if ( C4::Context->preference('FinesIncludeGracePeriod') ) {
error: patch failed: C4/Overdues.pm:264
error: C4/Overdues.pm: patch does not apply
error: patch failed: installer/data/mysql/sysprefs.sql:374
error: installer/data/mysql/sysprefs.sql: patch does not apply
error: patch failed: installer/data/mysql/updatedatabase.pl:5635
error: installer/data/mysql/updatedatabase.pl: patch does not apply
Patch failed at 0001 Bug 4906 - Problem with grace period calculation and fine
intervals >1
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".
Patch left in
/tmp/Bug-4906---Problem-with-grace-period-calculation-a-w6Gl8z.patch
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4906] Problem with grace period calculation and fine intervals >1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4906] Problem with grace period calculation and fine intervals >1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906 Kyle M Hall changed: What|Removed |Added Attachment #11507|0 |1 is obsolete|| --- Comment #6 from Kyle M Hall --- Created attachment 11508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11508&action=edit Bug 4906 - Problem with grace period calculation and fine intervals >1 This patch adds the system preference FinesIncludeGracePeriod which allows the library the choice to include the grace period when calculating a fine ( Koha's current behavior ) or to ingore the grace period for the purposes of fines calculation. It is set by default to preserve the current behavior. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4906] Problem with grace period calculation and fine intervals >1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906 --- Comment #5 from Kyle M Hall --- Created attachment 11507 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11507&action=edit Bug 4906 - Problem with grace period calculation and fine intervals >1 This patch adds the system preference FinesIncludeGracePeriod which allows the library the choice to include the grace period when calculating a fine ( Koha's current behavior ) or to ingore the grace period for the purposes of fines calculation. It is set by default to preserve the current behavior. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4906] Problem with grace period calculation and fine intervals >1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906 --- Comment #4 from Kyle M Hall --- Katrin, I was trying to re-assign it to myself, but it looks like I only switched it to the default assignee. I was planning on taking a crack at this, but I have re-assigned it back to you in case you get to it first. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4906] Problem with grace period calculation and fine intervals >1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | --- Comment #3 from Kyle M Hall --- Katrin, I was trying to re-assign it to myself, but it looks like I only switched it to the default assignee. I was planning on taking a crack at this. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4906] Problem with grace period calculation and fine intervals >1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906 --- Comment #2 from Katrin Fischer --- Hi Kyle, is there a reason you removed me as assignee from this bug? I know it's an old bug - but I have some code that would have worked before hourly loans an I hoped to look into this again before end of August. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4906] Problem with grace period calculation and fine intervals >1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Assignee|katrin.fisc...@bsz-bw.de|koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4906] Problem with grace period calculation and fine intervals >1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906 Katrin Fischer changed: What|Removed |Added Assignee|kyle.m.h...@gmail.com |katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4906] Problem with grace period calculation and fine intervals >1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906 Katrin Fischer changed: What|Removed |Added Version|rel_3_2 |master --- Comment #1 from Katrin Fischer 2012-01-06 16:08:17 UTC --- Still valid :( -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
