[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #66 from Katrin Fischer katrin.fisc...@bsz-bw.de --- While I got distracted, Robin wrote a patch to fix the list email in OPAC - but we still need the real once and for all solution. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=12849 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #67 from M. Tompsett mtomp...@hotmail.com --- Okay, okay. When I finally get around to upgrading our system, I'll take a whack at changing everything to expect the protocol in the OPACBaseURL, like it should be. So, unless someone beats me to it, I'll get on it. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Robin Sheat ro...@catalyst.net.nz changed: What|Removed |Added CC||ro...@catalyst.net.nz --- Comment #68 from Robin Sheat ro...@catalyst.net.nz --- (In reply to M. Tompsett from comment #67) Okay, okay. When I finally get around to upgrading our system, I'll take a whack at changing everything to expect the protocol in the OPACBaseURL, like it should be. So, unless someone beats me to it, I'll get on it. That is the way to do it, imo. There's technically no reason you couldn't have your opac at gopher://example.com, and it'd be good to handle that sort of craziness. Most things shouldn't require any changes, as they already expect that Auth.pm will attach the http(s) to the start anyway. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #65 from M. Tompsett mtomp...@hotmail.com --- Also should be noted a minor rebase is required before fixing. I think it would be optimal if all the OPACBaseURLs passed to the templates were full paths including the https or http accordingly. I am not so sure I think the OpacProtocol system preference idea is the best way to do it, but rather it should be in the OPACBaseURL system preference itself. We shouldn't be hardcoding http or https anywhere. We shouldn't need to check for http or https anywhere. I feel the best solution is the most painful to do: fix every instance of OPACBaseURL use or hardcoded protocols to just use the OPACBaseURL. However, once done, it will just work. That is the way Koha should work. Sadly, there are partial links in some of the included header templates which would cascade to a larger than simpler solution, as far as I recall from last time I checked. Honestly, someone needs to bite the bullet. I don't have time. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 David Cook dc...@prosentient.com.au changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #64 from David Cook dc...@prosentient.com.au --- It's worth noting that bug 11575 has been pushed to master, so that might affect this bug. The OpacProtocol system preference is probably a good idea. Heck, that might remove the need to do more fancy checking for HTTPS when using reverse proxies and/or Plack. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Marc Véron ve...@veron.ch changed: What|Removed |Added CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010
--- Comment #57 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to Katrin Fischer from comment #56)
Maybe we could take a step by step approach here?
Currently we are sending out incomplete emails and making the way we create
the links consistent, will take a lot more work.
We have code in Auth.pm that produces working links for the opac cart email,
but doesn't use OpacBaseUrl. And the links in the opac list emails are
broken.
The first patch was just trying to copy the logic from the cart email for
the opac list email, so both would create the links the same way using the
same lines of code. Maybe this could be still be a valid first step?
I would not mind passing QA on the first patch, overriding opacbaseurl with the
stuff from Auth.pm as a temporary measure. (Maybe adding a comment somewhere?)
But the lines in Auth.pm:
OPACBaseURL = ($in-{'query'}-https() ? https://;
: http://;) . $ENV{'SERVER_NAME'} .
($ENV{'SERVER_PORT'} eq ($in-{'query'}-https() ? 443 :
80) ? '' : :$ENV{'SERVER_PORT'}),
should actually be adjusted when resolving the various OpacBaseURL bugs. Note
that there was an issue too with the https function and Plack..
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #58 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I totally agree that we need to figure out a proper way to generate the URLs that works in the various possible situations. I'd also not mind if we changed the code in Auth.pm - I think in the OPAC it should be possible to determine if https is being used. Maybe ist would be best to split off the OPAC problem into a separate bug now? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #59 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Katrin Fischer from comment #58) I totally agree that we need to figure out a proper way to generate the URLs that works in the various possible situations. I'd also not mind if we changed the code in Auth.pm - I think in the OPAC it should be possible to determine if https is being used. Maybe ist would be best to split off the OPAC problem into a separate bug now? Looking forward to your proposal.. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #60 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I am not sure I will be able to provide an idea for the final solution, but I can try and split out a bug for the OPAC change - but probably won't be today. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010
--- Comment #61 from M. Tompsett mtomp...@hotmail.com ---
(In reply to M. de Rooy from comment #57)
But the lines in Auth.pm:
OPACBaseURL = ($in-{'query'}-https() ?
https://; : http://;) . $ENV{'SERVER_NAME'} .
($ENV{'SERVER_PORT'} eq ($in-{'query'}-https() ? 443
: 80) ? '' : :$ENV{'SERVER_PORT'}),
should actually be adjusted when resolving the various OpacBaseURL bugs.
Note that there was an issue too with the https function and Plack..
One could run their staff and OPAC clients on different ports. I'm not saying
every combination is sane, but every combination is not accounted for with that
code. This code does not account for the sane combination of https (staff) and
http (OPAC), nor the strange combination of http (staff) and https (OPAC).
The best way, without the OpacProtocol system preference, is a full-out across
the board fix the hard coded 'http' 'https' messes, and require the protocol in
OPACBaseURL.
The problem with this solution is that it is much larger to implement, because
if you put http(s) into your OPACBaseURL, you'll get http://http(s):// in
locations you haven't fixed yet.
If Katrin can fix all the OPACBaseURLs, that would be great. :)
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #62 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to M. Tompsett from comment #61) One could run their staff and OPAC clients on different ports. I'm not saying every combination is sane, but every combination is not accounted for with that code. This code does not account for the sane combination of https (staff) and http (OPAC), nor the strange combination of http (staff) and https (OPAC). I think that she wants to concentrate first on fixing the opac side of this problem: so only opac-sendshelf. In that case the protocol will hopefully be correct in most cases. Sending a wrong shelf list from staff may be a much smaller issue.. The best way, without the OpacProtocol system preference, is a full-out across the board fix the hard coded 'http' 'https' messes, and require the protocol in OPACBaseURL. Agreed. Like adjust when resolving the various OpacBaseURL bugs.. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #63 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Marcel is right, I was offering to try the 'cheaper' solution, as I probably won't have time for the bigger fix. I think the suggested solution to include the protocol sounds good. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |In Discussion CC||m.de.r...@rijksmuseum.nl --- Comment #55 from M. de Rooy m.de.r...@rijksmuseum.nl --- I would favor resolving this issue via OPACBaseURL and not create a new preference that only tells you about the protocol. The protocol should just be in OPACBaseURL. Smart code could assume that it is HTTP if this pref does not start with a protocol. Changing status to In Discussion -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #56 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Maybe we could take a step by step approach here? Currently we are sending out incomplete emails and making the way we create the links consistent, will take a lot more work. We have code in Auth.pm that produces working links for the opac cart email, but doesn't use OpacBaseUrl. And the links in the opac list emails are broken. The first patch was just trying to copy the logic from the cart email for the opac list email, so both would create the links the same way using the same lines of code. Maybe this could be still be a valid first step? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Keywords|rel_3_16_candidate | --- Comment #48 from Galen Charlton gmcha...@gmail.com --- I won't be including this in 3.16.0, as I think it needs to bake for a bit longer: - do we /really/ need a new system preference when we could enforce making OPACBaseURL contain the protocol? - is it clear that somebody email a cart from the staff interface wants the results to point to the OPAC, rather than the staff interface? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #49 from M. Tompsett mtomp...@hotmail.com --- (In reply to Galen Charlton from comment #48) - do we /really/ need a new system preference when we could enforce making OPACBaseURL contain the protocol? Valid point. Just that if one only wants to fix a tiny piece at a time, this solution works. Enforcing the protocol is a much larger patch. - is it clear that somebody email a cart from the staff interface wants the results to point to the OPAC, rather than the staff interface? One could email it to someone without staff access. I think it is best to email OPAC links, and not staff links. That is, I think the current behaviour is best. Now, that doesn't mean that they won't want the staff interface link, but since we do not know if the email address has staff access (we don't check, though I suppose we could), OPAC is quickest solution. Perhaps a logged in user should have the staff URL in their OPAC details pages, if they have access? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #50 from M. Tompsett mtomp...@hotmail.com --- Created attachment 27951 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27951action=edit Bug 5010: Send list emails with complete links back into the catalog This patch adapts the way the links in the cart email in OPAC are generated for the list emails. The OpacBaseURL variable is generated from code in Auth.pm. To test: - Create a list - Email yourself the list Note: Email is sent directly and not via messagequeue table - Verify the links back into the catalog are missing http(s):// - Apply the patch - Email yourself the list again - Verify the links are now ok and working Note: The way Auth.pm generates the OpacBaseURL is not correct, as it does not take into account the OpacBaseURL system preference. This patch makes both emails sent from OPAC rely on the same code and is an improvement over the current behaviour. Tested both together using steps similar to larger test plan. Signed-off-by: Mark Tompsett mtomp...@hotmail.com Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Just add a sign. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #53 from M. Tompsett mtomp...@hotmail.com --- Created attachment 27954 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27954action=edit Bug 5010 - Follow up: Case typographical error The call had 'OPACProtocol', but it should be 'OpacProtocol'. I am uncertain why it functioned. TEST PLAN - 1) Retest the sending cart from staff client. Sign comment: It works because mysql is case insensitive :) (try select variable from systempreferences where variable like 'opac%') Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com No koha-qa errors -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #51 from M. Tompsett mtomp...@hotmail.com --- Created attachment 27952 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27952action=edit Bug 5010: Fix incomplete links in carts and lists sent from the staff client While the list email hardcoded http:// in front of the URL, the cart email was missing http(s)://. As there seems to be no reliable way to determine in staff if the OPAC is using SSL or not, this patch introduces a new system preference: PublicCatalogUsesSSL. To test: - Create a list - Send yourself the list from the staff interface - Verify that the links are http://OPACBaseURL - Put some records into your cart - Send yourself the cart from the staff interface - Verify that the links are missing http(s):// in front of them - Apply patch - Run database update - Verify that the default setting for PublicCatalogUsesSSL is 'doesn't use' - Resent both emails - Verfiy the catalog links are now both http:// links - Change system preference setting to 'uses' - Resent both emails - Verify the catalog links are now https:// links NOTE: My cart didn't have a 'In online catalog:' line on master. My list had http:// on master. System preference affected both cart and list sending. System preference necessary, because there is no way to determine http or https in the middle of an email. Signed-off-by: Mark Tompsett mtomp...@hotmail.com NOTE: The rebase removed sendshelf.tt, because bug 11248 removed the hardcoded http:// in the template file. That may have been a mistake, since nothing was added to the corresponding sendshelf.pl file. Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Add a sign -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #52 from M. Tompsett mtomp...@hotmail.com --- Created attachment 27953 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27953action=edit Bug 5010: (2) Fix incomplete links in carts and lists sent from the staff client While the list email hardcoded http:// in front of the URL, the cart email was missing http(s)://. As there seems to be no reliable way to determine in staff if the OPAC is using SSL or not, this patch introduces a new OPAC system preference, OpacProtocol, in the Policy subsection. It defaults to doesn't use (http://), but can be changed to uses (https://). Both basket/sendbasket.pl and virtualshelves/sendshelf.pl were tweaked to always set OPACBaseURL. If OPACBaseURL is undef or not set, the URL is not given in the corresponding template files. opac/opac-sendshelf.pl was returned to previous state, because it affects doc-head-close.inc if OPACBaseURL is not passed. This should be fixed to use the OpacProtocol system preference in another bug fix. However, this is OPAC, not Staff, and outside of the bugs scope. Both basket/sendbasket.tt and virtualshelves/sendshelf.tt template files contain the suggested Koha.Preference logic recommended by Kyle in comment #21. TEST PLAN - 1) Back up your database 2) Drop your koha database and recreate it empty 3) In the mysql client: SOURCE .../installer/data/mysql/sysprefs.sql; -- It should run without error. SELECT variable,value from systempreferences WHERE variable='OpacProtocol'; -- It should have the value 'http://' 4) Restore your database 5) $ ./installer/data/mysql/updatedatabase.pl -- It should run the upgrade to insert OpacProtocol. 6) In the mysql client: SELECT variable,value from systempreferences WHERE variable='OpacProtocol'; -- It should have the value 'http://' 7) Log into the staff client 8) Click 'Koha administration' 9) Click 'Global system preferences' 10) Click the 'OPAC' tab on the left side. 11) Scroll down to the Policy section, and find the OpacProtocol preference. -- It should have a value of doesn't use in the drop down. 12) Fill your cart with something(s). 13) Make sure you have a list filled with something(s). 14) Click 'Cart' in the top menu bar area. 15) Click 'Send', and send it to yourself. 16) Click 'Close window' 17) Click 'Hide window' 18) Click 'More' and click 'Lists' 19) Choose a list and 'Send list' to yourself. 20) Check your email -- both emails should have OPAC URLs which start with http:// 21) Change the OPAC system preference OpacProtocol to 'uses' (https://), log out and log in (to force refresh of cached system preferences), and repeat steps 14 through 19. 22) Check your email -- the two new emails should have OPAC URLS which start with https:// NOTE: Other URLs may be broken as well, this bug only fixes carts and lists sent from staff. Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Work as described, shelf and cart. No koha-qa errors -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #27435|0 |1 is obsolete|| -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #27436|0 |1 is obsolete|| -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #27779|0 |1 is obsolete|| -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #27437|0 |1 is obsolete|| -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Assignee|mtomp...@hotmail.com|katrin.fisc...@bsz-bw.de --- Comment #54 from M. Tompsett mtomp...@hotmail.com --- I have rebased, but the discussion on comment 48 and comment 49 should continue. Also, Katrin, I've bounced this back to you, as my development time available for Koha has drastically reduced. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #45 from Jonathan Druart jonathan.dru...@biblibre.com --- 2 questions: 1/ Shouldn't we use this pref wherever OPACBaseURL is used? 2/ Shouldn't we put a warning in the updatedb entry? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #46 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I think the problem mostly is where we try to build the URL in staff, because there you can't get the information if the OPAC is run as https. There are other options used for links in the OPAC. Maybe this could be a first step? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #47 from M. Tompsett mtomp...@hotmail.com --- This is a first step. We fix one place, and if this is deemed sufficient, we go on to the rest. Ideally, this could be integrated into a function that will get used everywhere. Yes, it would be a good idea to put a warning: If you use HTTPS for your OPAC, then please set OpacProtocol to 'use' in the OPAC system preferences' Policy section. However, I don't have time to add that. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Keywords||rel_3_16_candidate CC||gmcha...@gmail.com --- Comment #42 from Galen Charlton gmcha...@gmail.com --- Marking as a candidate for 3.16.0. Not a guarantee, however. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #27673|0 |1 is obsolete|| --- Comment #43 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 27779 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27779action=edit [SIGNED-OFF] Bug 5010 - Follow up: Case typographical error The call had 'OPACProtocol', but it should be 'OpacProtocol'. I am uncertain why it functioned. TEST PLAN - 1) Retest the sending cart from staff client. Sign comment: It works because mysql is case insensitive :) (try select variable from systempreferences where variable like 'opac%') Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com No koha-qa errors -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #44 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Solved small conflicts on updatedatabse.pl, but only upload last patch signed. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #41 from M. Tompsett mtomp...@hotmail.com --- Created attachment 27673 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27673action=edit Bug 5010 - Follow up: Case typographical error The call had 'OPACProtocol', but it should be 'OpacProtocol'. I am uncertain why it functioned. TEST PLAN - 1) Retest the sending cart from staff client. NOTE: Last patch needed sign off. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Assignee|katrin.fisc...@bsz-bw.de|mtomp...@hotmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010
Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:
What|Removed |Added
CC||bgkrie...@gmail.com
--- Comment #31 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Question:
On opac-sendbasket.pl you send
if (C4::Context-preference('OPACBaseURL')){
$template2-param( OPACBaseURL = C4::Context-preference('OPACBaseURL') );
}
and in virtualshelves/sendshelf.tt
[% Koha.Preference( 'OPACProtocol' ) %][% OPACBaseURL %]/cgi-bin/koha/opac...
Why not
[% Koha.Preference('OPACProtocol') %][% Koha.Preference('OPACBaseURL') %]
?
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010
--- Comment #32 from M. Tompsett mtomp...@hotmail.com ---
(In reply to Bernardo Gonzalez Kriegel from comment #31)
Question:
On opac-sendbasket.pl you send
if (C4::Context-preference('OPACBaseURL')){
$template2-param( OPACBaseURL = C4::Context-preference('OPACBaseURL') );
}
and in virtualshelves/sendshelf.tt
[% Koha.Preference( 'OPACProtocol' ) %][% OPACBaseURL %]/cgi-bin/koha/opac...
Why not
[% Koha.Preference('OPACProtocol') %][% Koha.Preference('OPACBaseURL') %]
?
Because the include file requires OPACBaseURL defined for the opac ones:
$ grep -l -i opacbaseurl `find . | grep en/.*inc$`
./koha-tmpl/opac-tmpl/prog/en/includes/masthead.inc
./koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc
./koha-tmpl/opac-tmpl/ccsr/en/includes/masthead.inc
./koha-tmpl/opac-tmpl/ccsr/en/includes/doc-head-close.inc
./koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc
$ grep -i opacbaseurl ./koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc
link rel=unapi-server type=application/xml title=unAPI href=[%
OPACBaseURL %]/cgi-bin/koha/unapi /
This would explode into a wider scale fix required (lots more testing!). That's
beyond the scope of this bug.
I believe the second one has potential merit, but my goal was to minimize
impact without having to look for other areas affected. I have found the
OPACBaseURL logic was added by bug 6957, but I haven't looked much further.
Since I was leaving OPACBaseURL intact to minimize potential impact, accessing
the Template variable is likely faster than the Preference call and it is
shorter to type, I didn't change that. The goal of this bug is to add
OpacProtocol.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #33 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Patch 2/3 has fixable conflicts Patch 3/3 no, needs rebasing -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #34 from M. Tompsett mtomp...@hotmail.com --- Bug 11248 triggered the need for a rebase. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #25878|0 |1 is obsolete|| --- Comment #35 from M. Tompsett mtomp...@hotmail.com --- Created attachment 27431 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27431action=edit Bug 5010: Send list emails with complete links back into the catalog This patch adapts the way the links in the cart email in OPAC are generated for the list emails. The OpacBaseURL variable is generated from code in Auth.pm. To test: - Create a list - Email yourself the list Note: Email is sent directly and not via messagequeue table - Verify the links back into the catalog are missing http(s):// - Apply the patch - Email yourself the list again - Verify the links are now ok and working Note: The way Auth.pm generates the OpacBaseURL is not correct, as it does not take into account the OpacBaseURL system preference. This patch makes both emails sent from OPAC rely on the same code and is an improvement over the current behaviour. Tested both together using steps similar to larger test plan. Signed-off-by: Mark Tompsett mtomp...@hotmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #25879|0 |1 is obsolete|| Attachment #27072|0 |1 is obsolete|| --- Comment #36 from M. Tompsett mtomp...@hotmail.com --- Created attachment 27432 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27432action=edit Bug 5010: Fix incomplete links in carts and lists sent from the staff client While the list email hardcoded http:// in front of the URL, the cart email was missing http(s)://. As there seems to be no reliable way to determine in staff if the OPAC is using SSL or not, this patch introduces a new system preference: PublicCatalogUsesSSL. To test: - Create a list - Send yourself the list from the staff interface - Verify that the links are http://OPACBaseURL - Put some records into your cart - Send yourself the cart from the staff interface - Verify that the links are missing http(s):// in front of them - Apply patch - Run database update - Verify that the default setting for PublicCatalogUsesSSL is 'doesn't use' - Resent both emails - Verfiy the catalog links are now both http:// links - Change system preference setting to 'uses' - Resent both emails - Verify the catalog links are now https:// links NOTE: My cart didn't have a 'In online catalog:' line on master. My list had http:// on master. System preference affected both cart and list sending. System preference necessary, because there is no way to determine http or https in the middle of an email. Signed-off-by: Mark Tompsett mtomp...@hotmail.com NOTE: The rebase removed sendshelf.tt, because bug 11248 removed the hardcoded http:// in the template file. That may have been a mistake, since nothing was added to the corresponding sendshelf.pl file. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #37 from M. Tompsett mtomp...@hotmail.com --- Created attachment 27433 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27433action=edit Bug 5010: Fix incomplete links in carts and lists sent from the staff client While the list email hardcoded http:// in front of the URL, the cart email was missing http(s)://. As there seems to be no reliable way to determine in staff if the OPAC is using SSL or not, this patch introduces a new OPAC system preference, OpacProtocol, in the Policy subsection. It defaults to doesn't use (http://), but can be changed to uses (https://). Both basket/sendbasket.pl and virtualshelves/sendshelf.pl were tweaked to always set OPACBaseURL. If OPACBaseURL is undef or not set, the URL is not given in the corresponding template files. opac/opac-sendshelf.pl was returned to previous state, because it affects doc-head-close.inc if OPACBaseURL is not passed. This should be fixed to use the OpacProtocol system preference in another bug fix. However, this is OPAC, not Staff, and outside of the bugs scope. Both basket/sendbasket.tt and virtualshelves/sendshelf.tt template files contain the suggested Koha.Preference logic recommended by Kyle in comment #21. TEST PLAN - 1) Back up your database 2) Drop your koha database and recreate it empty 3) In the mysql client: SOURCE .../installer/data/mysql/sysprefs.sql; -- It should run without error. SELECT variable,value from systempreferences WHERE variable='OpacProtocol'; -- It should have the value 'http://' 4) Restore your database 5) $ ./installer/data/mysql/updatedatabase.pl -- It should run the upgrade to insert OpacProtocol. 6) In the mysql client: SELECT variable,value from systempreferences WHERE variable='OpacProtocol'; -- It should have the value 'http://' 7) Log into the staff client 8) Click 'Koha administration' 9) Click 'Global system preferences' 10) Click the 'OPAC' tab on the left side. 11) Scroll down to the Policy section, and find the OpacProtocol preference. -- It should have a value of doesn't use in the drop down. 12) Fill your cart with something(s). 13) Make sure you have a list filled with something(s). 14) Click 'Cart' in the top menu bar area. 15) Click 'Send', and send it to yourself. 16) Click 'Close window' 17) Click 'Hide window' 18) Click 'More' and click 'Lists' 19) Choose a list and 'Send list' to yourself. 20) Check your email -- both emails should have OPAC URLs which start with http:// 21) Change the OPAC system preference OpacProtocol to 'uses' (https://), log out and log in (to force refresh of cached system preferences), and repeat steps 14 through 19. 22) Check your email -- the two new emails should have OPAC URLS which start with https:// NOTE: Other URLs may be broken as well, this bug only fixes carts and lists sent from staff. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #27432|0 |1 is obsolete|| --- Comment #39 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 27436 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27436action=edit [SIGNED-OFF] Bug 5010: Fix incomplete links in carts and lists sent from the staff client While the list email hardcoded http:// in front of the URL, the cart email was missing http(s)://. As there seems to be no reliable way to determine in staff if the OPAC is using SSL or not, this patch introduces a new system preference: PublicCatalogUsesSSL. To test: - Create a list - Send yourself the list from the staff interface - Verify that the links are http://OPACBaseURL - Put some records into your cart - Send yourself the cart from the staff interface - Verify that the links are missing http(s):// in front of them - Apply patch - Run database update - Verify that the default setting for PublicCatalogUsesSSL is 'doesn't use' - Resent both emails - Verfiy the catalog links are now both http:// links - Change system preference setting to 'uses' - Resent both emails - Verify the catalog links are now https:// links NOTE: My cart didn't have a 'In online catalog:' line on master. My list had http:// on master. System preference affected both cart and list sending. System preference necessary, because there is no way to determine http or https in the middle of an email. Signed-off-by: Mark Tompsett mtomp...@hotmail.com NOTE: The rebase removed sendshelf.tt, because bug 11248 removed the hardcoded http:// in the template file. That may have been a mistake, since nothing was added to the corresponding sendshelf.pl file. Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Add a sign -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #27431|0 |1 is obsolete|| --- Comment #38 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 27435 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27435action=edit [SIGNED-OFF] Bug 5010: Send list emails with complete links back into the catalog This patch adapts the way the links in the cart email in OPAC are generated for the list emails. The OpacBaseURL variable is generated from code in Auth.pm. To test: - Create a list - Email yourself the list Note: Email is sent directly and not via messagequeue table - Verify the links back into the catalog are missing http(s):// - Apply the patch - Email yourself the list again - Verify the links are now ok and working Note: The way Auth.pm generates the OpacBaseURL is not correct, as it does not take into account the OpacBaseURL system preference. This patch makes both emails sent from OPAC rely on the same code and is an improvement over the current behaviour. Tested both together using steps similar to larger test plan. Signed-off-by: Mark Tompsett mtomp...@hotmail.com Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Just add a sign. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #27433|0 |1 is obsolete|| --- Comment #40 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 27437 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27437action=edit [SIGNED-OFF] Bug 5010: (2) Fix incomplete links in carts and lists sent from the staff client While the list email hardcoded http:// in front of the URL, the cart email was missing http(s)://. As there seems to be no reliable way to determine in staff if the OPAC is using SSL or not, this patch introduces a new OPAC system preference, OpacProtocol, in the Policy subsection. It defaults to doesn't use (http://), but can be changed to uses (https://). Both basket/sendbasket.pl and virtualshelves/sendshelf.pl were tweaked to always set OPACBaseURL. If OPACBaseURL is undef or not set, the URL is not given in the corresponding template files. opac/opac-sendshelf.pl was returned to previous state, because it affects doc-head-close.inc if OPACBaseURL is not passed. This should be fixed to use the OpacProtocol system preference in another bug fix. However, this is OPAC, not Staff, and outside of the bugs scope. Both basket/sendbasket.tt and virtualshelves/sendshelf.tt template files contain the suggested Koha.Preference logic recommended by Kyle in comment #21. TEST PLAN - 1) Back up your database 2) Drop your koha database and recreate it empty 3) In the mysql client: SOURCE .../installer/data/mysql/sysprefs.sql; -- It should run without error. SELECT variable,value from systempreferences WHERE variable='OpacProtocol'; -- It should have the value 'http://' 4) Restore your database 5) $ ./installer/data/mysql/updatedatabase.pl -- It should run the upgrade to insert OpacProtocol. 6) In the mysql client: SELECT variable,value from systempreferences WHERE variable='OpacProtocol'; -- It should have the value 'http://' 7) Log into the staff client 8) Click 'Koha administration' 9) Click 'Global system preferences' 10) Click the 'OPAC' tab on the left side. 11) Scroll down to the Policy section, and find the OpacProtocol preference. -- It should have a value of doesn't use in the drop down. 12) Fill your cart with something(s). 13) Make sure you have a list filled with something(s). 14) Click 'Cart' in the top menu bar area. 15) Click 'Send', and send it to yourself. 16) Click 'Close window' 17) Click 'Hide window' 18) Click 'More' and click 'Lists' 19) Choose a list and 'Send list' to yourself. 20) Check your email -- both emails should have OPAC URLs which start with http:// 21) Change the OPAC system preference OpacProtocol to 'uses' (https://), log out and log in (to force refresh of cached system preferences), and repeat steps 14 through 19. 22) Check your email -- the two new emails should have OPAC URLS which start with https:// NOTE: Other URLs may be broken as well, this bug only fixes carts and lists sent from staff. Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Work as described, shelf and cart. No koha-qa errors -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Blocks||6874 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #27049|0 |1 is obsolete|| --- Comment #30 from M. Tompsett mtomp...@hotmail.com --- Created attachment 27072 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27072action=edit Bug 5010: Fix incomplete links in carts and lists sent from the staff client While the list email hardcoded http:// in front of the URL, the cart email was missing http(s)://. As there seems to be no reliable way to determine in staff if the OPAC is using SSL or not, this patch introduces a new OPAC system preference, OpacProtocol, in the Policy subsection. It defaults to doesn't use (http://), but can be changed to uses (https://). Both basket/sendbasket.pl and virtualshelves/sendshelf.pl were tweaked to always set OPACBaseURL. If OPACBaseURL is undef or not set, the URL is not given in the corresponding template files. opac/opac-sendshelf.pl was returned to previous state, because it affects doc-head-close.inc if OPACBaseURL is not passed. This should be fixed to use the OpacProtocol system preference in another bug fix. However, this is OPAC, not Staff, and outside of the bugs scope. Both basket/sendbasket.tt and virtualshelves/sendshelf.tt template files contain the suggested Koha.Preference logic recommended by Kyle in comment #21. TEST PLAN - 1) Back up your database 2) Drop your koha database and recreate it empty 3) In the mysql client: SOURCE .../installer/data/mysql/sysprefs.sql; -- It should run without error. SELECT variable,value from systempreferences WHERE variable='OpacProtocol'; -- It should have the value 'http://' 4) Restore your database 5) $ ./installer/data/mysql/updatedatabase.pl -- It should run the upgrade to insert OpacProtocol. 6) In the mysql client: SELECT variable,value from systempreferences WHERE variable='OpacProtocol'; -- It should have the value 'http://' 7) Log into the staff client 8) Click 'Koha administration' 9) Click 'Global system preferences' 10) Click the 'OPAC' tab on the left side. 11) Scroll down to the Policy section, and find the OpacProtocol preference. -- It should have a value of doesn't use in the drop down. 12) Fill your cart with something(s). 13) Make sure you have a list filled with something(s). 14) Click 'Cart' in the top menu bar area. 15) Click 'Send', and send it to yourself. 16) Click 'Close window' 17) Click 'Hide window' 18) Click 'More' and click 'Lists' 19) Choose a list and 'Send list' to yourself. 20) Check your email -- both emails should have OPAC URLs which start with http:// 21) Change the OPAC system preference OpacProtocol to 'uses' (https://), log out and log in (to force refresh of cached system preferences), and repeat steps 14 through 19. 22) Check your email -- the two new emails should have OPAC URLS which start with https:// NOTE: Other URLs may be broken as well, this bug only fixes carts and lists sent from staff. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Failed QA CC||k...@bywatersolutions.com --- Comment #21 from Kyle M Hall k...@bywatersolutions.com --- I have a few suggestions for this: 1) Use the Preference method of the Koha TT plugin instead of passing them in from the perl script. No real processing is done. 2) Change the new sys pref PublicCatalogUsesSSL to OpacProtocol and give it the two options with the values http://; and https://; instead of it being a yes/no. That way in the template we can use do [% Koha.Preference( 'OPACProtocol' ) %][% OPACBaseURL %] which will mean far fewer changes. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #22 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Kyle, good suggestions, thank you for your review :) - I hope I will find some time to improve the patches. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #23 from M. Tompsett mtomp...@hotmail.com --- I'll make the patches for you in a few hours, Katrin, if you would like. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #24 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Thx for the offer! I'd not be too unhappy if you took that item off my to do list :) Maybe leave a quick note here, when you get to it? So we don't try to fix it at the same time. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #25 from M. Tompsett mtomp...@hotmail.com --- Actually, I've started on it, but it may take me another 9 hours before I finish, test, and post it up. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010
--- Comment #26 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 25878
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25878
[SIGNED OFF] Bug 5010: Send list emails with complete links back into the
catalog
Review of attachment 25878:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=5010attachment=25878)
-
::: opac/opac-sendshelf.pl
@@ -109,5 @@
-if (C4::Context-preference('OPACBaseURL')){
- $template2-param( OPACBaseURL =
C4::Context-preference('OPACBaseURL') );
-}
-
Unfortunately, koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc is
affected by the removal: link rel=unapi-server type=application/xml
title=unAPI href=[% OPACBaseURL %]/cgi-bin/koha/unapi /
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #27 from M. Tompsett mtomp...@hotmail.com --- Created attachment 27049 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27049action=edit Bug 5010: Fix incomplete links in carts and lists sent from the staff client While the list email hardcoded http:// in front of the URL, the cart email was missing http(s)://. As there seems to be no reliable way to determine in staff if the OPAC is using SSL or not, this patch introduces a new OPAC system preference, OpacProtocol, in the Policy subsection. It defaults to doesn't use (http://), but can be changed to uses (https://). basket/sendbasket.pl was tweaked for OpacProtocol changes. opac/opac-sendshelf.pl was returned to previous state, because it affects doc-head-close.inc if OPACBaseURL is not passed. This should be fixed to use the OpacProtocol system preference in another bug fix. virtualshelves/sendshelf.pl was returned to previous state, because the OpacProtocol logic is now in the virtualshelves/sendshelf.tt template file. TEST PLAN - 1) Back up your database 2) Drop your koha database and recreate it empty 3) In the mysql client: SOURCE .../installer/data/mysql/sysprefs.sql; -- It should run without error. SELECT variable,value from systempreferences WHERE variable='OpacProtocol'; -- It should have the value 'http://' 4) Restore your database 5) $ ./installer/data/mysql/updatedatabase.pl -- It should run the upgrade to insert OpacProtocol. 6) In the mysql client: SELECT variable,value from systempreferences WHERE variable='OpacProtocol'; -- It should have the value 'http://' 7) Log into the staff client 8) Click 'Koha administration' 9) Click 'Global system preferences' 10) Click the 'OPAC' tab on the left side. 11) Scroll down to the Policy section, and find the OpacProtocol preference. -- It should have a value of doesn't use in the drop down. 12) Fill your cart with something(s). 13) Make sure you have a list filled with something(s). 14) Click 'Cart' in the top menu bar area. 15) Click 'Send', and send it to yourself. 16) Click 'Close window' 17) Click 'Hide window' 18) Click 'More' and click 'Lists' 19) Choose a list and 'Send list' to yourself. 20) Check your email -- both emails should have OPAC URLs which start with http:// 21) Change the OPAC system preference OpacProtocol to 'uses' (https://), log out and log in (to force refresh of cached system preferences), and repeat steps 14 through 19. 22) Check your email -- the two new emails should have OPAC URLS which start with https:// NOTE: Other URLs may be broken as well, this bug only fixes carts and lists sent from staff. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010
--- Comment #28 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 27049
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27049
Bug 5010: Fix incomplete links in carts and lists sent from the staff client
Review of attachment 27049:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=5010attachment=27049)
-
::: basket/sendbasket.pl
@@ +102,5 @@
+if (C4::Context-preference('OPACBaseURL')){
+my $protocol = C4::Context-preference('OpacProtocol') // 'http://';
+$template2-param( OPACBaseURL = $protocol .
C4::Context-preference('OPACBaseURL') );
+}
koha-tmpl/intranet-tmpl/prog/en/modules/basket/sendbasketform.tt does not have
OPACBaseURL in it. However, doc-head-close.inc does. This is a short-term fix,
as the problem in doc-head-close.inc affects much more than just carts and
lists.
::: koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/sendshelf.tt
@@ +35,4 @@
LCCN: [% BIBLIO_RESULT.lccn %][% END %][% IF ( BIBLIO_RESULT.url ) %]
URL : [% BIBLIO_RESULT.url %][% END %][% IF ( OPACBaseURL ) %]
In the online catalog:
+[% Koha.Preference( 'OPACProtocol' ) %][% OPACBaseURL
%]/cgi-bin/koha/opac-detail.pl?biblionumber=[% BIBLIO_RESULT.biblionumber
|url %][% END %]
Took Kyle's second suggestion from comment #21.
::: opac/opac-sendshelf.pl
@@ +109,5 @@
+if (C4::Context-preference('OPACBaseURL')){
+ $template2-param( OPACBaseURL =
C4::Context-preference('OPACBaseURL') );
+}
+
Oops. I think I let a bad piece in.
::: virtualshelves/sendshelf.pl
@@ +103,2 @@
if (C4::Context-preference('OPACBaseURL')){
+$template2-param( OPACBaseURL =
C4::Context-preference('OPACBaseURL') );
This represents changing it back to what it was initially.
@@ -104,2 @@
if (C4::Context-preference('OPACBaseURL')){
-$template2-param( OPACBaseURL = $protocol .
C4::Context-preference('OPACBaseURL') );
The protocol logic is moved to the template now. Only need the OPACBaseURL,
which is not available by default for staff client pages.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010
--- Comment #29 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 27049
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27049
Bug 5010: Fix incomplete links in carts and lists sent from the staff client
Review of attachment 27049:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=5010attachment=27049)
-
::: opac/opac-sendshelf.pl
@@ +109,5 @@
+if (C4::Context-preference('OPACBaseURL')){
+ $template2-param( OPACBaseURL =
C4::Context-preference('OPACBaseURL') );
+}
+
Nope. Triple check shows this is what it was before. Removing probably does
correct a problem, but it is unrelated to this bug (carts and lists in staff).
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11575 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #19 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Afaik the prefs sort alphabetically within the groups, so putting it right above OPACBaseURL would not be possible without renaming. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #20 from M. Tompsett mtomp...@hotmail.com --- Okay, but you put it in a completely different section. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #13 from M. Tompsett mtomp...@hotmail.com --- I just realized that I would prefer the system preference to be right beside (above preferably) the OPACBaseURL system preference. Because, the text of the OPACBaseURL probably needs tweaking too. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010
--- Comment #14 from M. Tompsett mtomp...@hotmail.com ---
mtompset@ubuntu:~/kohaclone$ git bz apply 5010
Bug 5010 - Incomplete links in carts and lists sent from the staff client
23436 - Bug 5010: Send list emails with complete links back into the catalog
23457 - Bug 5010: Fix incomplete links in carts and lists sent from the staff
client
Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 5010: Send list emails with complete links back into the catalog
Applying: Bug 5010: Fix incomplete links in carts and lists sent from the staff
client
/home/mtompset/kohaclone/.git/rebase-apply/patch:58: trailing whitespace.
$dbh-do(q{INSERT INTO systempreferences ( `variable`, `value`, `options`,
`explanation`, `type` ) VALUES
/home/mtompset/kohaclone/.git/rebase-apply/patch:80: trailing whitespace.
choices:
warning: 2 lines add whitespace errors.
Using index info to reconstruct a base tree...
stdin:58: trailing whitespace.
$dbh-do(q{INSERT INTO systempreferences ( `variable`, `value`, `options`,
`explanation`, `type` ) VALUES
stdin:80: trailing whitespace.
choices:
warning: 2 lines applied after fixing whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
Auto-merging installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/sysprefs.sql
Auto-merging basket/sendbasket.pl
Ugly but it applies. :)
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #23436|0 |1 is obsolete|| --- Comment #15 from M. Tompsett mtomp...@hotmail.com --- Created attachment 25877 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25877action=edit [SIGNED OFF] Bug 5010: Send list emails with complete links back into the catalog This patch adapts the way the links in the cart email in OPAC are generated for the list emails. The OpacBaseURL variable is generated from code in Auth.pm. To test: - Create a list - Email yourself the list Note: Email is sent directly and not via messagequeue table - Verify the links back into the catalog are missing http(s):// - Apply the patch - Email yourself the list again - Verify the links are now ok and working Note: The way Auth.pm generates the OpacBaseURL is not correct, as it does not take into account the OpacBaseURL system preference. This patch makes both emails sent from OPAC rely on the same code and is an improvement over the current behaviour. Tested both together using steps similar to larger test plan. Signed-off-by: Mark Tompsett mtomp...@hotmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #25877|0 |1 is obsolete|| --- Comment #16 from M. Tompsett mtomp...@hotmail.com --- Created attachment 25878 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25878action=edit [SIGNED OFF] Bug 5010: Send list emails with complete links back into the catalog This patch adapts the way the links in the cart email in OPAC are generated for the list emails. The OpacBaseURL variable is generated from code in Auth.pm. To test: - Create a list - Email yourself the list Note: Email is sent directly and not via messagequeue table - Verify the links back into the catalog are missing http(s):// - Apply the patch - Email yourself the list again - Verify the links are now ok and working Note: The way Auth.pm generates the OpacBaseURL is not correct, as it does not take into account the OpacBaseURL system preference. This patch makes both emails sent from OPAC rely on the same code and is an improvement over the current behaviour. Tested both together using steps similar to larger test plan. Signed-off-by: Mark Tompsett mtomp...@hotmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #23457|0 |1 is obsolete|| --- Comment #17 from M. Tompsett mtomp...@hotmail.com --- Created attachment 25879 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25879action=edit [SIGNED OFF] Bug 5010: Fix incomplete links in carts and lists sent from the staff client While the list email hardcoded http:// in front of the URL, the cart email was missing http(s)://. As there seems to be no reliable way to determine in staff if the OPAC is using SSL or not, this patch introduces a new system preference: PublicCatalogUsesSSL. To test: - Create a list - Send yourself the list from the staff interface - Verify that the links are http://OPACBaseURL - Put some records into your cart - Send yourself the cart from the staff interface - Verify that the links are missing http(s):// in front of them - Apply patch - Run database update - Verify that the default setting for PublicCatalogUsesSSL is 'doesn't use' - Resent both emails - Verfiy the catalog links are now both http:// links - Change system preference setting to 'uses' - Resent both emails - Verify the catalog links are now https:// links NOTE: My cart didn't have a 'In online catalog:' line on master. My list had http:// on master. System preference affected both cart and list sending. System preference necessary, because there is no way to determine http or https in the middle of an email. Signed-off-by: Mark Tompsett mtomp...@hotmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #18 from M. Tompsett mtomp...@hotmail.com --- Don't forget to read comment #13. :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #22945|0 |1 is obsolete|| CC||mtomp...@hotmail.com --- Comment #12 from M. Tompsett mtomp...@hotmail.com --- Comment on attachment 22945 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22945 Patch to fix and use OPACBaseURL on all send list and send basket pages Second set of patches looks more thorough. Testing them. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Assignee|gmcha...@gmail.com |katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #8 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 23436 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23436action=edit Bug 5010: Send list emails with complete links back into the catalog This patch adapts the way the links in the cart email in OPAC are generated for the list emails. The OpacBaseURL variable is generated from code in Auth.pm. To test: - Create a list - Email yourself the list Note: Email is sent directly and not via messagequeue table - Verify the links back into the catalog are missing http(s):// - Apply the patch - Email yourself the list again - Verify the links are now ok and working Note: The way Auth.pm generates the OpacBaseURL is not correct, as it does not take into account the OpacBaseURL system preference. This patch makes both emails sent from OPAC rely on the same code and is an improvement over the current behaviour. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010
--- Comment #9 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
The first patch makes sure the URL in the list email is generated like
everywhere else in the OPAC. The same method won't work for the intranet and
the OPACBaseURL is not taken into account at all.
This is what creates the OpacBaseURL in OPAC from Auth.pm:
(($in-{'query'}-https() ? https://; : http://;) . $ENV{'SERVER_NAME'} .
($ENV{'SERVER_PORT'} eq ($in-{'query'}-https() ? 443 : 80) ? '' :
:$ENV{'SERVER_PORT'}))),
Feedback and ideas welcome... the attached patch could still be a small
improvement as it adds consistency and makes the link work.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #10 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 23457 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23457action=edit Bug 5010: Fix incomplete links in carts and lists sent from the staff client While the list email hardcoded http:// in front of the URL, the cart email was missing http(s)://. As there seems to be no reliable way to determine in staff if the OPAC is using SSL or not, this patch introduces a new system preference: PublicCatalogUsesSSL. To test: - Create a list - Send yourself the list from the staff interface - Verify that the links are http://OPACBaseURL - Put some records into your cart - Send yourself the cart from the staff interface - Verify that the links are missing http(s):// in front of them - Apply patch - Run database update - Verify that the default setting for PublicCatalogUsesSSL is 'doesn't use' - Resent both emails - Verfiy the catalog links are now both http:// links - Change system preference setting to 'uses' - Resent both emails - Verify the catalog links are now https:// links -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #11 from Katrin Fischer katrin.fisc...@bsz-bw.de --- NOTE: 2 last patches here are alternatives to the first patch, trying to avoid hardcoding the http:// into the templates. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11248 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010
--- Comment #6 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I have looked into this a bit, it seems that for the OPAC cart the problem does
not exist and I think I found the reason in Auth.pm:
OPACBaseURL = ($in-{'query'}-https() ? https://;
: http://;) . $ENV{'SERVER_NAME'} .
($ENV{'SERVER_PORT'} eq ($in-{'query'}-https() ? 443 :
80) ? '' : :$ENV{'SERVER_PORT'}),
I will try to provide an alternative patch trying to fix it using that logic,
so we don't need to hardcode http:// or https:// into the templates.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Depends on|6957|11248 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Depends on|11248 | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #7 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hm ok, as discussed on IRC: The solution in Auth.pm is not quite right either because it totally ignores the syspref setting. I think a combination of the http/https bit + checking the syspref could do it. For multiple OPACs you can now overwrite the OpacBaseURL in your apache configuration. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Maxime Pelletier pelletiermax...@gmail.com changed: What|Removed |Added CC||pelletiermax...@gmail.com --- Comment #4 from Maxime Pelletier pelletiermax...@gmail.com --- A note that since ug 8368 the link is also broken in the OPAC for send cart and send list. http://; was removed before the OPACBaseURL variable, so the link is now localhost/cgi-bin/koha/opac-detail.pl?biblionumber=11 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #5 from Maxime Pelletier pelletiermax...@gmail.com --- Created attachment 22945 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22945action=edit Patch to fix and use OPACBaseURL on all send list and send basket pages Fix use of OPACBaseURL on send list(shelf) and send basket of OPAC and staff client. To test, try sending a list and a basket in both opac and staff pages. All links should contains http:// followed by OPACBaseURL. If OPACBaseURL isn't set in the preferences, no links should be in the email. I hardcoded http://; everywhere because no decision were taken in bug #7770, so the preference description still says that the http:// shouldn't be in OPACBaseURL. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Bug 5010 depends on bug 6957, which changed state. Bug 6957 Summary: Authors disappearing when emailing lists http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6957 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- This is still a problem on current master: Mailing a cart from the staff client I my URLs look like: /cgi-bin/koha/opac-detail.pl?biblionumber=11 Mailing a cart from the OPAC my URLs look like: http://localhost/cgi-bin/koha/opac-detail.pl?biblionumber=11 staffClientBaseURL = localhost:8080 OpacBaseURL = localost -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Version|rel_3_2 |master Depends on||6957 --- Comment #2 from Owen Leonard oleon...@myacpl.org 2011-10-05 20:07:34 UTC --- My fix for Bug 6957 will address this issue by hiding the link if the OPACBaseURL preference is not filled out. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
