[Koha-bugs] [Bug 5473] 952 fields should be filled in by Acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5473 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #23 from Jared Camins-Esakov jcam...@cpbibliography.com --- This fix was included in the 3.6.x branch prior to 3.6.4. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5473] 952 fields should be filled in by Acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5473 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Priority|PATCH-Sent (DO NOT USE) |P2 Status|Signed Off |Passed QA Version|master |rel_3_6 --- Comment #22 from Paul Poulain paul.poul...@biblibre.com 2012-01-20 15:32:40 UTC --- QA comment: * a warn must be removed: +warn AAA $itemnumber; * the patch also updated some PODDOC and removed some commented code I made a follow-up: * removing the warn * updating some indentation (s/tab/4 spaces/, that where not in the patch, but where here since years) I made tests with UNIMARC, everything is OK (as I suspected, as there is no more hardcoded values, and using ModItem is the way to go) Just about: Interface to ModItem() is just insane... This is a little bit short man. What is insane, and which alternative do you propose ? Just saying it's insane won't help fixing the insanity ;-) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5473] 952 fields should be filled in by Acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5473 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5473] 952 fields should be filled in by Acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5473 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Attachment #6877|0 |1 is obsolete|| --- Comment #21 from Nicole C. Engard neng...@gmail.com 2011-12-20 14:35:21 UTC --- Created attachment 6888 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6888 [SIGNED-OFF] bug_5473: Update items when receiving shipments Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com Tested by recieving multiple items with the AcqCreateItem preference set to 'placing and order' and 'receiving an item' In both cases the pricing and vendor is brought over to the item record so I'm signing off. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5473] 952 fields should be filled in by Acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5473 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5473] 952 fields should be filled in by Acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5473 --- Comment #19 from Nicole C. Engard neng...@gmail.com 2011-12-19 15:48:38 UTC --- I'm still seeing the same thing - see here: http://screencast.com/t/sQUZIHbszbL -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5473] 952 fields should be filled in by Acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5473 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #6855|0 |1 is obsolete|| --- Comment #20 from Srdjan Jankovic srd...@catalyst.net.nz 2011-12-20 01:59:06 UTC --- Created attachment 6877 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6877 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5473] 952 fields should be filled in by Acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5473 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #6646|0 |1 is obsolete|| --- Comment #18 from Srdjan Jankovic srd...@catalyst.net.nz 2011-12-19 05:01:32 UTC --- Created attachment 6855 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6855 patch Interface to ModItem() is just insane... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5473] 952 fields should be filled in by Acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5473 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Patch Status|Needs Signoff |Failed QA --- Comment #17 from Nicole C. Engard neng...@gmail.com 2011-12-14 15:05:48 UTC --- This works awesome if you have your AcqCreateItem preference is set to 'placing an order' but if it's set to 'receiving an order' then it looks like the pricing info is not populating the item record at all. I think that it needs to work for both of these options for AcqCreateItem. I don't think it's possible to have it work for the third option on the preference of 'cataloging the record' but am up to being corrected if I'm wrong. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5473] 952 fields should be filled in by Acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5473 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #5410|0 |1 is obsolete|| --- Comment #16 from Srdjan Jankovic srd...@catalyst.net.nz 2011-12-07 21:26:50 UTC --- Created attachment 6646 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6646 patch The last comment is absolutely valid, I made a wrong assumption. This patch should apply correct update. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5473] 952 fields should be filled in by Acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5473 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5473] 952 fields should be filled in by Acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5473 Marijana mglav...@ffzg.hr changed: What|Removed |Added CC||mglav...@ffzg.hr -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5473] 952 fields should be filled in by Acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5473 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Patch Status|Needs Signoff |Failed QA --- Comment #14 from Katrin Fischer katrin.fisc...@bsz-bw.de 2011-09-18 20:43:50 UTC --- I would love to see this functionality in Koha, but I think Paul is right that it should be redone to check for the mapping of the fields instead of using the marc fields. So add the value into the field that is mapped to the right database column. Or it needs to be possible to be turned off/on, because it might not be useful bordering to annoying for libraries not using this combination of fields. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5473] 952 fields should be filled in by Acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5473 --- Comment #13 from Paul Poulain paul.poul...@biblibre.com 2011-09-13 08:37:19 UTC --- mmm... the more I see it, the more I dislike it... hardcoding values that can be set differently In C4/Biblio, there is GetMarcFromKohaField, that you could call with items.itemnumber to retrieve the MARC field for items. That could be safer for the 0.01% of libraries that don't use 952 for items and will be very disappointed to loose some data or think they've found a bug. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5473] 952 fields should be filled in by Acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5473 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added CC||paul.poul...@biblibre.com Patch Status|Needs Signoff |Failed QA --- Comment #11 from Paul Poulain paul.poul...@biblibre.com 2011-09-12 14:01:30 UTC --- frenchy/UNIMARC guy comment: Looking at this patch I heavily suspect some MARC things are hardcoded and it would heavily break non MARC21 instances... A if (marcflavour eq marc21) would be a bare minimum PS : are you sure *everybody* using marc21 will have field 952 with those subfields content ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5473] 952 fields should be filled in by Acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5473 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #5369|0 |1 is obsolete|| --- Comment #12 from Srdjan Jankovic srd...@catalyst.net.nz 2011-09-13 00:29:44 UTC --- Created attachment 5410 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5410 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5473] 952 fields should be filled in by Acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5473 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5473] 952 fields should be filled in by Acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5473 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Patch Status|Needs Signoff |Failed QA --- Comment #8 from Srdjan Jankovic srd...@catalyst.net.nz 2011-09-08 23:24:30 UTC --- If the order of subfields is meaningful then I'll have to correct my patch slightly -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5473] 952 fields should be filled in by Acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5473 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Patch Status|Failed QA |Needs Signoff --- Comment #10 from Srdjan Jankovic srd...@catalyst.net.nz 2011-09-09 01:43:34 UTC --- Ready for testing -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5473] 952 fields should be filled in by Acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5473 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|henridam...@koha-fr.org |srd...@catalyst.net.nz --- Comment #3 from Srdjan Jankovic srd...@catalyst.net.nz 2011-09-07 08:35:03 UTC --- Created attachment 5335 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5335 patch I did not know where to source Price effective from, the only date available is Date received -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5473] 952 fields should be filled in by Acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5473 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff Change sponsored?|--- |Sponsored -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5473] 952 fields should be filled in by Acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5473 --- Comment #4 from Nicole C. Engard neng...@gmail.com 2011-09-07 13:21:48 UTC --- Srdjan, I guess the received date would work. I have tested this and it's not doing anything differently so I'm wondering if you could give me a test plan. I ordered two titles and added items at the time I placed the order. When I received the items they were not updated with the pricing information. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5473] 952 fields should be filled in by Acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5473 --- Comment #5 from Nicole C. Engard neng...@gmail.com 2011-09-07 15:40:36 UTC --- Via the mailing list : On Wed, Sep 7, 2011 at 4:52 AM, LAURENT Henri-Damien henridamien.laur...@biblibre.com wrote: Hi In my opinion, append_fields should not be used that much. use insert_fields_ordered or insert_fields_before rather than append_fields... Why ? Because usually, what you want is tags to be grouped and not dispatched in the biblio. And append_fields will append them at the end of the record. If the record is too long, then it will simply fail to index that part. (when 999 tag/subfields which stores the biblionumber, you would certainly have indexing problems on big records.) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5473] 952 fields should be filled in by Acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5473 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #5335|0 |1 is obsolete|| --- Comment #6 from Srdjan Jankovic srd...@catalyst.net.nz 2011-09-08 04:15:39 UTC --- Created attachment 5348 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5348 patch I have replaced append_fields() with insert_fields_ordered(). Also using $field-update when appropriate. Anote on subfields: they are not ordered within fields. My impression is that it is like that anyway. I can order them if required When testing I used Add Order To Basket - From an existing record - From a Suggestion - From a new (empty) record Not tried From an external source and From a staged file After receiving all orders and looking MARC lightbox popup all 952 subfields showed as expected -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
