[Koha-bugs] [Bug 5630] CAS improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 Dobrica Pavlinusic changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23723 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 Olli-Antti Kivilahti changed: What|Removed |Added Blocks||18237 CC||olli-antti.kivila...@jns.fi Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18237 [Bug 18237] Can't use a hash as a reference at docs/CAS/CASProxy/examples/proxy_cas_data.pl line 60. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 Matthias Meusburger changed: What|Removed |Added Blocks||8279 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 Chris Cormack changed: What|Removed |Added Patch Status|Passed QA |Patch Pushed --- Comment #33 from Chris Cormack 2011-10-12 21:54:26 UTC --- Introduces no string changes, Pushing please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 --- Comment #32 from Ian Walls 2011-10-12 20:27:15 UTC --- Applying the 3 patches in order seems to resolve any of the bleed-through issues with LDAP authentication and Search History. Required installation of Authen::CAS::Client is noted in the C4/Installer/PerlDependencies.pm modules. The rest of the changes are all to Auth_with_cas.pm, which I don't have the means to test right now (but I'm sure Paul has working to his libraries' satisfaction). Marking as Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 Paul Poulain changed: What|Removed |Added Patch Status|Failed QA |Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 --- Comment #31 from Paul Poulain 2011-09-02 16:22:00 UTC --- Created attachment 5297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5297 proposed patch follow-up 2 After speaking with Matthias, this file is necessary if you want to check the test provided in docs. It could have been empty. I've reviewed all the patch, and don't see anything that should not be here. I did some tests, nothing seems brokent (and nothing in the message log) chris = not sure what to do with the patch status in such a case. will switch back to QA passed, but this may be disputable -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 --- Comment #30 from Paul Poulain 2011-09-02 10:39:42 UTC --- I've reviewed the code, I've found another strange thing, the file docs/CAS/CASProxy/examples/casSession.tmp I've asked matts to confirm it can be removed. Will submit a follow-up in a few hours (removing the search_history stuff) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 --- Comment #29 from Paul Poulain 2011-09-02 07:49:26 UTC --- it's probably a mistake when splitting the "BibLibre big branch". bug 5981 is related to the search history problem (and i'll submit a new patch in the next minutes, I was working on it) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630
Chris Cormack changed:
What|Removed |Added
Patch Status|Needs Signoff |Failed QA
--- Comment #28 from Chris Cormack 2011-09-02
01:22:41 UTC ---
Sorry my bad, I shouldn't have pushed this.
It contains code that changes more than just CAS, including code that changes
the way search history is stored, and without a corresponding change to the
database.
I am reverting it, it needs to be tidied up, the changes like
+VALUES( ?, ?, ?, ?,
?, ?, ?, FROM_UNIXTIME(?))
EOQ
sub get_template_and_user {
my $in = shift;
@@ -264,13 +271,9 @@ sub get_template_and_user {
my @recentSearches = @{thaw($searchcookie) || []};
if (@recentSearches) {
my $sth = $dbh->prepare($SEARCH_HISTORY_INSERT_SQL);
-$sth->execute( $borrowernumber,
- $in->{'query'}->cookie("CGISESSID"),
- $_->{'query_desc'},
- $_->{'query_cgi'},
- $_->{'total'},
- $_->{'time'},
-) foreach @recentSearches;
+
+$sth->execute( $borrowernumber,
$in->{'query'}->cookie("CGISESSID"), $_->{'query_desc'}, $_->{'query_cgi'},
$_->{'limit_desc'}, $_->{'limit_cgi'}, $_->{'total'}, $_->{'time'}, )
+foreach @recentSearches;
Need to be removed and put in their own bug. With the corresponding database
change, the lack of which is causing the error Marcel reports
Plus the patch from Ian integrated.
--
Configure bugmail:
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 M. de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #27 from M. de Rooy 2011-09-01 13:18:59 UTC --- (In reply to comment #22) > Without a CAS server to test against, I have no real way of checking, however > if it works for Biblibre who have clients using it, and Paul has signed off, > that is enough for me to push it. > I have tested it doesnt touch non CAS auth, so no regressions. > Pushed please test. Recent error [Thu Sep 01 14:22:45 2011] [error] [client 192.87.126.61] [Thu Sep 1 14:22:45 2011] opac-MARCdetail.pl: DBD::mysql::st execute failed: Unknown column 'limit_desc' in 'field list' at /usr/share/koha/testclone/C4/Auth.pm line 276. Seems to come from this commit 9a3950f673c28688a2ead6514c3320e34ec0cc4c (5630 CAS Improvements) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 --- Comment #26 from Ian Walls 2011-08-31 10:35:05 UTC --- One other thing to note: Authen::CAS::Client has gone from optional to required. While C4/Installer/PerlDependencies.pm already has it marked as such, many libraries were able up to this point to use Koha without it without incident. Do the Debian dependencies need to be updated, as well? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 --- Comment #25 from Ian Walls 2011-08-30 15:57:22 UTC --- Paul, No, no explanation. We're running off master (as of yesterday, I believe). Looking at the code, I'm not sure how your tests worked, if checkpw_ldap was never imported into C4/Auth.pm. Either it would have needed to have been explicitly specified as C4::Auth_with_ldap::checkpw_ldap, or checkpw_ldap added to @INC in C4/Auth_with_ldap.om. Or, I'm missing some nuance of how perl require/import works. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 Paul Poulain changed: What|Removed |Added Severity|enhancement |normal --- Comment #24 from Paul Poulain 2011-08-30 15:36:08 UTC --- It's no more an ENH, it now a follow-up to fix a bug. Ian = Was there something specific in your configuration that could explain my tests worked and not yours ? ( There's nothing in my test, I just used biblibre internal ldap server :( ) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 Ian Walls changed: What|Removed |Added Patch Status|Patch Pushed|Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 --- Comment #23 from Ian Walls 2011-08-30 14:44:07 UTC --- Created attachment 5219 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5219 Follow up Patch Previous patch stopped checkpw_ldap from being imported, resulting in an error message the C4::Auth::checkpw_ldap is undefined. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 Julian Maurice changed: What|Removed |Added Blocks||6694 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 Chris Cormack changed: What|Removed |Added Patch Status|Passed QA |Patch Pushed --- Comment #22 from Chris Cormack 2011-08-10 01:18:28 UTC --- Without a CAS server to test against, I have no real way of checking, however if it works for Biblibre who have clients using it, and Paul has signed off, that is enough for me to push it. I have tested it doesnt touch non CAS auth, so no regressions. Pushed please test. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 Bug 5630 depends on bug 6012, which changed state. Bug 6012 Summary: Set up a working example of a CAS proxy http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6012 What|Old Value |New Value Status|ASSIGNED|RESOLVED Resolution||DUPLICATE --- Comment #21 from Paul Poulain 2011-08-09 15:07:59 UTC --- *** Bug 6012 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 --- Comment #20 from Paul Poulain 2011-08-09 13:48:46 UTC --- yikes ! you're right. At the beginning, I wrote "works" everywhere when testing. Then I realized in fact when login is rejected, "works" can be suspicious. So I changed what I wrote and forgot c) :'(( (time to head for 2 weeks AFK ;-) ) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 --- Comment #19 from Frère Sébastien Marie 2011-08-09 13:45:14 UTC --- (In reply to comment #18) > QA comment > > (works = I could connect) > > I've checked [...] > b) by userid for invalid userid/password > => works [...] > > marking passed QA, no specific problem detected. > I hope the (b) case should be read as "login rejected"... else I think there is a specific problem: user could log with wrong password :-) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 Paul Poulain changed: What|Removed |Added Patch Status|Signed Off |Passed QA --- Comment #18 from Paul Poulain 2011-08-09 13:33:52 UTC --- QA comment (works = I could connect) I've checked a) by userid for valid userid/password => works b) by userid for invalid userid/password => works c) by cardnumber for valid cardnumber/password => works d) by cardnumber for invalid cardnumber/password => login rejected e) by root database user => works Situation 2: LDAP authentication Check logins: a) by valid LDAP userid/password => works b) by invalid LDAP userid/password, but valid Koha userid/password => works c) by invalid LDAP userid/password, but valid Koha cardnumber/password => works d) by invalid LDAP userid/password and invalid Koha userid/password => login rejected e) by root database user => works (tested against BibLibre internal LDAP. I haven't checked all possible combination of replicate/update, as the code really has nothing to do with those flags. Same comment for auth_by_bind ON and OFF) marking passed QA, no specific problem detected. (ouch... was quite long & complex to set up all that stuff ;-) ) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 --- Comment #17 from Ian Walls 2011-08-05 12:05:32 UTC --- OK, so a testing plan to check against regressions: Situation 1: Koha-only authentication Check logins: a) by userid for valid userid/password b) by userid for invalid userid/password c) by cardnumber for valid cardnumber/password d) by cardnumber for invalid cardnumber/password e) by root database user Situation 2: LDAP authentication (I believe the particular configurations of the LDAP are irrelevant here, but for more rigour, check with all combinations of update/replicate on/off) Check logins: a) by valid LDAP userid/password b) by invalid LDAP userid/password, but valid Koha userid/password c) by invalid LDAP userid/password, but valid Koha cardnumber/password d) by invalid LDAP userid/password and invalid Koha userid/password e) by root database user All that said, I suspect that this will apply fine to Koha without any breakages, given the limited changes to C4/Auth.pm and opac-user.tt. But, please test all 10 conditions and provide results to earn "Passed QA" status. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 --- Comment #16 from Paul Poulain 2011-08-05 11:47:35 UTC --- Ian, FYI: I don't know for anyone in the community that uses cas. I've searched for a demo server on internet and couldn't find one. What I suggest would be to test that it doesn't break anything without CAS. If someone else tries to setup CAS and has problem, he will report it. Note most of our universities (5 so far) uses CAS, I don't know the details, but that's not just one. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 --- Comment #15 from Ian Walls 2011-08-05 11:34:54 UTC --- Does anyone else in the community use CAS Authentication? If not, would it be possible to set up a CAS server for community testing? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 Paul Poulain changed: What|Removed |Added CC||ian.walls@bywatersolutions. ||com --- Comment #14 from Paul Poulain 2011-08-03 15:40:32 UTC --- QA comment Ian/chris, won't mark it "passed QA", as i've signed-off. Just can guarantee i've tested it against the servers of one of our customer, and it works. There is a documentation provided (docs/ directory), as well as an example C4/Auth_cas_servers.yaml.orig I've detected a docs/CAS/CASProxy/examples/casSession.tmp| Bin 0 -> 134 bytes file in git, that could probably be not here, but it's created My opinion is that it can be applied to master, but i'll let you decide -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 --- Comment #13 from Paul Poulain 2011-07-22 09:50:24 UTC --- (I also have squashed all patches in one) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 Paul Poulain changed: What|Removed |Added Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 Paul Poulain changed: What|Removed |Added Attachment #3549|0 |1 is obsolete|| Attachment #3550|0 |1 is obsolete|| Attachment #3551|0 |1 is obsolete|| Attachment #3552|0 |1 is obsolete|| Attachment #3553|0 |1 is obsolete|| Attachment #3813|0 |1 is obsolete|| --- Comment #12 from Paul Poulain 2011-07-22 09:49:48 UTC --- Created attachment 4716 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4716 proposed patch squashed, rebased and signed-off I've : * rebased the patch * fixed a small H::T::P string remaining * tested on a test CAS server works fine, signing-off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 Paul Poulain changed: What|Removed |Added Patch Status|Does not apply |Needs Signoff --- Comment #11 from Paul Poulain 2011-04-08 13:05:01 UTC --- matts forgot to switch back to Needs signoff I think -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 --- Comment #10 from MJ Ray (software.coop) 2011-04-08 06:29:16 UTC --- This bug is mentioned in: Bug 5630 CAS improvements http://lists.koha-community.org/pipermail/koha-patches/2011-March/014374.html Bug 5630 : MT4057: Let the user choosethe CAS server to authenticate against in case of multipleCAS servers http://lists.koha-community.org/pipermail/koha-patches/2011-March/014375.html Bug 5630 add PSGI ability to C4::Auth http://lists.koha-community.org/pipermail/koha-patches/2011-March/014376.html Bug 5630 : MT4057: [Follow-up] Let the userchoose the CAS server to authenticate against in case ofmultiple CAS servers http://lists.koha-community.org/pipermail/koha-patches/2011-March/014378.html Bug 5630 : MT4704: Fix multiple CASauthentication http://lists.koha-community.org/pipermail/koha-patches/2011-March/014377.html -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 --- Comment #9 from Matthias Meusburger 2011-04-07 15:18:56 UTC --- Created attachment 3813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3813 Compilation errors and syspref edition - This patch fixes compilation errors due to previous patches - It also fixes syspref edition that was broken when CAS authentication was enabled. *But* this may break CAS-Proxy authentication. It needs to be tested. CAS Proxy is not an easy feature to set up. But there are (working) examples in docs/CAS/CASProxy. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630
--- Comment #8 from claire.hernan...@biblibre.com
2011-04-05 12:33:41 UTC ---
Try to add to proposedpatch lines
- C4/Auth.pm
warn "OPAC Install required, redirecting to maintenance";
553print $query->redirect("/cgi-bin/koha/maintenance.pl");
554}
555unless ($version = C4::Context->preference('Version')) {#
assignment, not comparison
556 if ($type ne 'opac') {
557warn "Install required, redirecting to Installer";
558print $query->redirect("/cgi-bin/koha/installer/install.pl");
559 }
560 else {
(no more compilations errors)
- Auth_with_cas.pm
add "use YAML"
Tests done:
- syspref casAUthentication to true and an ip set -> log in opac ok
- with this configuration sysprefs weren't editable anymore (error)
- syspref casAUthentication to true and yaml file with differents servers -> ko
--
Configure bugmail:
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 claire.hernan...@biblibre.com changed: What|Removed |Added CC||claire.hernandez@biblibre.c ||om Patch Status|Needs Signoff |Does not apply --- Comment #7 from claire.hernan...@biblibre.com 2011-04-05 10:13:01 UTC --- Follow up 2 and 3 gives me: fatal: sha1 information is lacking or useless (C4/Auth.pm). Repository lacks necessary blobs to fall back on 3-way merge. so I applied others and on koha pro homepage I have: Global symbol "$version" requires explicit package name at /home/koha/versions//koha_community/C4/Auth.pm line 573. Global symbol "$version" requires explicit package name at /home/koha/versions//koha_community/C4/Auth.pm line 574. Global symbol "$type" requires explicit package name at /home/koha/versions//koha_community/C4/Auth.pm line 575. Global symbol "$query" requires explicit package name at /home/koha/versions//koha_community/C4/Auth.pm line 577. Global symbol "$query" requires explicit package name at /home/koha/versions//koha_community/C4/Auth.pm line 580. Unmatched right curly bracket at /home/koha/versions//koha_community/C4/Auth.pm line 584, at end of line syntax error at /home/koha/versions//koha_community/C4/Auth.pm line 584, near "}" syntax error at /home/koha/versions//koha_community/C4/Auth.pm line 591, near "}" Bareword "C4::Auth_with_cas::multipleAuth" not allowed while "strict subs" in use at /home/koha/versions//koha_community/C4/Auth.pm line 960. syntax error at /home/koha/versions//koha_community/C4/Auth.pm line 996, near "}" /home/koha/versions//koha_community/C4/Auth.pm has too many errors. Compilation failed in require at /home/koha/versions/koha_community/mainpage.pl line 23. BEGIN failed--compilation aborted at /home/koha/versions/koha_community/mainpage.pl line 23 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 Matthias Meusburger changed: What|Removed |Added Blocks||5983 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 --- Comment #6 from Chris Cormack 2011-03-30 21:31:59 UTC --- Created attachment 3553 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3553 Followup 4 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 --- Comment #5 from Chris Cormack 2011-03-30 21:30:02 UTC --- Created attachment 3552 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3552 Followup 3 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 --- Comment #4 from Chris Cormack 2011-03-30 21:29:37 UTC --- Created attachment 3551 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3551 Follow up 2 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 --- Comment #3 from Chris Cormack 2011-03-30 21:13:21 UTC --- Created attachment 3550 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3550 Follow up patch number 1 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 --- Comment #2 from Chris Cormack 2011-03-30 21:12:49 UTC --- There are 4 more patches that could belong here but they do not apply. Working on refactoring them and adding them as a follow up patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 --- Comment #1 from Chris Cormack 2011-03-30 21:08:40 UTC --- Created attachment 3549 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3549 Proposed Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 Chris Cormack changed: What|Removed |Added Priority|P5 |PATCH-Sent -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 Chris Cormack changed: What|Removed |Added Depends on||6012 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 Chris Cormack changed: What|Removed |Added Blocks||5992 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 Chris Cormack changed: What|Removed |Added Priority|PATCH-Sent |P5 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5630] CAS improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
