[Koha-bugs] [Bug 5634] Ordering branches should be case independent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 Jonathan Druart changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=9457 --- Comment #17 from Jonathan Druart --- Patch submitted on bug 9457 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5634] Ordering branches should be case independent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |RESOLVED Resolution|--- |FIXED --- Comment #16 from Jonathan Druart --- Works on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5634] Ordering branches should be case independent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 Jonathan Druart changed: What|Removed |Added Attachment #14505|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5634] Ordering branches should be case independent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 --- Comment #15 from Bernardo Gonzalez Kriegel --- Ok, no problem for me. A new bug is cleaner, but this patch do not solve all cases. So, have to be several patches and/or bugs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5634] Ordering branches should be case independent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 --- Comment #14 from Jonathan Druart --- Hi Bernardo, Could you create a new bug and submit your patch in it please? Since this patch has been pushed to master, all new followups must be proposed in a new bug. Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5634] Ordering branches should be case independent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5634] Ordering branches should be case independent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Pushed to Master|ASSIGNED CC||bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5634] Ordering branches should be case independent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 --- Comment #13 from Bernardo Gonzalez Kriegel --- Created attachment 14505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14505&action=edit Bug 5634 - Followup - Ordering branches should be case independent This followup replace use of CGI::scroll_list() to show list of branches. In two files, marc21_linking_section.pl and unimarc_field_4XX.pl, the scrolling list is created but not used in the template file, so the code is removed. Also minor renaming/normalizing of variables. To test: 1) Install with some branches, records and patrons 2.1) Select a record, click 'Place hold', select user, there is a pull-down next to 'Pickup at:', list is ordered case sensitive 2.2) Go to Reports > Average loan time, next to Library is a pull-down, list without order 2.3) Go to Reports > Catalog by item type, next to 'Select a library' is a pull-down, list is ordered case sensitive 2.4) This is tricky, go to Reports home, change last part of URL 'reports-home.pl' with 'manager.pl?report_name=issues_by_borrower_category' (can't find a direct link), next to 'Select a library' is a library pull-down, list without order 2.5) Edit/Add a patron, on section 'Library management' there is a library pull-down, case sensitive 2.6) OPAC, as logged user, make a suggestion or hold, there is library pull-down, correct order 3) Apply the patch 4.1) Repeat 2.1), correctly ordered list 4.2) Repeat 2.2), correctly ordered list 4.3) Repeat 2.3), correctly ordered list 4.4) Repeat 2.4), correctly ordered list 4.5) This is a bit more work There are 3 possible situations to test: A) No branches, must show a message that are no libraries defined B) New patron, must show a correctly ordered list of branches, current branch selected C) Edit patron, must show a correctly ordered list of branches, patron branch selected 4.6) Small changes on variable names, so retest 2.6) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5634] Ordering branches should be case independent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 Jared Camins-Esakov changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #12 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5634] Ordering branches should be case independent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 Jonathan Druart changed: What|Removed |Added Attachment #14201|0 |1 is obsolete|| --- Comment #11 from Jonathan Druart --- Created attachment 14220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14220&action=edit Follow-up Bug 5634: Ordering branches should be case independent This patch fix the order of branches in the log-in page, on Branch.pm we added the variable branchcode to the hash returned by GetBranchesLoop, and this function is used on Auth.pm to get a list of branches ordered by branchname To test 1) Use an installation with some branches 2) On login screen the branches are ordered by branchcode 3) apply the patch 4) On login screen the branches are now ordered by branchname Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart This patch works as expected. Before applying the patch the branches with lower case was at the end of the list. Now they are well ordered. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5634] Ordering branches should be case independent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m QA Contact|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m --- Comment #10 from Jonathan Druart --- QA Comments: The odications in C4/Branch.pm are just in order to not use the default variable ($_). On the login page we call the GetBranchesLoop routine. Marked as Passed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5634] Ordering branches should be case independent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 Chris Cormack changed: What|Removed |Added Attachment #14200|0 |1 is obsolete|| -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5634] Ordering branches should be case independent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 Chris Cormack changed: What|Removed |Added Attachment #3006|0 |1 is obsolete|| -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5634] Ordering branches should be case independent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5634] Ordering branches should be case independent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 --- Comment #9 from Chris Cormack --- Created attachment 14201 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14201&action=edit Follow-up Bug 5634: Ordering branches should be case independent This patch fix the order of branches in the log-in page, on Branch.pm we added the variable branchcode to the hash returned by GetBranchesLoop, and this function is used on Auth.pm to get a list of branches ordered by branchname To test 1) Use an installation with some branches 2) On login screen the branches are ordered by branchcode 3) apply the patch 4) On login screen the branches are now ordered by branchname Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5634] Ordering branches should be case independent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 Chris Cormack changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5634] Ordering branches should be case independent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 --- Comment #8 from Nadia Nicolaides --- Created attachment 14200 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14200&action=edit Follow-up Bug 5634: Ordering branches should be case independent This patch fix the order of branches in the log-in page, on Branch.pm we added the variable branchcode to the hash returned by GetBranchesLoop, and this function is used on Auth.pm to get a list of branches ordered by branchname To test 1) Use an installation with some branches 2) On login screen the branches are ordered by branchcode 3) apply the patch 4) On login screen the branches are now ordered by branchname -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5634] Ordering branches should be case independent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 Owen Leonard changed: What|Removed |Added Status|Pushed to Master|ASSIGNED Version|3.4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5634] Ordering branches should be case independent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
