[Koha-bugs] [Bug 5680] When deleting an order, delete attached items, and if applicable biblio

2013-03-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680

mathieu saby mathieu.s...@univ-rennes2.fr changed:

   What|Removed |Added

 CC||mathieu.saby@univ-rennes2.f
   ||r

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5680] When deleting an order, delete attached items, and if applicable biblio

2012-07-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=7162

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5680] When deleting an order, delete attached items, and if applicable biblio

2012-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

 CC||mag...@enger.priv.no
 Blocks||8149

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5680] When deleting an order, delete attached items, and if applicable biblio

2011-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680

Ian Walls ian.wa...@bywatersolutions.com changed:

   What|Removed |Added

   Attachment #5916|0   |1
is obsolete||

--- Comment #29 from Ian Walls ian.wa...@bywatersolutions.com 2011-10-18 
20:39:34 UTC ---
Created attachment 5965
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5965
Passed QA followup patch

Followup patch passed QA; minor change to template language.  Was showing items
remaining, but talking about holds remaining, so I made that consistent.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5680] When deleting an order, delete attached items, and if applicable biblio

2011-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680

Ian Walls ian.wa...@bywatersolutions.com changed:

   What|Removed |Added

 CC||ian.walls@bywatersolutions.
   ||com
   Patch Status|Signed Off  |Passed QA

--- Comment #30 from Ian Walls ian.wa...@bywatersolutions.com 2011-10-18 
20:41:06 UTC ---
I've tested and reviewed these patches, and found them sound.  Some minor
updates to apply to current HEAD, and fix a small language issue in a tooltip.

Some new C4::Items subroutines here... could be very helpful in our de-nesting
efforts be removing the need to include other modules than C4::Items.  Will
investigate in the future.

Passed QA

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5680] When deleting an order, delete attached items, and if applicable biblio

2011-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

   Patch Status|Passed QA   |Patch Pushed

--- Comment #31 from Chris Cormack ch...@bigballofwax.co.nz 2011-10-19 
03:59:48 UTC ---
Pushed, thank you Katrin and Ian for the good testing, and Christophe for all
your hard work writing the card.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5680] When deleting an order, delete attached items, and if applicable biblio

2011-10-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Attachment #5904|0   |1
is obsolete||

--- Comment #27 from Katrin Fischer katrin.fisc...@bsz-bw.de 2011-10-17 
06:09:50 UTC ---
Created attachment 5916
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5916
[SIGNED-OFF] Bug 5680: Follow Up for Order cancelling improvement : the same
for parcel.pl

The same scope than in basket.pl

Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Detailed information about possible deletion of orders on parcel page.

1) Delete order for record with 1 other item and item level hold
OK. Record, item and hold remain, only on order item is deleted.

2) Delete order for ordered record with 1 item and title level hold
OK. Deletion is not possible, before hold is cancelled.

3) Delete order for new record with only items connected to this order
OK. Cancelling the order deletes record and item or only order,
depending on link used.

4) Delete order for record with subscription.
OK. Subscription remains untouched, item is deleted.

Also checked:
AcqCreateItem = on receive / in cataloging
Links show and it's possible to delete the order or only the record
using different links.

Comments:
There is a table sorter option for the last column with the delete links.
I am not sure it is useful here, but it does work.

Before patch is applied, the links use 'cancel' instead of 'delete'.
I am not sure which is better and if it should be different on
basket summary and order receive or the same on both.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5680] When deleting an order, delete attached items, and if applicable biblio

2011-10-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Patch Status|Needs Signoff   |Signed Off

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5680] When deleting an order, delete attached items, and if applicable biblio

2011-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680

--- Comment #25 from Katrin Fischer katrin.fisc...@bsz-bw.de 2011-10-17 
05:50:22 UTC ---
Created attachment 5914
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5914
screenshot of messages on order receive page

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5680] When deleting an order, delete attached items, and if applicable biblio

2011-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Attachment #5914|screenshot of messages on   |screenshot of messages on
description|order receive page  |basket summary page

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5680] When deleting an order, delete attached items, and if applicable biblio

2011-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680

--- Comment #26 from Katrin Fischer katrin.fisc...@bsz-bw.de 2011-10-17 
05:53:33 UTC ---
Created attachment 5915
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5915
screenshot of messages on order receive page

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5680] When deleting an order, delete attached items, and if applicable biblio

2011-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680

--- Comment #23 from Christophe Croullebois 
christophe.croulleb...@biblibre.com 2011-10-15 20:50:17 UTC ---
Created attachment 5904
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5904
Bug 5680: Follow Up for Order cancelling improvement : the same for parcel.pl

It is the part concerning the parcel.pl page.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5680] When deleting an order, delete attached items, and if applicable biblio

2011-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680

--- Comment #24 from Christophe Croullebois 
christophe.croulleb...@biblibre.com 2011-10-15 20:58:42 UTC ---
Hello Katrin,
I hope this part is ok.
I have created one more column in parcel.pl.
Of course it was not the same script, so I hope I haven't forgotten something.
Good tests.
Thx

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5680] When deleting an order, delete attached items, and if applicable biblio

2011-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680

Christophe Croullebois christophe.croulleb...@biblibre.com changed:

   What|Removed |Added

   Patch Status|Failed QA   |Needs Signoff

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5680] When deleting an order, delete attached items, and if applicable biblio

2011-10-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680

--- Comment #22 from Christophe Croullebois 
christophe.croulleb...@biblibre.com 2011-10-11 07:32:33 UTC ---
Katrin,
many thx for your tests.
Oups, I have forgotten the basket summary page...
I'll work on a follow up.
Right, it's better with your changes, visualy it's clearer.
So  with your help, quite to have something.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5680] When deleting an order, delete attached items, and if applicable biblio

2011-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680

Christophe Croullebois christophe.croulleb...@biblibre.com changed:

   What|Removed |Added

   Attachment #4256|0   |1
is obsolete||

--- Comment #17 from Christophe Croullebois 
christophe.croulleb...@biblibre.com 2011-10-09 18:54:49 UTC ---
Created attachment 5813
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5813
The lat one

I finalize this patch taking in count katrin's comments.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5680] When deleting an order, delete attached items, and if applicable biblio

2011-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680

--- Comment #18 from Christophe Croullebois 
christophe.croulleb...@biblibre.com 2011-10-09 19:38:17 UTC ---
So Katrin,
I hope this one is ok, must be tested deeply, because multiple cases.
I have taken care of the difference between an hold on catalog record and an
hold on a specific item.
In some cases you can't delete an order, in other cases you can't delete the
order and catalog's record but the order can be deleted.
On mouse over you have explanations with count.
More, some lines of warnings with count are shown depending of the case.
The ergonomy can be discussed, I have chosen these viewing options to have a
technical structure steady.
Good tests.
Waiting your comments.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5680] When deleting an order, delete attached items, and if applicable biblio

2011-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680

--- Comment #19 from Katrin Fischer katrin.fisc...@bsz-bw.de 2011-10-09 
22:01:27 UTC ---
Created attachment 5814
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5814
screenshot with new error messages

Testing...

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5680] When deleting an order, delete attached items, and if applicable biblio

2011-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Attachment #5813|0   |1
is obsolete||

--- Comment #20 from Katrin Fischer katrin.fisc...@bsz-bw.de 2011-10-09 
22:45:08 UTC ---
Created attachment 5816
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5816
Bug 5680: Order cancelling improvement : delete attached items  biblio if
avalaible

- all items attached to the order are deleted
- if there is no more items, and if the biblio is not in other orders and no
subscriptions and no holds then the biblio is proposed to deletion
Now whe have 2 links : delete order and delete order and catalog record,
the second one appears only if the deletion is possible.
Note that if an hold is related to the item or if the item is unique for the
biblio the link Delete order is canceled due to hold remaining.
On mouse over explanations are shown with count.
More lines of warnings with count are shown depending of the case.

Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Configuration:
AcqCreateItem = on order

Test cases and results:

1) Order new record with 2 items
a) From basket
- delete order: only deletes items, OK!
- delete order and catalog record: deletes record and items, OK
b) From shipment/receive
- delete order: only deletes items, OK!

2) Order 1 additional item for existing record with 1 item
a) From basket:
- delete order: works, existing item and record remain, OK
- Can't delete order and catalog record, 1 item left, OK!

3) Order new record with 1 item, title level hold on record
a) From basket:
- delete order: not possible, OK!
- delete orer and catalog record: not possible, OK!
b) From shipment/receive page
- Cancel: Deletes order, record and hold silently.
NO WARNING. NOT OK. See note below.

4) Order 1 additional item for existing record with 1 item,
item level hold on existing item
a) From basket:
- delete order: works, hold and existing item remain, OK!
- delete order and catalog record: not possible, OK!
b) From shipment/receive page
- Cancel: on order item is deleted, other item and hold remain.

5) Order new serial record, create subscription
a) From basket:
- delete order: works, record and subscription remain, OK!
- delete order and catalog record: not possible, OK!
b) From shipment/receive page:
- Cancel: Subscription and record are silently deleted. NOT OK.

6) Order additional item for existing record with other on order items
a) From basket:
- delete order: works, existing on order items remain, OK!
- delete order and catalog record: not possible, OK!
b) From shipment:
- Cancel: deletes order and ordered item. OK.

Changes made:
I changed the wording of the error messages a bit in the template.
I changed the message 'Can't delete order and catalog record' to not be
shown as a link, as the link does nothing. Tooltip still appears.
I attached a screenshot to the bug showing some of my changes.

Hope that's ok.

Necessary  enhancements:
Cancelling orders when receiving items should work the same as from the
basket summary page. We need the same checks and messages there before
deleting records and items automatically.
I am signing off on this, but to go into Koha it  needs a follow-up for the
order receive page.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5680] When deleting an order, delete attached items, and if applicable biblio

2011-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680

--- Comment #21 from Katrin Fischer katrin.fisc...@bsz-bw.de 2011-10-09 
22:48:20 UTC ---
Thx Christophe for your work on this! I think we are almost there!

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5680] When deleting an order, delete attached items, and if applicable biblio

2011-10-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680

--- Comment #16 from Katrin Fischer katrin.fisc...@bsz-bw.de 2011-10-07 
05:54:28 UTC ---
Hi Christophe, can you update on the status?

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5680] When deleting an order, delete attached items, and if applicable biblio

2011-09-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680

--- Comment #15 from Katrin Fischer katrin.fisc...@bsz-bw.de 2011-09-19 
10:48:16 UTC ---
Hi Christophe, 

thx for commenting :)

4) Showing no link is ok for me. I am trying to imagine a good way to show the
reason why the link is not available, but I have no good idea right now. If you
don't show the link for existing subscriptiosn I will sign-off.

5) I like the idea for hold cancellation messages. But to sign-off on this
patch I think it would be ok if you check for existing holds, give an alert and
refuse to delete the order in that case. So the librarian can cancel them
manually and inform the borrower if they want to.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5680] When deleting an order, delete attached items, and if applicable biblio

2011-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680

--- Comment #14 from Christophe Croullebois 
christophe.croulleb...@biblibre.com 2011-09-16 10:24:16 UTC ---
Katrin,
1) TYPO: OK, right, sry for my poor english
3) PROBLEM: right I have forforgoten this, I propose to include a test to see
if subscription exists. In this case no second link.
4) PROBLEM: it's more complex, I  propose to test if there are holds on items
in order, and if so, to use notices for emailing to borrower the hold
cancelation.
I think this option needs to speak about, what is your opinion about my suggest
?
Because I think even if we keep biblio we can't keep ghost items, so its better
to advise the borrower as we can do when the order is receveid.
Waiting suggests.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5680] When deleting an order, delete attached items, and if applicable biblio

2011-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680

--- Comment #13 from Katrin Fischer katrin.fisc...@bsz-bw.de 2011-06-15 
12:55:44 UTC ---
Created attachment 4480
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4480
screenshot of basket with test cases

1) TYPO: Wording of confirmation message and link
Currently: Are you sure you want to delete this order with his biblio ?
I am not sure if we should use 'biblio' or better say record. Also 'his' should
be 'its'. Suggestion: Are you sure you want to delete this catalog record and
order? Both links have long descriptions and are close to each other - but I
have no idea, how to improve that for a clearer display.

2) OK: Link to delete order and biblio is only shown, when there are no
additional items on the record. Deleting the order only deletes the on order
items.

3) PROBLEM: Deleting a record from the order silently deletes subscription
attached to that biblio. You can loose a lot of data this way.

4) PROBLEM: One big reason to create items on orders is to enable holds on
these items. If you delete a order and biblio with holds on the on order items,
the hold is silently deleted.

5) OK: Deleting order, items and biblio with no holds, subscriptions and other
items attached to the record. Works.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5680] When deleting an order, delete attached items, and if applicable biblio

2011-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Patch Status|Needs Signoff   |Failed QA

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5680] When deleting an order, delete attached items, and if applicable biblio

2011-05-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 AssignedTo|paul.poul...@biblibre.com   |christophe.croullebois@bibl
   ||ibre.com

--- Comment #9 from Paul Poulain paul.poul...@biblibre.com 2011-05-20 
10:34:13 UTC ---
Christophe will work on a patch for that: when the user clicks on delete
order, an AJAX will return the question that must be asked.

2 possibilities :
POSSIBILITY 1 :
* no more items on the biblio
* no other order (usefull if AcqCreateItems is set to recieving or
cataloguing !)
 = ask delete order only / delete order and biblio / cancel

POSSIBILITY 2:
 otherwise
= ask delete order / cancel

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5680] When deleting an order, delete attached items, and if applicable biblio

2011-05-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680

--- Comment #10 from Katrin Fischer katrin.fisc...@bsz-bw.de 2011-05-20 
10:44:12 UTC ---
+1

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/