[Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #19 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.12 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 Tomás Cohen Arazi changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #18 from Tomás Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks Jonathan! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #17 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 Kyle M Hall changed: What|Removed |Added Attachment #20750|0 |1 is obsolete|| --- Comment #16 from Kyle M Hall --- Created attachment 20766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20766&action=edit Bug 5904: ysearch.pl members improvements (Independent branches behaviour) Test plan: - Add a staff user foo in a library A - Add a staff user bar in a library B - log in as foo and try to search 'bar' - Switch on (Prevent) the new pref IndependentBranches - the search returns no result - log in as a superlibrarian - Check that you are allow to search all patrons. Signed-off-by: Srdjan Signed-off-by: Kyle M Hall Passes koha-qa.pl, works as advertised. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 Srdjan Jankovic changed: What|Removed |Added Attachment #20742|0 |1 is obsolete|| --- Comment #15 from Srdjan Jankovic --- Created attachment 20750 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20750&action=edit Bug 5904: ysearch.pl members improvements (Independent branches behaviour) Test plan: - Add a staff user foo in a library A - Add a staff user bar in a library B - log in as foo and try to search 'bar' - Switch on (Prevent) the new pref IndependentBranches - the search returns no result - log in as a superlibrarian - Check that you are allow to search all patrons. Signed-off-by: Srdjan -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 Srdjan Jankovic changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 Jonathan Druart changed: What|Removed |Added Attachment #20122|0 |1 is obsolete|| --- Comment #14 from Jonathan Druart --- Created attachment 20742 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20742&action=edit Bug 5904: ysearch.pl members improvements (Independent branches behaviour) Test plan: - Add a staff user foo in a library A - Add a staff user bar in a library B - log in as foo and try to search 'bar' - Switch on (Prevent) the new pref IndependentBranches - the search returns no result - log in as a superlibrarian - Check that you are allow to search all patrons. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 --- Comment #13 from Jonathan Druart --- (In reply to Kyle M Hall from comment #12) > (In reply to Srdjan Jankovic from comment #11) > > I've signed this off, but not sure how much sense it makes. It is just for > > auto-complete, so used only for the checkouts. If you search eg patrons on > > /members/member.pl it is not used. > > I agree. Independent branches already hides patrons from other branches, so > having a separate system preference for this doesn't make much sense to me. > > Jonathan, can you think of any compelling reason we should have a separate > system preference for this? I would consider the original functionality to > be a bug, and this to be a bug fix. Kyle, Yes you are right, I stupidly rebased this patch but it does not make sense for me neither. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 Jonathan Druart changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Failed QA CC||k...@bywatersolutions.com --- Comment #12 from Kyle M Hall --- (In reply to Srdjan Jankovic from comment #11) > I've signed this off, but not sure how much sense it makes. It is just for > auto-complete, so used only for the checkouts. If you search eg patrons on > /members/member.pl it is not used. I agree. Independent branches already hides patrons from other branches, so having a separate system preference for this doesn't make much sense to me. Jonathan, can you think of any compelling reason we should have a separate system preference for this? I would consider the original functionality to be a bug, and this to be a bug fix. If you agree, a followup to remove the new system preference should be sufficient for this to pass qa. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 Srdjan Jankovic changed: What|Removed |Added CC||srd...@catalyst.net.nz --- Comment #11 from Srdjan Jankovic --- I've signed this off, but not sure how much sense it makes. It is just for auto-complete, so used only for the checkouts. If you search eg patrons on /members/member.pl it is not used. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 Srdjan Jankovic changed: What|Removed |Added Attachment #19259|0 |1 is obsolete|| --- Comment #10 from Srdjan Jankovic --- Created attachment 20122 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20122&action=edit [SIGNED-OFF] Bug 5904: ysearch.pl members improvements (Independent branches behaviour) Test plan: - Add a staff user foo in a library A - Add a staff user bar in a library B - log in as foo and try to search 'bar' - Switch on (Prevent) the new pref IndependentBranchPatron - the search returns no result - log in as a superlibrarian - Check that you are allow to search all patrons. Signed-off-by: Srdjan -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 Srdjan Jankovic changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 Jonathan Druart changed: What|Removed |Added Priority|PATCH-Sent (DO NOT USE) |P5 - low CC||jonathan.dru...@biblibre.co ||m Assignee|paul.poul...@biblibre.com |jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 Jonathan Druart changed: What|Removed |Added Attachment #3364|0 |1 is obsolete|| Attachment #3365|0 |1 is obsolete|| Attachment #3809|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart --- Created attachment 19259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19259&action=edit Bug 5904: ysearch.pl members improvements (Independent branches behaviour) Test plan: - Add a staff user foo in a library A - Add a staff user bar in a library B - log in as foo and try to search 'bar' - Switch on (Prevent) the new pref IndependentBranchPatron - the search returns no result - log in as a superlibrarian - Check that you are allow to search all patrons. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #8 from Katrin Fischer --- Patches need to be rewritten by now, because we handle system preferences differently now and less files have to be changed. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 Owen Leonard changed: What|Removed |Added Patch Status|Needs Signoff |Does not apply --- Comment #7 from Owen Leonard 2011-10-11 16:13:43 UTC --- This no longer applies. I would be helpful if we could also get a good explanation of what this patch is supposed to fix and how to test. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 claire.hernan...@biblibre.com changed: What|Removed |Added Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 --- Comment #6 from claire.hernan...@biblibre.com 2011-04-07 15:02:06 UTC --- Created attachment 3809 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3809 Follow up patch Bug 5904 - Follow up : .pref and fix - adds parenthesis to query - modify patron.pref file -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 --- Comment #5 from claire.hernan...@biblibre.com 2011-04-07 14:34:27 UTC --- Is .pref file missing? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 claire.hernan...@biblibre.com changed: What|Removed |Added CC||claire.hernandez@biblibre.c ||om Patch Status|Needs Signoff |Failed QA --- Comment #3 from MJ Ray (software.coop) 2011-04-01 09:42:38 UTC --- This bug is mentioned in: Bug 5904 : ysearch.pl membersimprovements (Independant branches behaviour) http://lists.koha-community.org/pipermail/koha-patches/2011-March/014143.html Bug 5904 - Follow up patch,with the db changes http://lists.koha-community.org/pipermail/koha-patches/2011-March/014144.html --- Comment #4 from claire.hernan...@biblibre.com 2011-04-07 14:33:28 UTC --- Produce this query: SELECT surname, firstname, cardnumber, address, city, zipcode, country FROM borrowers WHERE surname LIKE 'a%' OR firstname LIKE 'a%' OR cardnumber LIKE 'a%' AND borrowers.branchcode ='MPL' ORDER BY surname, firstname I think it should produce ... WHERE (surname LIKE 'a%' OR firstname LIKE 'a%' OR cardnumber LIKE 'a%') AND borrowers.branchcode ='MPL' ORDER BY surname, firstname -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 Paul Poulain changed: What|Removed |Added AssignedTo|kyle.m.h...@gmail.com |paul.poul...@biblibre.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
