[Koha-bugs] [Bug 5979] Add separate OPACISBD system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #47 from Brendan Gallagher--- Pushed last patch from Mtompsett (thanks!) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5979] Add separate OPACISBD system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #46 from M. Tompsett--- Created attachment 50591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50591=edit Bug 5979: Follow up on systempreferences.sql Missing comma, extra comma, and bad placement -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5979] Add separate OPACISBD system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #45 from Brendan Gallagher--- (In reply to Brendan Gallagher from comment #44) > ERROR 1064 (42000) at line 1: You have an error in your SQL syntax; check > the manual that corresponds to your MySQL server version for the right > syntax to use near '('OPACISBD','#100||{ 100a }{ 100b }{ 100c }{ 100d }{ > 110a }{ 110b }{ 110c }{ 110' at line 536 That's doing a fresh install... If anyone spots the problem before I do - please let me know - This is a candidate to get reverted... Thanks, Brendan -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5979] Add separate OPACISBD system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #44 from Brendan Gallagher--- ERROR 1064 (42000) at line 1: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '('OPACISBD','#100||{ 100a }{ 100b }{ 100c }{ 100d }{ 110a }{ 110b }{ 110c }{ 110' at line 536 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5979] Add separate OPACISBD system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Julian Mauricechanged: What|Removed |Added Severity|normal |enhancement CC||julian.maur...@biblibre.com --- Comment #43 from Julian Maurice --- (In reply to M. Tompsett from comment #41) > (In reply to Katrin Fischer from comment #40) > > Maybe this should be an enh? > > I agree, because it adds a new system preference. So be it -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5979] Add separate OPACISBD system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Brendan Gallagherchanged: What|Removed |Added CC||bren...@bywatersolutions.co ||m Status|Passed QA |Pushed to Master --- Comment #42 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5979] Add separate OPACISBD system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #41 from M. Tompsett--- (In reply to Katrin Fischer from comment #40) > Maybe this should be an enh? I agree, because it adds a new system preference. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5979] Add separate OPACISBD system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #40 from Katrin Fischer--- Maybe this should be an enh? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5979] Add separate OPACISBD system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #35 from Jonathan Druart--- Created attachment 49899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49899=edit Bug 5979 - Follow up: using OPACISBD systempreference to display link Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5979] Add separate OPACISBD system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #39 from Jonathan Druart--- Created attachment 49903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49903=edit Bug 5979: Update INSERT IGNORE INTO statement Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5979] Add separate OPACISBD system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #37 from Jonathan Druart--- Created attachment 49901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49901=edit Bug 5979: follow to fix spelling Changed Montains -> Mountains koha-qa complains!! Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5979] Add separate OPACISBD system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #38 from Jonathan Druart--- Created attachment 49902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49902=edit Attachment to Bug 5979 - Add separate OPACISBD system preference Bug 5979 - Follow up: Change ISBD syspref description and fix warning in t/Biblio/Isbd.t Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5979] Add separate OPACISBD system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Jonathan Druartchanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5979] Add separate OPACISBD system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Jonathan Druartchanged: What|Removed |Added Attachment #44208|0 |1 is obsolete|| Attachment #44209|0 |1 is obsolete|| Attachment #44210|0 |1 is obsolete|| Attachment #49873|0 |1 is obsolete|| Attachment #49874|0 |1 is obsolete|| --- Comment #34 from Jonathan Druart --- Created attachment 49898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49898=edit Bug 5979 : OPAC : using OPACISBD systempreference to display link The OPACISBD system preference is used in order to be able to have one ISBD for OPAC another one for intranet. But the link ISBD at OPAC was depending on the presence or absence of value in ISBD which is for intranet. This patch fixes the behaviour to depend on the correct system preference at OPAC Signed-off-by: Katrin Fischer Verified that new system preference is added cleanly and ISBD view can be configured independently for staff and OPAC using OPACISBD and viewISBD system preferences. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5979] Add separate OPACISBD system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #32 from Owen Leonard--- Created attachment 49873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49873=edit [SIGNED-OFF] Bug 5979: follow to fix spelling Changed Montains -> Mountains koha-qa complains!! Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5979] Add separate OPACISBD system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Owen Leonardchanged: What|Removed |Added Attachment #44211|0 |1 is obsolete|| -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5979] Add separate OPACISBD system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Owen Leonardchanged: What|Removed |Added Attachment #48295|0 |1 is obsolete|| --- Comment #33 from Owen Leonard --- Created attachment 49874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49874=edit [SIGNED-OFF] Bug 5979 - Follow up: Change ISBD syspref description and fix warning in t/Biblio/Isbd.t Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5979] Add separate OPACISBD system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Owen Leonardchanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5979] Add separate OPACISBD system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #31 from M. Tompsett--- I was thinking perhaps INSERT IGNORE INTO ... not just INSERT INTO `systempreferences` (variable,value,options,explanation,type) SELECT 'OPACISBD', value, '70|10', 'Allows to define ISBD view in OPAC', 'Textarea' FROM `systempreferences` WHERE variable = 'ISBD'; -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5979] Add separate OPACISBD system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #30 from M. Tompsett--- Comment on attachment 44210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44210 [SIGNED-OFF] Bug 5979 - OPAC ISBD view has its own syspref Review of attachment 44210: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=5979=44210) - ::: t/Biblio/Isbd.t @@ +26,5 @@ > +use_ok('C4::Biblio'); > +} > + > +my $dbh = C4::Context->dbh; > +# Start transaction Perhaps this is better suited for t/db_dependent? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5979] Add separate OPACISBD system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Alex Arnaudchanged: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5979] Add separate OPACISBD system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #29 from Alex Arnaud--- Created attachment 48295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48295=edit Bug 5979 - Follow up: Change ISBD syspref description and fix warning in t/Biblio/Isbd.t -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5979] Add separate OPACISBD system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #28 from Katrin Fischer--- Looks ok! -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5979] Add separate OPACISBD system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #27 from Alex Arnaud--- (In reply to Katrin Fischer from comment #21) > 1) Please copy the current ISBD into OPACISBD to keep the same behaviour as > before the patch for an installation with a modified ISBD view. Katrin, i think this is done in installer/data/mysql/atomicupdate/bug_5979-add_opacisbd_syspref.sql Are you ok with that ? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5979] Add separate OPACISBD system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #26 from Katrin Fischer--- comment#21 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5979] Add separate OPACISBD system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #25 from Alex Arnaud--- Does anyone known why this bug failed QA ? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5979] Add separate OPACISBD system preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #24 from Katrin Fischer--- Hi Alex, you are right, sorry - I think I misread last night. I think deduplicating the 2 staff preferences would be good, but on a separate bug :) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5979] Add separate OPACISBD system preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #23 from Alex Arnaud--- (In reply to Katrin Fischer from comment #22) > Hm, also a question: if we have separate preferences, do we really still > need 4 preferences? Could we have only 2 preferences and deactivate the > feature by emptying them out? Hello Katrin, We have 3 preferences. 2 for staff (ISBD, viewISBD) and 1 for OPAC (OPACISBD). I agree that we don't need 2 preferences for staff as we do the same job with 1 on opac. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5979] Add separate OPACISBD system preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Katrin Fischerchanged: What|Removed |Added Summary|OPAC : using OPACISBD |Add separate OPACISBD |systempreference to display |system preference |link| -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5979] Add separate OPACISBD system preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #22 from Katrin Fischer--- Hm, also a question: if we have separate preferences, do we really still need 4 preferences? Could we have only 2 preferences and deactivate the feature by emptying them out? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/