[Koha-bugs] [Bug 6039] Cancel all waiting holds button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 Kyle M Hall changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=8213 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6039] Cancel all waiting holds button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 Ian Walls changed: What|Removed |Added Status|In Discussion |RESOLVED Resolution|--- |FIXED --- Comment #26 from Ian Walls --- Best to file a new bug against this behaviour, since the feature has already been pushed. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6039] Cancel all waiting holds button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 --- Comment #25 from Srdjan Jankovic --- (In reply to comment #24) > Yes, I agree that it should only cancel holds over (which is the same as > holds that are older than ReservesMaxPickUpDelay, yes?). I presume. In any case whatever is on that tab and not for transfer. > I don't know if it's best to create another bug report or just submit a > follow up patch. Not sure what the community likes to do in a case like > this. Either way is fine with me! I will wait for the second opinion, but I think whatever is pushed to a release should not be touched any more. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6039] Cancel all waiting holds button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 --- Comment #24 from Melia Meggs --- Yes, I agree that it should only cancel holds over (which is the same as holds that are older than ReservesMaxPickUpDelay, yes?). The holds waiting do not all need to be canceled. I don't know if it's best to create another bug report or just submit a follow up patch. Not sure what the community likes to do in a case like this. Either way is fine with me! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6039] Cancel all waiting holds button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 --- Comment #23 from Srdjan Jankovic --- Ok, now when I look at the screen I think it is rewasonable to expect only the holds over to be cancelled, because it is on that tab. How do we sort this one out? maybe create another bug cause this one has already been pushed? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6039] Cancel all waiting holds button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 --- Comment #22 from Melia Meggs --- So let's clarify what the button is supposed to do. - Cancel all holds on the holds over tab? Or - Cancel all holds on the holds over AND holds waiting tabs? Right now it is canceling all holds over and all holds waiting. So it is canceling holds regardless of whether they are older than the ReservesMaxPickUpDelay. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6039] Cancel all waiting holds button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 --- Comment #21 from Srdjan Jankovic --- That is misfortunate. To my defence, I have to say that the request was for “Cancel All”, not “Cancel All Expired” button. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6039] Cancel all waiting holds button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 Melia Meggs changed: What|Removed |Added Status|Pushed to Master|In Discussion CC||me...@bywatersolutions.com --- Comment #20 from Melia Meggs --- Two libraries on 3.8.1 have reported that the "Cancel All" button is not working as expected. After clicking the "Cancel All" button, all of their waiting holds were deleted, not just the expired ones. We had to restore the waiting holds from backup. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6039] Cancel all waiting holds button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 Jared Camins-Esakov changed: What|Removed |Added Version|rel_3_6 |rel_3_8 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6039] Cancel all waiting holds button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 Paul Poulain changed: What|Removed |Added Priority|PATCH-Sent (DO NOT USE) |P4 Status|Passed QA |Pushed to Master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6039] Cancel all waiting holds button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 Paul Poulain changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #19 from Paul Poulain 2012-02-27 15:16:47 UTC --- QA comment: clean patch, create a cancel sub to factorize cancellation. This sub could have been in a C4 package for future use, but won't reject QA for this reason passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6039] Cancel all waiting holds button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6039] Cancel all waiting holds button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 Chris Cormack changed: What|Removed |Added Attachment #7779|0 |1 is obsolete|| --- Comment #18 from Chris Cormack 2012-02-21 02:01:59 UTC --- Created attachment 7781 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7781 bug 6039: Cancel All waiting holds button - Addendum: Add redirect to refresh list after canceling all holds. Signed-off-by: Chris Cormack -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6039] Cancel all waiting holds button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 Chris Cormack changed: What|Removed |Added Status|Signed Off |Needs Signoff --- Comment #17 from Chris Cormack 2012-02-20 17:51:05 UTC --- Last patch needs signoff still -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6039] Cancel all waiting holds button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6039] Cancel all waiting holds button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 --- Comment #16 from Kyle M Hall 2012-02-20 17:20:37 UTC --- Created attachment 7779 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7779 bug 6039: Cancel All waiting holds button - Addendum: Add redirect to refresh list after canceling all holds. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6039] Cancel all waiting holds button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 Kyle M Hall changed: What|Removed |Added Attachment #7550|0 |1 is obsolete|| -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6039] Cancel all waiting holds button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 --- Comment #15 from Kyle M Hall 2012-02-20 17:19:04 UTC --- Created attachment 7778 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7778 bug 6039: Cancel All waiting holds button TransferWhenCancelAllWaitingHolds syspref Signed-off-by: Kyle M Hall -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6039] Cancel all waiting holds button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Failed QA --- Comment #14 from Kyle M Hall 2012-02-20 17:16:38 UTC --- This patch works great with only one small but serious problem: Assume that there are a number of old waiting holds, both needing transfers and not need transfers. If TransferWhenCancelAllWaitingHolds is set to "Don't Transfer", and the "Cancel All' button is clicked, the page comes back with "No Holds Found". Only, when you visit the page again ( not just clicking refresh ) will you see that the holds with transfers were not canceled. I guarantee this will cause heart attacks for librarians if this is not fixed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6039] Cancel all waiting holds button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||kyle.m.h...@gmail.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6039] Cancel all waiting holds button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 --- Comment #13 from Liz Rea 2012-02-10 15:22:05 UTC --- spectacular, I see the button now. Will test! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6039] Cancel all waiting holds button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 Srdjan Jankovic changed: What|Removed |Added Status|In Discussion |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6039] Cancel all waiting holds button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 Srdjan Jankovic changed: What|Removed |Added Attachment #7282|0 |1 is obsolete|| --- Comment #12 from Srdjan Jankovic 2012-02-10 01:07:11 UTC --- Created attachment 7550 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7550 patch Apologies, totally my fault, missed closing " in the patch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6039] Cancel all waiting holds button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 --- Comment #11 from Liz Rea 2012-02-09 04:20:28 UTC --- here are my reserves: *** 3. row *** borrowernumber: 44 reservedate: 2011-01-08 biblionumber: 39204 constrainttype: a branchcode: CPL notificationdate: NULL reminderdate: NULL cancellationdate: NULL reservenotes: priority: 0 found: W timestamp: 2012-02-08 22:11:17 itemnumber: 1036 waitingdate: 2012-01-08 expirationdate: NULL lowestPriority: 0 *** 4. row *** borrowernumber: 44 reservedate: 2011-01-08 biblionumber: 39201 constrainttype: a branchcode: CPL notificationdate: NULL reminderdate: NULL cancellationdate: NULL reservenotes: priority: 0 found: W timestamp: 2012-02-08 22:11:17 itemnumber: 1033 waitingdate: 2012-01-08 expirationdate: NULL lowestPriority: 0 *** 5. row *** borrowernumber: 44 reservedate: 2011-01-08 biblionumber: 39202 constrainttype: a branchcode: CPL notificationdate: NULL reminderdate: NULL cancellationdate: NULL reservenotes: priority: 0 found: W timestamp: 2012-02-08 22:11:17 itemnumber: 1034 waitingdate: 2012-01-08 expirationdate: NULL lowestPriority: 0 *** 6. row *** borrowernumber: 44 reservedate: 2011-01-08 biblionumber: 39203 constrainttype: a branchcode: CPL notificationdate: NULL reminderdate: NULL cancellationdate: NULL reservenotes: priority: 0 found: W timestamp: 2012-02-08 22:11:17 itemnumber: 1035 waitingdate: 2012-01-08 expirationdate: NULL lowestPriority: 0 reservesmaxpickupdelay set to 1 - all of these are well over 1 day waiting. I can see, when I flip the syspref, the message about "only holds that need not be transferred will be canceled" but I still see no actual "cancel all" button. Result is similar with the syspref set to "transfer" - the message seems right but there is no button. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6039] Cancel all waiting holds button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 --- Comment #10 from Liz Rea 2012-02-09 03:18:32 UTC --- I believe so but I will double check - the holds were in the "hold over" tab, my impression was that things in that tab were things that were beyond reservesmaxpickupdelay. I'm happy to check this again though. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6039] Cancel all waiting holds button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 Srdjan Jankovic changed: What|Removed |Added Status|Failed QA |In Discussion --- Comment #9 from Srdjan Jankovic 2012-02-08 23:59:30 UTC --- In order for button to appear, holds must be older than ReservesMaxPickUpDelay days. Was that the case? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6039] Cancel all waiting holds button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||wizzy...@gmail.com --- Comment #8 from Liz Rea 2012-02-07 16:07:24 UTC --- Patch applied with the caveat that I had to merge the sysprefs.sql and updatedatabase.pl files. However, I don't see the "cancel all" button on the "hold over" screen. Things I tried: flipped the syspref both ways, no luck applied/merged again, no luck. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6039] Cancel all waiting holds button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 Srdjan Jankovic changed: What|Removed |Added Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6039] Cancel all waiting holds button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 Srdjan Jankovic changed: What|Removed |Added Attachment #3608|0 |1 is obsolete|| --- Comment #7 from Srdjan Jankovic 2012-01-23 00:51:21 UTC --- Created attachment 7282 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7282 patch I kind of lost track here a bit. I hope all I needed to do was to rebase. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6039] Cancel all waiting holds button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 --- Comment #6 from Ian Walls 2011-08-12 14:14:14 UTC --- Srdjan, The functionality part of the patch can still be made to depend on the system preference TransferWhenCancelAllWaitingHolds; for testing, we'd just add it manually to our test DBs. That gives us a little more control over our test database's state (particular version number), and removes some of the potential merge conflicts that comes with the patch sitting in the queue for long enough for the database number to increment. Database update patches are usually pretty easy to QA, as well, so if the functionality works, it's simple to check the followup patch for the database entries, and QA that, as well. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6039] Cancel all waiting holds button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 Paul Poulain changed: What|Removed |Added CC||paul.poul...@biblibre.com --- Comment #5 from Paul Poulain 2011-08-09 16:07:48 UTC --- (In reply to comment #4) > I can place them to separate patches, but then it will be a possible to have > "Cancel All" button without TransferWhenCancelAllWaitingHolds syspref. Is that > acceptable? Once 6537 will have been applied, the problem with sysprefs in various language will be fixed, as there will be only one syspref file (with sometimes a specific file for specific values, but "localizers" will have to take care of it. Thus the problem Ian rises will be forgotten-able. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6039] Cancel all waiting holds button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 --- Comment #4 from Srdjan Jankovic 2011-08-08 00:05:06 UTC --- I can place them to separate patches, but then it will be a possible to have "Cancel All" button without TransferWhenCancelAllWaitingHolds syspref. Is that acceptable? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6039] Cancel all waiting holds button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 Ian Walls changed: What|Removed |Added CC||ian.walls@bywatersolutions. ||com Patch Status|Signed Off |Failed QA --- Comment #3 from Ian Walls 2011-08-05 17:22:55 UTC --- This patch no longer applies. It needs to be rebased onto Template:Toolkit. The database structure parts of the patch should be updated, as well, to include not only English but other languages, and to apply to the current code state. I'd recommend placing them in a separate patch from the functionality, for ease of testing and application -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6039] Cancel all waiting holds button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 Frederic Durand changed: What|Removed |Added CC||frederic.durand@univ-lyon2. ||fr Patch Status|Needs Signoff |Signed Off --- Comment #2 from Frederic Durand 2011-04-07 13:18:02 UTC --- "Cancel All" button working good, new sys pref too. All is ok -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6039] Cancel all waiting holds button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 Chris Cormack changed: What|Removed |Added Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6039] Cancel all waiting holds button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz Version|rel_3_4 |rel_3_6 Change sponsored?|--- |Sponsored -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6039] Cancel all waiting holds button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 Srdjan Jankovic changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|kyle.m.h...@gmail.com |srd...@catalyst.net.nz --- Comment #1 from Srdjan Jankovic 2011-04-04 01:47:53 UTC --- Created attachment 3608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3608 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
