[Koha-bugs] [Bug 6254] can't set patron privacy by default

2014-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Blocks||12454

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2014-05-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
   Severity|minor   |enhancement

--- Comment #43 from Galen Charlton gmcha...@gmail.com ---
Pushed to master.  Thanks, Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2014-05-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #24696|0   |1
is obsolete||
  Attachment #24697|0   |1
is obsolete||
  Attachment #24698|0   |1
is obsolete||
  Attachment #24699|0   |1
is obsolete||

--- Comment #37 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 28033
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28033action=edit
Bug 6254 [1] - Can't set patron privacy by default

There is currently no way to set the privacy setting for newly created
patrons. This patch adds a new field default privacy to the patron
categories such that each patron category may have a different default
privacy setting.

Test Plan:
1) Apply this patch
2) Edit a patron category, change the default privacy to forever
3) Create a new patron of that category
4) Log into the catalog as that patron, verify the privacy setting
   is set to forever
5) Repeat steps 2-4 with the settings never and default

Signed-off-by: Joel Sasse jsa...@plumcreeklibrary.net

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

Bug 6254 [QA Followup 1] - can't set patron privacy by default

* Adds default privacy column to summary table
* Adds default privacy to delete category summary
* Adds AFTER categorycode to the database update
* Whitespace cleanup and formatting for affected code blocks
* Switch basic DBI queries to DBIx::Class to simplify code
* Adds reference to misc/cronjobs/batch_anonymise.pl to description

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

Bug 6254 [QA Followup 2] - can't set patron privacy by default

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

Bug 6254: QA FIX: remove trailing whitespaces

This patch removes trailing whitespaces/tab and fix the fields order in
the updatedb entry (according to the kohastructure.pl).

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2014-05-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

--- Comment #38 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 28034
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28034action=edit
Bug 6254 [2] - Update Schema File

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2014-05-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2014-05-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

--- Comment #40 from Kyle M Hall k...@bywatersolutions.com ---
I've re-flowed these patches for simplicity and ease of updating:
1) Squashed all qa followups into main patch
2) Split schema file update into separate patch
3) Split whitespace cleanup into separate patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2014-05-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

--- Comment #39 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 28035
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28035action=edit
Bug 6254 [3] - Tidy admin/categorie.pl ( whitespace changes only )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2014-05-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #28035|0   |1
is obsolete||

--- Comment #41 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 28036
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28036action=edit
Bug 6254 [3] - Tidy admin/categorie.pl ( whitespace changes only )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2014-05-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #42 from Kyle M Hall k...@bywatersolutions.com ---
I do believe this had passed qa. I've made no functional changes with my
re-arrangement of the patch set, so back it goes! I did re-test and verify this
patch set before uploading.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

   Keywords|rel_3_16_candidate  |
 Status|Passed QA   |Patch doesn't apply

--- Comment #36 from Galen Charlton gmcha...@gmail.com ---
Patch does not apply.

Reminder: please keep extensive whitespace changes onto separate patches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2014-04-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

   Keywords||rel_3_16_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2014-01-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #29 from Jonathan Druart jonathan.dru...@biblibre.com ---
Maybe should we hide the default privacy entry on the categorie.pl page (form
add/edit and list) if OPACPrivacy is off?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2014-01-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 QA Contact|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co
   |ity.org |m

--- Comment #30 from Jonathan Druart jonathan.dru...@biblibre.com ---
All seems good to me.
It would have been good to have several patches instead of one (for indentation
and wording fixes).
I still don't think it is a good idea to call Koha::Database in script file but
it seems this idea does not win unanimous support.

I will provide 1 patch with 2 small fixes.

Marked as Passed QA.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2014-01-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #23520|0   |1
is obsolete||

--- Comment #32 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 24696
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24696action=edit
Bug 6254 - can't set patron privacy by default

There is currently no way to set the privacy setting for newly created
patrons. This patch adds a new field default privacy to the patron
categories such that each patron category may have a different default
privacy setting.

Test Plan:
1) Apply this patch
2) Edit a patron category, change the default privacy to forever
3) Create a new patron of that category
4) Log into the catalog as that patron, verify the privacy setting
   is set to forever
5) Repeat steps 2-4 with the settings never and default

Signed-off-by: Joel Sasse jsa...@plumcreeklibrary.net

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2014-01-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #24606|0   |1
is obsolete||

--- Comment #34 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 24698
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24698action=edit
Bug 6254 [QA Followup 2] - can't set patron privacy by default

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2014-01-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #23987|0   |1
is obsolete||

--- Comment #33 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 24697
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24697action=edit
Bug 6254 [QA Followup 1] - can't set patron privacy by default

* Adds default privacy column to summary table
* Adds default privacy to delete category summary
* Adds AFTER categorycode to the database update
* Whitespace cleanup and formatting for affected code blocks
* Switch basic DBI queries to DBIx::Class to simplify code
* Adds reference to misc/cronjobs/batch_anonymise.pl to description

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2014-01-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

--- Comment #35 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 24699
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24699action=edit
Bug 6254: QA FIX: remove trailing whitespaces

This patch removes trailing whitespaces/tab and fix the fields order in
the updatedb entry (according to the kohastructure.pl).

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2014-01-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

--- Comment #28 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 24606
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24606action=edit
Bug 6254 [QA Followup 2] - can't set patron privacy by default

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2014-01-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2014-01-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2014-01-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

--- Comment #27 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Comment on attachment 23987
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23987
Bug 6254 [QA Followup 1] - can't set patron privacy by default

Review of attachment 23987:
 -- 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=6254attachment=23987)
-

Kyle, we are really almost there, but there is a translation problem:

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/categorie.tt
@@ +276,5 @@
 +trth scope=rowEnrollment fee: /thtd[% 
 category.enrolmentfee | format('%.02f') %]/td/tr
 +trth scope=rowReceives overdue notices: /thtd[% IF 
 ( category.overduenoticerequired ) %]Yes[% ELSE %]No[% END %]/td/tr
 +trth scope=rowLost items in staff client/thtd[% IF 
 ( category.hidelostitems ) %]Hidden by default[% ELSE %]Shown[% END 
 %]/td/tr
 +trth scope=rowHold fee: /thtd[% 
 category.reservefee | format('%.02f') %]/td/tr
 +trth scope=rowDefault privacy: /thtd[% 
 category.default_privacy %]/td/tr

I think this should be a SWITCH making the never, forever and default
translatable. The configuration page already does it correctly.

@@ +404,5 @@
  No limitation
  [% END %]
  /td
 +td
 +[% loo.default_privacy %]

And here.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2014-01-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

--- Comment #23 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 23983
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23983action=edit
Bug 6254 [QA Followup 1] - can't set patron privacy by default

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2014-01-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #23983|0   |1
is obsolete||

--- Comment #24 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 23985
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23985action=edit
Bug 6254 [QA Followup 1] - can't set patron privacy by default

* Adds default privacy column to summary table
* Adds default privacy to delete category summary
* Adds AFTER categorycode to the database update
* Whitespace cleanup and formatting for affected code blocks
* Switch basic DBI queries to DBIx::Class to simplify code

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2014-01-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2014-01-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #23985|0   |1
is obsolete||

--- Comment #25 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 23986
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23986action=edit
Bug 6254 [QA Followup 1] - can't set patron privacy by default

* Adds default privacy column to summary table
* Adds default privacy to delete category summary
* Adds AFTER categorycode to the database update
* Whitespace cleanup and formatting for affected code blocks
* Switch basic DBI queries to DBIx::Class to simplify code
* Adds reference to misc/cronjobs/batch_anonymise.pl to description

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2014-01-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #23986|0   |1
is obsolete||

--- Comment #26 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 23987
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23987action=edit
Bug 6254 [QA Followup 1] - can't set patron privacy by default

* Adds default privacy column to summary table
* Adds default privacy to delete category summary
* Adds AFTER categorycode to the database update
* Whitespace cleanup and formatting for affected code blocks
* Switch basic DBI queries to DBIx::Class to simplify code
* Adds reference to misc/cronjobs/batch_anonymise.pl to description

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2013-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #22 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Some QA notes:
- The new column is missing from the summary table
- The new column is also missing from the summary on deleting a patron category
- The database update could be improved by specifying where the new column
  will be added ('AFTER categorycode')
- I think the note in the staff client could be a bit more specific and mention
the cronjob, as it's directed at the librarians and not at the patrons. 

Kyle, could you provide a follow up?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2013-12-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

--- Comment #19 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Kyle, 
ready to QA this, but I have a question about the default setting. In the
templates I read:

Controls how long a patrons checkout history is kept for new patrons of this
category. Default lets the library decide, Never anonymizes checkouts on
return, and Forever keeps a patron's checkout history indefinitely.

Where and how does the library decide the meaning of default?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2013-12-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

--- Comment #20 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
And a quick note so I don't forget: we should fix the librairies typo in
categorie.tt :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2013-12-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

--- Comment #21 from Magnus Enger mag...@enger.priv.no ---
(In reply to Katrin Fischer from comment #19)
 Where and how does the library decide the meaning of default?

If i remember correctly, default means loans get anonymized as often as the
library decides to run the anonymize cronjob: misc/cronjobs/batch_anonymise.pl
The language here seems to be same that is used on the privacu settings page in
the OPAC (for logged in users).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2013-12-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #23317|0   |1
is obsolete||

--- Comment #16 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 23516
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23516action=edit
Bug 6254 - can't set patron privacy by default

There is currently no way to set the privacy setting for newly created
patrons. This patch adds a new field default privacy to the patron
categories such that each patron category may have a different default
privacy setting.

Test Plan:
1) Apply this patch
2) Edit a patron category, change the default privacy to forever
3) Create a new patron of that category
4) Log into the catalog as that patron, verify the privacy setting
   is set to forever
5) Repeat steps 2-4 with the settings never and default

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2013-12-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Joel Sasse jsa...@plumcreeklibrary.net changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2013-12-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

sandbo...@biblibre.com sandbo...@biblibre.com changed:

   What|Removed |Added

 CC||sandbo...@biblibre.com

--- Comment #17 from sandbo...@biblibre.com sandbo...@biblibre.com ---
Patch tested with a sandbox, by Joel Sasse jsa...@plumcreeklibrary.net

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2013-12-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

sandbo...@biblibre.com sandbo...@biblibre.com changed:

   What|Removed |Added

  Attachment #23516|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2013-12-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

--- Comment #18 from sandbo...@biblibre.com sandbo...@biblibre.com ---
Created attachment 23520
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23520action=edit
Bug 6254 - can't set patron privacy by default

There is currently no way to set the privacy setting for newly created
patrons. This patch adds a new field default privacy to the patron
categories such that each patron category may have a different default
privacy setting.

Test Plan:
1) Apply this patch
2) Edit a patron category, change the default privacy to forever
3) Create a new patron of that category
4) Log into the catalog as that patron, verify the privacy setting
   is set to forever
5) Repeat steps 2-4 with the settings never and default

Signed-off-by: Joel Sasse jsa...@plumcreeklibrary.net

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2013-12-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Joel Sasse jsa...@plumcreeklibrary.net changed:

   What|Removed |Added

 CC||jsa...@plumcreeklibrary.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2013-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2013-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #23309|0   |1
is obsolete||
  Attachment #23310|0   |1
is obsolete||

--- Comment #15 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 23317
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23317action=edit
Bug 6254 - can't set patron privacy by default

There is currently no way to set the privacy setting for newly created
patrons. This patch adds a new field default privacy to the patron
categories such that each patron category may have a different default
privacy setting.

Test Plan:
1) Apply this patch
2) Edit a patron category, change the default privacy to forever
3) Create a new patron of that category
4) Log into the catalog as that patron, verify the privacy setting
   is set to forever
5) Repeat steps 2-4 with the settings never and default

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2013-12-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19631|0   |1
is obsolete||

--- Comment #13 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 23309
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23309action=edit
[PASSED QA] Bug 6254 - can't set patron privacy by default

There is currently no way to set the privacy setting for newly created
patrons. This patch adds the system preference NewPatronPrivacySetting
to define what privacy setting new patrons should have.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Create a new patron
4) Verify the patron's privacy is set to 1
5) Set NewPatronPrivacySetting to never
6) Create a new patron
7) Verify the patron's privacy is set to 2
8) Set NewPatronPrivacySetting to forever
9) Create a new patron
10) Verify the patron's privacy is set to 0

Signed-off-by: Liz Rea wizzy...@gmail.com
Tested per plan, all looks ok.

Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Passes all tests and QA script.
Additional tests done:
- Verified syspref.sql insert works alright
- Checked editing patrons left privacy untouched.
- Checked importing patrons with overlay leaves privacy alone
  if not provided.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2013-12-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

--- Comment #14 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 23310
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23310action=edit
Bug 6254 - can't set patron privacy by default - QA Followup

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2013-07-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |In Discussion

--- Comment #11 from Galen Charlton gmcha...@gmail.com ---
There are two separate requests in this bug to have the default be per-patron
category.

Kyle, are you amenable to redoing the patch to have the default privacy value
be an attribute of patron category?  Consider this part of my sometimes a
global YASP is not the right level of configurability hobbyhorse.

Setting to in discussion.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2013-07-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

--- Comment #12 from Galen Charlton gmcha...@gmail.com ---
(In reply to Katrin Fischer from comment #10)
 Functionality wise this works and passes QA, but I am not so happy about the
 system preference description:
 
 NewPatronPrivacySetting:
 New patrons should have a privacy setting of default|never|forever
 
 I don't thinks this explains what this setting will do to a librarian trying
 to configure Koha and without deeper knowledge about the features and
 terminology. Also Privacy is a pretty broad term and this only affects how
 long we keep the reading history.

I share Katrin's concerns about the description and feel that it could be
expanded a bit.  If we end up running with a syspref (but see my previous
comment), I also think that DefaultPatronPrivacySetting would be a better name.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2013-07-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #19272|0   |1
is obsolete||

--- Comment #9 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 19631
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19631action=edit
[PASSED QA] Bug 6254 - can't set patron privacy by default

There is currently no way to set the privacy setting for newly created
patrons. This patch adds the system preference NewPatronPrivacySetting
to define what privacy setting new patrons should have.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Create a new patron
4) Verify the patron's privacy is set to 1
5) Set NewPatronPrivacySetting to never
6) Create a new patron
7) Verify the patron's privacy is set to 2
8) Set NewPatronPrivacySetting to forever
9) Create a new patron
10) Verify the patron's privacy is set to 0

Signed-off-by: Liz Rea wizzy...@gmail.com
Tested per plan, all looks ok.

Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Passes all tests and QA script.
Additional tests done:
- Verified syspref.sql insert works alright
- Checked editing patrons left privacy untouched.
- Checked importing patrons with overlay leaves privacy alone
  if not provided.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2013-07-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #10 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Functionality wise this works and passes QA, but I am not so happy about the
system preference description:

NewPatronPrivacySetting:
New patrons should have a privacy setting of default|never|forever

I don't thinks this explains what this setting will do to a librarian trying to
configure Koha and without deeper knowledge about the features and terminology.
Also Privacy is a pretty broad term and this only affects how long we keep
the reading history.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2013-07-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2013-06-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Viktor Sarge viktor.sa...@regionhalland.se changed:

   What|Removed |Added

 CC||viktor.sarge@regionhalland.
   ||se

--- Comment #7 from Viktor Sarge viktor.sa...@regionhalland.se ---
Here in Sweden we are generally forbidden to have reading history active. There
are certain categories of borrowers however (those reading DAISY for example)
that are dependent on reading history being enabled. Therefore it would be
highly useful to have Koha allow setting the default privacy per patron
category. Imported users should get the default privacy setting if nothing else
is specified.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2013-06-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Liz Rea wizzy...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2013-06-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Liz Rea wizzy...@gmail.com changed:

   What|Removed |Added

  Attachment #19133|0   |1
is obsolete||

--- Comment #8 from Liz Rea wizzy...@gmail.com ---
Created attachment 19272
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19272action=edit
Bug 6254 - can't set patron privacy by default

There is currently no way to set the privacy setting for newly created
patrons. This patch adds the system preference NewPatronPrivacySetting
to define what privacy setting new patrons should have.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Create a new patron
4) Verify the patron's privacy is set to 1
5) Set NewPatronPrivacySetting to never
6) Create a new patron
7) Verify the patron's privacy is set to 2
8) Set NewPatronPrivacySetting to forever
9) Create a new patron
10) Verify the patron's privacy is set to 0

Signed-off-by: Liz Rea wizzy...@gmail.com
Tested per plan, all looks ok.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2013-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2013-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

--- Comment #4 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 19131
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19131action=edit
Bug 6254 - can't set patron privacy by default

There is currently no way to set the privacy setting for newly created
patrons. This patch adds the system preference NewPatronPrivacySetting
to define what privacy setting new patrons should have.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Create a new patron
4) Verify the patron's privacy is set to 1
5) Set NewPatronPrivacySetting to never
6) Create a new patron
7) Verify the patron's privacy is set to 2
8) Set NewPatronPrivacySetting to forever
9) Create a new patron
10) Verify the patron's privacy is set to 0

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2013-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
   Assignee|koha.sek...@gmail.com   |k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2013-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19131|0   |1
is obsolete||

--- Comment #5 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 19132
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19132action=edit
Bug 6254 - can't set patron privacy by default

There is currently no way to set the privacy setting for newly created
patrons. This patch adds the system preference NewPatronPrivacySetting
to define what privacy setting new patrons should have.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Create a new patron
4) Verify the patron's privacy is set to 1
5) Set NewPatronPrivacySetting to never
6) Create a new patron
7) Verify the patron's privacy is set to 2
8) Set NewPatronPrivacySetting to forever
9) Create a new patron
10) Verify the patron's privacy is set to 0

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2013-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19132|0   |1
is obsolete||

--- Comment #6 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 19133
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19133action=edit
Bug 6254 - can't set patron privacy by default

There is currently no way to set the privacy setting for newly created
patrons. This patch adds the system preference NewPatronPrivacySetting
to define what privacy setting new patrons should have.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Create a new patron
4) Verify the patron's privacy is set to 1
5) Set NewPatronPrivacySetting to never
6) Create a new patron
7) Verify the patron's privacy is set to 2
8) Set NewPatronPrivacySetting to forever
9) Create a new patron
10) Verify the patron's privacy is set to 0

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2013-02-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=9298

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2012-01-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

--- Comment #3 from Nicole C. Engard neng...@gmail.com 2012-01-23 22:32:43 
UTC ---
*** Bug 4426 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2011-05-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

 CC||mag...@enger.priv.no

--- Comment #2 from Magnus Enger mag...@enger.priv.no 2011-05-06 12:03:05 UTC 
---
The privacy setting is stored in borrowers.privacy which has a default of 1. A
quick and dirty hack for a library that wanted 0 or 2 as the default could be
to change the default of the column in MySQL. 

But I agree with Nicole, it would be nice to have a proper way to set the
defualt to something else than 1, and very nice if a default could be set for
each patron category.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2011-04-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

--- Comment #1 from Nicole C. Engard neng...@gmail.com 2011-04-22 14:50:16 
UTC ---
Also, patron import shouldn't be allowed to change the privacy setting on
existing patrons .. only for new patrons.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/