[Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #21 from Galen Charlton --- Pushed to master, along with a follow-up that fixes various issues preventing the payment type from being recording correctly and avoiding a regression on bug 2546. Thanks, Ian! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Galen Charlton changed: What|Removed |Added Keywords||rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Brendan Gallagher changed: What|Removed |Added CC||bren...@bywatersolutions.co ||m --- Comment #20 from Brendan Gallagher --- Two notes 1) The string that is present in this patch has been addressed with bug 2546 - So I leave it up to the RM to decided about removing the 2 lines that have "Payment, Thanks" + "(via SIP)"... 2) I would like to see some message that does include a (via SIP) in a translatable string and perhaps we can create that as a another bug once this has been pushed. Otherwise this works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Brendan Gallagher changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Brendan Gallagher changed: What|Removed |Added Attachment #25167|0 |1 is obsolete|| --- Comment #19 from Brendan Gallagher --- Created attachment 26463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26463&action=edit [passed-qa] Bug 6273 - SIP2 Fee Paid and Fee Paid Response support Adds support for recording in Koha accountlines a different accounttype depending on how the fee was paid at the SIP2 station (cash, credit, etc) Adds a new param to recordpayment(), $sip_paytype, which is appended to the 'Pay' type if present. The payment descriptin is also appended with " (via SIP2)" if this is present. In order for other scripts to keep working as expected, "eq 'Pay'" needed to be replaced with a regex comparison "=~ /^Pay/", so that 'Pay' and 'Pay-##' would continue to group together. To test: 1. Make a payment over a SIP2 connection 2. Check the patron record in the staff client; you should see the modified description 3. Attempt to print a invoice or a reciept for the borrower; the payment should show up where expected http://bugs.koha-community.org/show_bug.cgi?id=6273 Signed-off-by: Benjamin Rokseth Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Benjamin Rokseth changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 --- Comment #18 from Katrin Fischer --- Ah, thx for clarifying. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 --- Comment #17 from paxed --- (In reply to Katrin Fischer from comment #16) > All the SIP messages are currently in English and untranslatable. I think > this is something for a more general bug and should not be a blocker here. Except this is added to the payment description, it's not a SIP message. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 --- Comment #16 from Katrin Fischer --- All the SIP messages are currently in English and untranslatable. I think this is something for a more general bug and should not be a blocker here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 paxed changed: What|Removed |Added CC||pasi.kalli...@pttk.fi --- Comment #15 from paxed --- (In reply to Benjamin Rokseth from comment #13) > > The payment descriptin is also appended with " (via SIP2)" if this is present. > That should be made translatable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 --- Comment #14 from M. de Rooy --- (In reply to Benjamin Rokseth from comment #13) > Created attachment 25167 [details] [review] > Signed-off-by: Benjamin Rokseth Thanks, Benjamin. Please update the status to Signed off again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 M. de Rooy changed: What|Removed |Added Priority|PATCH-Sent (DO NOT USE) |P5 - low -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Benjamin Rokseth changed: What|Removed |Added Attachment #24935|0 |1 is obsolete|| --- Comment #13 from Benjamin Rokseth --- Created attachment 25167 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25167&action=edit Bug 6273 - SIP2 Fee Paid and Fee Paid Response support Adds support for recording in Koha accountlines a different accounttype depending on how the fee was paid at the SIP2 station (cash, credit, etc) Adds a new param to recordpayment(), $sip_paytype, which is appended to the 'Pay' type if present. The payment descriptin is also appended with " (via SIP2)" if this is present. In order for other scripts to keep working as expected, "eq 'Pay'" needed to be replaced with a regex comparison "=~ /^Pay/", so that 'Pay' and 'Pay-##' would continue to group together. To test: 1. Make a payment over a SIP2 connection 2. Check the patron record in the staff client; you should see the modified description 3. Attempt to print a invoice or a reciept for the borrower; the payment should show up where expected http://bugs.koha-community.org/show_bug.cgi?id=6273 Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 M. de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #12 from M. de Rooy --- Benjamin: Please adjust subject line and add your signoff at the end of the commit message. Examples enough on another report :) You are almost there. Hang on.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Benjamin Rokseth changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Deichman Digital Development changed: What|Removed |Added Attachment #22834|0 |1 is obsolete|| Attachment #24889|0 |1 is obsolete|| Attachment #24890|0 |1 is obsolete|| --- Comment #11 from Deichman Digital Development --- Created attachment 24935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24935&action=edit Signed-off-by: Benjamin Rokseth Adds support for recording in Koha accountlines a different accounttype depending on how the fee was paid at the SIP2 station (cash, credit, etc) Adds a new param to recordpayment(), $sip_paytype, which is appended to the 'Pay' type if present. The payment descriptin is also appended with " (via SIP2)" if this is present. In order for other scripts to keep working as expected, "eq 'Pay'" needed to be replaced with a regex comparison "=~ /^Pay/", so that 'Pay' and 'Pay-##' would continue to group together. To test: 1. Make a payment over a SIP2 connection 2. Check the patron record in the staff client; you should see the modified description 3. Attempt to print a invoice or a reciept for the borrower; the payment should show up where expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 --- Comment #10 from Chris Cormack --- Thanks for signing off Benjamin A few things though Please mark the bug signed off when you are done Please obsolete the old patches and In the rebase the original commit message has been killed, can we get that back? So amend the signed off patch, add back the original commit message, attach it, and obsolete all the others. And finally switch to signed off. Thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Benjamin Rokseth changed: What|Removed |Added CC||benjamin.roks...@kul.oslo.k ||ommune.no --- Comment #9 from Benjamin Rokseth --- FYI, this was tested using SIP2 through telnet. 1. sent SIP2 Fee paid command after successful login: >> 37201401300900010401NOKBV333.33|AOFilleinstitusjon|AA1003|BKbbs001| got successful SIP2 response: << 38Y20140130154751AOFilleinstitusjon|AA1003|BKbbs001| 2. checked patron info in koha admin. Payment was added, with Payment, thanks msg. 3. Printed slip, where payment showed ok. Benjamin Rokseth (In reply to Deichman Digital Development from comment #8) > Created attachment 24890 [details] [review] > Signed-off-by: Benjamin Rokseth > > Rebased against master 2014-01-30 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 --- Comment #8 from Deichman Digital Development --- Created attachment 24890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24890&action=edit Signed-off-by: Benjamin Rokseth Rebased against master 2014-01-30 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 --- Comment #7 from Deichman Digital Development --- Created attachment 24889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24889&action=edit Rebased against master 2014-01-30 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Joel Sasse changed: What|Removed |Added CC||jsa...@plumcreeklibrary.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Kyle M Hall changed: What|Removed |Added Attachment #11476|0 |1 is obsolete|| --- Comment #6 from Kyle M Hall --- Created attachment 22834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22834&action=edit Bug 6273: Add support for recording SIP2 Fee Paid Payment Type Adds support for recording in Koha accountlines a different accounttype depending on how the fee was paid at the SIP2 station (cash, credit, etc) Adds a new param to recordpayment(), $sip_paytype, which is appended to the 'Pay' type if present. The payment descriptin is also appended with " (via SIP2)" if this is present. In order for other scripts to keep working as expected, "eq 'Pay'" needed to be replaced with a regex comparison "=~ /^Pay/", so that 'Pay' and 'Pay-##' would continue to group together. To test: 1. Make a payment over a SIP2 connection 2. Check the patron record in the staff client; you should see the modified description 3. Attempt to print a invoice or a reciept for the borrower; the payment should show up where expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 jdem...@roseville.ca.us changed: What|Removed |Added CC||jdem...@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Galen Charlton changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||gmcha...@gmail.com --- Comment #5 from Galen Charlton --- The rebased patch no longer applies. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Patch complexity|--- |Medium patch Version|3.6 |master --- Comment #4 from Katrin Fischer --- Resetting version to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #3 from Chris Cormack --- I had to rebase and fix a conflict, not sure I got it right. So I would like someone else to sign off please. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Chris Cormack changed: What|Removed |Added Attachment #6539|0 |1 is obsolete|| --- Comment #2 from Chris Cormack --- Created attachment 11476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11476&action=edit Bug 6273: Add support for recording SIP2 Fee Paid Payment Type Adds support for recording in Koha accountlines a different accounttype depending on how the fee was paid at the SIP2 station (cash, credit, etc) Adds a new param to recordpayment(), $sip_paytype, which is appended to the 'Pay' type if present. The payment descriptin is also appended with " (via SIP2)" if this is present. In order for other scripts to keep working as expected, "eq 'Pay'" needed to be replaced with a regex comparison "=~ /^Pay/", so that 'Pay' and 'Pay-##' would continue to group together. To test: 1. Make a payment over a SIP2 connection 2. Check the patron record in the staff client; you should see the modified description 3. Attempt to print a invoice or a reciept for the borrower; the payment should show up where expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Bug 6273 depends on bug 5605, which changed state. Bug 5605 Summary: Add Support for SIP Fee Paid Message http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5605 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Lori Ayre changed: What|Removed |Added CC||loria...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Ian Walls changed: What|Removed |Added Priority|P5 - low|PATCH-Sent Patch Status|--- |Needs Signoff QAContact|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 --- Comment #1 from Ian Walls 2011-12-02 15:57:37 UTC --- Created attachment 6539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6539 SIP2 Fee Paid Pay Type support Adds support for recording in Koha accountlines a different accounttype depending on how the fee was paid at the SIP2 station (cash, credit, etc) Adds a new param to recordpayment(), $sip_paytype, which is appended to the 'Pay' type if present. The payment descriptin is also appended with " (via SIP2)" if this is present. In order for other scripts to keep working as expected, "eq 'Pay'" needed to be replaced with a regex comparison "=~ /^Pay/", so that 'Pay' and 'Pay-##' would continue to group together. To test: 1. Make a payment over a SIP2 connection 2. Check the patron record in the staff client; you should see the modified description 3. Attempt to print a invoice or a reciept for the borrower; the payment should show up -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
