[Koha-bugs] [Bug 6374] Use size as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6374 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11357 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6374] Use size as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6374 David Cook dc...@prosentient.com.au changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10466 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6374] Use size as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6374 Chris Nighswonger cnighswon...@foundations.edu changed: What|Removed |Added CC||cnighswon...@foundations.ed ||u --- Comment #13 from Chris Nighswonger cnighswon...@foundations.edu 2012-01-21 05:17:17 UTC --- FWIW... it looks like large portions of this patch are simply reformatting of code style. Please be sure to keep those sorts of changes to a minimum in bugfixes, and submit separate patches to handle reformatting only. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6374] Use size as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6374 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Priority|PATCH-Sent (DO NOT USE) |P3 Status|Pushed to Master|Pushed to Stable CC||katrin.fisc...@bsz-bw.de -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6374] Use size as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6374 Ian Walls ian.wa...@bywatersolutions.com changed: What|Removed |Added Attachment #7027|0 |1 is obsolete|| -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6374] Use size as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6374 Ian Walls ian.wa...@bywatersolutions.com changed: What|Removed |Added CC||ian.walls@bywatersolutions. ||com Patch Status|Signed Off |Passed QA --- Comment #11 from Ian Walls ian.wa...@bywatersolutions.com 2012-01-06 13:11:16 UTC --- This patch is mostly indentation changes... only two sections of code changing are done. Changes seems sane and secure. Marking as Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6374] Use size as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6374 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added CC||paul.poul...@biblibre.com Version|master |rel_3_6 Patch Status|Passed QA |Patch Pushed --- Comment #12 from Paul Poulain paul.poul...@biblibre.com 2012-01-06 15:04:38 UTC --- Patch pushed, please test Gaetan, just a small comment: when you signoff a patch, be carefull : the 1st line is the header of the patch comment and is what appear on all lists. you've added works beautifully !, which is not a good description ;-) i've modified the comment to put your happyness after your signature ! Also note that your enthousiasm is nice, but it's not really usefull in the patch itself. Remember it's in the patch forever (really) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6374] Use size as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6374 Gaetan Boisson gaetan.bois...@biblibre.com changed: What|Removed |Added Patch Status|Signed Off |Failed QA --- Comment #8 from Gaetan Boisson gaetan.bois...@biblibre.com 2012-01-03 13:40:29 UTC --- I turns out there are actually two search forms on the admin side concerned with this issue. (Maybe more?) From the home of the admin interface, there is a quick search field and a link to advanced search, both using the same search which is now fixed. But in the cataloguing section it is a different search. The patch needs to fix this part too. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6374] Use size as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6374 Gaetan Boisson gaetan.bois...@biblibre.com changed: What|Removed |Added Attachment #7016|0 |1 is obsolete|| -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6374] Use size as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6374 Adrien SAURAT adrien.sau...@biblibre.com changed: What|Removed |Added Attachment #7014|0 |1 is obsolete|| --- Comment #9 from Adrien SAURAT adrien.sau...@biblibre.com 2012-01-03 14:32:41 UTC --- Created attachment 7027 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7027 proposed patch #3 Modifies also the addbooks result page. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6374] Use size as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6374 Adrien SAURAT adrien.sau...@biblibre.com changed: What|Removed |Added Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6374] Use size as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6374 --- Comment #10 from Gaetan Boisson gaetan.bois...@biblibre.com 2012-01-03 14:43:59 UTC --- Created attachment 7028 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7028 [SIGNED-OFF] Works beautifully! Bug 6374: default value for Size in result pages When no size info is available, an empty string is sent to the TT (if nothing is sent, the TT engine will display another information, irrelevant for Koha). Signed-off-by: Gaetan Boisson gaetan.bois...@biblibre.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6374] Use size as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6374 Gaetan Boisson gaetan.bois...@biblibre.com changed: What|Removed |Added Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6374] Use size as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6374 Adrien SAURAT adrien.sau...@biblibre.com changed: What|Removed |Added Attachment #6721|0 |1 is obsolete|| --- Comment #6 from Adrien SAURAT adrien.sau...@biblibre.com 2012-01-02 16:01:49 UTC --- Created attachment 7014 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7014 proposed patch #2 New patch, correcting staff+OPAC results. Corrects also a lot of indentation. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6374] Use size as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6374 Adrien SAURAT adrien.sau...@biblibre.com changed: What|Removed |Added Priority|P5 - low|PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6374] Use size as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6374 --- Comment #7 from Gaetan Boisson gaetan.bois...@biblibre.com 2012-01-02 16:32:06 UTC --- Created attachment 7016 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7016 Bug 6374: default value for Size in results In order to avoid the TT to display random numbers when the size information is not provided, a default empty string is sent if nothing else is available. Signed-off-by: Gaetan Boisson gaetan.bois...@biblibre.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6374] Use size as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6374 Gaetan Boisson gaetan.bois...@biblibre.com changed: What|Removed |Added CC||gaetan.bois...@biblibre.com Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6374] Use size as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6374 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Priority|PATCH-Sent |P5 - low -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6374] Use size as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6374 Adrien SAURAT adrien.sau...@biblibre.com changed: What|Removed |Added Patch Status|Needs Signoff |--- --- Comment #5 from Adrien SAURAT adrien.sau...@biblibre.com 2011-12-26 10:27:45 UTC --- Doesn't work well but I can't see why yet. I'll send a new patch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6374] Use size as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6374 Adrien SAURAT adrien.sau...@biblibre.com changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|ch...@bigballofwax.co.nz|adrien.sau...@biblibre.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6374] Use size as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6374 --- Comment #4 from Adrien SAURAT adrien.sau...@biblibre.com 2011-12-13 09:14:14 UTC --- MT8364 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6374] Use size as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6374 --- Comment #3 from Adrien SAURAT adrien.sau...@biblibre.com 2011-12-12 11:30:33 UTC --- Created attachment 6721 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6721 proposed patch I don't know the database enough to judge if a name change would be the best solution, but I attach here a patch which would at least define a default value for size (empty space), preventing conflict with TT. A lot of lines appear modified because I corrected some indentation/space tabs, but only three lines of code were really added. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6374] Use size as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6374 Adrien SAURAT adrien.sau...@biblibre.com changed: What|Removed |Added Priority|P5 - low|PATCH-Sent CC||adrien.sau...@biblibre.com Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6374] Use size as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6374 Janusz Kaczmarek janus...@gmail.com changed: What|Removed |Added Blocks||5917 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6374] Use size as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6374 --- Comment #1 from Janusz Kaczmarek janus...@gmail.com 2011-05-19 15:37:16 UTC --- Created attachment 4191 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4191 A screenshot illustrating one of the cases -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
