[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 M. de Rooy changed: What|Removed |Added Blocks|11078 | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #55 from Fridolin SOMERS --- This patch has been pushed to 3.14.x, will be in 3.14.1 Contains 3 patches : 08c8bea Bug 6435: (follow-up) make -daemon really imply -a and -b ae9e02a Bug 6435: (follow-up) rebuild_zebra -daemon option now smarter e7482ec Bug 6435: Add daemon mode to rebuild_zebra.pl -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 Fridolin SOMERS changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 --- Comment #54 from Martin Renvoize --- Nice work Doug, excellent follow through. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #53 from Galen Charlton --- Pushed to master. Thanks, Doug! Also, this appears to be your first patch accepted into Koha. Congratulation! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 --- Comment #52 from Doug Kingston --- Created attachment 22986 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22986&action=edit QA Patch - Make daemon mode imply -z -a -b and abort on incompatible flags -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 --- Comment #51 from Galen Charlton --- (In reply to Doug Kingston from comment #50) > I can try to pull that patch together this weekend. Great, thanks! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 --- Comment #50 from Doug Kingston --- I can try to pull that patch together this weekend. -Doug- -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 Galen Charlton changed: What|Removed |Added CC||gmcha...@gmail.com --- Comment #49 from Galen Charlton --- (In reply to Martin Renvoize from comment #48) > Follow-up note 1: I also tested the -sleep option and it worked well. > Follow-up note 2: As an afterthought, should the -z be implied by daemon > mode? In response to this and the previous comment, my view is that --daemon should imply (and be) "here's how you keep your Zebra index up to date." IOW, I think --daemon should imply the following options: -z -a -b It should exclude (by refusing to start or by simply ignoring) the following options: -r -s -k -h -y -where -length -offset -I | -skip-index I wouldn't consider this a blocker for putting the patch in master, but lean towards considering a it blocker for putting in a stable branch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 Martin Renvoize changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11078 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 --- Comment #48 from Martin Renvoize --- Follow-up note 1: I also tested the -sleep option and it worked well. Follow-up note 2: As an afterthought, should the -z be implied by daemon mode? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Signed Off --- Comment #47 from Martin Renvoize --- I'm up and down on passing this one.. discussed it with Katrin.. 1. Passes QA script (after I fixed some minor white space errors - Doug, please take a look at http://blog.bigballofwax.co.nz/2011/12/15/fixing-whitespace-when-apply-patches-with-git/ to stop these in their tracks before they hit QA with future patches ;) ) 2. Tested with various combinations of options: -a -daemon, -b -daemon, -a -b -daemon, -a -b -x -daemon, all worked as expected along with not breaking existing options. One niggle worth discussing: The intention of this patch is clear, to allow regular rebuilds as a daemon.. However, the patch allows all/any params to be passed along with the daemon mode. This slightly scares me as it becomes rather easy to break the system using the wrong combination of options. (for instance, running with -r would mean that every time a catalogue update happens, the zebra index disappears moments later whilst a full rebuild is happening) I don't think it's a QA fail, but it may be worth documenting that certain options don't work well with a daemon model. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 Martin Renvoize changed: What|Removed |Added Attachment #22851|0 |1 is obsolete|| --- Comment #46 from Martin Renvoize --- Created attachment 22859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22859&action=edit Bug 6435 Add daemon mode to rebuild_zebra.pl This change adds code to check the zebraqueue table with a cheap SQL query and a daemon loop that checks for new entries and processes them incremantally before sleeping for a controllable number of seconds. The default is 5 seconds which provides a near realtime search index update. This is desirable particularly for libraries that are doing active catalogue updating. The query is adjusted based on whether -a, -b, or -a -b are specified. Help text updated. Tested against a live 3.12 system. Note that this fix will benefit from the fix to lack of locking (bug 11078) Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 Chris Cormack changed: What|Removed |Added Attachment #22457|0 |1 is obsolete|| --- Comment #45 from Chris Cormack --- Created attachment 22851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22851&action=edit Bug 6435 Add daemon mode to rebuild_zebra.pl This change adds code to check the zebraqueue table with a cheap SQL query and a daemon loop that checks for new entries and processes them incremantally before sleeping for a controllable number of seconds. The default is 5 seconds which provides a near realtime search index update. This is desirable particularly for libraries that are doing active catalogue updating. The query is adjusted based on whether -a, -b, or -a -b are specified. Help text updated. Tested against a live 3.12 system. Note that this fix will benefit from the fix to lack of locking (bug 11078) Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 --- Comment #44 from Doug Kingston --- I addressed the recent QA issue on 10/28 with the updated patch. Can this be re-reviewed? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 --- Comment #43 from Katrin Fischer --- Yes, you'd probably want both, but for example if your library don't uses authorities and you don't turn it on and then someone catalogs an authority for testing... it shouldn't lead to trouble. It's just something that could go wrong that we might want to avoid either by documentation or by catching it in the code. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 M. Tompsett changed: What|Removed |Added Status|Failed QA |Needs Signoff CC||mtomp...@hotmail.com --- Comment #42 from M. Tompsett --- I'm just curious if you would want to run daemon mode for only biblios or only authorities. If this process is going to run in daemon mode, would you not want both to be picked up? Otherwise, you'd have to run two daemons (one for bibs and one for auths). Changing the status to needs sign off, since this question doesn't really affect whether the code does what it is supposed to do, but I haven't tested it. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 Doug Kingston changed: What|Removed |Added Attachment #21390|0 |1 is obsolete|| Attachment #21391|0 |1 is obsolete|| --- Comment #41 from Doug Kingston --- Created attachment 22457 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22457&action=edit [ENH] Bug 6435 Add daemon mode to rebuild_zebra.pl (revised 10/27) (combines previous patches and addresses recent QA issue) This change adds code to check the zebraqueue table with a cheap SQL query and a daemon loop that checks for new entries and processes them incremantally before sleeping for a controllable number of seconds. The default is 5 seconds which provides a near realtime search index update. This is desirable particularly for libraries that are doing active catalogue updating. The query is adjusted based on whether -a, -b, or -a -b are specified. Help text updated. Tested against a live 3.12 system. Note that this fix will benefit from the fix to lack of locking (bug 11078) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #40 from Katrin Fischer --- I think this doesn't work quite right if you use the daemon mode only for -b not for -a. The command I ran was: ./misc/migration_tools/rebuild_zebra.pl -daemon -sleep 4 -b -v -z Then I added a new authority, it keeps repeating the following lines: queued records: 1 skipping authorities exporting biblio Records exported: 0 Records exported: 0 REINDEXING zebra The record is not reindexed, but Koha keeps trying. I think this is because the SQL statement doesn't differentiate between authority and biblio records. Doug, could you take a look? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 Martin Renvoize changed: What|Removed |Added Attachment #22201|0 |1 is obsolete|| --- Comment #39 from Martin Renvoize --- Comment on attachment 22201 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22201 Bug 6345 Add locking to rebuild_zebra Oops.. wrong bug. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 --- Comment #38 from Martin Renvoize --- Created attachment 22201 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22201&action=edit Bug 6345 Add locking to rebuild_zebra This patch adds flock based locking for rebuild_zebra.pl on a per-instance basis. This prevents races between full rebuilds and background incremental updates from the zebraqueue table in the database. The race condition exists whether you are doing incremental updates with a periodic cronjob or with the new daemon mode. Suppose you start a full rebuild at time T0 which will take until T20 to extract the records. Suppose also at T10, a biblio or auth is updated and processed through the zebraqueue by T15. In this situation the updated record in zebra will be overwritten when the full rebuild records are uploaded to zebra after T20. We prevent this by only allowing one rebuild_zebra per koha instance to be running at one time. When running in daemon mode, incremental updates will be skipped while a full rebuild is running, and resume afterwards. A full rebuild or other adhoc request will wait for any previous lock to clear. Tested by flocking the lock file while invoking rebuild_zebra.pl in various modes (daemon, adhoc zebraqueue task, and full rebuild) using flock program I will attach to bug. http://bugs.koha-community.org/show_bug.cgi?id=11078 Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 M. Tompsett changed: What|Removed |Added Attachment #22080|0 |1 is obsolete|| --- Comment #37 from M. Tompsett --- Comment on attachment 22080 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22080 empty file to allow obsoleting other files. There is no need for this file. To obsolete files: Click on "Details" beside the attachment name. Click on "Edit Details" beside the name at the top. Check the obsolete box near the middle/bottom right. Click the appropriate save/submit button. To un-obsolete files: Click on link to show all the obsoleted items Click on "Details" beside the attachment name. Click on "Edit Details" beside the name at the top. Un-check the obsolete box near the middle/bottom right. Click the appropriate save/submit button. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 Doug Kingston changed: What|Removed |Added Attachment #22039|0 |1 is obsolete|| Attachment #22040|0 |1 is obsolete|| --- Comment #36 from Doug Kingston --- Created attachment 22080 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22080&action=edit empty file to allow obsoleting other files. Deleting unneeded files which have moved to a new bug 11078. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 --- Comment #35 from Doug Kingston --- I have created separate bug 11078 to track the race condition and its locking fix. 11078 depends on this bug. 6435 does not create any race condition that did not already exist. The patch for locking and the flock test program are attached to 11078. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 Doug Kingston changed: What|Removed |Added Blocks||11078 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #34 from Martin Renvoize --- Any chance we can move the 'Add locking to rebuild_zebra to prevent races' followup patch to a dependant bug instead of adding it here.. That way QA can go on with the deamon mode patch without being held in waiting for a further signoff. (PS, if you do that, I'll test and sign off on it). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 --- Comment #33 from Doug Kingston --- Created attachment 22040 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22040&action=edit Small perl program to flock files and run commands This program can be used to test the flock functionality introduced in patch 0003 also attached to this bug. Test I performed that QA can replicate (modify for your test instance name): flock the file, and make sure a full rebuild waits for the lock to clear before proceeding window 1: flock /var/lock/koha_rebuild_zebra_koha_test/lock sleep 15 window 2: ./rebuild_zebra.pl -b -a -v window 2 should wait for window 1's sleep to time out before proceeding. test that an flock from another process with cause the daemon mode to pause updates and resume when the flock is removed window 1: ./rebuild_zebra.pl -daemon -sleep 2 -v -z -b -a window 2: flock /var/lock/koha_rebuild_zebra_koha_test/lock sleep 15 start window 2 after window 1 is printing a message every 2 seconds. when you launch the sleep, it will stop the updates which will resume when the sleep times out. remove /var/log/koha_rebuild_zebra_koha_test and make sure its recreated on the next invocation of rebuild_zebra.pl. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 --- Comment #32 from Doug Kingston --- Created attachment 22039 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22039&action=edit Add locking to rebuild_zebra to prevent races This patch adds flock based locking for rebuild_zebra.pl on a per-instance basis. This prevents races between full rebuilds and background incremental updates from the zebraqueue table in the database. The race condition exists whether you are doing incremental updates with a periodic cronjob or with the new daemon mode. Suppose you start a full rebuild at time T0 which will take until T20 to extract the records. Suppose also at T10, a biblio or auth is updated and processed through the zebraqueue by T15. In this situation the updated record in zebra will be overwritten when the full rebuild records are uploaded to zebra after T20. We prevent this by only allowing one rebuild_zebra per koha instance to be running at one time. When running in daemon mode, incremental updates will be skipped while a full rebuild is running, and resume afterwards. A full rebuild or other adhoc request will wait for any previous lock to clear. Tested by flocking the lock file while invoking rebuild_zebra.pl in various modes (daemon, adhoc zebraqueue task, and full rebuild) using flock program I will attach to bug. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 Doug Kingston changed: What|Removed |Added Summary|Added daemon mode |[ENH] Added daemon mode |parameters to |parameters to |rebuild_zebra.pl|rebuild_zebra.pl -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/