[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2014-01-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Blocks||11515

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2012-04-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Blocks||7935

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2012-01-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

Frédéric Demians frede...@tamil.fr changed:

   What|Removed |Added

 Blocks||7394

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2012-01-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

--- Comment #50 from Chris Cormack ch...@bigballofwax.co.nz 2012-01-03 
07:10:55 UTC ---
(In reply to comment #49)
 This is working great in production.

Except for bug 7394

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 CC||fridolyn.som...@gmail.com

--- Comment #47 from Owen Leonard oleon...@myacpl.org 2011-10-24 12:26:48 UTC 
---
*** Bug 6120 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-10-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

   Patch Status|Passed QA   |Patch Pushed

--- Comment #46 from Chris Cormack ch...@bigballofwax.co.nz 2011-10-20 
15:59:41 UTC ---
Pushed, please test

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-10-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

Ian Walls ian.wa...@bywatersolutions.com changed:

   What|Removed |Added

   Attachment #4484|0   |1
is obsolete||
   Attachment #4495|0   |1
is obsolete||
   Attachment #4977|0   |1
is obsolete||
   Attachment #5114|0   |1
is obsolete||

--- Comment #45 from Ian Walls ian.wa...@bywatersolutions.com 2011-10-19 
17:55:56 UTC ---
Created attachment 5988
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5988
Passed QA patch (rebased on current master)

Patch had minor conflict in opac.css (resolved now).

Marking as Passed QA

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-10-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

Ian Walls ian.wa...@bywatersolutions.com changed:

   What|Removed |Added

   Patch Status|Signed Off  |Passed QA

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-08-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

   Attachment #5114|0   |1
   is patch||
   Attachment #5114|application/octet-stream|text/plain
  mime type||

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-08-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

--- Comment #43 from Frédéric Demians frede...@tamil.fr 2011-08-25 16:08:33 
UTC ---
Thanks for your quick and detailed reply.

 Query: Café

 busc variable on session: busc:

 q=Caf\xC3\xA9amp;query=kw,wrdl,rtrn=Caf\xC3\xA9
 amp;count=10amp;simple_query=Caf\xC3\xA9amp;listBiblios=29,30amp;total=2

I haven't Caf\xC3\xA9 but Caf\xC3\x83\xC2\xA9. 

And I have the same sessions table charset: utf8. So something get wrong
when writing the busc variable. I can reproduce the bug on whatever web
browser.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-08-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

--- Comment #44 from Owen Leonard oleon...@myacpl.org 2011-08-25 16:10:53 UTC 
---
I can't reproduce that bug either:

li class=back_resultsa title=Back to the results search list
href=opac-search.pl?q=café Back to results/a/li

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-08-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

--- Comment #38 from Frédéric Demians frede...@tamil.fr 2011-08-24 13:24:55 
UTC ---
Created attachment 5114
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5114
Signed-off patch

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-08-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

Frédéric Demians frede...@tamil.fr changed:

   What|Removed |Added

 CC||frede...@tamil.fr

--- Comment #39 from Frédéric Demians frede...@tamil.fr 2011-08-24 13:27:12 
UTC ---
There is a bug with search containing accented characters. For example, if you
search 'café', the 'busc' variable used to create 'back to results' link
contain: café

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-08-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

Frédéric Demians frede...@tamil.fr changed:

   What|Removed |Added

   Patch Status|Does not apply  |Signed Off

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-08-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

--- Comment #40 from Owen Leonard oleon...@myacpl.org 2011-08-24 13:29:01 UTC 
---
Shouldn't that bug be fixed before this gets a signoff?

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-08-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

--- Comment #41 from Frédéric Demians frede...@tamil.fr 2011-08-24 13:37:08 
UTC ---
 Shouldn't that bug be fixed before this gets a signoff?
'
I'd expect a following patch from the (great) enhancement submitter. He is in
situation to fix it quickly. If he can't, he could leave a note here, and I may
try...

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-08-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

--- Comment #42 from Salva Zaragoza Rubio sa...@masmedios.com 2011-08-24 
20:51:05 UTC ---
I can't seem to recreate the bug reported by Frédéric with the accented
characters. I've tested the patch with Koha running on servers OpenBSD 4.9 and
FreeBSD 8.2 without success.

OS FreeBSD:
---

Table sessions in mysql:

mysql show create table sessions;

| sessions | CREATE TABLE `sessions` (
  `id` varchar(32) NOT NULL,
  `a_session` text NOT NULL,
  UNIQUE KEY `id` (`id`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8 |


mysql SELECT CCSA.character_set_name FROM information_schema.`TABLES` T,
-information_schema.`COLLATION_CHARACTER_SET_APPLICABILITY` CCSA
- WHERE CCSA.collation_name = T.table_collation AND T.table_name =
'sessions';
++
| character_set_name |
++
| utf8   |
++

Query: Café

busc variable on session: busc:
q=Caf\xC3\xA9amp;query=kw,wrdl,rtrn=Caf\xC3\xA9
amp;count=10amp;simple_query=Caf\xC3\xA9amp;listBiblios=29,30amp;total=2

Link back to results:

Opera on PCBSD:
http://192.168.1.12:8079/cgi-bin/koha/opac-search.pl?q=Caf%C3%A9
SeaMonkey on PCBSD:
http://192.168.1.12:8079/cgi-bin/koha/opac-search.pl?q=Caf%C3%A9
Chromium on PCBSD:
http://192.168.1.12:8079/cgi-bin/koha/opac-search.pl?q=Caf%C3%A9


When returns always shows Café with the accent fine.

OS OpenBSD:
---

mysql show create table sessions;

| sessions | CREATE TABLE `sessions` (
  `id` varchar(32) NOT NULL,
  `a_session` text NOT NULL,
  UNIQUE KEY `id` (`id`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8 |


mysql SELECT CCSA.character_set_name FROM information_schema.`TABLES` T,
-information_schema.`COLLATION_CHARACTER_SET_APPLICABILITY` CCSA
- WHERE CCSA.collation_name = T.table_collation AND T.table_name =
'sessions';
++
| character_set_name |
++
| utf8   |
++

Query: Sé

busc variable on session: busc: q=S\xC3\xA9amp;query=kw,wrdl,rtrn=S\xC3\xA9
amp;count=20amp;simple_query=S\xC3\xA9amp;listBiblios=25,24,23,21,18,17,16,12,7,6,4,2amp;total=12

Link back to results:

Opera on PCBSD: http://192.168.1.14:8079/cgi-bin/koha/opac-search.pl?q=S%C3%A9
SeaMonkey on PCBSD:
http://192.168.1.14:8079/cgi-bin/koha/opac-search.pl?q=S%C3%A9
Chromium on PCBSD:
http://192.168.1.14:8079/cgi-bin/koha/opac-search.pl?q=S%C3%A9


When returns always shows Sé with the accent fine.


I've seen that café is the utf8 codification of Café, maybe there's a
codification in some place, but in the patch there is not one.

[salzaru@pcbsd /usr/home/salzaru]$ echo Café | iconv -t UTF-8 -f ISO-8859-1 
Café

[salzaru@pcbsd /usr/home/salzaru]$ perl -e 'use Encode; print (encode(utf8,
Café) . chr(10));'
Café

[salzaru@pcbsd /usr/home/salzaru]$ perl -e 'use Encode; print (decode(utf8,
café) . chr(10));'
café

Any ideas?

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

--- Comment #36 from Salva Zaragoza Rubio sa...@masmedios.com 2011-08-12 
07:32:00 UTC ---
(In reply to comment #34)
 Other comment : it seems this ENH has not been announced on the wiki, through 
 a
 RFC. Am I right ?

You're right, I didn't think it was worth adding as is a minor enhancement,
without database modification or large number of pages affected. But I'll add a
RFC if you consider it necessary.

BTW, looking at bugs I think it might cause a confict with bug 6120
(http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6120) as both add the
back to search functionality in the same place. I see that bug 6120 doesn't add
paging, only the back to results button. We'll have to evaluate whether both
bugs can coexist, a merge is done or one is rejected.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

--- Comment #37 from Paul Poulain paul.poul...@biblibre.com 2011-08-12 
07:45:22 UTC ---
(In reply to comment #36)
 (In reply to comment #34)
  Other comment : it seems this ENH has not been announced on the wiki, 
  through a
  RFC. Am I right ?
 
 You're right, I didn't think it was worth adding as is a minor enhancement,
 without database modification or large number of pages affected. But I'll add 
 a RFC if you consider it necessary.

well, IMO :
* it's not a minor ENH ! And I just discovered the feature when QAing it. The
bad news is that BibLibre just developed something very similar to this one.
Lack of coordination/communication :(( (see my RM for 3.8/4.0 application on
the wiki )
* in RFC, the C means 'Comment'. Once it's done, there are no real comments we
can do. I would vote to continue without RFCs on the wiki.

 BTW, looking at bugs I think it might cause a confict with bug 6120
 (http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6120) as both add 
 the
 back to search functionality in the same place. I see that bug 6120 doesn't 
 add
 paging, only the back to results button. We'll have to evaluate whether both
 bugs can coexist, a merge is done or one is rejected.

Well spotted ! i've removed the passed QA to bug 6120, we must discuss what
we do with those conflicting developments. My personal preference would be to
deal with your patch, as he does more things.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-08-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com

--- Comment #32 from Paul Poulain paul.poul...@biblibre.com 2011-08-11 
16:31:04 UTC ---
(In reply to comment #31)
 As per discussion in IRC, the need for a system preference to control this can
 be put off onto another ticket, since for anyone who wants to hide this, they
 can use the CSS provided.

+1 from me for this option or not creating a syspref
join me at the LASTCEBABTAASM (the league against sysprefs that can easily be
avoided, because there are already so many)

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-08-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

   Patch Status|Signed Off  |Does not apply

--- Comment #33 from Paul Poulain paul.poul...@biblibre.com 2011-08-11 
16:38:48 UTC ---
QA comment

This patch does not apply anymore, there is a conflict on opac.css

I think it's easy to solve, but I don't want to do something wrong, so I mark
does not apply. Salva, please rebase  fix the problem, i'll have a look
ASAP, I agree it's a great feature.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-08-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

--- Comment #34 from Paul Poulain paul.poul...@biblibre.com 2011-08-11 
16:41:19 UTC ---
Other comment : it seems this ENH has not been announced on the wiki, through a
RFC. Am I right ?

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-07-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

Ian Walls ian.wa...@bywatersolutions.com changed:

   What|Removed |Added

 CC||ian.walls@bywatersolutions.
   ||com

--- Comment #25 from Ian Walls ian.wa...@bywatersolutions.com 2011-07-15 
11:49:19 UTC ---
Agreed, these new screenshots do look really good.  Will test the functionality
more in depth soon, but I wanted to provide this bit of feedback:

Should this be a system-preference controlled option?  Can we safely assume
that all libraries will want this feature, since it's really neat, or should we
err on the side of caution and make in an opt-in feature.

If a system preference was added, should it go in OPAC preferences, or
Searching preferences?

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-07-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

--- Comment #26 from Salva Zaragoza Rubio sa...@masmedios.com 2011-07-15 
12:48:02 UTC ---
The idea was to enhance the usability and the navigation of the opac-detail
page. We didn't create a new sytem preference because the patch doesn't show
new information or add new content features, only links to a result already
achieved.

But as always the patch can be modified to give the option of activate it
through a system preference if the community thinks so.

I suggest the system preference to go in the Opac Preferences (Appearance) if
it's decided that has to be modified.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-07-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

--- Comment #27 from Magnus Enger mag...@enger.priv.no 2011-07-15 13:54:18 
UTC ---
I'd say get the feature in there and let's worry about the syspref later if
anyone complains...

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-07-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #28 from Katrin Fischer katrin.fisc...@bsz-bw.de 2011-07-15 
13:58:40 UTC ---
It's quite a big change and because it's OPAC and not staff I would like to see
a system preference. Perhaps a compromise could be to turn it ON by default
instead of OFF? :)

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-07-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

--- Comment #29 from Owen Leonard oleon...@myacpl.org 2011-07-15 16:30:19 UTC 
---
To hide this using OPACUserCSS you would add this:

.nav_results { display: none; }

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-07-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

--- Comment #30 from Katrin Fischer katrin.fisc...@bsz-bw.de 2011-07-15 
16:55:07 UTC ---
Good point :)

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-06-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

   Attachment #4476|0   |1
is obsolete||
   Attachment #4477|0   |1
is obsolete||
   Attachment #4509|0   |1
is obsolete||

--- Comment #24 from Magnus Enger mag...@enger.priv.no 2011-06-21 07:08:49 
UTC ---
Created attachment 4512
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4512
Signed-off patch

I can't vouch for the technical quality of the code, but the feature works
beautifully. Thanks to the author for doing multiple revisions based on
feedback from the Community!

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-06-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

   Patch Status|Needs Signoff   |Signed Off

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

Salva Zaragoza Rubio sa...@masmedios.com changed:

   What|Removed |Added

   Attachment #4446|0   |1
is obsolete||

--- Comment #23 from Salva Zaragoza Rubio sa...@masmedios.com 2011-06-20 
09:01:58 UTC ---
Created attachment 4509
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4509
Proposed patch with the new look

Modified patch to include the new look.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

--- Comment #17 from Salva Zaragoza Rubio sa...@masmedios.com 2011-06-16 
12:11:19 UTC ---
Created attachment 4495
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4495
New look proposal for the pagination in opac-detail

Hi,

After looking at your proposals and consulting with our design team we have
decided this new look for the pagination.
The links are all on the top right, the browse results is a link to open a
layer with two areas. The top one is an index list and two special links, the
leftmost and rightmost are just to navigate the list. The bottom area is a list
with the biblios that correspond to the index list. Everytime you move over the
index list, the biblio list sorts itself to accomodate to the index list.

The features hasn't changed, only the look.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

--- Comment #18 from Owen Leonard oleon...@myacpl.org 2011-06-16 12:19:55 UTC 
---
Created attachment 4496
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4496
Extracted first image from PDF: Pagination links

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

--- Comment #19 from Owen Leonard oleon...@myacpl.org 2011-06-16 12:20:40 UTC 
---
Created attachment 4497
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4497
Extracted second image from PDF: Expanded results menu

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

--- Comment #20 from Owen Leonard oleon...@myacpl.org 2011-06-16 12:21:10 UTC 
---
I think the latest proposal looks great.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

--- Comment #21 from Magnus Enger mag...@enger.priv.no 2011-06-16 12:36:53 
UTC ---
+1

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-06-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

--- Comment #22 from Nicole C. Engard neng...@gmail.com 2011-06-16 17:08:37 
UTC ---
I LOVE IT!! +1

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

--- Comment #10 from Magnus Enger mag...@enger.priv.no 2011-06-15 10:09:10 
UTC ---
I have tested the revised patch (attachment 4446) and it works beautifully. I
do have some comments, though: 

- the size of the text in the box on the right (Pagination: « previous next »
) should be a little larger, to match the text above and below it

- I would prefer if all the added functionality was in the box on the right,
and nothing was below the items - but that might just be me? 

This is kind of a big change to how the OPAC detail view looks, so it would be
good to have some more opinions! I'll attach a couple screen shots so others
can see without applying the patch.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

--- Comment #12 from Magnus Enger mag...@enger.priv.no 2011-06-15 10:12:10 
UTC ---
Created attachment 4477
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4477
Pagination, expanded view

Again, this is with the patch applied, but here the ... below the items has
been clicked, to reveal the list of records that are on the same page as the
one being displayed on the page.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

--- Comment #13 from Salva Zaragoza Rubio sa...@masmedios.com 2011-06-15 
10:28:06 UTC ---
(In reply to comment #10)
 I have tested the revised patch (attachment 4446 [details]) and it works 
 beautifully. I
 do have some comments, though: 
 
 - the size of the text in the box on the right (Pagination: « previous next »
 ) should be a little larger, to match the text above and below it

You're right the font size doesn't match, I'll change the css to fix it.

 
 - I would prefer if all the added functionality was in the box on the right,
 and nothing was below the items - but that might just be me? 

I've added only the simple functionality in the right box, and the same with
the paging list below the items to not overload the page at the top area.
But it can be modified to render it as the community decides.

 
 This is kind of a big change to how the OPAC detail view looks, so it would be
 good to have some more opinions! I'll attach a couple screen shots so others
 can see without applying the patch.

Ok, good idea.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-06-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

--- Comment #16 from Nicole C. Engard neng...@gmail.com 2011-06-15 16:12:38 
UTC ---
I approve of that image (since I previously said it should be elsewhere I
figured I should mention that).

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-06-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

Salva Zaragoza Rubio sa...@masmedios.com changed:

   What|Removed |Added

   Attachment #4430|0   |1
is obsolete||

--- Comment #9 from Salva Zaragoza Rubio sa...@masmedios.com 2011-06-13 
16:16:31 UTC ---
Created attachment 4446
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4446
Proposed patch for Add paging in opac-detail when coming from a search with
session storage

Add paging in opac-detail when coming from a search to be
able to continue viewing the previous and next register
from the detail without returning to the results.
The partial list pagination can be showed to increase forwarding
or rewinding in the pagination.
It's implemented for Zebra search and not build_grouped_results.

The param busc with all the information from the search is stored
on the session when running opac-search and opac-detail, outside these
pages the busc param is removed from the session.

A list of the biblionumbers inside the OPACnumSearchResults range
is passed to avoid repeating the searching everytime we see the
previous or next biblio. The searching will be run again when
we are going to exceed the list and a new one will be calculated
from the new search.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-06-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

   Priority|P5  |PATCH-Sent
 CC||ch...@bigballofwax.co.nz
   Patch Status|--- |Needs Signoff

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-06-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

--- Comment #1 from Salva Zaragoza Rubio sa...@masmedios.com 2011-06-08 
11:26:31 UTC ---
Created attachment 4430
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4430
Proposed Patch for Paging in opac-detail when coming from a search

 Add paging in opac-detail when coming from a search to be
able to continue viewing the previous and next register
from the detail without returning to the results.
The partial list pagination can be showed to increase forwarding
or rewinding in the pagination.
It's implemented for Zebra search and not build_grouped_results.

The param busc with all the information from the search is passed
encrypted in zip and base64 for security reasons and to avoid
storing it in the session or submitting by POST.
The Compress::Zlib perl library is needed.

A list of the biblionumbers inside the OPACnumSearchResults range
is passed to avoid repeating the searching everytime we see the
previous or next biblio. The searching will be run again when
we are going to exceed the list and a new one will be calculated
from the new search.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-06-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

 CC||mag...@enger.priv.no

--- Comment #2 from Magnus Enger mag...@enger.priv.no 2011-06-08 13:03:35 UTC 
---
This looks like a really, really cool new feature! Assessing the implementation
of it is a little bit over my head, but I do have a couple of questions: 

1. I'm not crazy about that busc-parameter in the URL of the detail view - I'm
rather fond of the clean and simple URL structure of Koha... Would it be
possible to store that information in a cookie/session? You say something about
avoid storing it in the session - I'm not sure it should be avoided... ;-) 

2. This is such a cool feature, I think it deserves a more prominent place than
at the bottom of the screen, possibly below lots and lots of items. Could it be
placed in the right hand column, as a new box between the existing two?
(Below more searches and above save record.)

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-06-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

--- Comment #3 from Salva Zaragoza Rubio sa...@masmedios.com 2011-06-08 
13:45:15 UTC ---
(In reply to comment #2)
 This looks like a really, really cool new feature! Assessing the 
 implementation
 of it is a little bit over my head, but I do have a couple of questions: 
 
 1. I'm not crazy about that busc-parameter in the URL of the detail view - I'm
 rather fond of the clean and simple URL structure of Koha... Would it be
 possible to store that information in a cookie/session? You say something 
 about
 avoid storing it in the session - I'm not sure it should be avoided... ;-) 

The reason for avoid storing it in the session is to be able to take the url
and paste it in another place and have the same result, if you have it in a
session it's impossible, and with the session you have the obligued task of
cleaning all the information you've stored, and it'll have to be made from all
the pages you go from the opac-detail, a lot of more coding. But I'm open to
all options. I thought it was the more simple solution.

 
 2. This is such a cool feature, I think it deserves a more prominent place 
 than
 at the bottom of the screen, possibly below lots and lots of items. Could it 
 be
 placed in the right hand column, as a new box between the existing two?
 (Below more searches and above save record.)
Of course, I'll change it and present the new rendering.

Thanks for the positive response.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-06-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

--- Comment #4 from Magnus Enger mag...@enger.priv.no 2011-06-08 13:52:41 UTC 
---
(In reply to comment #3)
 The reason for avoid storing it in the session is to be able to take the url
 and paste it in another place and have the same result

Hm, that doesn't seem to work for me. I copied the URL for a detail page from
Firefox and pasted it into Chromium, but the next and previous links do not
show up there...

Here's the URL:
http://localhost/cgi-bin/koha/opac-detail.pl?biblionumber=661busc=eNo9zMEKwjAQBNBf8eRpD4ltNxskl%2F6IVJpCMDU1iVT%2F3iEFDw%2BGnWHD%2FHGP%2FTyt2%2FXlUompxbQs%0AxVene3U0b5%2B%2FmNGe50i55mebnlpZwrpFfzs2%2Fw8xlDqGewypOGZFzBp6GEDAEhvczAU6YkEWZEEv%0ADOgtsjVklIYOehja%2F5rqFJ0V%2FQNRVznG%0A

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-06-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
Version|unspecified |master
 AssignedTo|oleon...@myacpl.org |sa...@masmedios.com

--- Comment #5 from Owen Leonard oleon...@myacpl.org 2011-06-08 14:12:54 UTC 
---
(In reply to comment #3)
 The reason for avoid storing it in the session is to be able to take the url
 and paste it in another place and have the same result

That is a positive aspect of it, but I wonder if it isn't outweighed by the
negative of the unfriendly URL. I think yes, but it might be a question to
raise on the mailing list. I think it's much more likely that someone is going
to want to share the URL of a page because of the item in question. I think the
use case of wanting to share the item along with search context is less likely.

(In reply to comment #4)
 Hm, that doesn't seem to work for me. I copied the URL for a detail page from
 Firefox and pasted it into Chromium, but the next and previous links do not
 show up there...

It works for me.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-06-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

--- Comment #6 from Salva Zaragoza Rubio sa...@masmedios.com 2011-06-08 
14:16:25 UTC ---
(In reply to comment #4)
 (In reply to comment #3)
  The reason for avoid storing it in the session is to be able to take the 
  url
  and paste it in another place and have the same result
 
 Hm, that doesn't seem to work for me. I copied the URL for a detail page from
 Firefox and pasted it into Chromium, but the next and previous links do not
 show up there...
 
 Here's the URL:
 http://localhost/cgi-bin/koha/opac-detail.pl?biblionumber=661busc=eNo9zMEKwjAQBNBf8eRpD4ltNxskl%2F6IVJpCMDU1iVT%2F3iEFDw%2BGnWHD%2FHGP%2FTyt2%2FXlUompxbQs%0AxVene3U0b5%2B%2FmNGe50i55mebnlpZwrpFfzs2%2Fw8xlDqGewypOGZFzBp6GEDAEhvczAU6YkEWZEEv%0ADOgtsjVklIYOehja%2F5rqFJ0V%2FQNRVznG%0A

From what I see it's a fine url, but obviously I can't access you localhost ;)

I've tested it on my server and works the copying and pasting action for
Chromium, Opera, IE, Firefox, Safari. But maybe you've found a bug that I
didn't expect or foresee. Can you see your logs to narrow the problem?

Thanks

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-06-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

--- Comment #7 from Salva Zaragoza Rubio sa...@masmedios.com 2011-06-08 
14:23:10 UTC ---
(In reply to comment #5)
 (In reply to comment #3)
  The reason for avoid storing it in the session is to be able to take the 
  url
  and paste it in another place and have the same result
 
 That is a positive aspect of it, but I wonder if it isn't outweighed by the
 negative of the unfriendly URL. I think yes, but it might be a question to
 raise on the mailing list. I think it's much more likely that someone is going
 to want to share the URL of a page because of the item in question. I think 
 the
 use case of wanting to share the item along with search context is less 
 likely.
 

Perfect, I'll change it as the community decides, I know it's an ugly url, so
as I said before I'm open to all options.


 (In reply to comment #4)
  Hm, that doesn't seem to work for me. I copied the URL for a detail page 
  from
  Firefox and pasted it into Chromium, but the next and previous links do not
  show up there...
 
 It works for me.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6483] Paging in opac-detail when coming from a search

2011-06-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6483

--- Comment #8 from Magnus Enger mag...@enger.priv.no 2011-06-08 14:23:33 UTC 
---
 (In reply to comment #4)
  Hm, that doesn't seem to work for me. I copied the URL for a detail page 
  from
  Firefox and pasted it into Chromium, but the next and previous links do not
  show up there...
 
 It works for me.

Sorry about that, it works for me too. (I forgot to switch from Norwegian to
English when testing - again...) 

Anyway, I do agree with Owen's comment that the benefit of this functionality
probably does not outweigh the unfriendliness of the URL.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/