[Koha-bugs] [Bug 6598] OPACFineNoRenewals syspreference does not stop user renewing in opac

2012-05-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6598

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #14 from Jared Camins-Esakov  ---
This fix was included in the 3.6.x branch prior to 3.6.4.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6598] OPACFineNoRenewals syspreference does not stop user renewing in opac

2012-02-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6598

Paul Poulain  changed:

   What|Removed |Added

Version|master  |rel_3_6

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6598] OPACFineNoRenewals syspreference does not stop user renewing in opac

2012-02-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6598

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6598] OPACFineNoRenewals syspreference does not stop user renewing in opac

2012-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6598

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6598] OPACFineNoRenewals syspreference does not stop user renewing in opac

2012-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6598

--- Comment #13 from Owen Leonard  2012-02-13 14:31:24 UTC 
---
Created attachment 7620
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7620
Screenshot showing view after the patch

After the patch renewal controls are no longer displayed.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6598] OPACFineNoRenewals syspreference does not stop user renewing in opac

2012-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6598

--- Comment #12 from Owen Leonard  2012-02-13 14:29:36 UTC 
---
Created attachment 7619
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7619
Screenshot showing view without the patch

Before this patch the user logged in to the OPAC is correctly told that they
cannot renew items online because of their fine, but renewal-related controls
are displayed (renew selected, renew all).

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6598] OPACFineNoRenewals syspreference does not stop user renewing in opac

2012-02-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6598

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #11 from Paul Poulain  2012-02-03 
14:10:19 UTC ---
Sorry, I wanted to test before pushing, and could not understand which test
data I must have to see how the fix works.

Please give a full test plan and switch back to passed QA to reach me directly.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6598] OPACFineNoRenewals syspreference does not stop user renewing in opac

2012-02-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6598

M. de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #10 from M. de Rooy  2012-02-03 10:51:51 
UTC ---
QA Comment: Looks good (without testing it). Well documented change, improving
code. Marking as Passed QA.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6598] OPACFineNoRenewals syspreference does not stop user renewing in opac

2012-02-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6598

M. de Rooy  changed:

   What|Removed |Added

   Priority|PATCH-Sent (DO NOT USE) |P3

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6598] OPACFineNoRenewals syspreference does not stop user renewing in opac

2012-01-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6598

Owen Leonard  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6598] OPACFineNoRenewals syspreference does not stop user renewing in opac

2012-01-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6598

Owen Leonard  changed:

   What|Removed |Added

   Attachment #6179|0   |1
is obsolete||

--- Comment #9 from Owen Leonard  2012-01-17 21:09:51 UTC 
---
Created attachment 7204
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7204
Revised fix

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6598] OPACFineNoRenewals syspreference does not stop user renewing in opac

2011-12-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6598

Paul Poulain  changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com
   Patch Status|Signed Off  |Does not apply

--- Comment #8 from Paul Poulain  2011-12-13 
14:05:42 UTC ---
changed to "does not apply", once you've submitted an updated bug, switch back
to signed-off, no problem with that

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6598] OPACFineNoRenewals syspreference does not stop user renewing in opac

2011-12-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6598

M. de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
  QAContact|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |

--- Comment #7 from M. de Rooy  2011-12-01 08:06:45 
UTC ---
Patch does not apply anymore. Automerge still works, but result needs some
editing since a few warnings have been added in the meantime..
Please send a new version; leave the status at Signed Off.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6598] OPACFineNoRenewals syspreference does not stop user renewing in opac

2011-11-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6598

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
   Patch Status|Needs Signoff   |Signed Off

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6598] OPACFineNoRenewals syspreference does not stop user renewing in opac

2011-11-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6598

Brendan Gallagher  changed:

   What|Removed |Added

   Attachment #5842|0   |1
is obsolete||

--- Comment #6 from Brendan Gallagher  2011-11-04 
06:04:31 UTC ---
Created attachment 6179
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6179
Signed-off

Signed-Off

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6598] OPACFineNoRenewals syspreference does not stop user renewing in opac

2011-10-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6598

Owen Leonard  changed:

   What|Removed |Added

   Priority|P5  |PATCH-Sent
   Patch Status|--- |Needs Signoff

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6598] OPACFineNoRenewals syspreference does not stop user renewing in opac

2011-10-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6598

Owen Leonard  changed:

   What|Removed |Added

   Attachment #4657|0   |1
is obsolete||

--- Comment #5 from Owen Leonard  2011-10-11 19:17:22 UTC 
---
Created attachment 5842
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5842
Proposed fix

This patch standardizes the condition under which renewal controls
are displayed at the page (as opposed to item) level. In some
places "canrenew" was used, in others "patron_flagged" was used.
Now "canrenew" controls renew controls and "patron_flagged" only
triggers the display of user warnings.

This patch also allows for renewal information to be displayed
for each item in situations where OPAC renewals are allowed but
disabled for whatever reason. This gives the patron information
about used/available renew counts but hides renew controls.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6598] OPACFineNoRenewals syspreference does not stop user renewing in opac

2011-10-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6598

Owen Leonard  changed:

   What|Removed |Added

   Priority|PATCH-Sent  |P5
 AssignedTo|colin.campbell@ptfs-europe. |oleon...@myacpl.org
   |com |

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6598] OPACFineNoRenewals syspreference does not stop user renewing in opac

2011-10-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6598

Nicole C. Engard  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
   Patch Status|Patch Pushed|---
 Resolution|FIXED   |

--- Comment #4 from Nicole C. Engard  2011-10-11 18:05:42 
UTC ---
I think this bug is back ... 

Patron was allowed to renew at home with late items. Our system setting is set
to no renew if more than .01.

The patron was at home and used IE. She told staff the it said it would not
renew because of fine, but then when she hit OK it renewed. That's all the info
I have.

I tested in FF7 on Mac and it prevents renewals, so I think it's a browser
compatibility issue.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6598] OPACFineNoRenewals syspreference does not stop user renewing in opac

2011-08-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6598

Colin Campbell  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6598] OPACFineNoRenewals syspreference does not stop user renewing in opac

2011-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6598

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
   Patch Status|Signed Off  |Patch Pushed

--- Comment #3 from Chris Cormack  2011-08-01 
01:21:56 UTC ---
Easily tested, works well, pushing. Please test and mark resolved

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6598] OPACFineNoRenewals syspreference does not stop user renewing in opac

2011-07-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6598

Nicole C. Engard  changed:

   What|Removed |Added

 CC||neng...@gmail.com
   Patch Status|Needs Signoff   |Signed Off

--- Comment #2 from Nicole C. Engard  2011-07-18 12:04:48 
UTC ---
Actually it fixed another bug as well which was that the columns were
mislabeled if you have the barcode and the 'links' column appearing. I have
signed off on this patch!

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6598] OPACFineNoRenewals syspreference does not stop user renewing in opac

2011-07-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6598

Colin Campbell  changed:

   What|Removed |Added

   Priority|P5  |PATCH-Sent
   Patch Status|--- |Needs Signoff

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6598] OPACFineNoRenewals syspreference does not stop user renewing in opac

2011-07-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6598

Colin Campbell  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|oleon...@myacpl.org |colin.campbell@ptfs-europe.
   ||com

--- Comment #1 from Colin Campbell  2011-07-18 
11:52:31 UTC ---
Created attachment 4657
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4657
Proposed Patch

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/