[Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links also get imported
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 simith.dolive...@inlibro.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links also get imported
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 simith.dolive...@inlibro.com changed: What|Removed |Added Attachment #30795|0 |1 is obsolete|| -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links also get imported
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 --- Comment #15 from simith.dolive...@inlibro.com --- Created attachment 31181 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31181&action=edit Bug 6681 - When importing a biblio record via Z39.50, authority links and items also get imported. This patch removes the content of subfield 9 for all authority headings and items in biblios imported from a Z39.50 server. Changes: C4/Biblio.pm - new function RemoveItemsAndAuthidsFromRecord added acqui/neworderempty.pl - calls new function cataloguing/addbiblio.pl - calls new function t/Biblio.t - new tests added Testing: I Before applying the patch 0) Add a koha z39.50 server (Home › Administration › Z39.50 servers); 1) in Home > Cataloging click <>; 2) Import a record with an autority link (with zone 100 subzone 9 for example); 3) Validate: The record imported have zone 100, subzone 9; II After applying the patch 1) in Home > Cataloging click <>; 2) Import a record with an autority link (with zone 100 subzone 9 for example); 3) Validate: The record imported don't have the subzone 9 in the zone 100; -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links also get imported
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 --- Comment #14 from simith.dolive...@inlibro.com --- Hi Katrin, 1) Done. 2) When a record is imported from Z39.50, both authorities and items are specific to the library imported, so should be removed. 3) Done. 4) I sent a wrong patch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links also get imported
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links also get imported
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681
--- Comment #13 from Katrin Fischer ---
Comment on attachment 30795
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30795
This patch update the code and fix MARC flavour problem by removing all
subfields $9 from the imported record.
Review of attachment 30795:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6681&attachment=30795)
-
Starting with a code review here:
1) This patch lacks a test plan and a description of the changes - please add
those to the commit message.
2) This patch also doesn't do, what the bug description says. It not only
removes $9 subfields, but it also removes items. I am not quite happy with both
those features combined into one method. I'd like it a bit better if they were
separated - but there might be reason to have both combined?
3) Anyway, we need a unit test for the new routine(s).
4) It's not MARC-agnostic, but only adds code for MARC21 - not for UNIMARC or
NORMARC. It would be nice to add code for the other dialects as well or at
least file bugs for them.
::: C4/Biblio.pm
@@ +2800,5 @@
> +}
> +
> +# Remove all authid links ($9) in the record
> +if ( $marcflavour eq "MARC21" ) {
> +my @heading = qw(100 110 111 130 440 600 610 611 630 648 650 651 655
> 700 710 711 730 800 810 811 830);
I am a bit torn about hardcoding the fields.
One idea I had was to look up the authority linked fields in the frameworks -
but you might have a library that doesn't use authorities at all or differently
and import from another that does use them - in that case it won't work. So I
don't have a better idea currently.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links also get imported
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 simith.dolive...@inlibro.com changed: What|Removed |Added Priority|PATCH-Sent (DO NOT USE) |P2 Status|Failed QA |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links also get imported
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 simith.dolive...@inlibro.com changed: What|Removed |Added Attachment #7117|0 |1 is obsolete|| -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links also get imported
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 --- Comment #12 from simith.dolive...@inlibro.com --- Created attachment 30795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30795&action=edit This patch update the code and fix MARC flavour problem by removing all subfields $9 from the imported record. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links also get imported
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 simith.dolive...@inlibro.com changed: What|Removed |Added CC||eric.be...@inlibro.com, ||francois.charbonnier@inlibr ||o.com, ||philippe.blo...@inlibro.com ||, ||simith.dolive...@inlibro.co ||m Assignee|fcapovi...@live.ca |simith.dolive...@inlibro.co ||m -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links also get imported
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 --- Comment #11 from Frédérick Capovilla --- Having never worked with unimarc or normarc records and Z39.50 servers, we are not equipped to easily adapt our patch for it to work with these formats. Could anyone improve this patch so it becomes flexible enough for inclusion on master? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links also get imported
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 Paul Poulain changed: What|Removed |Added Status|Signed Off |Failed QA CC||paul.poul...@biblibre.com --- Comment #10 from Paul Poulain 2012-02-01 17:03:38 UTC --- QA comment This patch depends on MARC flavour, and unimarc should be added. But there's an other option: make it marc independant, and use select DISTINCT tagfield FROM marc_subfield_structure WHERE authtypecode<>''; to get the tags that are "connected" to an authority. could you update your patch ? (marking failed QA this one) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links also get imported
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 Chris Cormack changed: What|Removed |Added Patch Status|Needs Signoff |Signed Off --- Comment #9 from Chris Cormack 2012-01-13 03:48:23 UTC --- Signed off, this now has the added benefit of fixing neworderempty.pl which used to blindly delete 952, wether the record was UNIMARC, NORMARC or MARC21. A follow up to add removing the authority id's for UNIMARC and NORMARC would be good. But this introduces no regressions, adds a feature and fixes a bug so should not have to wait for a follow up. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links also get imported
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 Chris Cormack changed: What|Removed |Added Attachment #7115|0 |1 is obsolete|| --- Comment #8 from Chris Cormack 2012-01-13 03:46:13 UTC --- Created attachment 7117 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7117 Bug 6681: Remove Koha-specific fields from records imported via Z39.50 - Corrected RemoveItemsAndAuthidsFromRecord should now use the system preferences. Signed-off-by: Chris Cormack -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links also get imported
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 Frédérick Capovilla changed: What|Removed |Added Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links also get imported
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 Frédérick Capovilla changed: What|Removed |Added Attachment #6929|0 |1 is obsolete|| --- Comment #7 from Frédérick Capovilla 2012-01-12 17:55:59 UTC --- Created attachment 7115 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7115 Corrected patch - Now checks system preferences Here is a new version that checks the marcflavour and also uses the configured koha item tag. I only did the code for the MARC21 marcflavour since I only use and understand the MARC21 format. Somebody else should add the code to take care of the authority links for UNIMARC or NORMARC records. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links also get imported
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz Patch Status|Needs Signoff |Failed QA --- Comment #6 from Chris Cormack 2011-12-31 06:58:02 UTC --- Hmm it looks to me like this only does MARC21, and it will try to do it for UNIMARC and NORMARC probably making a mess of the record. I think it needs to check the syspref for MARC Flavour and do the right thing for each flavour. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links also get imported
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 Owen Leonard changed: What|Removed |Added Version|rel_3_2 |master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links also get imported
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 --- Comment #5 from Frédérick Capovilla 2011-12-23 15:35:19 UTC --- Patch sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links also get imported
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 Frédérick Capovilla changed: What|Removed |Added Patch Status|Does not apply |Needs Signoff Change sponsored?|--- |Sponsored Severity|normal |major -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links also get imported
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 --- Comment #4 from Frédérick Capovilla 2011-12-23 15:34:08 UTC --- Created attachment 6929 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6929 Corrected patch, ported to Koha 3.6 Here is a corrected version of this patch. Empty fields should now be deleted. The patch was also ported to Koha 3.6 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links also get imported
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 Frère Sébastien Marie changed: What|Removed |Added CC||semarie-k...@latrappe.fr -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links also get imported
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 Frédérick Capovilla changed: What|Removed |Added Attachment #4892|0 |1 is obsolete|| --- Comment #3 from Frédérick Capovilla 2011-10-13 19:01:41 UTC --- Comment on attachment 4892 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4892 Remove Koha-specific fields from records imported via Z39.50 A bug was found in this patch : If a field contains only one subfield and this subfield is $9, the $9 gets deleted, but the field isn't deleted. This can cause the record to become invalid MARC (empty field). Patch marked as obsolete. Keeping the bug open. A new, corrected version of this patch can be sent when it is adapted for Koha version 3.6 . -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links also get imported
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 M. de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Patch Status|Needs Signoff |Does not apply --- Comment #2 from M. de Rooy 2011-09-02 08:45:04 UTC --- GBSD#4 This patch is marked for release 3.2, but 3.2 has reached end-of-life. It fails to apply on current master: error: patch failed: C4/Biblio.pm:2490 error: C4/Biblio.pm: patch does not apply Changing status. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links also get imported
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 Frédérick Capovilla changed: What|Removed |Added Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links also get imported
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 Frédérick Capovilla changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|gmcha...@gmail.com |fcapovi...@live.ca --- Comment #1 from Frédérick Capovilla 2011-08-08 15:54:56 UTC --- Created attachment 4892 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4892 Remove Koha-specific fields from records imported via Z39.50 Patch attached that removes the content of subfield 9 for all authority headings in biblios imported from a Z39.50 server. This patch is an improvement of Patch 4102 from Bug 5684. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
