[Koha-bugs] [Bug 6699] Add not-empty check for warnings from load_sql in Installer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6699 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6699] Add not-empty check for warnings from load_sql in Installer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6699 --- Comment #5 from M. de Rooy m.de.r...@rijksmuseum.nl 2011-12-03 11:58:44 UTC --- (In reply to comment #4) patch pushed, with a small follow-up: the fix was hidding the error message, but, if there were an SQL error, the error would hare reappeared, as warn $bla does not work Thanks for pushing. No problem with the follow up too. I was only curious if warn $error would not work. So I tested this: my $err='a'; warn $err; warn $err; With the following result in the logfile: [Sat Dec 03 12:38:41 2011] [error] [client 82.173.53.17] [Sat Dec 3 12:38:41 2011] opac-main.pl: a at /usr/share/koha/testclone/opac/opac-main.pl line 31. [Sat Dec 03 12:38:41 2011] [error] [client 82.173.53.17] [Sat Dec 3 12:38:41 2011] opac-main.pl: a at /usr/share/koha/testclone/opac/opac-main.pl line 31. So I am inclined to think that the followup was not needed, since there is also a check on $error in the if-condition. But it does not hurt either! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6699] Add not-empty check for warnings from load_sql in Installer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6699 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #4936|0 |1 is obsolete|| -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6699] Add not-empty check for warnings from load_sql in Installer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6699 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added CC||paul.poul...@biblibre.com Version|master |rel_3_6 Patch Status|Passed QA |Patch Pushed --- Comment #4 from Paul Poulain paul.poul...@biblibre.com 2011-12-03 06:45:27 UTC --- patch pushed, with a small follow-up: the fix was hidding the error message, but, if there were an SQL error, the error would hare reappeared, as warn $bla does not work -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6699] Add not-empty check for warnings from load_sql in Installer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6699 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m Patch Status|Signed Off |Passed QA --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com 2011-12-01 09:44:25 UTC --- Simple test for display an error Marking as Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6699] Add not-empty check for warnings from load_sql in Installer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6699 --- Comment #2 from Julian Maurice julian.maur...@biblibre.com 2011-11-04 10:32:49 UTC --- Created attachment 6194 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6194 Signed off patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6699] Add not-empty check for warnings from load_sql in Installer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6699 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added CC||julian.maur...@biblibre.com Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6699] Add not-empty check for warnings from load_sql in Installer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6699 --- Comment #1 from M. de Rooy m.de.r...@rijksmuseum.nl 2011-08-10 13:39:17 UTC --- Created attachment 4936 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4936 Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6699] Add not-empty check for warnings from load_sql in Installer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6699 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/