[Koha-bugs] [Bug 6955] Toolbar on reading history broken

2011-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6955

Paul Poulain  changed:

   What|Removed |Added

   Patch Status|Passed QA   |Patch Pushed

--- Comment #6 from Paul Poulain  2011-11-04 
09:33:46 UTC ---
patch pushed, please test

(made a small mistake when pushing : don't search for a new/bug_6955 branch, it
was one of my 1st push)

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6955] Toolbar on reading history broken

2011-10-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6955

Ian Walls  changed:

   What|Removed |Added

 CC||ian.walls@bywatersolutions.
   ||com

--- Comment #5 from Ian Walls  2011-10-12 
21:09:58 UTC ---
Template only change, wrapping a conditional around dependent code.  Introduces
new strings, so it may need to wait until 3.6.1, but as for now, it's Passed
QA.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6955] Toolbar on reading history broken

2011-10-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6955

Paul Poulain  changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com
   Patch Status|Signed Off  |Passed QA
   Severity|major   |minor

--- Comment #4 from Paul Poulain  2011-10-12 
12:10:32 UTC ---
QA comment
  * Minor problem, not major
  * works as expected, good description, small patch
passed QA

Note for 3.6 RM : this patch adds a string. We've string freezed, it's up to
you to decide wether to apply the patch or not : the problem is minor, but it's
a bug, definetly

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6955] Toolbar on reading history broken

2011-10-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6955

Paul Poulain  changed:

   What|Removed |Added

   Attachment #5757|0   |1
is obsolete||

--- Comment #3 from Paul Poulain  2011-10-12 
12:08:50 UTC ---
Created attachment 5849
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5849
Fix for Bug 6955, Toolbar on reading history broken

Table sorter script causes error if there is no  to sort.
JS errors cause the YUI toolbar js to abort, causing the problem
observed. When there are no results the whole table should be
omitted and a message displayed in its place.

Signed-off-by: Katrin Fischer 
To test:
- check toolbar on top of patron reading history with no entries
- check toolbar on top of patron reading history after a few checkouts

Signed-off-by: Katrin Fischer 
Signed-off-by: Paul Poulain 

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6955] Toolbar on reading history broken

2011-10-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6955

Katrin Fischer  changed:

   What|Removed |Added

   Patch Status|Needs Signoff   |Signed Off

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6955] Toolbar on reading history broken

2011-10-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6955

Katrin Fischer  changed:

   What|Removed |Added

   Attachment #5676|0   |1
is obsolete||

--- Comment #2 from Katrin Fischer  2011-10-07 
04:35:26 UTC ---
Created attachment 5757
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5757
[SIGNED-OFF] Fix for Bug 6955, Toolbar on reading history broken

Table sorter script causes error if there is no  to sort.
JS errors cause the YUI toolbar js to abort, causing the problem
observed. When there are no results the whole table should be
omitted and a message displayed in its place.

Signed-off-by: Katrin Fischer 
To test:
- check toolbar on top of patron reading history with no entries
- check toolbar on top of patron reading history after a few checkouts

Signed-off-by: Katrin Fischer 

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6955] Toolbar on reading history broken

2011-10-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6955

Owen Leonard  changed:

   What|Removed |Added

   Priority|P5  |PATCH-Sent
 Status|NEW |ASSIGNED
   Patch Status|--- |Needs Signoff

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6955] Toolbar on reading history broken

2011-10-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6955

--- Comment #1 from Owen Leonard  2011-10-03 13:33:34 UTC 
---
Created attachment 5676
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5676
Proposed fix

Table sorter script causes error if there is no  to sort.
JS errors cause the YUI toolbar js to abort, causing the problem
observed. When there are no results the whole table should be
omitted and a message displayed in its place.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/