[Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong

2013-10-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019

Sophie MEYNIEUX sophie.meyni...@biblibre.com changed:

   What|Removed |Added

 CC||sophie.meyni...@biblibre.co
   ||m

--- Comment #22 from Sophie MEYNIEUX sophie.meyni...@biblibre.com ---
Would it be possible to have it in 3.10.x ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong

2013-10-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019

--- Comment #23 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22305
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22305action=edit
Bug 7019: [3.10.x] Circulation History Sort Order Wrong (in datatable)

The return date column sort is not using the date sort algorithm because it
is
confused by the combination of date data and text data (Checked out).

This patch adds the use of datatable title-string sort type.
With that, the date in ISO format are used for sorting and because letters are
before numbers, Checked out rows are more recent than any date.

Test plan :
- set dateformat syspref to dd/mm/
- Go to members/readingrec.pl for a borrower having a old issues and
checked out issues
= Check that sort of Return date is correct.
For example :
With patch :
  20/01/2011
  06/03/2011
  20/03/2011
  Checked Out
Without patch :
  06/03/2011
  20/01/2011
  20/03/2011
  Checked Out
- Test also with dateformat syspref mm/dd/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong

2013-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Depends on||5766

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong

2013-08-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #21 from Tomás Cohen Arazi tomasco...@gmail.com ---
This patch has been pushed to 3.12.x, will be in 3.12.4.

Thanks Fridolyn!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong

2013-07-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #19707|0   |1
is obsolete||

--- Comment #19 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 19723
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19723action=edit
Bug 7019: Circulation History Sort Order Wrong (in datatable)

The return date column sort is not using the date sort algorithm because it
is
confused by the combination of date data and text data (Checked out).

This patch adds the use of datatable title-string sort type.
With that, the date in ISO format are used for sorting and because letters are
before numbers, Checked out rows are more recent than any date.

Test plan :
- set dateformat syspref to dd/mm/
- Go to members/readingrec.pl for a borrower having a old issues and
checked out issues
= Check that sort of Return date is correct.
For example :
With patch :
  20/01/2011
  06/03/2011
  20/03/2011
  Checked Out
Without patch :
  06/03/2011
  20/01/2011
  20/03/2011
  Checked Out
- Test also with dateformat syspref mm/dd/

Signed-off-by: Srdjan srd...@catalyst.net.nz
Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong

2013-07-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #18 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA comment:
The last patch works great.
Marked as Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong

2013-07-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #20 from Galen Charlton gmcha...@gmail.com ---
Pushed to master.  Thanks, Fridolyn!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong

2013-07-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019

Srdjan Jankovic srd...@catalyst.net.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong

2013-07-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019

Srdjan Jankovic srd...@catalyst.net.nz changed:

   What|Removed |Added

  Attachment #19549|0   |1
is obsolete||

--- Comment #17 from Srdjan Jankovic srd...@catalyst.net.nz ---
Created attachment 19707
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19707action=edit
[SIGNED-OFF] Bug 7019: Circulation History Sort Order Wrong (in datatable)

The return date column sort is not using the date sort algorithm because it
is
confused by the combination of date data and text data (Checked out).

This patch adds the use of datatable title-string sort type.
With that, the date in ISO format are used for sorting and because letters are
before numbers, Checked out rows are more recent than any date.

Test plan :
- set dateformat syspref to dd/mm/
- Go to members/readingrec.pl for a borrower having a old issues and
checked out issues
= Check that sort of Return date is correct.
For example :
With patch :
  20/01/2011
  06/03/2011
  20/03/2011
  Checked Out
Without patch :
  06/03/2011
  20/01/2011
  20/03/2011
  Checked Out
- Test also with dateformat syspref mm/dd/

Signed-off-by: Srdjan srd...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong

2013-07-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

  Attachment #15710|0   |1
is obsolete||

--- Comment #16 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Created attachment 19549
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19549action=edit
Proposed patch (revisited)

Here is the patch with title argument.
See commit message for more details.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong

2013-07-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong

2013-06-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019

Derryn derr...@gmail.com changed:

   What|Removed |Added

 CC||derr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com ---
Fridolyn,

I reproduce the issue and your patch fixes something, but it is not perfect. I
got:
Checked Out
20/04/2012
13/04/2012
19/03/2013
Checked Out
12/09/2012
Checked Out
12/09/2012
12/09/2012

In fact when the sort plugin find something else than a date, it get all mixed
up.


But try (members/readingrec.tt ~l.83):

-[% issue.returndate | $KohaDates %]
+span title=[% issue.returndate %][% issue.returndate |
$KohaDates %]/span

It works for me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong

2013-06-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019

--- Comment #14 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
 Comment 13
Had you a checked out row in circulation history ?
It is this text Checked Out which, even with dt_add_type_uk_date stuff,
prevents the library from sorting by date because column does not contain only
dates.
You should see that Date due column sorting is always fine whereas Return
date not when having some Checked Out.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong

2013-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong

2013-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #15589|0   |1
is obsolete||

--- Comment #12 from Owen Leonard oleon...@myacpl.org ---
Created attachment 15710
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15710action=edit
[SIGNED-OFF] Bug 7019: Circulation History Sort Order Wrong (in datatable)

The return column sort is using the right sort algorithm because it was
confused by the combination of date data and text data (Checked out).

This patch adds an explicit instruction to sort by date for UK and US
formats.

Test plan :
- set dateformat syspref to dd/mm/
- Go to members/readingrec.pl for a borrower having a old issues and
checked out issues
= Check that sort of Return date is correct.
For example :
With patch :
  20/01/2011
  06/03/2011
  20/03/2011
  Checked Out
Without patch :
  06/03/2011
  20/01/2011
  20/03/2011
  Checked Out
- Test also with dateformat syspref mm/dd/

Signed-off-by: Owen Leonard oleon...@myacpl.org

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong

2013-02-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

   Attachment #5891|0   |1
is obsolete||
 Status|ASSIGNED|Needs Signoff
   Assignee|oleon...@myacpl.org |fridolyn.som...@biblibre.co
   ||m

--- Comment #11 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Created attachment 15589
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15589action=edit
Proposed patch (3.11)

Proposed patch for actual master (3.11.00.018).
Bug is the same but technically the table uses now JQuery datatables.
Ths patch forces date format for US and UK formats.
See commit message

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong

2013-02-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 Status|Pushed to Master|ASSIGNED

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019

--- Comment #8 from Nicole C. Engard neng...@gmail.com ---
Still an issue in 3.8.8.

Nicole

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019

--- Comment #9 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
(In reply to comment #7)
 Very odd, datatables.js method dt_add_type_uk_date does not use UK format
 MM/DD/ but metric format DD/MM/.

My coworkers explained me : UK = metric format (for dates only), it is US
format who is MM/DD/.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019

--- Comment #10 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Datatables looks for datas to choose the default sort algorithm.
When looking at Checked Out and dates, it will use alphabetical sort algorithm.
Date format must be forced for metric ('uk_date') AND us format ('date').

Note that ISO format sorted by alphabetical order is correct.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong

2012-11-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019

JA puss...@gmail.com changed:

   What|Removed |Added

 CC||puss...@gmail.com

--- Comment #6 from JA puss...@gmail.com ---
Using Koha 3.08.03 with Systempref dateformat= dd/mm/
the date are not well sorted. If I change it to /mm/dd it's OK.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong

2011-10-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

   Attachment #5877|0   |1
is obsolete||

--- Comment #3 from Nicole C. Engard neng...@gmail.com 2011-10-14 13:40:36 
UTC ---
Created attachment 5891
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5891
[SIGNED-OFF] Fix for Bug 7019 - Circulation History Sort Order Wrong

The return column sort was not using the right sort algorithm
because it was confused by the combination of date data and
text data (Checked out). I've added an explicit instruction
to sort by date. The downside to this change is that checked
out items are sorted with the oldest checkouts rather than
the newest:

Checked Out
Checked Out
10/14/1988
07/14/2005

Not perfect, but an improvement over completely incorrect
sorting. This patch also adds the necessary check for system
dateformat preference to properly sort metric dates.

Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong

2011-10-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

   Patch Status|Needs Signoff   |Signed Off

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong

2011-10-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019

Ian Walls ian.wa...@bywatersolutions.com changed:

   What|Removed |Added

 CC||ian.walls@bywatersolutions.
   ||com
   Patch Status|Signed Off  |Passed QA

--- Comment #4 from Ian Walls ian.wa...@bywatersolutions.com 2011-10-14 
13:46:47 UTC ---
Template-only changes, string-free, improves sorting.  While not perfect, it's
MUCH better than what we had, so marking as Passed QA.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong

2011-10-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
   Patch Status|Passed QA   |Patch Pushed

--- Comment #5 from Chris Cormack ch...@bigballofwax.co.nz 2011-10-15 
01:20:28 UTC ---
Pushed, please test

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong

2011-10-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019

--- Comment #1 from Nicole C. Engard neng...@gmail.com 2011-10-13 13:09:38 
UTC ---
Created attachment 5874
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5874
screenshot

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong

2011-10-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|kyle.m.h...@gmail.com   |oleon...@myacpl.org

--- Comment #2 from Owen Leonard oleon...@myacpl.org 2011-10-13 16:09:16 UTC 
---
Created attachment 5877
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5877
Proposed fix

The return column sort was not using the right sort algorithm
because it was confused by the combination of date data and
text data (Checked out). I've added an explicit instruction
to sort by date. The downside to this change is that checked
out items are sorted with the oldest checkouts rather than
the newest:

Checked Out
Checked Out
10/14/1988
07/14/2005

Not perfect, but an improvement over completely incorrect
sorting. This patch also adds the necessary check for system
dateformat preference to properly sort metric dates.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong

2011-10-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

   Priority|P5  |PATCH-Sent
   Patch Status|--- |Needs Signoff

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/