[Koha-bugs] [Bug 7090] Add "AllowItemsOnHandCheckout" syspref to allow issue to the patron regardless of hold status
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7090 Paul Poulain changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #9 from Paul Poulain 2012-02-10 18:48:00 UTC --- Well, found a QA comment to do = there was a tab instead of 4 spaces in the updatedatabase. I've fixed it before pushing, as there's the DBrev number to push. Srdjan, about your comment: > Sorry, I'm not familiar with the procedure, do you need me to rebase it now? When a patch does not apply, the author of the patch is supposed to deal with the rebase. There is an exception to this rule: a conflict on updatedatabase can usually be solved easily by the sign-offer, the QAer or the RM, as it's a very common problem. that's why i've fixed it (and it was trivial : your syspref was added at the end of the syspref file, and another patch already had added another line. Just tell git that both lines must be added (vi sysprefs.sql, remove <<<, and >>> lines, git add sysprefs.sql;git am --resolved, and you're done) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7090] Add "AllowItemsOnHandCheckout" syspref to allow issue to the patron regardless of hold status
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7090
Paul Poulain changed:
What|Removed |Added
Priority|PATCH-Sent (DO NOT USE) |P3
Status|Signed Off |Passed QA
CC||paul.poul...@biblibre.com
Version|master |rel_3_8
--- Comment #8 from Paul Poulain 2012-02-10
18:34:13 UTC ---
QA comment
* this patch seems quite large, but in fact, it's mostly reindenting
consequence of a new if () { }
* add consistently a new syspref
passed QA
--
Configure bugmail:
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7090] Add "AllowItemsOnHandCheckout" syspref to allow issue to the patron regardless of hold status
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7090 --- Comment #7 from Srdjan Jankovic 2012-02-01 22:57:39 UTC --- Sorry, I'm not familiar with the procedure, do you need me to rebase it now? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7090] Add "AllowItemsOnHandCheckout" syspref to allow issue to the patron regardless of hold status
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7090 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7090] Add "AllowItemsOnHandCheckout" syspref to allow issue to the patron regardless of hold status
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7090 Liz Rea changed: What|Removed |Added Attachment #7177|0 |1 is obsolete|| --- Comment #6 from Liz Rea 2012-02-01 17:05:41 UTC --- Created attachment 7413 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7413 [Signed Off] bug_7090: AllowItemsOnHandCheckout syspref Observe AllowItemsOnHandCheckout syspref when using SIP self checkout Signed-off-by: Liz Rea To test: * place an item on hold for patron A * attempt to circulate that item to patron B (via SIP/selfcheck) syspref off: item should not circulate to patron B Syspref On: item should circulate to patron B Both conditions passed in our testing. Also verified that normal staff client behavior regarding this situation was preserved. It was. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7090] Add "AllowItemsOnHandCheckout" syspref to allow issue to the patron regardless of hold status
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7090 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com --- Comment #5 from Liz Rea 2012-02-01 16:18:34 UTC --- I plan to sign off on this today - it will need to be rebased due to syspref/updatedatabase changes - but otherwise works a treat. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7090] Add "AllowItemsOnHandCheckout" syspref to allow issue to the patron regardless of hold status
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7090 Ian Walls changed: What|Removed |Added Attachment #6900|0 |1 is obsolete|| --- Comment #4 from Ian Walls 2012-01-16 20:10:26 UTC --- Created attachment 7177 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7177 Rebased Patch (2012-01-16) Rebased on current master from 2012-01-16, 20:00 UTC -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7090] Add "AllowItemsOnHandCheckout" syspref to allow issue to the patron regardless of hold status
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7090 Srdjan Jankovic changed: What|Removed |Added Attachment #6069|0 |1 is obsolete|| --- Comment #3 from Srdjan Jankovic 2011-12-21 08:31:52 UTC --- Created attachment 6900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6900 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7090] Add "AllowItemsOnHandCheckout" syspref to allow issue to the patron regardless of hold status
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7090 Srdjan Jankovic changed: What|Removed |Added Patch Status|Does not apply |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7090] Add "AllowItemsOnHandCheckout" syspref to allow issue to the patron regardless of hold status
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7090 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Patch Status|Needs Signoff |Does not apply --- Comment #2 from Katrin Fischer 2011-12-21 06:17:57 UTC --- Patch doesn't apply on current master: Observe AllowItemsOnHandCheckout syspref when using self checkout -- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: bug_7090: AllowItemsOnHoldCheckout syspref Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Circulation.pm CONFLICT (content): Merge conflict in C4/Circulation.pm Auto-merging installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging opac/sco/sco-main.pl Failed to merge in the changes. Patch failed at 0001 bug_7090: AllowItemsOnHoldCheckout syspref When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7090] Add "AllowItemsOnHandCheckout" syspref to allow issue to the patron regardless of hold status
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7090 Srdjan Jankovic changed: What|Removed |Added Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7090] Add "AllowItemsOnHandCheckout" syspref to allow issue to the patron regardless of hold status
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7090 Srdjan Jankovic changed: What|Removed |Added AssignedTo|ian.walls@bywatersolutions. |srd...@catalyst.net.nz |com | --- Comment #1 from Srdjan Jankovic 2011-10-27 05:11:39 UTC --- Created attachment 6069 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6069 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7090] Add "AllowItemsOnHandCheckout" syspref to allow issue to the patron regardless of hold status
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7090 Srdjan Jankovic changed: What|Removed |Added Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
