[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Paul Poulain changed: What|Removed |Added Status|In Discussion |RESOLVED Resolution|--- |FIXED --- Comment #32 from Paul Poulain --- follow-up in bug 9923 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Paul Poulain changed: What|Removed |Added Depends on||9923 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 --- Comment #31 from Christophe Croullebois --- Ok Jared, I have created bz 9923 in "passed QA" Thx -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Jared Camins-Esakov changed: What|Removed |Added Status|Passed QA |In Discussion --- Comment #30 from Jared Camins-Esakov --- Setting to In Discussion for review and probable patch movement by the author. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 --- Comment #29 from Jared Camins-Esakov --- What is this patch? If this is fixing a bug caused by 7129 it should be moved to a new bug, which can be set straight to "Passed QA." -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Paul Poulain changed: What|Removed |Added Status|Signed Off |Passed QA Assignee|ale...@vujicic.com |christophe.croullebois@bibl ||ibre.com --- Comment #28 from Paul Poulain --- QA comment: * passes koha-qa.pl * small patch, I made some changes in the comment, for a better readability passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Paul Poulain changed: What|Removed |Added Attachment #15990|0 |1 is obsolete|| --- Comment #27 from Paul Poulain --- Created attachment 16300 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16300&action=edit (MT #11060) correction of a bug due to bz 7129 See comments in the patch Signed-off-by: Mathieu Saby Signed-off-by: Paul Poulain -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Mirko Tietgen changed: What|Removed |Added CC|mi...@abunchofthings.net| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Chris Cormack changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Chris Cormack changed: What|Removed |Added Attachment #13735|0 |1 is obsolete|| -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Chris Cormack changed: What|Removed |Added Attachment #6134|0 |1 is obsolete|| -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Chris Cormack changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Chris Cormack changed: What|Removed |Added Status|Pushed to Stable|ASSIGNED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 mathieu saby changed: What|Removed |Added Attachment #15337|0 |1 is obsolete|| --- Comment #26 from mathieu saby --- Created attachment 15990 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15990&action=edit [SIGNED-OFF] transitional patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 --- Comment #25 from mathieu saby --- Your corrective patch works : - before your patch : If unitprice = 0 in database, in receipt page, the value of "Actual cost" is 0 - before your patch : If unitprice = 0 in database, in receipt page, the value of "Actual cost" is ecost I sign it off. M. Saby -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 mathieu saby changed: What|Removed |Added CC||mathieu.saby@univ-rennes2.f ||r --- Comment #24 from mathieu saby --- Hello We have just discovered the problem, and I agree with Christophe Croullebois, it must be solved. I will test transitional patch tomorrow. M. Saby Rennes 2 university -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 --- Comment #23 from Christophe Croullebois --- Created attachment 15337 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15337&action=edit transitional patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129
Christophe Croullebois changed:
What|Removed |Added
CC||christophe.croullebois@bibl
||ibre.com
--- Comment #22 from Christophe Croullebois
---
We must revert this patch, it introduces a bug if the unitprice is 0..
Instead of showing in this case the 'ecost' if there is not 'unitprice', it
shows 0.00 and the 'Actual cost' must be manually entered.
The line :
if ( @$results[0]->{'unitprice'} == 0 ) {
@$results[0]->{'unitprice'} = '';
was wrote in this perspective.
But sprintf ( "%.2f", with '' or 0 or any string will return 0.00
and then, in the .tt 'unitprice' exists so we have the bad result.
I have made a quick patch to just resolve this problem, but I think that the
Colin's idea is nice, I will create a new patch to work in this way in the .tt
page.
I join the quick patch, but I think it would be better to make one with the
Colin's idea.
I am waiting for advises.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Chris Cormack changed: What|Removed |Added Status|Passed QA |Pushed to Stable --- Comment #21 from Chris Cormack --- Pushed to 3.8.x will be in 3.8.8 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Chris Cormack changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 --- Comment #20 from Chris Cormack --- Yeah a custom filter plugin would be good, since quite a few currencies format differently to 2dp, the plugin could do the right thing following the syspref, like KohaDates does. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 --- Comment #19 from Katrin Fischer --- I think it would be awesome if we had a plugin doing that, because it would allow us to extend the formatting options for different currencies later on. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129
--- Comment #18 from Owen Leonard ---
There are many existing examples in master of doing it this way:
[% total | format('%.2f') %]
...which is a little more verbose if you have a lot of instances. It might be
something we should have a guideline for.
Since the patch I just submitted was a reworking for 3.8.x, I didn't want to
re-do it in a different way. I can resubmit if the TT version is preferable.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129
Colin Campbell changed:
What|Removed |Added
CC||colin.campbell@ptfs-europe.
||com
Patch complexity|--- |Small patch
--- Comment #17 from Colin Campbell ---
Heres an approach using TT to format money amounts. At the top of the template
declare
[% USE money=format('%.2f') -%]
then in the body of the template when you want to display e.g. price use
[% money(price) %]
It takes the display logic out of the the cgi scripts ( a good thing) and
you've got an easier to maintain template
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Owen Leonard changed: What|Removed |Added Attachment #10300|0 |1 is obsolete|| --- Comment #16 from Owen Leonard --- Created attachment 13735 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13735&action=edit Bug 7129 [3.8.x] actual cost showing too many zeros Reimplemented for 3.8.x: Added a sprintf to format the actual cost -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Owen Leonard changed: What|Removed |Added Status|Pushed to Master|ASSIGNED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #15 from Chris Cormack --- Does not apply for 3.8.x please reformat for 3.8.x -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Paul Poulain changed: What|Removed |Added Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #14 from Paul Poulain --- Patch pushed, but, in the long term, I'd love to see a "currency display" T::T plugin (I would be surprised if it does not exist already, as it's a very common need) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Ian Walls changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #13 from Ian Walls --- Same work that passed QA the first time, just updated to reflect new variable names. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Ian Walls changed: What|Removed |Added Attachment #10216|0 |1 is obsolete|| -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 --- Comment #12 from Ian Walls --- Created attachment 10300 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10300&action=edit [PASSED QA] Bug 7129: Added a sprintf to format the actual cost. Signed-off-by: Katrin Fischer Rebased to current master, please test. Signed-off-by: Kyle M Hall Signed-off-by: Ian Walls QA note: changed call to use $order instead of @$results[0], for consistency with surrounding variables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Kyle M Hall changed: What|Removed |Added Attachment #10030|0 |1 is obsolete|| --- Comment #11 from Kyle M Hall --- Created attachment 10216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10216&action=edit [SIGNED-OFF] Bug 7129: Added a sprintf to format the actual cost. Signed-off-by: Katrin Fischer Rebased to current master, please test. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Mirko <5...@gmx.de> changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #10 from Mirko <5...@gmx.de> --- My bad, it works now and fixes the problem, thanks Katrin. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 --- Comment #9 from Katrin Fischer --- Hi Mirko, try clicking the "Add link" at the end of the item form. Quantity will go up if you do that. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Mirko <5...@gmx.de> changed: What|Removed |Added CC||5...@gmx.de --- Comment #8 from Mirko <5...@gmx.de> --- Tried to test this patch in a sandbox but could not put any items to the basket because a mandatory field was set to readonly and could not be edited. Should have nothing to do with this patch but can't signoff because can't test it. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Katrin Fischer changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Katrin Fischer changed: What|Removed |Added Attachment #7305|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 10030 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10030&action=edit Bug 7129: Added a sprintf to format the actual cost. Signed-off-by: Katrin Fischer Rebased to current master, please test. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Paul Poulain changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Paul Poulain changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Paul Poulain changed: What|Removed |Added Status|Pushed to Master|ASSIGNED --- Comment #6 from Paul Poulain --- oups, mistake in the status... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Paul Poulain changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #5 from Paul Poulain --- This patch does not apply anymore (since bug 7175) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Jared Camins-Esakov changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Jared Camins-Esakov changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Jared Camins-Esakov changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Jared Camins-Esakov changed: What|Removed |Added Status|Pushed to Master|ASSIGNED Version|rel_3_6 |master --- Comment #4 from Jared Camins-Esakov --- Resetting to Passed QA (by way of ASSIGNED, Needs Signoff, and Signed Off), since this patch does not appear to have been pushed. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Paul Poulain changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||paul.poul...@biblibre.com --- Comment #3 from Paul Poulain 2012-02-10 14:40:02 UTC --- patch pushed, but this kind of display is a good candidate for : http://wiki.koha-community.org/wiki/Generalise_the_use_Template_Toolkit_plugins ! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Ian Walls changed: What|Removed |Added Status|Signed Off |Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Ian Walls changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||koha.sek...@gmail.com --- Comment #2 from Ian Walls 2012-02-07 20:22:16 UTC --- Simple change to add string formatting to numeric values. Marking Signed off and Passed QA in one go. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7129] actual cost showing too many zeros
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Aleksa changed: What|Removed |Added Status|NEW |Needs Signoff AssignedTo|henridam...@koha-fr.org |ale...@catalyst.net.nz --- Comment #1 from Aleksa 2012-01-24 00:38:49 UTC --- Created attachment 7305 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7305 Added a sprintf to format the actual cost. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
