[Koha-bugs] [Bug 7144] Floating collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Blocks||14422 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7144] Floating collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144 David Cook dc...@prosentient.com.au changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #32 from David Cook dc...@prosentient.com.au --- Can anyone say what is actually going on with this bug? Was anything ever pushed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7144] Floating collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #33 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Yes, check the possible return settings on the circulation conditions page :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7144] Floating collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144 --- Comment #34 from David Cook dc...@prosentient.com.au --- (In reply to Katrin Fischer from comment #33) Yes, check the possible return settings on the circulation conditions page :) What do you mean by the circulation conditions page, Katrin? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7144] Floating collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144 --- Comment #35 from David Cook dc...@prosentient.com.au --- (In reply to David Cook from comment #34) (In reply to Katrin Fischer from comment #33) Yes, check the possible return settings on the circulation conditions page :) What do you mean by the circulation conditions page, Katrin? Ahh...the circulation and fines rules page. I'm seeing the Item floats return policies now. Interesting... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7144] Floating collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Blocks||7830 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7144] Floating collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144 --- Comment #29 from Srdjan Jankovic srd...@catalyst.net.nz --- (In reply to comment #28) Finally... I could test and make this patch work ! Patch pushed, but 2 questions: * the string for items returned by patrons is usually check in in Koha (see mainpage.pl for example). Here, it's return. Should it be fixed for consistency or is it an english subtilty i'm missing ? Not being a native speaker I'm subtlety resistant myself. My train of thoughts was: - Check in branch is where an item is *returned by the borrower* (checked-in); Return branch is where the item is supposed to be stored, ie *returned by the receiving librarian* - The original syspref was named HomeOrHoldingBranchReturn. I could have named it BranchReturn, but ReturnBranch somehow appealed more. * I'm not sure that the all libraries rule work. I could make the feature working by entering item float for a given library. Maybe I made something wrong, maybe it's how it's supposed to work, explanation welcomed ;-) I'm not sure what particular rule/operation you are referring to. Can you please tell me what to do to duplicate the issue. Also, I've found a small bug there, will create a follow up -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7144] Floating collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144 --- Comment #30 from Srdjan Jankovic srd...@catalyst.net.nz --- Ooops, sorry, this moved on quite a bit. Please disregard my input. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7144] Floating collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added CC||kyle.m.h...@gmail.com --- Comment #26 from Kyle M Hall kyle.m.h...@gmail.com --- Maybe I'm a bit late in asking this, but why use itemtype for the floating collection rules instead of collection code? It seems odd to require a separate item type for floating items that are really Books, Audiobooks, etc. For example, at the Crawford County Federated Library System, there are a number of 'rotating collections'. The books and audiobooks move from from one library to the next each month. I have written a rotating collections feature for them that lets the librarian's create 'collections' of items, and set what branch the collection is currently at. Koha currently tracks who owns and item, and where an item is at, but not where an item should be. For example, Collection1 is at LibraryA, and is now to be moved to LibraryB. It my system, a librarian simply goes into the rotating collections system and changes the current library for Collection1 from LibraryA to LibraryB. LibraryA then packs up all the items that are currently on the shelf and ships them to LibraryB. When any books in Collection1 that are currently circulating are checked in, the librarian recieves a notice that the item is part of a rotating collection and should be transferred to LibraryB immediately. Could this feature be used to replicate this scenario? If not, I would be more than happy to open a bug and submit my rotating collections code. I suppose rotating collections are different than floating collections in how they behave. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7144] Floating collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144 --- Comment #27 from Ian Walls koha.sek...@gmail.com --- This code works off of item type because item types are the What parameter in circulation rules (where being branch, and who being patron category). Collection codes to not factor into circulation rules, and I don't believe they should. If you need materials to have a different set of behaviours, assign them different item types. If that set of types isn't what you'd want your users to search on, that's okay, Collection Code can be used for searching instead. Rotating Collections wouldn't be well covered by this code; as you say, we need to track not only who owns a material and where it currently is, but where it should be. If you abstract this a little further, we could have temporary item information of any kind. This would support Course Reserves, in that materials could have their item types and shelving locations changed for the term, then reverted back. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7144] Floating collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144 Melia Meggs me...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Passed QA CC||me...@bywatersolutions.com --- Comment #25 from Melia Meggs me...@bywatersolutions.com --- Just switching status back to Passed QA based on Paul's note from 2/27. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7144] Floating collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Attachment #7899|0 |1 is obsolete|| --- Comment #24 from Kyle M Hall kyle.m.h...@gmail.com --- Created attachment 8056 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8056action=edit [Signed Off] Bug 7144 follow-up cleaning for HTML4 coding guideline http://wiki.koha-community.org/wiki/Coding_Guidelines#Upper_and_Lower_cases_in_strings Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7144] Floating collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #22 from Paul Poulain paul.poul...@biblibre.com 2012-02-27 13:17:23 UTC --- QA comment (continued) * the [HTML4] coding guideline about upercase was not respected, attaching a follow-up fixing that, please counter-signoff welcomed * I think the smart-rules documentation need a little update: In the last section, it's written: Holds policy by item type for Branch 1 For this library, you can edit rules for given itemtypes, regardless of the patron's category. Currently, this means hold policies. The various policies have the following effects: From any library: Patrons from any library may put this item on hold. (default if none is defined) From home library: Only patrons from the item's home library may put this book on hold. No holds allowed: No patron may put this book on hold. Note that if the system preference AllowHoldPolicyOverride is enabled, these policies can be overridden by your circulation staff. Also, these policies are based on the patron's home library, not the library where the hold is being placed.. There's not reference to return policy. It's worth adding some documentation for it. And, more specifically, how it interfere with the Default checkout, checkin and hold policy for Branch 1 which one is used first if both are specified ? Note that in my follow-up, there's also a small addition to the documentation of the default rules section (the 2nd one, just after the main rules) -h3Default checkout and hold policy for [% IF ( humanbranch ) %][% humanbranch %][% ELSE %]all libraries[% END %]/h3 -pYou can set a default maximum number of checkouts and hold policy that will be used if none is defined below for a particular item type or category./p +h3Default checkout, checkin and hold policy for [% IF ( humanbranch ) %][% humanbranch %][% ELSE %]all libraries[% END %]/h3 +pYou can set a default maximum number of checkouts, hold policy and checkin policy that will be used if none is defined below for a particular item type or category./p Please: * signoff my follow-up * add a small follow-up to document the default itemtype checkin policy how it interfere with the default one (switch back to passed QA when it's done) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7144] Floating collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144 --- Comment #23 from Paul Poulain paul.poul...@biblibre.com 2012-02-27 13:17:42 UTC --- Created attachment 7899 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7899 Bug 7144 follow-up cleaning for HTML4 coding guideline http://wiki.koha-community.org/wiki/Coding_Guidelines#Upper_and_Lower_cases_in_strings -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7144] Floating collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144 --- Comment #21 from Ian Walls koha.sek...@gmail.com 2012-02-23 21:33:43 UTC --- Paul, You don't need any special configured branches to use this feature. All it does is move the AutomaticItemReturn system preference to a branch/itemtype level. This allows you to specify whether certain kinds of materials (like DVDs) return to either the homebranch or holdingbranch, or, for cheap paperbacks not worth the transportation costs, if they float (which means remain at the branch at which they were returned). A NULL value in the returnbranch field of the circ rules, or in fact any value that's not homebranch or holdingbranch, will result in the item floating. We hardcode noreturn in the system preferences to be explicit, but if somewhere we to manually edit the data or some error were to creep in, that's what the system would default to. This code interacts with Branch Transfer Limits the exact same way that AutomaticItemReturn did; again, this just moves the logic from a global syspref to a branch/itemtype configurable rule. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7144] Floating collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144 Brendan Gallagher bren...@bywatersolutions.com changed: What|Removed |Added CC||bren...@bywatersolutions.co ||m --- Comment #20 from Brendan Gallagher bren...@bywatersolutions.com 2012-02-23 00:25:52 UTC --- (In reply to comment #19) (In reply to comment #16) Documentation: * floating collection settings need to be added to the help descriptions on the page. You're perfectly right. And I'd like to have more details about how to test this feature. Here is my thought: * I must have a branch called Floating Collection (FC, or anything else) * floating items have homebranch=FC * in circ rules, for branch LIB (my main branch), i'll set: - homebranch = if I want the item to be returned to his home branch - holdingbranch = if I want the item to be returned to his holdingbranch (in case of a book homebranch=BranchA, checked out at= BranchB, checked in at = BranchC) - no return = the book stays where it has been returned Some questions: * what does NULL mean ? in the circ rules ? * which combinations of branch_transfer_limit have you tested ? (was it ON, OFF, which branch transfers are permitted/forbidden ?) I don't change the bug status, I just feel I just need a few more informations. I'm not sure what these questions mean - perhaps Ian can answer these questions. Passing QA is a great sign and the testing has already been completed on production servers - so Paul I know that it should be good and great to pass into master. So I'll ping Ian too see if he can answer these - but I'll tell you it's good :) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7144] Floating collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Priority|PATCH-Sent (DO NOT USE) |P3 CC||paul.poul...@biblibre.com --- Comment #19 from Paul Poulain paul.poul...@biblibre.com 2012-02-20 15:02:45 UTC --- (In reply to comment #16) Documentation: * floating collection settings need to be added to the help descriptions on the page. You're perfectly right. And I'd like to have more details about how to test this feature. Here is my thought: * I must have a branch called Floating Collection (FC, or anything else) * floating items have homebranch=FC * in circ rules, for branch LIB (my main branch), i'll set: - homebranch = if I want the item to be returned to his home branch - holdingbranch = if I want the item to be returned to his holdingbranch (in case of a book homebranch=BranchA, checked out at= BranchB, checked in at = BranchC) - no return = the book stays where it has been returned Some questions: * what does NULL mean ? in the circ rules ? * which combinations of branch_transfer_limit have you tested ? (was it ON, OFF, which branch transfers are permitted/forbidden ?) I don't change the bug status, I just feel I just need a few more informations. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7144] Floating collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #18 from Jonathan Druart jonathan.dru...@biblibre.com 2012-02-17 15:43:27 UTC --- QA comments: Code clean with comments. Note for RM: don't forget to create an entry in the updatedatabase file :-) Marked as passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7144] Floating collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144 Ian Walls koha.sek...@gmail.com changed: What|Removed |Added QAContact|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7144] Floating collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144 Liz Rea wizzy...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7144] Floating collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144 Liz Rea wizzy...@gmail.com changed: What|Removed |Added Attachment #7033|0 |1 is obsolete|| --- Comment #17 from Liz Rea wizzy...@gmail.com 2012-02-09 15:42:49 UTC --- Created attachment 7533 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7533 [Signed Off] Enhancement 7144: Floating Collections (per branch/itemtype) Adds support for Floating Collections (i.e. items that don't automatically return home when checked in at another branch) on a per branchcode/itemtype basis. This patch adds a new column (returnbranch) to the default_circ_rules, default_branch_item_rules, default_branch_circ_rules and branch_item_rules tables, after the 'holdsallowed' column. While this is coded as a varchar(15), the only currently supported values are 'homebranch', 'holdingbranch', 'noreturn' and NULL. On upgrade, the value of HomeOrHoldingBranchReturn is used to populate the global default (which is stored in default_circ_rules.returnbranch). To access this value, use C4::Circulation::GetBranchItemRule. This subroutine is altered to supply an additional key, returnbranch, containing this value (or 'homebranch' as a default). No existing usage of GetBranchItemRule should need to be modified. The use of HomeOrHoldingBranchReturn is removed in AddReturn to instead use this subroutine. This will determine, on a more granular level, where the item should be transferred, after all is said and done. If 'noreturn' is specified, then the material will remain at the branch doing the checking in. Signed-off-by: Liz Rea wizzy...@gmail.com Passes prove t xt t/db_dependent I was able to make this feature work as advertised. As noted above, if you want a floating rule applied across all branches, adding a single default rule won't suffice, you'll need to add the rule to all branches. That issue is not related to the functioning of *this* patch however. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7144] Floating collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144 Liz Rea wizzy...@gmail.com changed: What|Removed |Added CC||wizzy...@gmail.com --- Comment #15 from Liz Rea wizzy...@gmail.com 2012-02-07 16:35:18 UTC --- for those doing testing - this patch uses an atomicupdate - don't forget to run it (like I did. :)) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7144] Floating collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144 --- Comment #16 from Liz Rea wizzy...@gmail.com 2012-02-07 22:31:50 UTC --- Notes: Functionality: * seems to be working, but still testing. Documentation: * floating collection settings need to be added to the help descriptions on the page. * libraries wanting to enforce a floating collection for a specific item type across an entire set of libraries will need to define that rule in all library definitions - fixing that issue is outside the scope of this dev but it will need to be documented. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7144] Floating collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #6482|0 |1 is obsolete|| --- Comment #14 from Paul Poulain paul.poul...@biblibre.com 2012-01-24 09:42:44 UTC --- Comment on attachment 6482 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6482 bug_7144: renamed HomeOrHoldingBranchReturn to returnBranch and added returningbranch option for floating collections Obsoleting chris version : the feature will be more usefull at itemtype level, so we should test work on integrating this one. (PS: and it's a damn usefull feature !) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7144] Floating collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144 Magnus Enger mag...@enger.priv.no changed: What|Removed |Added CC||mag...@enger.priv.no --- Comment #10 from Magnus Enger mag...@enger.priv.no 2012-01-06 11:03:31 UTC --- What's the relationship between these two patches? Should the one from Ian be applied on top of the one from Chris, or are they independent? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7144] Floating collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144 --- Comment #11 from Ian Walls ian.wa...@bywatersolutions.com 2012-01-06 13:53:35 UTC --- Magnus, The two patches are independent, alternate implementations. Chris's works at a global level, while mine works at the branch/itemtype level as well. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7144] Floating collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144 --- Comment #12 from Magnus Enger mag...@enger.priv.no 2012-01-06 14:43:12 UTC --- Sorry for being slow... Are they mutually exclusive (competing solutions for the same problem) or could they co-exist? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7144] Floating collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144 Ian Walls ian.wa...@bywatersolutions.com changed: What|Removed |Added Attachment #6891|0 |1 is obsolete|| --- Comment #9 from Ian Walls ian.wa...@bywatersolutions.com 2012-01-03 20:12:07 UTC --- Created attachment 7033 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7033 Revised Patch Fixes bug with my original patch; was using a hashref in scalar context. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7144] Floating collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144 --- Comment #8 from Ian Walls ian.wa...@bywatersolutions.com 2011-12-20 20:04:23 UTC --- Created attachment 6891 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6891 Enhancement 7144: Floating Collections (per branch/itemtype) Adds support for Floating Collections (i.e. items that don't automatically return home when checked in at another branch) on a per branchcode/itemtype basis. This patch adds a new column (returnbranch) to the default_circ_rules, default_branch_item_rules, default_branch_circ_rules and branch_item_rules tables, after the 'holdsallowed' column. While this is coded as a varchar(15), the only currently supported values are 'homebranch', 'holdingbranch', 'noreturn' and NULL. On upgrade, the value of HomeOrHoldingBranchReturn is used to populate the global default (which is stored in default_circ_rules.returnbranch). To access this value, use C4::Circulation::GetBranchItemRule. This subroutine is altered to supply an additional key, returnbranch, containing this value (or 'homebranch' as a default). No existing usage of GetBranchItemRule should need to be modified. The use of HomeOrHoldingBranchReturn is removed in AddReturn to instead use this subroutine. This will determine, on a more granular level, where the item should be transferred, after all is said and done. If 'noreturn' is specified, then the material will remain at the branch doing the checking in. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7144] Floating collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144 --- Comment #5 from Ian Walls ian.wa...@bywatersolutions.com 2011-12-12 14:44:05 UTC --- This can be done at a global level in the default_circ_rules table; it if's also then added to branch_item_rules, default_branch_circ_rules and default_branch_item_rules, then it can be controlled on a per branch and item type basis, as well. The preference can piggyback on the GetBranchItemRule subroutine. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7144] Floating collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144 --- Comment #6 from Chris Cormack ch...@bigballofwax.co.nz 2011-12-12 17:00:26 UTC --- I feel you are scope creeping the bug, outside of the clients requirements. As such you are welcome to send a counter patch. But I do not think that it is harmful to accept this patch and extend it later. It will change no existing behaviour without turning the systempreference on. And will work for libraries who want it to work this way. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7144] Floating collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144 --- Comment #7 from Ian Walls ian.wa...@bywatersolutions.com 2011-12-12 17:30:42 UTC --- Chris, I suppose I should have been more explicit; I've also got a couple partner libraries that need this, but on a per itemtype basis. Hence my interest in the generalization. A patch is forthcoming that should meet both our needs, and we can hopefully soon get rid of HomeOrHoldingBranchReturn entirely. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7144] Floating collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144 Ian Walls ian.wa...@bywatersolutions.com changed: What|Removed |Added CC||ian.walls@bywatersolutions. ||com --- Comment #3 from Ian Walls ian.wa...@bywatersolutions.com 2011-12-01 15:04:14 UTC --- This is working a global, system preference level. It would be better if the mechanism to determine whether an item floats or not occurred at the itemtype/homebranch level in the circ rules. Often, any given library will have it's Special Stuff that it will lend, but always want returned home. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7144] Floating collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #4 from Chris Cormack ch...@bigballofwax.co.nz 2011-12-01 15:44:59 UTC --- The library who commissioned it, specifically want it at a global level. But accepting it doesn't mean an itemtype level one can't be created in the future. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7144] Floating collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #6177|0 |1 is obsolete|| --- Comment #2 from Chris Cormack ch...@bigballofwax.co.nz 2011-12-01 02:06:58 UTC --- Created attachment 6482 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6482 bug_7144: renamed HomeOrHoldingBranchReturn to returnBranch and added returningbranch option for floating collections Added returningbranch support to returns How to test: * In systempreferences for circulation, for the ReturnBranch systemprefernce, choose 'leave the item at the library it is checked in at (floating collection) * Check out an item * Check it in at a branch other than its homebranch - you should not get a transfer prompt nor should it be automatically transferred. * Change the syspref to the other 2 pre existing options, test they still work This still needs sign off external to catalyst Signed-off-by: Chris Cormack chr...@catalyst.net.nz -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7144] Floating collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|kyle.m.h...@gmail.com |srd...@catalyst.net.nz --- Comment #1 from Srdjan Jankovic srd...@catalyst.net.nz 2011-11-04 05:37:19 UTC --- Created attachment 6177 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6177 patch Change in plan - we will rename current syspref HomeOrHoldingBranchReturn to ReturnBranch and add another option returningbranch to support floating collections. Effect is the same. We could have kept the name, but it was not a big effort to rename it, and I believe old name would be a bit confusing and inaccurate -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7144] Floating collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff Change sponsored?|--- |Sponsored -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
