[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2018-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||21080


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21080
[Bug 21080] patron attribute classes break patron's edit view
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2012-05-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2012-03-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Blocks||7836

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2012-03-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

   Priority|PATCH-Sent (DO NOT USE) |P3
 Status|Signed Off  |Passed QA
 CC||paul.poul...@biblibre.com
Version|rel_3_6 |rel_3_8

--- Comment #31 from Paul Poulain paul.poul...@biblibre.com ---
QA comments:
* perlcritic unchanged (still 1 error, that was here before the patch)
* feature nicely documented on the screen (for the PA_CLASS authorised values)
* feature works well  is great !

Passed QA

possible enhancement = put patron infos in tabs, as the patron display is more
and more full of informations ! but that will be for another bug !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2012-03-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2012-03-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Attachment #8353|0   |1
is obsolete||

--- Comment #27 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 8389
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8389action=edit
Bug 7154 Modification in borrower attributes

Display description if exists rather than code (in
cgi-bin/koha/members/moremember.pl and
cgi-bin/koha/admin/patron-attr-types.pl).
I don't change the status (signed off), easy to test.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2012-03-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Attachment #8389|0   |1
is obsolete||

--- Comment #28 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 8397
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8397action=edit
Bug 7154 Modification in borrower attributes

Rebased patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2012-03-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Attachment #8397|0   |1
is obsolete||

--- Comment #29 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 8407
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8407action=edit
Bug 7154 Modification in borrower attributes

This patch is rebased and add the description if exists rather than code in
memberentry.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2012-03-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2012-03-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

Julien Sicot julien.si...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #30 from Julien Sicot julien.si...@gmail.com ---
I applied the patch again and it works correct.
Tested on sandbox.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2012-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

MathildeF mathilde.form...@ville-nimes.fr changed:

   What|Removed |Added

 CC||mathilde.formery@ville-nime
   ||s.fr

--- Comment #19 from MathildeF mathilde.form...@ville-nimes.fr ---
i cant test with sandbox

CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
Auto-merging members/memberentry.pl
Auto-merging members/moremember.pl
Failed to merge in the changes.
Patch failed at 0001 Bug 7154: Modification in borrower attributes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2012-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Attachment #7559|0   |1
is obsolete||

--- Comment #20 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 8337
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8337action=edit
Bug 7154: Modification in borrower attributes

Rebased patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2012-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

Julien Sicot julien.si...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||julien.si...@gmail.com

--- Comment #21 from Julien Sicot julien.si...@gmail.com ---
Patch is not working. 
After i tried to create a new patron attribute type, i've got message Added
patron attribute type... but this one doesn't appear in the list or in add
patron form :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2012-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #22 from Jonathan Druart jonathan.dru...@biblibre.com ---
The sandbox seems to not launch the updatedatabase. Please check me when you
retest.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2012-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Attachment #8337|0   |1
is obsolete||

--- Comment #23 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 8350
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8350action=edit
Bug 7154 Modification in borrower attributes

FIX error in updatedatabase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2012-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Attachment #8350|0   |1
is obsolete||

--- Comment #24 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 8351
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8351action=edit
Bug 7154 Modification in borrower attributes

FIX error in updatedatabase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2012-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Attachment #8351|0   |1
is obsolete||

--- Comment #25 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 8353
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8353action=edit
Bug 7154: Modification in borrower attributes

rename missing category_type to category_code

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2012-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

Julien Sicot julien.si...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #26 from Julien Sicot julien.si...@gmail.com ---
Hi again,

I tested again and everything seems ok. 
I created several patron attributes with or without link between a borrower
category. I also used the AV PA_CLASS to group attributes.

The options make attribute staff_searchable in the staff patron search, show
attribute in patron check-out and display attribute on a patron's details
page in the OPAC work well.

Just one suggestion:

- Could it be possible to display the Description or Description OPAC
rather than the code Authorized value to group attributes in patron's details
page (cgi-bin/koha/members/moremember.pl)and Patron Attribute Types page
(cgi-bin/koha/admin/patron-attr-types.pl)

Thx
Julien

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2012-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Attachment #6909|0   |1
is obsolete||
   Attachment #7070|0   |1
is obsolete||
   Attachment #7074|0   |1
is obsolete||

--- Comment #18 from Jonathan Druart jonathan.dru...@biblibre.com 2012-02-10 
09:01:54 UTC ---
Created attachment 7559
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7559
Rebased and Squashed version

Bug 7154: Modification in borrower attributes

* group some attributes for a more friendly display

* allow a link between a borrower category and an attribute to display
  it only for the specified category

* Attr classes filled with AV 'PA_CLASS' category (you have to create AV
  with a new category 'PA_CLASS' to fill class list)

this patch add 2 fields in borrower_attribute_types :
category_type
class

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2012-02-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

--- Comment #17 from Owen Leonard oleon...@myacpl.org 2012-02-07 20:45:54 UTC 
---
Could we get a rebased and squashed version of this?

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

 CC||mag...@enger.priv.no

--- Comment #10 from Magnus Enger mag...@enger.priv.no 2012-01-06 10:55:22 
UTC ---
Nice enhancements! Just a couple of questions/suggestions: 

1. Could it be a good idea to use authorized values for class names? That would
leave less room for typos and make it possible to change the name of a class
without changing every attribute that uses that class. 

2. When a patron is viewed with e.g. members/moremember.pl?borrowernumber=3 the
attributes that have a class are displayed in a separate table, which is nice.
But in the edit screens they are all in the same table, sorted by Type. Could
it be an idea to sort the table by Class instead, to make the attributes with
the same class appear more close together? 

I'll attach screenshots of what the display looks like.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

--- Comment #11 from Magnus Enger mag...@enger.priv.no 2012-01-06 10:59:18 
UTC ---
Created attachment 7066
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7066
Displaying patron attributes

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

--- Comment #12 from Magnus Enger mag...@enger.priv.no 2012-01-06 10:59:46 
UTC ---
Created attachment 7067
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7067
Editing patron attributes

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

--- Comment #13 from Jonathan Druart jonathan.dru...@biblibre.com 2012-01-06 
15:07:32 UTC ---
Created attachment 7070
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7070
7154: Followup: Adds tables on modify + class filled wih AV

Hi Magnus, 

Thank you for returns.

This patch contains modifications you requested.

- FIX display/hide attr on memberentry.pl when category changes
- Attr classes filled with AV 'PA_CLASS' category (you have to create AV
  with a new category 'PA_CLASS' to fill class list)
- Use tables (classes separation) on member modification and attr management
  (admin). Theses array are sorted by name.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

--- Comment #14 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-06 
15:21:45 UTC ---
I have a question about this :)

Why was patron category type (adult, staff, etc.) chosen instead of patron
category? I think it would allow for a lot more flexibility. 

For example we use only 'adult' and 'staff' for academic libraries at the
moment.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

--- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com 2012-01-06 
17:11:18 UTC ---
Created attachment 7074
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7074
Bug 7154: Followup: Change link to patron category

Hi Katrin, 

You are right, it's more flexible.
I rapidly developed this patch. But it's not ok.
It seems some librairies could use the category type without the patron
category, is that right ?

To test this patch, you need to delete the contents of the table
borrower_attribute_types and add the modifications (cf updatedatabase, a
foreign key is insered)

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2012-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

--- Comment #16 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-06 
22:19:27 UTC ---
Afaik category type is an attribute for patron categories - I don't think you
can use Koha without creating patron categories. You can define more than 1
patron category for each category type and don't use some of them at all.

I think both things are named too similar, this is quite complicated to get
right :)

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2011-12-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Attachment #6575|0   |1
is obsolete||

--- Comment #8 from Katrin Fischer katrin.fisc...@bsz-bw.de 2011-12-21 
20:22:22 UTC ---
Created attachment 6909
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6909
Bug 7154: Modification in borrower attributes

* group some attributes for a more friendly display

* allow a link between a borrower category and an attribute to display
  it only for the specified category

this patch add 2 fields in borrower_attribute_types :
category_type
class

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2011-12-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

--- Comment #9 from Katrin Fischer katrin.fisc...@bsz-bw.de 2011-12-21 
20:22:46 UTC ---
Fixed conflict in updatedatabase.pl

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Attachment #6536|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com 2011-12-05 
08:50:13 UTC ---
Created attachment 6575
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6575
Proposed patch

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2011-12-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Patch Status|Failed QA   |Needs Signoff

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2011-12-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Attachment #6202|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com 2011-12-02 
15:23:34 UTC ---
Created attachment 6536
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6536
Proposed patch

@Owen: thanks for your return. This new patch should have to correct previous
problems.
However, I don't understand why you say qq{} syntax is not correct. Normally,
it's the same as quotes.

@Nicole: I don't modify search for patrons. I have test and it's ok for me.

Needs signoff

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2011-12-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Patch Status|Failed QA   |Needs Signoff

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2011-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com 2011-11-04 
13:50:07 UTC ---
Created attachment 6202
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6202
Proposed patch

For testing : 
- Create borrower attributes, link with borrower category (or not)
- Spécify a class (group of attributes) or not

See admin/patron-attr-types.pl, members/memberentrygen.pl and
members/moremember.pl

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2011-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Priority|P1  |PATCH-Sent
   Patch Status|--- |Needs Signoff

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2011-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

--- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com 2011-11-04 
14:02:56 UTC ---
ref BibLibre: MT5699

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute

2011-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

   Patch Status|Needs Signoff   |Failed QA

--- Comment #3 from Owen Leonard oleon...@myacpl.org 2011-11-04 15:24:03 UTC 
---
I've done some tests on this and ran into a couple of problems. First, the
updatedatabase process got stuck in a loop. The update completed, but I kept
getting  I'm not sure why, but changing:

$dbh-do(qq{ALTER TABLE borrower_attribute_types ADD COLUMN category_type
VARCHAR(1)  NOT NULL DEFAULT '' AFTER `display_checkout`});
$dbh-do(qq{ALTER TABLE borrower_attribute_types ADD COLUMN class
VARCHAR(255)  NOT NULL DEFAULT '' AFTER `category_type`});

To:

$dbh-do(ALTER TABLE borrower_attribute_types ADD COLUMN category_type
VARCHAR(1)  NOT NULL DEFAULT '' AFTER `display_checkout`;);
$dbh-do(ALTER TABLE borrower_attribute_types ADD COLUMN class
VARCHAR(255)  NOT NULL DEFAULT '' AFTER `category_type`;);

...made the process complete properly.

The other problem I found was that setting a category type limit seems to block
that attribute from appearing for *any* patrons. I set an Adult limit on one
of my attributes and found that the attribute didn't appear on Adult or Child
entry forms.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/