[Koha-bugs] [Bug 7184] have mysql returning errors

2011-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7184

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--- Comment #1 from Paul Poulain paul.poul...@biblibre.com 2011-11-06 
07:08:22 UTC ---
silly me ( ian) : -preference needs a db handler, that is not still open, so
it calls new_dbh, that need -preference ... = forever loop = boom !

We will have to use DEBUG pragma (in koha-httpd.conf)

Patch coming soon !

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7184] have mysql returning errors

2011-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7184

--- Comment #2 from Paul Poulain paul.poul...@biblibre.com 2011-11-06 
08:37:32 UTC ---
Created attachment 6238
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6238
Bug 7184 raise mySQL error if debug is set

Before this patch, if a mySQL occured in Koha (any error), then the user was
seeing nothing.
With this patch, if DEBUG is set in Koha VirtualHost, any mySQL error will make
Koha die and display the SQL error

Step to test:
=== BEFORE PATCH ===
go anywhere, and change a mySQL statement to make it invalid.
Launch a page using the SQL you've made wrong, you'll see nothing, except you
won't see the expected results

=== AFTER PATCH ===
Modify koha-httpd.conf, and add the following line, in the virtualhost (if it
does not already exist)
SetEnv DEBUG 1
restart/reload Apache
Launch the same page, you'll get a Perl statement saying something like:

DBD::mysql::st execute failed: blablabla SQL error at where the error was
raised line error line

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7184] have mysql returning errors

2011-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7184

Ian Walls ian.wa...@bywatersolutions.com changed:

   What|Removed |Added

   Patch Status|Needs Signoff   |Passed QA

--- Comment #3 from Ian Walls ian.wa...@bywatersolutions.com 2011-11-06 
10:43:45 UTC ---
Simple patch, implements more feedback information using the Environment
variable instead of the system preference.

Followup will become necessary: modify etc/koha-httpd.conf to include default
values for the DEBUG environment variable.  The choice of this default value
should be consistent with the level of debugging already defaulted to in Koha
with the syspref.

This will come in very handy whenever atomic update files are not applied along
with their companion code; a missing column or system preference value will
become very clear very quickly.

Marking as Passed QA

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7184] have mysql returning errors

2011-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7184

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

   Patch Status|Passed QA   |Patch Pushed

--- Comment #4 from Paul Poulain paul.poul...@biblibre.com 2011-11-06 
14:43:08 UTC ---
patch pushed, please test.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7184] have mysql returning errors

2011-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7184

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

Version|master  |rel_3_8

--- Comment #5 from Paul Poulain paul.poul...@biblibre.com 2011-11-06 
14:56:42 UTC ---
QMaint: I think this patch should be kept for 3.8: if it's activated on 3.6,
there may be unexpected errors. I'll propose on koha-devel to have all tester
setting DEBUG to 1, but I think it should not be done for 3.6 yet.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/