[Koha-bugs] [Bug 7365] Koha uses MySQL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com --- Comment #21 from M. Tompsett --- Well, bug 7785 is listed as blocking this. I have provided a patch which removes the MySQLism from C4::Members->column. Though, if there is a RDBMS specific LIMIT-like clause, the function will still need modifications for optimization purposes, not out of necessity. GPML... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7365] Koha uses MySQL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 --- Comment #20 from Ian Walls --- Bugzilla has done some great work on cross-database compatibility, and their guide can be referenced here: http://www.bugzilla.org/docs/developer.html#sql-crossdb -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7365] Koha uses MySQL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 Ian Walls changed: What|Removed |Added Depends on||8164 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7365] Koha uses MySQL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365
--- Comment #19 from Marc Balmer ---
The proposed patch does not introduce new vulnerabilities or possibilities for
SQL injection and you can not prevent the placeholder system. It does a mere
text replacement, so when you feed '?' to one of the (date) functions, the
resulting SQL code will contain the '?' at the right place and $dbh->prepare()
will do it's job like before.
The right flow of things is as follows:
$sql = $dbq->dateDiff('?', '?')
$qth = $dbh->prepare($sql)
$res = $qth->execute()
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7365] Koha uses MySQL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 Galen Charlton changed: What|Removed |Added CC||gmcha...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7365] Koha uses MySQL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 --- Comment #18 from MJ Ray (software.coop) --- After http://article.gmane.org/gmane.education.libraries.koha.devel/7566 and reviewing the patch, I think the current patch also fails coding guideline SQL9 because it will result in ways to avoid the placeholder system and inject SQL, particularly in date fields. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7365] Koha uses MySQL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365
Chris Cormack changed:
What|Removed |Added
CC||ch...@bigballofwax.co.nz
--- Comment #17 from Chris Cormack ---
* For hash refs, use $myhash->{mykey}, not $$myhash{mykey}
>From http://wiki.koha-community.org/wiki/Coding_Guidelines
Since we are making people resubmit patches for mysqlism, then this should be
resubmitted for style violations
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7365] Koha uses MySQL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 Chris Nighswonger changed: What|Removed |Added Status|Needs Signoff |In Discussion CC||cnighswon...@foundations.ed ||u --- Comment #16 from Chris Nighswonger --- IIRC, the QAM has the prerogative to put bugs "in discussion." This is one which should be discussed regardless of the "my plan works fine" declaration. Database agnosticism is bigger than just Pg. Furthermore, the last time an entity undertook to quickly push "custom" database agnostic work we got stuck with C4:SQLHelper which has its own set of problems in spite of the declaration that it worked fine. Moving back to "In Discussion" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7365] Koha uses MySQL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 stephane.dela...@biblibre.com changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7365] Koha uses MySQL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 stephane.dela...@biblibre.com changed: What|Removed |Added Attachment #8439|0 |1 is obsolete|| --- Comment #15 from stephane.dela...@biblibre.com --- Created attachment 8534 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8534&action=edit proposed patch (updated) as suggested by Ian Walls the patch replace "SHOW COLMUNS" in ImportExportFramework.pm with $dbh->column_info(undef, undef, $table, "%"); now DBQ implement 2 subs : - dateSub (Subtract a time value (interval) from a date) - ifNull (Returns $a if not null, else return $b) they are use in sub GetLateOrders in C4/Acquisition.pm . If db_scheme is mysql, the $query created by trhis sub is : SELECT aqbasket.basketno, aqorders.ordernumber, DATE(aqbasket.closedate) AS orderdate, aqorders.rrp AS unitpricesupplier, aqorders.ecostAS unitpricelib, aqorders.claims_count AS claims_count, aqorders.claimed_date AS claimed_date, aqbudgets.budget_name AS budget, borrowers.branchcode AS branch, aqbooksellers.nameAS supplier, aqbooksellers.id AS supplierid, biblio.author, biblio.title, biblioitems.publishercode AS publisher, biblioitems.publicationyear, aqorders.quantity - IFNULL(aqorders.quantityreceived, 0) AS quantity, (aqorders.quantity - IFNULL(aqorders.quantityreceived, 0)) * aqorders.rrp AS subtotal, (CAST(now() AS date) - closedate) AS latesince FROM aqorders LEFT JOIN biblio ON biblio.biblionumber = aqorders.biblionumber LEFT JOIN biblioitems ON biblioitems.biblionumber= biblio.biblionumber LEFT JOIN aqbudgets ON aqorders.budget_id = aqbudgets.budget_id, aqbasket LEFT JOIN borrowers ON aqbasket.authorisedby = borrowers.borrowernumber LEFT JOIN aqbooksellers ON aqbasket.booksellerid = aqbooksellers.id WHERE aqorders.basketno = aqbasket.basketno AND ( datereceived = '' OR datereceived IS NULL OR aqorders.quantityreceived < aqorders.quantity ) AND (aqorders.datecancellationprinted IS NULL OR aqorders.datecancellationprinted='-00-00') AND (closedate <= DATE_SUB(CAST(now() AS date), INTERVAL ? DAY)) AND aqbasket.booksellerid = ? AND borrowers.branchcode LIKE ? HAVING quantity <> 0 AND unitpricesupplier <> 0 AND unitpricelib <> 0 ORDER BY latesince, basketno, borrowers.branchcode, supplier If db_scheme is pg, the $query created by trhis sub is : SELECT aqbasket.basketno, aqorders.ordernumber, DATE(aqbasket.closedate) AS orderdate, aqorders.rrp AS unitpricesupplier, aqorders.ecostAS unitpricelib, aqorders.claims_count AS claims_count, aqorders.claimed_date AS claimed_date, aqbudgets.budget_name AS budget, borrowers.branchcode AS branch, aqbooksellers.nameAS supplier, aqbooksellers.id AS supplierid, biblio.author, biblio.title, biblioitems.publishercode AS publisher, biblioitems.publicationyear, aqorders.quantity - COALESCE(aqorders.quantityreceived, 0) AS quantity, (aqorders.quantity - COALESCE(aqorders.quantityreceived, 0)) * aqorders.rrp AS subtotal, (CAST(now() AS date) - closedate) AS latesince FROM aqorders LEFT JOIN biblio ON biblio.biblionumber = aqorders.biblionumber LEFT JOIN biblioitems ON biblioitems.biblionumber= biblio.biblionumber LEFT JOIN aqbudgets ON aqorders.budget_id = aqbudgets.budget_id, aqbasket LEFT JOIN borrowers ON aqbasket.authorisedby = borrowers.borrowernumber LEFT JOIN aqbooksellers ON aqbasket.booksellerid = aqbooksellers.id WHERE aqorders.basketno = aqbasket.basketno AND ( datereceived = '' OR datereceived IS NULL OR aqorders.quantityreceived < aqorders.quantity ) AND (aqorders.datecancellationprinted IS NULL OR aqorders.datecancellationprinted='-00-00') AND (closedate <= CAST(now() AS date) - interval '? DAY') AND aqbasket.booksellerid = ? AND borrowers.branchcode LIKE ? HAVING quantity <> 0 AND unitpricesupplier <> 0 AND unitpricelib <> 0 ORDER BY latesince, basketno, borrowers.branchcode, supplier -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org
[Koha-bugs] [Bug 7365] Koha uses MySQL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 Marc Balmer changed: What|Removed |Added Depends on||7806 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7365] Koha uses MySQL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 Marc Balmer changed: What|Removed |Added Depends on||7785 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7365] Koha uses MySQL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 Marc Balmer changed: What|Removed |Added Depends on|7785|7802 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7365] Koha uses MySQL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 --- Comment #14 from Marc Balmer --- SHOW COLUMNS FROM is only one example of a MySQLism, that we merely used to demonstrate the technique being used. What we - and we do it on purpose - is to not change the way how the database is accessed, but the SQL being used. For SHOW COLUMNS FROM there is a function in DBH, but did you check what it returns what the surrounding code in Koha expects? Well, we did check that and our goals was to minimally invasive, that is why we only change the way the SQL is generated. How will you address idoms for which no DBH equivalent, no standard SQL equivalent exists, i.e. where different SQL HAS to be used for MySQL or PostgreSQL? Our solution adresses exactly this problem. It is small, overseeable, and works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7365] Koha uses MySQL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 Ian Walls changed: What|Removed |Added Status|Signed Off |In Discussion --- Comment #13 from Ian Walls --- Okay, so this patch uses a bolt-on approach. Three new modules are added (along with a unit test!), along with a new Perl dependency, and then C4/ImportExportFramework.pm is modified to use those modules instead of direct MySQL "SHOW COLUMNS FROM". It seems like it'd be easier to use $dbh->column_info(undef, undef, $table, '%') or some modification thereof to get this information. We'd then be using a standardized, packaged database abstraction layer, instead of having to make our own, and it'd give us more than just MySQL and Postgres. The resulting change would likely be fewer lines of code than what we've got here currently. Moving to In Discussion, as we've likely still got a lot to talk about in terms of an implementation plan for adding database agnosticity. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7365] Koha uses MySQL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 --- Comment #12 from stephane.dela...@biblibre.com --- (In reply to comment #11) > (In reply to comment #10) > > Signed off the diff. > > Huh? Are we allowed to sign off our own enhancements now? no, but the patch was made by me -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7365] Koha uses MySQL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 --- Comment #11 from MJ Ray (software.coop) --- (In reply to comment #10) > Signed off the diff. Huh? Are we allowed to sign off our own enhancements now? Also, has this approach been discussed on koha-devel? I remember discussion of DBIx::Class in the past and the related RFC http://wiki.koha-community.org/wiki/RFC_for_using_DBIx_Class_in_Koha but I didn't find similar discussion of C4::DBQ. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7365] Koha uses MySQL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 stephane.dela...@biblibre.com changed: What|Removed |Added Assignee|gmcha...@gmail.com |m...@msys.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7365] Koha uses MySQL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 Marc Balmer changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #10 from Marc Balmer --- Signed off the diff. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7365] Koha uses MySQL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 --- Comment #9 from Marc Balmer --- Wwe are aiming at a minimally invasive solution that does not require us to make obstrusive changes. And this solution does not mean to go back to the minimal common available SQL subset, but still be able to use the full power of the underlying DB. And it does not prevent us from changing to a whole other approach in the future. For now, this is the bare minimum that is neede to enable Koha to run on different DBs. Switching do a different DB layer right now does help, because even if we did, Koha still expects MySQL result sets, C4::DBQ takes care of this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7365] Koha uses MySQL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 MJ Ray (software.coop) changed: What|Removed |Added CC||m...@ttllp.co.uk --- Comment #8 from MJ Ray (software.coop) --- (In reply to comment #7) > Why don't we just use one of the existing database abstraction layers > available for Perl? Then someone could use a completely different database, > if they so desired. I share this concern. I did a lot of work on the SQL ages ago and still feel that much of it should be replaced by a database-agnostic abstraction layer (if only I had the funding to do it). I don't feel that creating a Koha-specific multi-database SQL generator is a sustainable approach. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7365] Koha uses MySQL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 Ian Walls changed: What|Removed |Added Depends on||7785 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7365] Koha uses MySQL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 --- Comment #7 from Jared Camins-Esakov --- (In reply to comment #5) > Created attachment 8428 [details] > Add DBQ, a small module to generate DB specific SQL code > > To eliminate database specific SQL idoms (aka MySQLisms) it is necessary to > either use a standard SQL form like 'CAST(now() as date)' instead of the > non-standard MySQLism 'CURDATE()', or to generate a database specific idiom > where no such standard form exists (e.g. to get the list of column names > from a table). > > The new DBQ module is a generator for DB specific SQL idioms and comes with > an implementatio for both MySQL and PostgreSQL. Generating the SQL idioms > this way is the least invasive form of getting DB independence, as no large > changes to the database layer are required. Please note that DBQ->dbq > returns a singleton. > > DBQ stands for Database Query. Name, usage patterns, and implementation > discussed and agreed upon with many during the Marseille Hackfest 2012. Why don't we just use one of the existing database abstraction layers available for Perl? Then someone could use a completely different database, if they so desired. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7365] Koha uses MySQL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 Marc Balmer changed: What|Removed |Added Attachment #8428|0 |1 is obsolete|| --- Comment #6 from Marc Balmer --- Created attachment 8439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8439&action=edit Signed off patch to add DBQ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7365] Koha uses MySQL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 stephane.dela...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff CC||stephane.delaune@biblibre.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7365] Koha uses MySQL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 stephane.dela...@biblibre.com changed: What|Removed |Added Attachment #6851|0 |1 is obsolete|| --- Comment #5 from stephane.dela...@biblibre.com --- Created attachment 8428 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8428&action=edit Add DBQ, a small module to generate DB specific SQL code To eliminate database specific SQL idoms (aka MySQLisms) it is necessary to either use a standard SQL form like 'CAST(now() as date)' instead of the non-standard MySQLism 'CURDATE()', or to generate a database specific idiom where no such standard form exists (e.g. to get the list of column names from a table). The new DBQ module is a generator for DB specific SQL idioms and comes with an implementatio for both MySQL and PostgreSQL. Generating the SQL idioms this way is the least invasive form of getting DB independence, as no large changes to the database layer are required. Please note that DBQ->dbq returns a singleton. DBQ stands for Database Query. Name, usage patterns, and implementation discussed and agreed upon with many during the Marseille Hackfest 2012. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7365] Koha uses MySQL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 Jared Camins-Esakov changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #4 from Jared Camins-Esakov 2012-02-12 21:47:22 UTC --- You have a perplexing change in the patch: +$isbn = $isbn->as_isbn10 if $isbn->tHOW COLUMNS FROMype eq 'ISBN13'; Perhaps a typo? Please submit a revised patch, obsolete the existing patch, and change the status to "Needs signoff." -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7365] Koha uses MySQL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 Jared Camins-Esakov changed: What|Removed |Added Status|NEW |Needs Signoff CC||jcam...@cpbibliography.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7365] Koha uses MySQL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 Dobrica Pavlinusic changed: What|Removed |Added CC||dpav...@rot13.org -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7365] Koha uses MySQL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 --- Comment #3 from Marc Balmer 2011-12-18 09:50:04 UTC --- Created attachment 6852 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6852 A list of mysqlisms in C4 An (incomplete) list of MySQLisms in C4. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7365] Koha uses MySQL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 --- Comment #2 from Marc Balmer 2011-12-18 09:44:49 UTC --- I created a Wiki page to comment on the ongoing work to make Koha run happily with PostgreSQL: http://wiki.koha-community.org/wiki/PostgreSQL -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7365] Koha uses MySQL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 --- Comment #1 from Marc Balmer 2011-12-18 09:39:31 UTC --- Created attachment 6851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6851 Use 'pgsql' as synonym for 'Pg', remove some trailing whitespace -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
