[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 --- Comment #34 from Jared Camins-Esakov --- (In reply to comment #33) > How do you sterilise a toothpick? I was always told that a real programmer doesn't need to sterilize the toothpick. There's so much cola in their veins nothing can harm them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 --- Comment #33 from Srdjan Jankovic --- How do you sterilise a toothpick? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 --- Comment #32 from Chris Cormack --- (In reply to comment #31) > I always feel like the odd man out. I use joe set to wordstar style as my > primary editor. > I just write mine in my own blood, with a toothpick :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 --- Comment #31 from Kyle M Hall --- I always feel like the odd man out. I use joe set to wordstar style as my primary editor. (In reply to comment #29) > (In reply to comment #28) > > Sorry about that. It happens to me sometimes when I open files remotely. I > > try to exit file with :x, and somehow that : disappears, whichleaves only x > > and that deletes the character. Should be more careful. > > > You should first use a tool that is an efficient one, like Emacs > > > PS : just kidding, most of developers use VIM at BibLibre ;-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 Paul Poulain changed: What|Removed |Added Status|Passed QA |Pushed to Master Version|master |rel_3_10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 Paul Poulain changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #30 from Paul Poulain --- QA comments: * This patch clean some code indenting or writting, gg ! * perlcritic was complaining before the patch, still complains after the patch, not a reason to failed QA. * There are some additions like: +$template->param( showholds=>$show_holds_count); +$template->param( showpriority=>$show_priority); that could more cleanly be written +$template->param( showholds=>$show_holds_count, showpriority=>$show_priority ); but that's a minor comment, passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 Paul Poulain changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #29 from Paul Poulain --- (In reply to comment #28) > Sorry about that. It happens to me sometimes when I open files remotely. I > try to exit file with :x, and somehow that : disappears, whichleaves only x > and that deletes the character. Should be more careful. You should first use a tool that is an efficient one, like Emacs PS : just kidding, most of developers use VIM at BibLibre ;-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 Srdjan Jankovic changed: What|Removed |Added Attachment #9439|0 |1 is obsolete|| --- Comment #28 from Srdjan Jankovic --- Created attachment 9733 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9733&action=edit patch Sorry about that. It happens to me sometimes when I open files remotely. I try to exit file with :x, and somehow that : disappears, whichleaves only x and that deletes the character. Should be more careful. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 Paul Poulain changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #27 from Paul Poulain --- QA comment: trying to test this patch, I get a nasty = Template process failed: file error - parse error - /home/paul/koha.dev/koha-community/koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt line 314-315: unexpected token (]) [% END ] [% IF showholds && showpriority %] at /home/paul/koha.dev/koha-community/C4/Templates.pm line 127. ( My tests were done with the syspref set to holds_priority ) Could you please fix (probably a missing %) and resubmit ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||kyle.m.h...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 Kyle M Hall changed: What|Removed |Added Attachment #9251|0 |1 is obsolete|| --- Comment #26 from Kyle M Hall --- Created attachment 9439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9439&action=edit bug_7398: Replaced OPACDisplayRequestPriority syspref with OPACShowHoldQueueDetails New syspref is Choice, options being: - None - Priority only - Holds number only - Holds number and priority Show holds count on OPAC detail Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 Srdjan Jankovic changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 Srdjan Jankovic changed: What|Removed |Added Attachment #8737|0 |1 is obsolete|| --- Comment #25 from Srdjan Jankovic --- Created attachment 9251 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9251&action=edit patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 --- Comment #24 from Katrin Fischer --- Hi Srdjan, yes, please also make the current behaviour a valid option. In my opionino it should also be the default when updating existing installations. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 --- Comment #23 from Srdjan Jankovic --- > 1) There is no setting to keep current behaviour "only show priority" is not > an available setting. My thinking was that there's no reason to have "only show priority", ie if we want o show priority we may as well show the queue size. But I may be wrong. I will ad that one if you wish. > 2) The column could be named something like > "specific item holds"? (Item level holds, holds on this item?) Currently it > only says holds. The number at the bottom of the table could pehraps be > "Total holds"? We can do that. Please respond to 1) so I can do (or not) both things at once. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 --- Comment #22 from Katrin Fischer --- Created attachment 9008 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9008&action=edit screenshot I tested this and I see some problems: 1) There is no setting to keep current behaviour "only show priority" is not an available setting. We have no information, number of holds and number of holds and priority. I can imagine some libraries want the information about priority only to show to their patrons, not to everyone. So keeping current behaviour seems important to me. 2) I think the display is confusing if you have item level and title level holds. I am attaching a screenshot. Perhaps it would help to make the descriptions a bit more clear. The column could be named something like "specific item holds"? (Item level holds, holds on this item?) Currently it only says holds. The number at the bottom of the table could pehraps be "Total holds"? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 Chris Cormack changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff CC||ch...@bigballofwax.co.nz --- Comment #21 from Chris Cormack --- Just an updatedatabase conflict, fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 Chris Cormack changed: What|Removed |Added Attachment #8701|0 |1 is obsolete|| --- Comment #20 from Chris Cormack --- Created attachment 8737 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8737&action=edit bug_7398: Replaced OPACDisplayRequestPriority syspref with OPACShowHoldQueueDetails New syspref is Choice, options being: - None - Holds number only - Holds number and priority Show holds count on OPAC detail -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398
Nicole C. Engard changed:
What|Removed |Added
Status|Failed QA |Patch doesn't apply
CC||neng...@gmail.com
--- Comment #19 from Nicole C. Engard ---
patch
Apply? [yn] y
Applying: bug_7398: Replaced OPACDisplayRequestPriority syspref with
OPACShowHoldQueueDetails
/home/nengard/kohaclone/.git/rebase-apply/patch:230: trailing whitespace.
$_->{itemnumber}
error: patch failed: installer/data/mysql/updatedatabase.pl:5109
error: installer/data/mysql/updatedatabase.pl: patch does not apply
Patch failed at 0001 bug_7398: Replaced OPACDisplayRequestPriority syspref with
OPACShowHoldQueueDetails
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".
Patch left in /tmp/patch-q5mYrL.patch
nengard@kohavm:~/kohaclone$
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 Srdjan Jankovic changed: What|Removed |Added Attachment #8625|0 |1 is obsolete|| --- Comment #18 from Srdjan Jankovic --- Created attachment 8701 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8701&action=edit patch It looks ok except when one person puts a specific item hold, and another person has a non-specific hold. Can you please have a look and comment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 --- Comment #17 from Srdjan Jankovic --- I will check, but I assume 3) must be correct, cause no login - no user, therefore no priority. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 --- Comment #16 from Melia Meggs --- Srdjan, for the three options, I think what you have proposed is good: 1) none 2) number of holds only 3) both number of holds and priority I just need to make sure that if you choose 2) that the patron will be able to see the number of holds regardless of whether he is logged in or not. The main concern of the library that is sponsoring this is showing patrons the # of holds on an item when the patron is NOT logged in. I understand that with 3) obviously the patron can only see his priority if logged in. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 --- Comment #15 from Srdjan Jankovic --- That's fine with me. Do we have consensus re options? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 --- Comment #14 from Paul Poulain --- (In reply to comment #12) > The last two comments seem to come from the assumption that something is > being taken away, and I don't see it that way. I think the question is, is > there a situation where you would want to show one but not the other? Show > total holds count but not the user's priority? Show the user's priority but > not the overall hold count? Permissions for both could be combined into a > "OPACShowHoldQueueDetails" or something like that. that's exactly what I wanted to say ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 Srdjan Jankovic changed: What|Removed |Added Attachment #8171|0 |1 is obsolete|| Attachment #8552|0 |1 is obsolete|| --- Comment #13 from Srdjan Jankovic --- Created attachment 8625 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8625&action=edit patch This patch fixes the display issue. If you want me to replace sys prefs with "OPACShowHoldQueueDetails" please provide the set of options. The way it works now it would have 3 values: 1) none, 2) number of holds only, 3) both number of holds and priority -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 --- Comment #12 from Owen Leonard --- The last two comments seem to come from the assumption that something is being taken away, and I don't see it that way. I think the question is, is there a situation where you would want to show one but not the other? Show total holds count but not the user's priority? Show the user's priority but not the overall hold count? Permissions for both could be combined into a "OPACShowHoldQueueDetails" or something like that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 --- Comment #11 from Ian Walls --- Melia's right, both prefs are necessary: OPACShowHoldsCount shows how long the queue is. No login required. OPACDisplayRequestPriority shows where you are in the queue, once logged in. When OPACShowHoldsCount shows X, and you do not yet have a hold on the material, you can infer your priority at that moment will be X+1. Once you have a hold, however, you won't be able to see how close you are to getting it filled unless OPACDisplayRequestPriority is on -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 Melia Meggs changed: What|Removed |Added CC||me...@bywatersolutions.com --- Comment #10 from Melia Meggs --- > * 3rd = overall, i'm wondering if we really need 2 sysprefs, that does > almost the same thing. Is there a use case where we want to display the > number of requests but not your priority ? I feel it's meaningless = when > you put your request, if you know there are already 5 holds, you'll be the > 6th one. So shouldn't we just have one ? (and, maybe, remove > OPACDisplayRequestPriority) I think the two sys prefs are doing slightly different things. OPACShowHoldsCount shows the total # of holds to everyone, logged in or not. OPACDisplayRequestPriority shows the priority of your hold request, when you're logged in. I think the difference is when a patron does a search in the OPAC, even not logged in he can see how many holds are already on a particular item. If there are already 50 holds, he may decide he doesn't want to go to the effort of logging in and placing a hold. If all the patron can see is his priority, then he wouldn't know there are 50 holds until after he has already logged in and placed his hold, which he would then need to cancel if he doesn't want to wait in line behind 50 other people. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 --- Comment #9 from Paul Poulain --- Just tested this feature, and found a problem: there are 2 sysprefs related to displaying the hold counter on OPAC: OPACShowHoldsCount and OPACDisplayRequestPriority * 1st of all, it would be better to be consistent on names * 2nd = if you set OPACDisplayRequestPriority=1 and OPACShowHoldsCount=0 the display is broken (you get the but not the , so the table is wrong (I agree it's a strange idea though) * 3rd = overall, i'm wondering if we really need 2 sysprefs, that does almost the same thing. Is there a use case where we want to display the number of requests but not your priority ? I feel it's meaningless = when you put your request, if you know there are already 5 holds, you'll be the 6th one. So shouldn't we just have one ? (and, maybe, remove OPACDisplayRequestPriority) keeping failed QA because of #2 If you agree with #3, #1 becomes useless If you provide a patch for #3 i'll be pleased, otherwise, i'll be OK to push this patch without it and open an entry for removal of OPACDisplayRequestPriority. ( But, of course, I prefer the patch ;-) ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 --- Comment #8 from Srdjan Jankovic --- Created attachment 8552 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8552&action=edit follow-up patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 Paul Poulain changed: What|Removed |Added Status|Signed Off |Failed QA CC||paul.poul...@biblibre.com --- Comment #7 from Paul Poulain --- QA comment * the code is OK * the syspref is inconsistent I think: if it's set to OFF, the patron can see how many holds are done when he place the hold (opac-reserve.pl?biblionumber=5), in the priority column. So, from 2 choose 1: - remove the syspref - make the display consistent I'm member of the "group for removal of useless sysprefs", but I think this one is usefull, so i'm for option 2. Please provide a follow-up and i'll be happy to pass QA & push this patch ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 --- Comment #6 from jmbroust --- Created attachment 8441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8441&action=edit screenshot 2 of number of holds when only holds on next available -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 jmbroust changed: What|Removed |Added Attachment #8430|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 jmbroust changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||jean-manuel.broust@univ-lyo ||n2.fr --- Comment #5 from jmbroust --- works fine, nice feature :-) ; maybe number of holds could be more seeable when you only have holds on next available (because the table is empty in this case, see 2nd screenshot) ; and maybe it could be titled "total of holds" instead of "holds" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 --- Comment #4 from jmbroust --- Created attachment 8430 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8430&action=edit screenshot of number of holds when only holds on next available -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 --- Comment #3 from Owen Leonard --- Created attachment 8181 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8181&action=edit Screenshot showing total holds count versus item hold count -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 --- Comment #2 from Owen Leonard --- I wonder if the holds total should be shown at the top of the holdings list instead of the bottom? It would be hard to spot on a title with lots of items. I also wonder if the holds column in the holdings table should say "Holds on this item." That's a long label, but I'm concerned that it is confusing to patrons to see one number for total holds and another number in the table. For instance, 4 holds total, but only one line in the table says Holds: 1 because only one is an item-level hold? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 Srdjan Jankovic changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|oleon...@myacpl.org |srd...@catalyst.net.nz --- Comment #1 from Srdjan Jankovic --- Created attachment 8171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8171&action=edit patch Please say if any styling should be added -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 James Ghiorzi changed: What|Removed |Added CC||jghio...@cosb.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 Sharon Moreland changed: What|Removed |Added CC||smorel...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
