[Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 Jared Camins-Esakov changed: What|Removed |Added Status|Passed QA |RESOLVED Resolution|--- |WONTFIX --- Comment #24 from Jared Camins-Esakov --- Since I will not be rebasing this again, I am closing this bug. The problem still exists, of course. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 --- Comment #23 from Paul Poulain --- (In reply to comment #22) > My criticism here is those names are quite long, and I don't think these > routines are business logic at all. Are we going to build an inheritance > structure such that those are objects under inheriting from the classes > above them, or is it just an arbitrary naming scheme. agreed > If it's arbitrary and > there is no inheritance, then I like Koha::MARCUtils better. I suggested, for Logger.pm to have a Koha::Utils namespace. So Koha::Utils::Marc would easily take place here ! OTOH, it access the database, isn't it ? So will need access to Koha::DB::, and haven't we said something about business logic being the entry point for all db accesses ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 --- Comment #22 from Chris Cormack --- (In reply to comment #21) > (In reply to comment #19) > > I'm going to play curmudgeon, criticism without a valid counter suggestion > > is not useful :) So if not Koha::Utils what would you call it? > > A crusty, ill-tempered, and usually old man? ;) > I am not sure if that may not be useful [at times], btw.. But let me give it > a try: > High-level configuration functions like GetMarcFromKohaField and > GetAuthType.. > GetAuthType looks to me like a candidate for the originally called > Koha::DataObject, since it just passes the fields for auth_types table. > GetMarcFromKohaField should be moved somewhere within Koha::BusinessLogic or > its shorter variant. There could be room there for MARC utilities? > Let's say: Koha::BusinessLogic::MarcUtils::GetMarcTagForKohaField. > If we do not like MarcUtils after all, another proposal: > Koha::BusinessLogic::Administration::GetMarcTagForKohaField. Positive criticism, IE with useful suggestions on how to fix the problem is always useful, Negative criticism almost never is. Lest we become the linux kernel mailing list :-) My criticism here is those names are quite long, and I don't think these routines are business logic at all. Are we going to build an inheritance structure such that those are objects under inheriting from the classes above them, or is it just an arbitrary naming scheme. If it's arbitrary and there is no inheritance, then I like Koha::MARCUtils better. That would be my preference, but, I am not going to die in a ditch about it, I would accept something like Koha::Service::MARCUtils (Service is what BusinessLogic has moved to it seems). What I would like is this patch progressed and the remnants of no zebra to go away and stop causing us issues. And yes I am a grumpy old man :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 --- Comment #21 from M. de Rooy --- (In reply to comment #19) > I'm going to play curmudgeon, criticism without a valid counter suggestion > is not useful :) So if not Koha::Utils what would you call it? A crusty, ill-tempered, and usually old man? ;) I am not sure if that may not be useful [at times], btw.. But let me give it a try: High-level configuration functions like GetMarcFromKohaField and GetAuthType.. GetAuthType looks to me like a candidate for the originally called Koha::DataObject, since it just passes the fields for auth_types table. GetMarcFromKohaField should be moved somewhere within Koha::BusinessLogic or its shorter variant. There could be room there for MARC utilities? Let's say: Koha::BusinessLogic::MarcUtils::GetMarcTagForKohaField. If we do not like MarcUtils after all, another proposal: Koha::BusinessLogic::Administration::GetMarcTagForKohaField. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 --- Comment #20 from Julian Maurice --- I suggest something like Koha::MARC::Framework[::Biblio] for GetMarcFromKohaField and Koha::AuthorityTypes for GetAuthType. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 --- Comment #19 from Chris Cormack --- (In reply to comment #18) > (In reply to comment #14) > > However, I won't push this patch yet, because I think Koha::Utils is a too > > generic term, that will quickly result in a place where there is everything > > and anything. > > I'll propose quickly a naming convention and organisation (and a follow-up > > patch). > > +1 for Koha::Utils being too generic.. I'm going to play curmudgeon, criticism without a valid counter suggestion is not useful :) So if not Koha::Utils what would you call it? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 --- Comment #18 from M. de Rooy --- (In reply to comment #14) > However, I won't push this patch yet, because I think Koha::Utils is a too > generic term, that will quickly result in a place where there is everything > and anything. > I'll propose quickly a naming convention and organisation (and a follow-up > patch). +1 for Koha::Utils being too generic.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 M. de Rooy changed: What|Removed |Added Priority|PATCH-Sent (DO NOT USE) |P3 CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 --- Comment #17 from Jared Camins-Esakov --- I rebased the patch on latest master, and corrected an encoding issue that broke the patch subject. There are no changes in the latest version of the patch, so the status should remain at Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 Jared Camins-Esakov changed: What|Removed |Added Attachment #9240|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 --- Comment #16 from Jared Camins-Esakov --- Created attachment 9903 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9903&action=edit Bug 7430 - ModZebra should not be in C4::Biblio This proof-of-concept commit does the following: * Moves all the functionality from C4::Biblio::ModZebra into a new Koha::Search::Engine namespace, breaking it up into a Zebra class for the relevant section. * Rather than calling ModZebra, callers should now use Koha::Search and call AddToIndexQueue() with the same arguments. * Creates a new Koha::Utils class with GetMarcFromKohaField and GetAuthType methods, in an attempt to begin the process of reducing circular dependencies * Adds a syspref SearchEngine to specify which search engine should be used. At present the only option is Zebra. IMPORTANT NOTE: The syspref is added by the atomicupdate in installer/data/mysql/atomicupdate/bug_7430_add_searchengine_syspref IMPORTANT NOTE: NoZebra was deprecated for 3.4.0, and this commit entirely removes portions of the NoZebra code. Signed-off-by: Jared Camins-Esakov Signing off that the behavior is the same as in my original patch, except for a fix to the return type of Koha::Search::Engine::get_indexes and Koha::Search::GetIndexes. Another sign off is required. Signed-off-by: Henri-Damien LAURENT Signed-off-by: Mason James Signed-off-by: Jared Camins-Esakov Rebased 2 June 2012. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 --- Comment #15 from Jared Camins-Esakov --- > However, I won't push this patch yet, because I think Koha::Utils is a too > generic term, that will quickly result in a place where there is everything > and anything. > I'll propose quickly a naming convention and organisation (and a follow-up > patch). Do you have a proposal for the naming convention? I have further work which is dependent on untying this stuff from C4, and moving SearchAuthorities into Koha::Search. > Let me a few days. > > Other than this, I like this patch (and I think we could get rid of NoZebra > completely, as it does not work at all for now) I think there's another bug for removing NoZebra somewhere in Bugzilla. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 Paul Poulain changed: What|Removed |Added CC||paul.poul...@biblibre.com --- Comment #14 from Paul Poulain --- This patch still applies, with a tiny merge conflict that can easily be solved: <<< HEAD use C4::Search; === use Koha::Utils; use Koha::Search; >>> From: Juan Romay Sieira Date: Wed, 2 must be use C4::Search; use Koha::Utils; use Koha::Search; as use C4::Search has been reintroduced to avoid an error (see bug 7958) However, I won't push this patch yet, because I think Koha::Utils is a too generic term, that will quickly result in a place where there is everything and anything. I'll propose quickly a naming convention and organisation (and a follow-up patch). Let me a few days. Other than this, I like this patch (and I think we could get rid of NoZebra completely, as it does not work at all for now) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 Mason James changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #13 from Mason James --- (In reply to comment #12) > Back to Signed Off, as a QA team member has not signed off on this yet. just verified with Chris.C... flicking back to 'passed QA', for inclusion in Koha-3.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 --- Comment #12 from Chris Cormack --- Back to Signed Off, as a QA team member has not signed off on this yet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 Chris Cormack changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 Chris Cormack changed: What|Removed |Added Status|Passed QA |ASSIGNED CC||ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 Mason James changed: What|Removed |Added Status|Signed Off |Passed QA CC||m...@kohaaloha.com --- Comment #11 from Mason James --- setting status to 'passed QA' patch rebased against commit 012c6df0015b68dfa390d6ed4faedbc42c8af9ce Jared, i took the liberty of perltidying your newly added files (i just couldn't resist! :P) IMPORTANT NOTE: The syspref is added by the atomicupdate in installer/data/mysql/atomicupdate/bug_7430_add_searchengine_syspref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 Mason James changed: What|Removed |Added Attachment #8452|0 |1 is obsolete|| --- Comment #10 from Mason James --- Created attachment 9240 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9240&action=edit From: Juan Romay Sieira Date: Wed, 21 Mar 2012 11:05:16 +0100 Subject: [PATCH] Bug 7430 - ModZebra should not be in C4::Biblio This proof-of-concept commit does the following: * Moves all the functionality from C4::Biblio::ModZebra into a new Koha::Search::Engine namespace, breaking it up into a Zebra class for the relevant section. * Rather than calling ModZebra, callers should now use Koha::Search and call AddToIndexQueue() with the same arguments. * Creates a new Koha::Utils class with GetMarcFromKohaField and GetAuthType methods, in an attempt to begin the process of reducing circular dependencies * Adds a syspref SearchEngine to specify which search engine should be used. At present the only option is Zebra. IMPORTANT NOTE: The syspref is added by the atomicupdate in installer/data/mysql/atomicupdate/bug_7430_add_searchengine_syspref IMPORTANT NOTE: NoZebra was deprecated for 3.4.0, and this commit entirely removes portions of the NoZebra code. Signed-off-by: Jared Camins-Esakov Signing off that the behavior is the same as in my original patch, except for a fix to the return type of Koha::Search::Engine::get_indexes and Koha::Search::GetIndexes. Another sign off is required. Signed-off-by: Henri-Damien LAURENT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 Magnus Enger changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||mag...@enger.priv.no --- Comment #9 from Magnus Enger --- Looks like this can be set to signed off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 laurenthdl changed: What|Removed |Added Attachment #8403|0 |1 is obsolete|| --- Comment #8 from laurenthdl --- Created attachment 8452 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8452&action=edit signed off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 Jared Camins-Esakov changed: What|Removed |Added Attachment #8396|0 |1 is obsolete|| --- Comment #7 from Jared Camins-Esakov --- Created attachment 8403 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8403&action=edit Bug 7430 - ModZebra should not be in C4::Biblio This proof-of-concept commit does the following: * Moves all the functionality from C4::Biblio::ModZebra into a new Koha::Search::Engine namespace, breaking it up into a Zebra class for the relevant section. * Rather than calling ModZebra, callers should now use Koha::Search and call AddToIndexQueue() with the same arguments. * Creates a new Koha::Utils class with GetMarcFromKohaField and GetAuthType methods, in an attempt to begin the process of reducing circular dependencies * Adds a syspref SearchEngine to specify which search engine should be used. At present the only option is Zebra. IMPORTANT NOTE: The syspref is added by the atomicupdate in installer/data/mysql/atomicupdate/bug_7430_add_searchengine_syspref IMPORTANT NOTE: NoZebra was deprecated for 3.4.0, and this commit entirely removes portions of the NoZebra code. Signed-off-by: Jared Camins-Esakov Signing off that the behavior is the same as in my original patch, except for a fix to the return type of Koha::Search::Engine::get_indexes and Koha::Search::GetIndexes. Another sign off is required. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 Juan Romay Sieira changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff CC||juan.sie...@xercode.es -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 Juan Romay Sieira changed: What|Removed |Added Attachment #7144|0 |1 is obsolete|| --- Comment #6 from Juan Romay Sieira --- Created attachment 8396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8396&action=edit Bug 7430: Move ModZebra out of C4::Biblio (Rewrited to apply in current master) I submit the patch of Jared rewrited to apply in current master (it has no new changes). This is a nice job to start moving all Zebra code and adds the posibility to use other index engines like SolR -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 Paul Poulain changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Paul Poulain 2012-02-17 14:39:03 UTC --- The script devel/misc/testbugzillapatches.pl has detected that this bug does not apply anymore, so i'm marking this bug as "does not apply". The script is supposed to handle conflicts related to updatedatabase, but no other cases of merge conflict. So the conflict may be trivial to fix. If it happens that the patch attached does apply cleanly, please send me an email, there's something wrong in the script. It's possible, as it's a recent script. If the patch applies does not apply as I think, please rebase and resubmit, thanks -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 --- Comment #4 from Jared Camins-Esakov 2012-01-19 14:04:26 UTC --- (In reply to comment #3) > This is a great first step to permit Koha to use different search engines. > > I just want to add some remarks. > > First, why a new Koha::Utils ? Isn't C4::AuthoritiesMarc the good place for > GetAuthType ? If moving from C4 to Koha namespace, I would prefer something > like Koha::Authority::Type or Koha::AuthorityType for such a function. > I have no suggestion for GetMarcFromKohaField but I think it must be placed > anywhere but here. I believe we all agree that we don't want a new C4::Koha. We don't want any circular dependencies, and this helps reduce them. The reasoning behind Koha::Utils is that it seemed like a reasonable name for a module that provided utility functions to access Koha state information. Counter-patches gratefully accepted. > It seems that Koha::Search::Engine::Zebra::get_indexes returns a arrayref, > Koha::Search::Engine::get_indexes and Koha::Search::GetIndexes return directly > this arrayref, and it's assigned to a hash. I think there is a problem here. I think you are right. ;) Good catch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #3 from Julian Maurice 2012-01-19 11:23:24 UTC --- This is a great first step to permit Koha to use different search engines. I just want to add some remarks. First, why a new Koha::Utils ? Isn't C4::AuthoritiesMarc the good place for GetAuthType ? If moving from C4 to Koha namespace, I would prefer something like Koha::Authority::Type or Koha::AuthorityType for such a function. I have no suggestion for GetMarcFromKohaField but I think it must be placed anywhere but here. I believe we all agree that we don't want a new C4::Koha. It seems that Koha::Search::Engine::Zebra::get_indexes returns a arrayref, Koha::Search::Engine::get_indexes and Koha::Search::GetIndexes return directly this arrayref, and it's assigned to a hash. I think there is a problem here. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 Jared Camins-Esakov changed: What|Removed |Added Priority|P5 - low|PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 Jared Camins-Esakov changed: What|Removed |Added Attachment #7100|0 |1 is obsolete|| --- Comment #2 from Jared Camins-Esakov 2012-01-13 19:19:12 UTC --- Created attachment 7144 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7144 Bug 7430: Move ModZebra out of C4::Biblio This proof-of-concept commit does the following: * Moves all the functionality from C4::Biblio::ModZebra into a new Koha::Search::Engine namespace, breaking it up into a Zebra class for the relevant section. * Rather than calling ModZebra, callers should now use Koha::Search and call AddToIndexQueue() with the same arguments. * Creates a new Koha::Utils class with GetMarcFromKohaField and GetAuthType methods, in an attempt to begin the process of reducing circular dependencies * Adds a syspref SearchEngine to specify which search engine should be used. At present the only option is Zebra. IMPORTANT NOTE: The syspref is added by the atomicupdate in installer/data/mysql/atomicupdate/bug_7430_add_searchengine_syspref IMPORTANT NOTE: NoZebra was deprecated for 3.4.0, and this commit entirely removes portions of the NoZebra code. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 --- Comment #1 from Jared Camins-Esakov 2012-01-09 23:45:05 UTC --- Created attachment 7100 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7100 Bug 7430: Move ModZebra out of C4::Biblio This proof-of-concept commit does the following: * Moves all the functionality from C4::Biblio::ModZebra into a new Koha::Search::Engine namespace, breaking it up into Zebra and NoZebra classes for the relevant sections. * Rather than calling ModZebra, callers should now use Koha::Search and call AddToIndexQueue() with the same arguments. * Creates a new Koha::Utils class with GetMarcFromKohaField and GetAuthType methods, in an attempt to begin the process of reducing circular dependencies * Adds a syspref SearchEngine to specify whether Zebra or NoZebra is to be used, based on the setting of NoZebra. This syspref is checked *only* in ModZebra replacement code. The NoZebra is still relied upon by *all other* search-related code. IMPORTANT NOTE: The syspref is added by the atomicupdate in installer/data/mysql/atomicupdate/bug_7430_add_searchengine_syspref IMPORTANT NOTE: NoZebra indexing is currently broken due to the lack of a get_auth_type_location() method that can be used by the Koha::Search::Engine::NoZebra class. IMPORTANT NOTE: This patch depends on the patches for bug 7284. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
