[Koha-bugs] [Bug 7458] New call number allocation plugin

2012-03-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #28 from Paul Poulain  ---
follow-up pushed, still untested by me as it's very specific

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7458] New call number allocation plugin

2012-03-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #27 from Ian Walls  ---
Simple change to SQL to get distinct callnumbers.  Only affects this plugin, so
marking this as Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7458] New call number allocation plugin

2012-03-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458

Ian Walls  changed:

   What|Removed |Added

   Attachment #8129|0   |1
   is patch||
   Attachment #8129|application/octet-stream|text/plain
  mime type||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7458] New call number allocation plugin

2012-03-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458

Melia Meggs  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #26 from Melia Meggs  ---
Follow up patch corrects for duplicate call numbers in the database.  Works
better now, so I am signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7458] New call number allocation plugin

2012-03-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458

Melia Meggs  changed:

   What|Removed |Added

   Attachment #8046|0   |1
is obsolete||

--- Comment #25 from Melia Meggs  ---
Created attachment 8129
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8129&action=edit
Signed off follow up patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7458] New call number allocation plugin

2012-03-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458

Srdjan Jankovic  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7458] New call number allocation plugin

2012-03-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458

Srdjan Jankovic  changed:

   What|Removed |Added

 Status|Pushed to Master|In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7458] New call number allocation plugin

2012-03-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458

--- Comment #24 from Srdjan Jankovic  ---
Created attachment 8046
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8046&action=edit
follow-up patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7458] New call number allocation plugin

2012-02-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||paul.poul...@biblibre.com
Version|master  |rel_3_8

--- Comment #23 from Paul Poulain  2012-02-17 
10:25:53 UTC ---
I haven't tested it myself, but it just add a plugin, so, even if it does not
work, it can't break another part of Koha

Setting version to rel_3_8 and will advertise the feature when 3.8 is released

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7458] New call number allocation plugin

2012-02-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7458] New call number allocation plugin

2012-02-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458

Ian Walls  changed:

   What|Removed |Added

   Attachment #7668|0   |1
   is patch||
   Attachment #7668|application/octet-stream|text/plain
  mime type||

--- Comment #22 from Ian Walls  2012-02-16 16:36:29 UTC 
---
Comment on attachment 7668
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7668
Signed off patch

Thank you for splitting this patch off from it's database-changing dependency. 
As that patch has now passed QA, and this one is just the addition of new
(albeit highly specialized) plugin script, marking this one as Passed QA.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7458] New call number allocation plugin

2012-02-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458

Melia Meggs  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7458] New call number allocation plugin

2012-02-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458

Melia Meggs  changed:

   What|Removed |Added

   Attachment #7497|0   |1
is obsolete||

--- Comment #21 from Melia Meggs  2012-02-15 
22:25:32 UTC ---
Created attachment 7668
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7668
Signed off patch

Works as expected.  I have signed off.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7458] New call number allocation plugin

2012-02-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458

Srdjan Jankovic  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7458] New call number allocation plugin

2012-02-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458

Srdjan Jankovic  changed:

   What|Removed |Added

   Attachment #7461|0   |1
is obsolete||

--- Comment #20 from Srdjan Jankovic  2012-02-08 
02:15:50 UTC ---
Created attachment 7497
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7497
patch

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7458] New call number allocation plugin

2012-02-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458

Srdjan Jankovic  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=7509
  Change sponsored?|--- |Sponsored

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7458] New call number allocation plugin

2012-02-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458

--- Comment #19 from Srdjan Jankovic  2012-02-07 
23:53:35 UTC ---
I have no problems splitting it, it is just that I was not aware that database
changes need to be separated. To me it makes sense to put them together, but I
will create a new bug report if it makes it easier from the QA perspective.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7458] New call number allocation plugin

2012-02-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458

--- Comment #18 from Brendan Gallagher  
2012-02-07 18:14:37 UTC ---
(In reply to comment #17)
> The current patch implements both the plugin (which is in the scope of this 
> bug
> report) AND a database change to add an index on items.itemcallnumber (out of
> scope).  I do not object to either change; even if the new plugin isn't used 
> by
> anyone, it can safely sit in the plugins directory without harming anything. 
> The index on items.itemcallnumber may well provide useful, as I'm sure there
> are other places in Koha that perform SQL WHERE clauses on itemcallnumber
> (C4::Search::SearchAcquisitions() for example).
> 
> What I object to is the two enhancements being bundled together.  This new
> plugin should exist entirely on it's own, in it's own patch.  The new
> itemcallnumber index should be it's own change, on it's own bug report, tested
> independently.  If this plugin does indeed dependent on this index, a
> dependency between the two bug reports should be added.
> 
> Moving to "In Discussion" to solicit further opinions on this.

Great Makes Sense...

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7458] New call number allocation plugin

2012-02-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

--- Comment #17 from Ian Walls  2012-02-07 18:10:05 UTC 
---
The current patch implements both the plugin (which is in the scope of this bug
report) AND a database change to add an index on items.itemcallnumber (out of
scope).  I do not object to either change; even if the new plugin isn't used by
anyone, it can safely sit in the plugins directory without harming anything. 
The index on items.itemcallnumber may well provide useful, as I'm sure there
are other places in Koha that perform SQL WHERE clauses on itemcallnumber
(C4::Search::SearchAcquisitions() for example).

What I object to is the two enhancements being bundled together.  This new
plugin should exist entirely on it's own, in it's own patch.  The new
itemcallnumber index should be it's own change, on it's own bug report, tested
independently.  If this plugin does indeed dependent on this index, a
dependency between the two bug reports should be added.

Moving to "In Discussion" to solicit further opinions on this.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7458] New call number allocation plugin

2012-02-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #16 from Brendan Gallagher  
2012-02-07 17:48:00 UTC ---
(In reply to comment #15)
> Since this plugin is for a callnumber schema used by a single library, I do 
> not
> believe it in itself warrants any kind of changes to core Koha code.  In many
> ways, it's like a third-party service; this call number schema is locally
> developed by KU, and it's reusability is... unlikely.  Having it as a plugin 
> is
> just fine; when that plugin starts to dictate changes to the way the rest of
> Koha behaves, I believe that's a problem.
> 
> An index on items.itemcallnumber isn't a bad idea, but it should be filed as
> it's own separate bug report and patch.  If that index is required for this
> plugin to work, please list the newly filed bug report as a dependency.

Wait this is not passing because the QAM thinks that others will not use this? 
That's kind of a crazy idea.  So since something is programmed in a good manner
and works and does not effect any other aspects of Koha - unless you change
your framework to use this plugin - AND the QAM even said that the indexes on
itemcallnumber are a good idea (well shouldn't the QAM pass this?). 

This comment "Having it as a plugin is
> just fine; when that plugin starts to dictate changes to the way the rest of
> Koha behaves, I believe that's a problem."  Should be examined again - 
> reviewing the code I do not see how this changes core Koha code???  It adds 
> an index to itemcallnumber - which even the QAM agrees to..

Sorry just a bit perplexed as to why this was failed QA?

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7458] New call number allocation plugin

2012-02-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458

Ian Walls  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #15 from Ian Walls  2012-02-07 15:12:32 UTC 
---
Since this plugin is for a callnumber schema used by a single library, I do not
believe it in itself warrants any kind of changes to core Koha code.  In many
ways, it's like a third-party service; this call number schema is locally
developed by KU, and it's reusability is... unlikely.  Having it as a plugin is
just fine; when that plugin starts to dictate changes to the way the rest of
Koha behaves, I believe that's a problem.

An index on items.itemcallnumber isn't a bad idea, but it should be filed as
it's own separate bug report and patch.  If that index is required for this
plugin to work, please list the newly filed bug report as a dependency.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7458] New call number allocation plugin

2012-02-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458

Srdjan Jankovic  changed:

   What|Removed |Added

   Attachment #7406|0   |1
is obsolete||

--- Comment #14 from Srdjan Jankovic  2012-02-06 
00:38:10 UTC ---
Created attachment 7461
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7461
patch

I had to add an index on itemcallnumber as well, so there's a database patch
too.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7458] New call number allocation plugin

2012-02-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458

--- Comment #13 from Melia Meggs  2012-02-02 
22:56:14 UTC ---
This is very nearly perfect now. Only one thing - is it possible to prevent it
from ever returning FREN ? Can we make it start with FREN 0 - returns FREN
0001 as the first possible value?

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7458] New call number allocation plugin

2012-01-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458

--- Comment #12 from Srdjan Jankovic  2012-02-01 
02:20:56 UTC ---
Let's see it now.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7458] New call number allocation plugin

2012-01-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458

Srdjan Jankovic  changed:

   What|Removed |Added

   Attachment #7394|0   |1
is obsolete||

--- Comment #11 from Srdjan Jankovic  2012-02-01 
02:20:02 UTC ---
Created attachment 7406
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7406
patch

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7458] New call number allocation plugin

2012-01-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458

--- Comment #10 from Melia Meggs  2012-01-31 
23:17:09 UTC ---
Hey Srdjan,

I applied the latest patch, but I have a problem.  It now returns the same
barcode over and over.  Example:

I entered an item with call number FREN 0 - it returned FREN . (correct)
I entered an item with call number FREN 0 - it returned FREN 0001. (correct)
I entered an item with call number FREN 0 - it returned FREN 0001. (problem)
I entered an item with call number FREN 0 - it returned FREN 0001 again.
(problem)

Thanks,

Melia

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7458] New call number allocation plugin

2012-01-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458

--- Comment #9 from Srdjan Jankovic  2012-01-31 
08:05:54 UTC ---
I'll blame it on Melia, although most of them are of the "but wait, I did not
test this situation" kind. And a copyright fix.

Melia;

Here is a problem.

1. I added the call number FREN 0001 to a book named "Dog"
2. I then found a book named "Cat" and entered "FREN 0" and was given FREN
0002. So far, so good.
3. I changed the call number for "Cat" to FREN 0200
4. On the next record, I entered "FREN 0" and was given FREN 201 … when I
should have been given FREN 0002 as that was free

In short, the script is producing the first available number after the highest
number in the range. I could get around this problem by entering "FREN 00" but
the problem continues as you work through the numbers.

1. So let's say that I have "Elephant" at FREN 250, "Eloise" at FREN 500, and
"Eloise at the Plaza" at FREN 750.
2. "FREN 0" returns FREN 751, and I have to enter "FREN 00" to get FREN 0002.
3. In our system, French feature films have to fall between FREN 0200 and FREN
0999, but if I want something in the FREN range above 200 and I enter "FREN 02"
I get FREN 0251 because FREN 0250 is in the system already … and the only way
to get the available FREN 0201 would be to enter "FREN 020".
4. Once the range FREN 0200 – FREN 0209 is in use, I am unsure whether "FREN
020" would produce FREN 0210 (the lowest available number in the range) or FREN
0251 (the first available number after the highest number in the range). If the
latter, we will need to enter up to the third digit to fill in the gaps between
FREN 0211 and FREN 0249 inclusive … needing to use "FREN 021", "FREN 022",
"FREN 023" and "FREN 024" to get them all.

What we need is for the script to find the first available number in the range.

1. "FREN 0" should not return FREN 201 unless all of the numbers between FREN
0001 and FREN 0200 are already in use.
2. "FREN 02" should return the first number available after FREN 0200. If FREN
0200 - FREN 0299 are in use, it should return FREN 0300.
3. "FREN 1" should produce the first available number after FREN 1000.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7458] New call number allocation plugin

2012-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #8 from Katrin Fischer  2012-01-31 
06:47:26 UTC ---
Hi Srdjan, I am starting to wonder what's happening here - I see you have
replaced the patch a lot of times, but not sure what's the difference or what
got fixed with each. Could you add some comments to help us bug wranglers? :)

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7458] New call number allocation plugin

2012-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458

Srdjan Jankovic  changed:

   What|Removed |Added

   Attachment #7385|0   |1
is obsolete||

--- Comment #7 from Srdjan Jankovic  2012-01-31 
00:17:24 UTC ---
Created attachment 7394
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7394
patch

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7458] New call number allocation plugin

2012-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458

Srdjan Jankovic  changed:

   What|Removed |Added

   Attachment #7384|0   |1
is obsolete||

--- Comment #6 from Srdjan Jankovic  2012-01-30 
09:55:43 UTC ---
Created attachment 7385
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7385
patch

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7458] New call number allocation plugin

2012-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458

Srdjan Jankovic  changed:

   What|Removed |Added

   Attachment #7382|0   |1
is obsolete||

--- Comment #5 from Srdjan Jankovic  2012-01-30 
09:11:11 UTC ---
Created attachment 7384
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7384
patch

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7458] New call number allocation plugin

2012-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458

Srdjan Jankovic  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7458] New call number allocation plugin

2012-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458

Srdjan Jankovic  changed:

   What|Removed |Added

   Attachment #7332|0   |1
is obsolete||

--- Comment #4 from Srdjan Jankovic  2012-01-30 
02:34:15 UTC ---
Created attachment 7382
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7382
patch

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7458] New call number allocation plugin

2012-01-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458

Melia Meggs  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||me...@bywatersolutions.com

--- Comment #3 from Melia Meggs  2012-01-26 
01:40:54 UTC ---
Here's what I did for testing:

* On the Home › Administration › MARC Frameworks › Framework Structure › Tag
952 Subfield Structure › Edit subfields constraints for subfield o (Full call
number in my case) click on more constraints, pick plugin callnumber-KU.pl
* Home > Cataloging > search for a record
* Edit > Edit items

Scroll down to o - Full Call Number.  I typed in the following:

FREN 0 (then click on ...) - FREN  is returned
FREN 0 (then click on ...) - FREN 0001 is returned (the first unused value
beginning with this prefix) 
FREN 01 (then click on ...) - FREN 0100 is returned

And the one prefix that is different:

FEAT AM (then click on ...) - FEAT AM01 is returned
FEAT AM (then click on ...) - FEAT AM02 is returned

I think it works as expected, so I am signing off.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7458] New call number allocation plugin

2012-01-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458

Chris Cormack  changed:

   What|Removed |Added

   Attachment #7332|0   |1
   is patch||
   Attachment #7332|application/octet-stream|text/plain
  mime type||

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7458] New call number allocation plugin

2012-01-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458

Melia Meggs  changed:

   What|Removed |Added

   Attachment #7288|0   |1
is obsolete||

--- Comment #2 from Melia Meggs  2012-01-26 
01:30:59 UTC ---
Created attachment 7332
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7332
Signed off patch

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7458] New call number allocation plugin

2012-01-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458

Srdjan Jankovic  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 AssignedTo|gmcha...@gmail.com  |srd...@catalyst.net.nz

--- Comment #1 from Srdjan Jankovic  2012-01-23 
07:49:10 UTC ---
Created attachment 7288
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7288
patch

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/