[Koha-bugs] [Bug 7511] Caching Templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7511

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7511] Caching Templates

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7511

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Blocks||7533

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7511] Caching Templates

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7511

--- Comment #6 from Paul Poulain paul.poul...@biblibre.com 2012-02-13 
10:04:08 UTC ---
(In reply to comment #5)
 Next steps are to add this config option to the Makefile.PL so it does not
 need to be manually edited into existence.

Right. I've added a bug for that, and made it dependant from this one (bug
7533)

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7511] Caching Templates

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7511

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
Version|master  |rel_3_8

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7511] Caching Templates

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7511

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

   Attachment #7558|0   |1
is obsolete||

--- Comment #4 from Jared Camins-Esakov jcam...@cpbibliography.com 2012-02-12 
19:31:02 UTC ---
Created attachment 7589
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7589
Bug 7511 [ENH] Template caching (T::T feature)

Just add to your Koha configuration file
template_cache_dir/path/writable/by/apache/user/template_cache_dir
in the config block, and Koha will use template caching, for about
10% CPU time saving.

on linux servers, /tmp is usually OK

(also fixes an indenting with a TAB)

Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com
The results of using this are very striking. Based on an insufficient
sample size, it would seem that the time spent in T::T is reduced by a
factor of at least 5.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7511] Caching Templates

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7511

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||jcam...@cpbibliography.com

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7511] Caching Templates

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7511

Ian Walls koha.sek...@gmail.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #5 from Ian Walls koha.sek...@gmail.com 2012-02-12 22:12:39 UTC 
---
Safely implements a new config option using the features of T:T.  Marking
Passed QA.

Next steps are to add this config option to the Makefile.PL so it does not
need to be manually edited into existence.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7511] Caching Templates

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7511

--- Comment #1 from Paul Poulain paul.poul...@biblibre.com 2012-02-10 
08:43:02 UTC ---
Yesterday, I had a long trip in a train, so I investigated more, and wrote a
patch.

Just a performance thing: I tried to checkout a book, with and without caching,
on a copy of a real database. The result is absolutly astonishing:

The command run:
perl -d:NYTProf circ/circulation.pl userid=test password=test
borrowernumber=7852 barcode=0051900272

Without T::T cache =
Profile of circ/circulation.pl for 3.28s (of 4.74s), executing 486760
statements and 88239 subroutine calls in 284 source files and 87 string evals.

With T::T cache = 
Profile of circ/circulation.pl for 2.37s (of 2.83s), executing 144410
statements and 53427 subroutine calls in 293 source files and 74 string evals.

The circulation.tt is one of the largest template we have, the result is ...
well, use the word you want.
I was so surprised that I tried to find a mistake in my test, but could not.
without cache = run the command, run nytprofhtml to generate the result page
with cache =
* run the command once
* check that /tmp now has a cached version
* run the command again and run nytprofhtml to generate the result page

Patch to follow, it's a 2 lines one !

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7511] Caching Templates

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7511

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7511] Caching Templates

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7511

--- Comment #3 from Paul Poulain paul.poul...@biblibre.com 2012-02-10 
08:54:16 UTC ---
(In reply to comment #2)
 Just add to your Koha configuration file
 template_cache_dir/path/writable/by/apache/user/template_cache_dir
 and Koha will use template caching, for about 10% CPU time saving.

1- don't forget to reload apache
2- to check that cache now work: (I assume that KOHA_DIR is /home/koha/src and
the cache dir is /tmp) there is now a directory /tmp/home/koha/src, with sub
directories, owned by apache user

I encountered a problem when trying to run NYTProf and caching at the same
time: the NYTProf is run as paul while Koha run as apache2. Once you've
started running Koha with caching as one of those 2 users, you can't run a
script as the other user. This is because of linux permissions rwxr--r--
A little sudo rm -fr /tmp/home fixes this annoying problem if you need to run a
script as another user
a chmod +w+x could also work, I didn't tried

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/