[Koha-bugs] [Bug 7520] JSON script to return advanced search types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

Katrin Fischer  changed:

   What|Removed |Added

Summary|json script to return   |JSON script to return
   |advanced search types   |advanced search types
 Status|Failed QA   |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #28 from Katrin Fischer  ---
I think this should probably be implemented as a public REST API route
nowadays. 
It should also take into account if an itemtype has been marked to not display
in advanced search in configuration.

As this is really old I'll mark as WONTFIX, please reopen if you disagree!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7520] json script to return advanced search types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

--- Comment #27 from Srdjan Jankovic  ---
Heh, 5+ years ago when I created it there was no DBIx...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7520] json script to return advanced search types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #26 from M. Tompsett  ---
I'm going to be picky about the License. The DBIx vs DBI suggestions probably
could slide, though QA might fault you. Also, rather than assume the DB's have
category codes and branches, consider the use of TestBuilder.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7520] json script to return advanced search types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

--- Comment #25 from M. Tompsett  ---
Comment on attachment 60539
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60539
bug_7520 Added Meta handler to API v1 for metadata lists

Review of attachment 60539:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=7520=60539)
-

::: Koha/REST/V1/Meta.pm
@@ +12,5 @@
> +# A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License along
> +# with Koha; if not, write to the Free Software Foundation, Inc.,
> +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.

Since this is new, please use
https://wiki.koha-community.org/wiki/Coding_Guidelines#Licence

::: t/db_dependent/api/v1/meta.t
@@ +12,5 @@
> +# A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License along
> +# with Koha; if not, write to the Free Software Foundation, Inc.,
> +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.

Since this is new, please use
https://wiki.koha-community.org/wiki/Coding_Guidelines#Licence

@@ +32,5 @@
> +my $builder = t::lib::TestBuilder->new();
> +
> +my $dbh = C4::Context->dbh;
> +$dbh->{AutoCommit} = 0;
> +$dbh->{RaiseError} = 1;

This isn't necessary, since you can do it with the schema. No sense switching
between DBI and DBIx ways of doing things. It gets ugly if they conflict.

@@ +37,5 @@
> +
> +my $t = Test::Mojo->new('Koha::REST::V1');
> +
> +my $categorycode = 
> Koha::Database->new()->schema()->resultset('Category')->first()->categorycode();
> +my $branchcode = 
> Koha::Database->new()->schema()->resultset('Branch')->first()->branchcode();

my $schema = Koha::Database->new()->schema();
$schema->storage->txn_begin();
Then use $schema for the categorycode and branchcode.

@@ +77,5 @@
> +  ->json_has('/types/0/code')
> +  ->json_has('/types/0/description')
> +  ->json_has('/types/0/imageurl');
> +
> +$dbh->rollback;

$schema->storage->txn_rollback();

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7520] json script to return advanced search types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #53867|0   |1
is obsolete||

--- Comment #24 from Srdjan Jankovic  ---
Created attachment 60539
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60539=edit
bug_7520 Added Meta handler to API v1 for metadata lists

Useful for building drop-downs etc.

Kick off with /meta/advanced-search-types

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7520] json script to return advanced search types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

Srdjan Jankovic  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7520] json script to return advanced search types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #53865|0   |1
is obsolete||

--- Comment #23 from Srdjan Jankovic  ---
Created attachment 60538
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60538=edit
bug_7520 Added helper "syspref" to Mojolicious handlers

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7520] json script to return advanced search types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7520] json script to return advanced search types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

--- Comment #22 from Srdjan Jankovic  ---
Correction to the comment #14: url is now

/api/v1/meta/advanced-search-types

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7520] json script to return advanced search types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

--- Comment #21 from Srdjan Jankovic  ---
(In reply to Katrin Fischer from comment #18)
> Hm, not sure - but couldn't you use a public SQL report to achieve the same?

It would be a complex query that goes off two totally different tables
depending on a syspref.
If that's our policy I can certainly try.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7520] json script to return advanced search types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

Srdjan Jankovic  changed:

   What|Removed |Added

   Attachment #7613|0   |1
is obsolete||

--- Comment #20 from Srdjan Jankovic  ---
Created attachment 53867
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53867=edit
bug_7520 Added Meta handler to API v1 for metadata lists

Useful for building drop-downs etc.

Kick off with /meta/advanced-search-types

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7520] json script to return advanced search types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

Srdjan Jankovic  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7520] json script to return advanced search types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

--- Comment #19 from Srdjan Jankovic  ---
Created attachment 53865
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53865=edit
bug_7520 Added helper "syspref" to Mojolicious handlers

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7520] json script to return advanced search types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #18 from Katrin Fischer  ---
Hm, not sure - but couldn't you use a public SQL report to achieve the same?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7520] json script to return advanced search types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

--- Comment #17 from M. Tompsett  ---
Wasn't there some itype itemtype removal on something elsewhere recently?
Is the permissions check correct still?
Also, still stand by my question about the REST API.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7520] json script to return advanced search types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

Liz Rea  changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

--- Comment #16 from Liz Rea  ---
Hi, 

I think this deserves another look by QA.

Cheers,
Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7520] json script to return advanced search types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

--- Comment #15 from Liz Rea  ---
ccode, I can't read.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7520] json script to return advanced search types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #14 from Liz Rea  ---
An example of how one could use this, is as follows - example is of a drop down
that shows recent acquisitions by item type:

In your OpacMainUserBlock:

Something like









-- Please choose --






In your OpacUserJS, to fetch the list:

$(document).ready(function() {
$.getJSON("/cgi-bin/koha/advanced_search_types.json", function(data){
$.each(data.types, function (index, value) {
var opt = $('').text(value.description).appendTo("#new_orders_limit");
}); 
});

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7520] json script to return advanced search types

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #13 from M. Tompsett mtomp...@hotmail.com ---
*ping* Perhaps this could tie into the REST API development?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7520] json script to return advanced search types

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

Srdjan Jankovic srd...@catalyst.net.nz changed:

   What|Removed |Added

 Status|Failed QA   |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7520] json script to return advanced search types

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||paul.poul...@biblibre.com

--- Comment #11 from Paul Poulain paul.poul...@biblibre.com 2012-02-21 
13:52:33 UTC ---
QA comment
* the code itself is OK, use JSON, that is already a Koha dependancy
* perlcritic compliant

2 things that make me mark this patch failed QA though:
* a unit test for this script is needed (and should be easy to write)
* an example of how/where to use this would be cool.

A question: this script can be considered as a webservice right ? why not
putting it into a specific directory where we could put this kind of script ? I
don't request it, just suggesting.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7520] json script to return advanced search types

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

--- Comment #12 from Srdjan Jankovic srd...@catalyst.net.nz 2012-02-22 
06:19:28 UTC ---

 * a unit test for this script is needed (and should be easy to write)

I have no idea how to do that. Can you please point me to an example of a koha
test for a CGI request handler.
In general, I have huge problems running Koha test suite. Is there a wiki page
or similar on how to run tests when developing?

 * an example of how/where to use this would be cool.

Sure. In the code?

 A question: this script can be considered as a webservice right ? why not
 putting it into a specific directory where we could put this kind of script ? 
 I
 don't request it, just suggesting.

I wanted to do that myself, but found similar service(s) in the same place. So
I'm open to suggestions. I feel adventurous already for naming it .json

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7520] json script to return advanced search types

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

Srdjan Jankovic srd...@catalyst.net.nz changed:

   What|Removed |Added

   Attachment #7606|0   |1
is obsolete||

--- Comment #9 from Srdjan Jankovic srd...@catalyst.net.nz 2012-02-13 
08:02:36 UTC ---
Created attachment 7611
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7611
patch

Correct, sorry about that, thanks for spotting.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7520] json script to return advanced search types

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

Frédéric Demians frede...@tamil.fr changed:

   What|Removed |Added

   Attachment #7611|0   |1
is obsolete||

--- Comment #10 from Frédéric Demians frede...@tamil.fr 2012-02-13 08:14:11 
UTC ---
Created attachment 7613
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7613
Signed-off patch

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7520] json script to return advanced search types

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

Frédéric Demians frede...@tamil.fr changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7520] json script to return advanced search types

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

Srdjan Jankovic srd...@catalyst.net.nz changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #3 from Srdjan Jankovic srd...@catalyst.net.nz 2012-02-12 
23:09:53 UTC ---
If the opac requires authentication user must be logged in and auth cookie sent
in order to get a response. So if you just put the url in your browser it won't
work. However, if you visit the login page first and log in, it should be fine
afterwards.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7520] json script to return advanced search types

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

Frédéric Demians frede...@tamil.fr changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #4 from Frédéric Demians frede...@tamil.fr 2012-02-13 06:19:32 
UTC ---
(In reply to comment #3)
 If the opac requires authentication user must be logged in and auth cookie 
 sent
 in order to get a response. So if you just put the url in your browser it 
 won't
 work. However, if you visit the login page first and log in, it should be fine
 afterwards.

The OPAC doesn't require authentication except for accessing pages displaying
the borrower account. I now how to get a JSON result from your script, and I
get a valid response. But since the returned data doesn't contain any
confidential information (you find them on OPAC advanced search page which is
public), I don't think authentication should be required.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7520] json script to return advanced search types

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #5 from Chris Cormack ch...@bigballofwax.co.nz 2012-02-13 
06:29:24 UTC ---
It should only require authentication when opacpublic is turned off. (There is
a syspref to make the whole opac require authentication, this should of course
obey that)
But if the opac is public then yes, I don't see the need for auth. Maybe it
isn't checking this syspref correctly?

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7520] json script to return advanced search types

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

Srdjan Jankovic srd...@catalyst.net.nz changed:

   What|Removed |Added

   Attachment #7556|0   |1
is obsolete||

--- Comment #6 from Srdjan Jankovic srd...@catalyst.net.nz 2012-02-13 
07:22:07 UTC ---
Created attachment 7605
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7605
patch

Checking for OpacPublic now

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7520] json script to return advanced search types

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

Srdjan Jankovic srd...@catalyst.net.nz changed:

   What|Removed |Added

   Attachment #7605|0   |1
is obsolete||

--- Comment #7 from Srdjan Jankovic srd...@catalyst.net.nz 2012-02-13 
07:29:29 UTC ---
Created attachment 7606
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7606
patch

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7520] json script to return advanced search types

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

Srdjan Jankovic srd...@catalyst.net.nz changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7520] json script to return advanced search types

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

--- Comment #8 from Frédéric Demians frede...@tamil.fr 2012-02-13 07:53:32 
UTC ---
Thanks Chris for OpacPublic syspref.

There is a little typo. This line:

checkauth($input, !C4::Context-preference(OpacPublic), {}, opac);

should be:

checkauth($input, C4::Context-preference(OpacPublic), {}, opac);

IF the OPAC is public THEN no auth check.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7520] json script to return advanced search types

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

Srdjan Jankovic srd...@catalyst.net.nz changed:

   What|Removed |Added

Summary|json script to return item  |json script to return
   |types   |advanced search types

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7520] json script to return advanced search types

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

Srdjan Jankovic srd...@catalyst.net.nz changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 AssignedTo|oleon...@myacpl.org |srd...@catalyst.net.nz

--- Comment #1 from Srdjan Jankovic srd...@catalyst.net.nz 2012-02-10 
08:07:27 UTC ---
Created attachment 7556
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7556
patch

Correction, not item types but advanced search types, which could be collection
codes or item types

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7520] json script to return advanced search types

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520

Srdjan Jankovic srd...@catalyst.net.nz changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/