[Koha-bugs] [Bug 7669] Search Results Multiple Cover Image HTML & CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7669 David Cook changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #14 from David Cook --- *** This bug has been marked as a duplicate of bug 26933 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7669] Search Results Multiple Cover Image HTML & CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7669 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7669] Search Results Multiple Cover Image HTML & CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7669 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #13 from Lucas Gass --- (In reply to Liz Rea from comment #12) > Coce kind of solves this by handling the cover selection in a different > place, do we still want to deal with this in js/css? > > probably still relevant for local covers? I think this is still relevant for local covers, Syndetics, or any other non-Coce image services. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7669] Search Results Multiple Cover Image HTML & CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7669 --- Comment #12 from Liz Rea --- Coce kind of solves this by handling the cover selection in a different place, do we still want to deal with this in js/css? probably still relevant for local covers? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7669] Search Results Multiple Cover Image HTML & CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7669 Owen Leonardchanged: What|Removed |Added QA Contact|koha.sek...@gmail.com |testo...@bugs.koha-communit ||y.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7669] Search Results Multiple Cover Image HTML & CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7669 Owen Leonardchanged: What|Removed |Added Assignee|ssamm...@npelem.com |oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7669] Search Results Multiple Cover Image HTML & CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7669 Owen Leonardchanged: What|Removed |Added Attachment #14353|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7669] Search Results Multiple Cover Image HTML & CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7669 Owen Leonardchanged: What|Removed |Added Status|Failed QA |ASSIGNED --- Comment #11 from Owen Leonard --- I think the goals of the original patch could still be seen as useful. The display of cover images could be made more consistent. Since the original patch author never chose to follow up I think the best thing to do is return this to "New." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7669] Search Results Multiple Cover Image HTML & CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7669 Owen Leonardchanged: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7669] Search Results Multiple Cover Image HTML & CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7669 Marc Véronchanged: What|Removed |Added CC||ve...@veron.ch --- Comment #10 from Marc Véron --- Is this bug still valid or can it be marked as RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7669] Search Results Multiple Cover Image HTML CSS
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7669 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #8 from Owen Leonard oleon...@myacpl.org --- I can see that at the very least this patch breaks local cover images on the results page. Unfortunately the amount of changes in the patch make it difficult to debug. I think the relevant changes could be made in a new patch without touching so many lines. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7669] Search Results Multiple Cover Image HTML CSS
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7669 --- Comment #9 from Owen Leonard oleon...@myacpl.org --- The local cover images JavaScript tries to pull the biblionumber from the class of the #local-thumbnail div. Other classes have been added to that div, so the value is getting polluted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7669] Search Results Multiple Cover Image HTML CSS
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7669 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7669] Search Results Multiple Cover Image HTML CSS
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7669 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #8152|0 |1 is obsolete|| --- Comment #6 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 14353 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14353action=edit Bug 7669: Add CSS classes to OPAC results thumbnails Looks at the code for the images in the template I notices some were raw images, some were encased in div tags, and no-images were in spans. I added classes to the elements to make then more easily modified by the end user through the OPAC CSS options. Also, all images and no-images now have float:left (this was in the .thumbnail class). I combines the thumbnail elements into the .no-image{} class. It does not have div.no-image like the still active span.no-image, because that is an element specific class and thus any settings in it override user settings. So, it has to stay simply .no-image. Images img now have a class thumbnail_image. This was in keeping with consistent and unique element classes. thumbnail is used by all the div elements. Here are the new classes I have added, that are vendor/company specific: /* New Classes for Thumbnail Images */ .thumbnail_image { /* specific class for the actual img tag */ } /* specific classes for thumbnails */ .opac_thumb, .amazon_thumb, .google_thumb, .syndetics_thumb, .openlibrary_thumb, .bakertaylor_thumb{ } /* specific classes for no-image */ .amazon_no, .google_no, .openlibrary_no, .bakertaylor_no{ } Example Code to see why: /*examples how a specific class works*/ div.amazon_no{ /*Amazon no image [seem broken in code]*/ border: 1px solid #FFA500; /*amazon is ornage*/ } .google_thumb, .google_no{/*Google no image*/ border-top: 2px solid #F00; border-right: 2px solid #080; border-bottom: 2px solid #FF0; border-left: 2px solid #00F; padding: 2px; } .openlibrary_no{ background: url(http://openlibrary.org/images/logo_IA-sm.png) right center no-repeat; color: #00F; text-align: left; } Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7669] Search Results Multiple Cover Image HTML CSS
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7669 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #7 from Chris Cormack ch...@bigballofwax.co.nz --- Rebased the patch, it now applies, I have not tested it works, I made some changes to get it to apply so someone other than me needs to sign off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7669] Search Results Multiple Cover Image HTML CSS
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7669 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Patch doesn't apply CC||paul.poul...@biblibre.com --- Comment #5 from Paul Poulain paul.poul...@biblibre.com --- sorry but the patch doesn't apply anymore. The .css conflict is easy to solve, but the .tt isn't, so switching to does not apply. Sorry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7669] Search Results Multiple Cover Image HTML CSS
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7669 Ian Walls koha.sek...@gmail.com changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #4 from Ian Walls koha.sek...@gmail.com --- Template only change to opac-results.tt and CSS. Resulting HTML looks much cleaner and easier to work with. Marking as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7669] Search Results Multiple Cover Image HTML CSS
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7669 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #8065|0 |1 is obsolete|| --- Comment #3 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 8152 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8152action=edit Bug 7669: Add CSS classes to OPAC results thumbnails Looks at the code for the images in the template I notices some were raw images, some were encased in div tags, and no-images were in spans. I added classes to the elements to make then more easily modified by the end user through the OPAC CSS options. Also, all images and no-images now have float:left (this was in the .thumbnail class). I combines the thumbnail elements into the .no-image{} class. It does not have div.no-image like the still active span.no-image, because that is an element specific class and thus any settings in it override user settings. So, it has to stay simply .no-image. Images img now have a class thumbnail_image. This was in keeping with consistent and unique element classes. thumbnail is used by all the div elements. Here are the new classes I have added, that are vendor/company specific: /* New Classes for Thumbnail Images */ .thumbnail_image { /* specific class for the actual img tag */ } /* specific classes for thumbnails */ .opac_thumb, .amazon_thumb, .google_thumb, .syndetics_thumb, .openlibrary_thumb, .bakertaylor_thumb{ } /* specific classes for no-image */ .amazon_no, .google_no, .openlibrary_no, .bakertaylor_no{ } Example Code to see why: /*examples how a specific class works*/ div.amazon_no{ /*Amazon no image [seem broken in code]*/ border: 1px solid #FFA500; /*amazon is ornage*/ } .google_thumb, .google_no{/*Google no image*/ border-top: 2px solid #F00; border-right: 2px solid #080; border-bottom: 2px solid #FF0; border-left: 2px solid #00F; padding: 2px; } .openlibrary_no{ background: url(http://openlibrary.org/images/logo_IA-sm.png) right center no-repeat; color: #00F; text-align: left; } Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7669] Search Results Multiple Cover Image HTML CSS
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7669 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||jcam...@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7669] Search Results Multiple Cover Image HTML CSS
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7669 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|NEW |ASSIGNED Version|rel_3_6 |master Assignee|oleon...@myacpl.org |ssamm...@npelem.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7669] Search Results Multiple Cover Image HTML CSS
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7669 Liz Rea wizzy...@gmail.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff CC||wizzy...@gmail.com --- Comment #1 from Liz Rea wizzy...@gmail.com --- Changing to needs Signoff. Shane, how best do we go about testing this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7669] Search Results Multiple Cover Image HTML CSS
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7669 --- Comment #2 from Shane Sammons ssamm...@npelem.com --- If you use the OPAC CSS editing (Home › Administration › System Preferences OPAC OPACUserCSS ) section and use the .thumbnail class or the classes I added: .opac_thumb, .amazon_thumb, .google_thumb, .syndetics_thumb, .openlibrary_thumb, .bakertaylor_thumb (for thumbnails) .amazon_no, .google_no, .openlibrary_no, .bakertaylor_no (for no-image) Additionally to save time putting the following in the OPAC CSS editor will give you a setup similar to my screencast: /*examples how a specific class works*/ div.amazon_no{ /*Amazon no image [seem broken in code]*/ border: 1px solid #FFA500; /*amazon is ornage*/ } .google_thumb, .google_no{/*Google no image*/ border-top: 2px solid #F00; border-right: 2px solid #080; border-bottom: 2px solid #FF0; border-left: 2px solid #00F; padding: 2px; } .openlibrary_no{ background: url(http://openlibrary.org/images/logo_IA-sm.png) right center no-repeat; color: #00F; text-align: left; } Hopefully that explains how to try it? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/