[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Blocks||11255 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Magnus Enger mag...@enger.priv.no changed: What|Removed |Added Blocks||10283 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Magnus Enger mag...@enger.priv.no changed: What|Removed |Added Blocks||10257 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 --- Comment #51 from Brendan Gallagher bren...@bywatersolutions.com --- Created attachment 16493 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16493action=edit Bug 7674: Hide empty items tab Signed-off-by: Brendan bren...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Brendan Gallagher bren...@bywatersolutions.com changed: What|Removed |Added Attachment #14528|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Brendan Gallagher bren...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||bren...@bywatersolutions.co ||m --- Comment #52 from Brendan Gallagher bren...@bywatersolutions.com --- Worked as expected and you have meet all of the other thoughts and options presented. Great. I like this feature. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #16493|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 --- Comment #54 from Paul Poulain paul.poul...@biblibre.com --- Created attachment 16502 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16502action=edit Bug 7674: Hide empty items tab Signed-off-by: Corinne Bulac corinne.ha...@bulac.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added CC||paul.poul...@biblibre.com --- Comment #53 from Paul Poulain paul.poul...@biblibre.com --- Patch tested with a sandbox, by Corinne Bulac corinne.ha...@bulac.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 --- Comment #55 from Jared Camins-Esakov jcam...@cpbibliography.com --- Perhaps this latest patch could be moved to a separate bug? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Blocks||9875 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #16502|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |RESOLVED Resolution|--- |FIXED --- Comment #56 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Moved to 9875 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #13990|0 |1 is obsolete|| Attachment #13991|0 |1 is obsolete|| Attachment #13992|0 |1 is obsolete|| Attachment #13993|0 |1 is obsolete|| Attachment #14111|0 |1 is obsolete|| --- Comment #49 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 14528 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14528action=edit Bug 7674: Hide empty items tab -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Status|Pushed to Master|ASSIGNED --- Comment #50 from Julian Maurice julian.maur...@biblibre.com --- I obsoleted all previous patches that are in master and reset the status to Needs signoff. This patch is for the 2nd Jared's complaint. I don't think there is something to do for the first (in this bug). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Failed QA |Passed QA --- Comment #48 from Jared Camins-Esakov jcam...@cpbibliography.com --- It turns out the merge problem was caused trailing whitespace. I am not sure why. However, disabling the whitespace error squelching fixed it. I am going to push this patchset, with the following complaints: 1) If you choose to separate based on homebranch, the display makes no sense at all... the tab says Centerville holdings ( 1 ) and the items table says Fairfield in the location column. However, the display makes no sense anyway since apparently at some point we removed the possibility of displaying the home branch at all. 2) The two holdings tabs display whether or not there is anything to go in them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 --- Comment #46 from Julian Maurice julian.maur...@biblibre.com --- I'm unable to reproduce this problem. I think I've tried any combination of the 2 sysprefs involved here (OpacSeparateHoldings, OpacSeparateHoldingsBranch), logged in status, shelf browser displayed or not, and branch of items. I recreated the git branch like this git fetch origin git checkout -b bug/7674 origin/master git bz apply 7674 # applied all patches I found some debug text still present in the browser shelf so I will submit a patch for that. Jared if you are able to reproduce, could you investigate to find the line of code that produce this extra '%]' ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 --- Comment #47 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 14111 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14111action=edit Bug 7674: Remove some debug code -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 --- Comment #45 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 14082 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14082action=edit Picture of the problem An extra (and ugly) %] shows up on the OPAC in the holdings tab if I do not change any sysprefs at all after applying this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 --- Comment #40 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Working on this now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #13832|0 |1 is obsolete|| Attachment #13833|0 |1 is obsolete|| Attachment #13834|0 |1 is obsolete|| Attachment #13835|0 |1 is obsolete|| --- Comment #41 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 13990 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13990action=edit [SIGNED-OFF] Bug 7674: Separate items in two tabs on biblio detail page (staff+opac) Two tabs: branch holdings / Other holdings branch holdings tab contains items whose homebranch is the current branch. Other holdings tab contains all other items. If current branch is not set (connected with mysql user or not logged in (opac)), the display is unchanged (1 tab Holdings) Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 --- Comment #42 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 13991 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13991action=edit [SIGNED-OFF] Bug 7674: Open shelf browser in appropriate tab If you click on Browse shelf under mylibrary holdings, shelf browser should open under this tab. If you click on Browse shelf under other holdings tab, it should open under other holdings tab. Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 --- Comment #43 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 13992 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13992action=edit [SIGNED-OFF] Bug 7674: Add 2 sysprefs to indicate the branch we want to separate on The 2 sysprefs are SeparateHoldingsBranch and OpacSeparateHoldingsBranch and permit to chose between home branch and holding branch. Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 --- Comment #44 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 13993 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13993action=edit [SIGNED-OFF] Bug 7674 - Followup - Add missing right-hand curly bracket Signed-off-by: Julian Maurice julian.maur...@biblibre.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de All tests and perlcritic pass. Tests: Database update - OK, system preferences were added correctly - Version number of updatedatabase was only XXX, changed to 3.11.00.XX OPAC 1) Detail page - OK, no visible change when OpacSeparateHoldings is turned off - OK, switching OpacSeparateHoldingsBranch works correctly - OK, shelf browser opens in correct tab - OK, only one tab shows when logged out INTRANET 2) Detail page - OK, no visible change when SeparateHoldings is turned off - Number of items is missing on top of the tabs Notes: - database update doesn't include bug number - other holdings tab does show when there are 0 items at other branches, it could be hidden in those cases - if there are over 50 items in the holdings or Other holdings tab, the warning and link 'This record has many physical items. Click here to view them all.' is only shown for the first tab. - closing the shelf browser on the second tab goes back to first tab - number ofitems is missing on top of the tabs - there are lots of indentation changes in the second patch, this makes it very hard to see the changes, please provide separate patches in the future -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #13204|0 |1 is obsolete|| --- Comment #35 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 13832 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13832action=edit [SIGNED-OFF] Bug 7674: Separate items in two tabs on biblio detail page (staff+opac) Two tabs: branch holdings / Other holdings branch holdings tab contains items whose homebranch is the current branch. Other holdings tab contains all other items. If current branch is not set (connected with mysql user or not logged in (opac)), the display is unchanged (1 tab Holdings) Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #13206|0 |1 is obsolete|| --- Comment #37 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 13834 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13834action=edit [SIGNED-OFF] Bug 7674: Add 2 sysprefs to indicate the branch we want to separate on The 2 sysprefs are SeparateHoldingsBranch and OpacSeparateHoldingsBranch and permit to chose between home branch and holding branch. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #13215|0 |1 is obsolete|| --- Comment #38 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 13835 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13835action=edit [SIGNED-OFF] Bug 7674 - Followup - Add missing right-hand curly bracket Signed-off-by: Julian Maurice julian.maur...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #13205|0 |1 is obsolete|| --- Comment #36 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 13833 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13833action=edit [SIGNED-OFF] Bug 7674: Open shelf browser in appropriate tab If you click on Browse shelf under mylibrary holdings, shelf browser should open under this tab. If you click on Browse shelf under other holdings tab, it should open under other holdings tab. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #39 from Julian Maurice julian.maur...@biblibre.com --- All patches rebased on master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Patch doesn't apply Patch complexity|--- |Medium patch QA Contact|koha.sek...@gmail.com |katrin.fisc...@bsz-bw.de --- Comment #34 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Julian and others, can someone please rebase those patches? I fixed a conflict in sysprefs.sql, but was not sure how to resolve the next in opac-detail. Please set back to 'signed off' if the conflicts are not severe. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #13002|0 |1 is obsolete|| --- Comment #23 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 13189 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13189action=edit Bug 7674: Separate items in two tabs on biblio detail page (staff+opac) Two tabs: branch holdings / Other holdings branch holdings tab contains items whose homebranch is the current branch. Other holdings tab contains all other items. If current branch is not set (connected with mysql user or not logged in (opac)), the display is unchanged (1 tab Holdings) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #13003|0 |1 is obsolete|| --- Comment #24 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 13190 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13190action=edit Bug 7674: Open shelf browser in appropriate tab If you click on Browse shelf under mylibrary holdings, shelf browser should open under this tab. If you click on Browse shelf under other holdings tab, it should open under other holdings tab. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 --- Comment #27 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 13204 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13204action=edit [SIGNED-OFF] Bug 7674: Separate items in two tabs on biblio detail page (staff+opac) Two tabs: branch holdings / Other holdings branch holdings tab contains items whose homebranch is the current branch. Other holdings tab contains all other items. If current branch is not set (connected with mysql user or not logged in (opac)), the display is unchanged (1 tab Holdings) Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 --- Comment #28 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 13205 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13205action=edit [SIGNED-OFF] Bug 7674: Open shelf browser in appropriate tab If you click on Browse shelf under mylibrary holdings, shelf browser should open under this tab. If you click on Browse shelf under other holdings tab, it should open under other holdings tab. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 --- Comment #29 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 13206 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13206action=edit [SIGNED-OFF] Bug 7674: Add 2 sysprefs to indicate the branch we want to separate on The 2 sysprefs are SeparateHoldingsBranch and OpacSeparateHoldingsBranch and permit to chose between home branch and holding branch. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 --- Comment #30 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 13207 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13207action=edit Bug 7674 - Followup - Add missing right-hand curly bracket -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #13189|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #13190|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #13191|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 --- Comment #31 from Kyle M Hall k...@bywatersolutions.com --- Tested in both OPAC and staff with both settings. Everything appears to be working great! I did get a syntax error testing the staff side, but it was only a missing curly bracket. I've attached a followup. It is so small that I don't think it justifies holding back a signed-off status. Great work Paul Julian! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #13207|0 |1 is obsolete|| --- Comment #32 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 13215 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13215action=edit [SIGNED-0FF] Bug 7674 - Followup - Add missing right-hand curly bracket Signed-off-by: Julian Maurice julian.maur...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 --- Comment #33 from Julian Maurice julian.maur...@biblibre.com --- Thanks Kyle for the follow-up (next time I will test *after* doing the rebase...) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 --- Comment #21 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Kyle and Jonathan, I think it's debatable. I have been thinking about is since I saw this bug a whlie ago and I am not sure which is the right field to display and if every library wants it to be the same. When I am working in a library where the books are always sent back after being sent to another library for being checked out there and I want to see how many items my library owns - home branch is right. If I want to see what is currently on shelf for a borrower standing at the circulation desk and asking about the book, I would want the holdingbranch. These are 2 examples I came up with, but I think we had this discussion before about the branch to show with the item in OPAC and staff. I am not sure which bug that was, but before changing the patch it's maybe worth trying to figure out what exactly libraries want and if we need to make this an option maybe to be flexible enough. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 --- Comment #22 from Kyle M Hall k...@bywatersolutions.com --- Making this choice a system pref is the easy solution. There is a lot of conflict over where to show holding vs home branch. For example, in search results I believe we see an items home branch, but in the record details, we see the holding branch. Kyle (In reply to comment #21) Hi Kyle and Jonathan, I think it's debatable. I have been thinking about is since I saw this bug a whlie ago and I am not sure which is the right field to display and if every library wants it to be the same. When I am working in a library where the books are always sent back after being sent to another library for being checked out there and I want to see how many items my library owns - home branch is right. If I want to see what is currently on shelf for a borrower standing at the circulation desk and asking about the book, I would want the holdingbranch. These are 2 examples I came up with, but I think we had this discussion before about the branch to show with the item in OPAC and staff. I am not sure which bug that was, but before changing the patch it's maybe worth trying to figure out what exactly libraries want and if we need to make this an option maybe to be flexible enough. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #20 from Julian Maurice julian.maur...@biblibre.com --- Yes you are probably right. I reset status to Assigned and will send a follow up soon. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #19 from Kyle M Hall k...@bywatersolutions.com --- Question, it looks like this splits the items based on the homebranch. Shouldn't it be split by the holdingbranch? This seems like the sensible way to do it, if this is a 'show items in my library' feature. It especially makes more sense considering the tabs are labeled 'holdings' and not 'owned by'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #12749|0 |1 is obsolete|| --- Comment #17 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 13002 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13002action=edit Bug 7674: Separate items in two tabs on biblio detail page (staff+opac) Two tabs: branch holdings / Other holdings branch holdings tab contains items whose homebranch is the current branch. Other holdings tab contains all other items. If current branch is not set (connected with mysql user or not logged in (opac)), the display is unchanged (1 tab Holdings) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #12750|0 |1 is obsolete|| --- Comment #18 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 13003 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13003action=edit Bug 7674: Open shelf browser in appropriate tab If you click on Browse shelf under mylibrary holdings, shelf browser should open under this tab. If you click on Browse shelf under other holdings tab, it should open under other holdings tab. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff CC||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 --- Comment #16 from delaye stephane.del...@biblibre.com --- i have this message when i want to test in a sandbox(biblibre) CONFLICT (content): Merge conflict in catalogue/detail.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Koha Team AMU koha.aixmarsei...@gmail.com changed: What|Removed |Added CC||koha.aixmarsei...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #12433|0 |1 is obsolete|| --- Comment #13 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 12749 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12749action=edit Bug 7674: Separate items in two tabs on biblio detail page (staff+opac) rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 --- Comment #14 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 12750 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12750action=edit Bug 7674: Open shelf browser in appropriate tab If you click on Browse shelf under mylibrary holdings, shelf browser should open under this tab. If you click on Browse shelf under other holdings tab, it should open under other holdings tab. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #15 from Julian Maurice julian.maur...@biblibre.com --- Thanks Katrin, in fact the link didn't show up because my items have not a callnumber. Patch should fix the problem reported by Owen. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #11 from Julian Maurice julian.maur...@biblibre.com --- Marking as Failed QA for comment 9. Owen, how can I get this browse shelf link appearing ? When I made this patch I didn't notice it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #12 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Julian, there are system preferences to control the shelf browser and your items need to have callnumbers. I hope there is no UNIMARC/MARC21 problem involved here. Hope that helps! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 --- Comment #10 from delaye stephane.del...@biblibre.com --- i have this message when i want to test in a sandbox omething went wrong ! Applying: Bug 7674: Separate items in two tabs on biblio detail page (staff+opac) Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/updatedatabase.pl Failed to merge in the changes. Patch failed at 0001 Bug 7674: Separate items in two tabs on biblio detail page (staff+opac) When you have resolved this problem run git am --resolved. If you would prefer to skip this patch, instead run git am --skip. To restore the original branch and stop patching run git am --abort. Bug 7674 - Separate tabs for my holdings and others holdings Bug 7674: Separate items in two tabs on biblio detail page (staff+opac) Apply? [yn] Patch left in /tmp/Bug-7674-Separate-items-in-two-tabs-on-biblio-deta-iPrfAr.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Version|rel_3_8 |master Summary|tabs my holdings and others |Separate tabs for my |holdings. Buttons Remove |holdings and others |items Selected, Modify|holdings |items Selected | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 --- Comment #9 from Owen Leonard oleon...@myacpl.org --- Thanks for the improvements. I see another issue: Clicking a browse shelf link in the other holdings tab opens the shelf browser in the branch holdings tab. It would be easy enough to do something like this: [% PROCESS items_table items=otheritemloop tab=otherholdings %] ...and modify the link to the shelf browser: a href=/cgi-bin/koha/opac-detail.pl?biblionumber=[% ITEM_RESULT.biblionumber %]amp;shelfbrowse_itemnumber=[% ITEM_RESULT.itemnumber %]#[% tab %]Browse shelf/a ...but I'm not sure how you get the shelf browser to appear under the correct tab. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
