[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #54876|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #55000|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #45939|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #109 from Katrin Fischer  ---
Long story... happy ending? :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #45942|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #46216|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #45940|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #55323|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #45941|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #52010|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #47475|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #106 from Katrin Fischer  ---
Created attachment 55473
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55473=edit
[PASSED QA] Bug 7677: QA followup

Fix 'unique contraint primary' error when receiving serials

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #108 from Katrin Fischer  ---
Created attachment 55475
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55475=edit
[PASSED QA] Bug 7677: UT: Remove $dbh->rollback

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #105 from Katrin Fischer  ---
Created attachment 55472
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55472=edit
[PASSED QA] Bug 7677 [QA Followup] - Replace GetItemnumberFromSerialId with use
of Koha::Serial::Item(s)

 - use _type instead of type (see
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15446 )

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #107 from Katrin Fischer  ---
Created attachment 55474
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55474=edit
[PASSED QA] Bug 7677: QA followup

 - Fix tests

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #104 from Katrin Fischer  ---
Created attachment 55471
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55471=edit
[PASSED QA] Bug 7677 [QA Followup] - Replace GetItemnumberFromSerialId with use
of Koha::Serial::Item(s)

GetItemnumberFromSerialId has no unit tests. It would be better to start
using our object system here.

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #103 from Katrin Fischer  ---
Created attachment 55470
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55470=edit
[PASSED QA] Bug 7677 [Follow-up]: New areas in subscriptions and new functions
when receiving.

 - Various fixes.

Test plan:

Once the makePreviousSerialAvailable syspref is enabled, receive a serial, and
then another, then check that:

 - the first received itemtype has been set to the "previous item type" value
(set in the subscription).

 - the first received has been made available.

 - the last received serial itemtype has been set to the "item type" value (set
in the subscription).

 - 995$l is automatically prefilled.

Configure the serialsFieldsToAV syspref. When creating or editing a
subscription, check that:

 - the domain and/or origin and/or support fields are correctly displaying the
authorized values configured in the syspref.

Signed-off-by: Chris 

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #102 from Katrin Fischer  ---
Created attachment 55469
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55469=edit
[PASSED QA] Bug 7677: Fix tests

They don't pass since bug 12098 has been pushed.

Signed-off-by: Brendan Gallagher 

http://bugs.koha-community.org/show_bug.cgi?id=7767

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #101 from Katrin Fischer  ---
Created attachment 55468
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55468=edit
[PASSED QA] Bug 7677: FIX QA issues

 FAILC4/Serials.pm
   FAIL  forbidden patterns
forbidden pattern: trailing space char (line 1501)
forbidden pattern: trailing space char (line 921)

 FAILserials/serials-edit.pl
   FAIL  valid
"my" variable $dbh masks earlier declaration in same scope

Signed-off-by: Brendan Gallagher 

http://bugs.koha-community.org/show_bug.cgi?id=7767

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #100 from Katrin Fischer  ---
Created attachment 55467
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55467=edit
[PASSED QA] Bug 7677: UT: add unit tests for GetPreviousSerialid

Signed-off-by: Brendan Gallagher 

http://bugs.koha-community.org/show_bug.cgi?id=7767

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #99 from Katrin Fischer  ---
Created attachment 55466
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55466=edit
[PASSED QA] BZ7677: New areas in subscriptions and new functions when
receiving.

When enabling the makePreviousSerialAvailable syspref, the previously
 received serial's itemtype is set as defined in the subscription.
 (Please note that the item-level_itypes syspref must be set to specific item.)
 It is also made available.

Signed-off-by: Brendan Gallagher 

http://bugs.koha-community.org/show_bug.cgi?id=7767

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #98 from Julian Maurice  ---
Created attachment 55323
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55323=edit
Bug 7677: UT: Remove $dbh->rollback

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
  Attachment #54876|1   |0
is obsolete||

--- Comment #97 from Julian Maurice  ---
Comment on attachment 54876
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54876
Bug 7677: QA followup

This patch shouldn't have been obsoleted

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #96 from Jonathan Druart  
---
Comment on attachment 45940
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45940
Bug 7677: UT: add unit tests for GetPreviousSerialid

Review of attachment 45940:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=7677=45940)
-

::: t/db_dependent/Serials_2.t
@@ +255,5 @@
> +is( GetPreviousSerialid( $subscriptionid, 1 ), $serialid2, "get previous 
> serialid with 1" );
> +is( GetPreviousSerialid( $subscriptionid, 2 ), $serialid1, "get previous 
> serialid with 2" );
> +is( GetPreviousSerialid( $subscriptionid, 3 ), undef, "get previous serialid 
> with 3, does not exist" );
> +
> +$dbh->rollback;

This rollback should not have been added by this patch (added by a wrong merge
conflict).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #95 from Katrin Fischer  ---
I am not sure I understand how to fix - can you please provide a new patch for
the last patch? I think that's the one adding it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #94 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #93)
> Matthias, I am sorry, but there is still something odd about the test:
> rollback ineffective with AutoCommit enabled at t/db_dependent/Serials_2.t
> line 257.

Caused by a wrong fix conflict on "Bug 7677: UT: add unit tests for
GetPreviousSerialid", the rollback should not be added by this patch (was not
when I submitted it).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #93 from Katrin Fischer  ---
Matthias, I am sorry, but there is still something odd about the test:
rollback ineffective with AutoCommit enabled at t/db_dependent/Serials_2.t line
257.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger  changed:

   What|Removed |Added

  Attachment #54876|0   |1
is obsolete||

--- Comment #92 from Matthias Meusburger  ---
Created attachment 55000
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55000=edit
Bug 7677: QA followup

 - Fix tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #91 from Katrin Fischer  ---
Hi Matthias,
in testing things looked great, but now the tests are failing for me, hoping
it's easy to fix:
perl t/db_dependent/Serials_2.t:
Can't call method "lastvalue1" on an undefined value at
/home/katrin/kohaclone/C4/Serials.pm line 1575.
# Looks like your test exited with 2 just after 46.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #90 from Julian Maurice  ---
Created attachment 54876
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54876=edit
Bug 7677: QA followup

Fix 'unique contraint primary' error when receiving serials

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #89 from Katrin Fischer  ---
We are so close on this... please don't give up!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #88 from Katrin Fischer  ---
I've run the database update and created the schema files, but sadly, I am
still seeing an error:

DBIx::Class::ResultSource::unique_constraint_columns(): Unknown unique
constraint primary on 'serialitems' at /home/katrin/kohaclone/Koha/Objects.pm
line 83

It happens when I try to receive 2 serial issues at once. To reproduce this:
- Search for a subscription
- Go to it's serial collection page
- Create a next issue
- Try to receive both the now late issue and the expected one at once

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #87 from Matthias Meusburger  ---
Created attachment 52010
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52010=edit
Bug 7677 [QA Followup] - Replace GetItemnumberFromSerialId with use of
Koha::Serial::Item(s)

- use _type instead of type (see
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15446 )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #86 from Katrin Fischer  ---
I tried running misc/devel/update_dbix_class_files.pl, but I still get the
error message on trying to save the received issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #85 from Katrin Fischer  ---
I am sorry, this fails when I try to receive a serial issue:

Can't use an undefined value as an ARRAY reference at
/home/katrin/kohaclone/serials/serials-collection.pl line 131.

And after running the Schema update script:
DBIx::Class::Schema::resultset(): resultset() expects a source name at
/home/katrin/kohaclone/Koha/Objects.pm line 235

Please take a look!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #84 from Katrin Fischer  ---
I am experiencing bug 16118 again - so can't continue testing until I have
found the issue for this. Any help appreciated.

Meanwhile, can you check my written up test plan for this is correct?

Bug 7677 - New area in subscriptions and new function when receiving

This patch:
- It's now possible to select a default item type in the subscription,
  similar to the existing default location and call number.
- A new system preference makePreviousSerialAvailable is introcuded.
  This has 2 effects: 
  - It will automatically switch the not for loan status of the last
issue to 0 (available) when the next one is received.
  - It will allow you to pick an item type in the subscription, 
that the older issue is set to, when the next one is received.

To test:
- Create a subscription, where you create items on receive.
- Leave preference off and test the new default item type field.
- Verify new items are generated with the configured item type on
  receive.
- Activate preference.
- Receive issue, set not for loan != available/empty
- Receive another issue.
- Verify that the item is now available (not for loan = 0).
- Add another an item type for older issues.
- Receive another 2 issues, verify that the itemtype switch happens 
  correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #83 from Katrin Fischer  ---
Working on this!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #82 from Katrin Fischer  ---
Ah some note: I wonder about the change to the not for loan status that is
built in here. Wouldn't a 'not for loan' itemtype have the same effect? The
only difference I can think of is that the nfl in the item gives you the option
of having a custom nfl status text.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #81 from Katrin Fischer  ---
The subscription form behaviour looks good, although it would be nice if the
new settings appeared on the subscription detail page. Location and Call number
are also missing, so this could be handled separately.

But I have a problem on receiving serial items with and without this patch that
stops me from testing this further - see bug 16118.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #80 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #79)
>FAIL valid
>   Name "Cache::RemovalStrategy::FIELDS" used only once: possible 
> typo 
>   Name "Cache::RemovalStrategy::LRU::FIELDS" used only once: 
> possible typo 
>   Name "Tie::Hash::FIELDS" used only once: possible typo

See bug 16104.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #79 from Katrin Fischer  ---
Just starting with this - the QA tools have some complaints. Could you please
take a look?

 FAIL   Koha/Serial/Item.pm
   OK critic
   OK forbidden patterns
   OK pod
   OK spelling
0
   FAIL   valid
Name "Tie::Hash::FIELDS" used only once: possible typo 
Name "Cache::RemovalStrategy::LRU::FIELDS" used only once:
possible typo 
Name "Cache::RemovalStrategy::FIELDS" used only once: possible
typo 

 FAIL   Koha/Serial/Items.pm
   OK critic
   OK forbidden patterns
   OK pod
   OK spelling
0
   FAIL   valid
Name "Cache::RemovalStrategy::FIELDS" used only once: possible
typo 
Name "Cache::RemovalStrategy::LRU::FIELDS" used only once:
possible typo 
Name "Tie::Hash::FIELDS" used only once: possible typo

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #78 from Kyle M Hall  ---
Created attachment 47475
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47475=edit
Bug 7677 [QA Followup] - Replace GetItemnumberFromSerialId with use of
Koha::Serial::Item(s)

GetItemnumberFromSerialId has no unit tests. It would be better to start
using our object system here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Chris Cormack  changed:

   What|Removed |Added

  Attachment #45943|0   |1
is obsolete||

--- Comment #77 from Chris Cormack  ---
Created attachment 46216
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46216=edit
Bug 7677 [Follow-up]: New areas in subscriptions and new functions when
receiving.

- Various fixes.

Test plan:

Once the makePreviousSerialAvailable syspref is enabled, receive a serial, and
then another, then check that:

 - the first received itemtype has been set to the "previous item type" value
(set in the subscription).

 - the first received has been made available.

 - the last received serial itemtype has been set to the "item type" value (set
in the subscription).

 - 995$l is automatically prefilled.

Configure the serialsFieldsToAV syspref. When creating or editing a
subscription, check that:

 - the domain and/or origin and/or support fields are correctly displaying the
authorized values configured in the syspref.

Signed-off-by: Chris 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger  changed:

   What|Removed |Added

  Attachment #36679|0   |1
is obsolete||

--- Comment #70 from Matthias Meusburger  ---
Created attachment 45938
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45938=edit
BZ7677: New areas in subscriptions and new functions when receiving.

When enabling the makePreviousSerialAvailable syspref, the previously
 received serial's itemtype is set as defined in the subscription.
 (Please note that the item-level_itypes syspref must be set to specific item.)
 It is also made available.

Signed-off-by: Brendan Gallagher 

http://bugs.koha-community.org/show_bug.cgi?id=7767

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger  changed:

   What|Removed |Added

  Attachment #42924|0   |1
is obsolete||

--- Comment #75 from Matthias Meusburger  ---
Created attachment 45943
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45943=edit
BZ7677 [Follow-up]: New areas in subscriptions and new functions when
receiving.

- Various fixes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger  changed:

   What|Removed |Added

  Attachment #36682|0   |1
is obsolete||

--- Comment #74 from Matthias Meusburger  ---
Created attachment 45942
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45942=edit
Bug 7677: Fix tests

They don't pass since bug 12098 has been pushed.

Signed-off-by: Brendan Gallagher 

http://bugs.koha-community.org/show_bug.cgi?id=7767

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #76 from Matthias Meusburger  ---
Rebased. And moved SQL update from updatedatabase to atomic update.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger  changed:

   What|Removed |Added

  Attachment #36680|0   |1
is obsolete||

--- Comment #72 from Matthias Meusburger  ---
Created attachment 45940
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45940=edit
Bug 7677: UT: add unit tests for GetPreviousSerialid

Signed-off-by: Brendan Gallagher 

http://bugs.koha-community.org/show_bug.cgi?id=7767

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger  changed:

   What|Removed |Added

  Attachment #36681|0   |1
is obsolete||

--- Comment #73 from Matthias Meusburger  ---
Created attachment 45941
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45941=edit
Bug 7677: FIX QA issues

FAILC4/Serials.pm
   FAIL  forbidden patterns
forbidden pattern: trailing space char (line 1501)
forbidden pattern: trailing space char (line 921)

 FAILserials/serials-edit.pl
   FAIL  valid
"my" variable $dbh masks earlier declaration in same scope

Signed-off-by: Brendan Gallagher 

http://bugs.koha-community.org/show_bug.cgi?id=7767

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger  changed:

   What|Removed |Added

  Attachment #45938|0   |1
is obsolete||

--- Comment #71 from Matthias Meusburger  ---
Created attachment 45939
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45939=edit
BZ7677: New areas in subscriptions and new functions when receiving.

When enabling the makePreviousSerialAvailable syspref, the previously
 received serial's itemtype is set as defined in the subscription.
 (Please note that the item-level_itypes syspref must be set to specific item.)
 It is also made available.

Signed-off-by: Brendan Gallagher 

http://bugs.koha-community.org/show_bug.cgi?id=7767

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Koha Team Lyon 3  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #69 from Koha Team Lyon 3  ---
tried on a sandbox :
Something went wrong !Applying: BZ7677: New areas in subscriptions and
new functions when receiving.
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging serials/subscription-add.pl CONFLICT (content): Merge conflict in
serials/subscription-add.pl Auto-merging serials/serials-edit.pl Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/sysprefs.sql Auto-merging
installer/data/mysql/kohastructure.sql
CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql
Auto-merging C4/Serials.pm
Failed to merge in the changes.
Patch failed at 0001 BZ7677: New areas in subscriptions and new functions when
receiving.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger  changed:

   What|Removed |Added

  Attachment #36683|0   |1
is obsolete||

--- Comment #66 from Matthias Meusburger  ---
Created attachment 42923
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42923=edit
BZ7677 [Follow-up]: New areas in subscriptions and new functions when
receiving.

 - Various fixes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #67 from Matthias Meusburger  ---
This last patch fixes the issues you've raised when testing, Katrin.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger  changed:

   What|Removed |Added

  Attachment #42923|0   |1
is obsolete||

--- Comment #68 from Matthias Meusburger  ---
Created attachment 42924
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42924=edit
BZ7677 [Follow-up]: New areas in subscriptions and new functions when
receiving.

- Various fixes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #65 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I think we are not far - please fix so this long story can have a happy end :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #64 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Wow, first comment here from me was over a year ago :(

As this is a bigger feature with a longer history, I will leave some longer
testing notes for reference:

Automated Testing:

- OK - QA script passes on current 5 patches
- OK - Unit tests, especially all in t/db_dependent/Serial* pass

Code Review:

- OK - New sub GetPreviousSerialid has unit tests and is used to get the 
  last arrived serial item.
- OK - Database changes in updatedatabase and kohastructure are the same.
- (1) serials-edit.pl: Patch adds SQL to the .pl script - please move this 
  out of the pl script.
- (2) System preference description currently reads:
  previous serial automatically available when collecting a new serial. 
  Please note that the item-level_itypes syspref must be set to specific item.
-- s/collecting/receiving
-- s/serial/serial issue (?)
-- It would be nice to add a note that this will also enable you to switch
   the itemtype of the last issue to another item type on receiving a new
issue.

Testing:
- OK Adding subscription (syspref is OFF)
-- System preference not active, only item type shows on form
-- Item type is saved
- Receiving issue and creating an item
-- (3) In the item form, the selected itemtype doesn't preselect

- OK Editing subscription
-- Changes save correctly

- Editing subscription (syspref is now ON)
-- Previous item type: shows up now
-- (4) I think the descrption might be misleading - as it's the final and not
   really the previous item type of the issue. Not sure I can explain that
   well. Maybe we could use a longer description?
--- Item type for newest issue: / Item type for older issues:

- OK receiving issues
-- This is ok, as the last issue is set to my defined item type, 
   but (3) is still showing as a problem here

I have used numbers to mark some problematic bits. Please take a look!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Brendan Gallagher bren...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #36450|0   |1
is obsolete||

--- Comment #60 from Brendan Gallagher bren...@bywatersolutions.com ---
Created attachment 36680
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36680action=edit
Bug 7677: UT: add unit tests for GetPreviousSerialid

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

http://bugs.koha-community.org/show_bug.cgi?id=7767

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Brendan Gallagher bren...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #36451|0   |1
is obsolete||

--- Comment #61 from Brendan Gallagher bren...@bywatersolutions.com ---
Created attachment 36681
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36681action=edit
Bug 7677: FIX QA issues

FAILC4/Serials.pm
   FAIL  forbidden patterns
forbidden pattern: trailing space char (line 1501)
forbidden pattern: trailing space char (line 921)

 FAILserials/serials-edit.pl
   FAIL  valid
my variable $dbh masks earlier declaration in same scope

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

http://bugs.koha-community.org/show_bug.cgi?id=7767

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Brendan Gallagher bren...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #36449|0   |1
is obsolete||

--- Comment #59 from Brendan Gallagher bren...@bywatersolutions.com ---
Created attachment 36679
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36679action=edit
BZ7677: New areas in subscriptions and new functions when receiving.

When enabling the makePreviousSerialAvailable syspref, the previously
 received serial's itemtype is set as defined in the subscription.
 (Please note that the item-level_itypes syspref must be set to specific item.)
 It is also made available.

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

http://bugs.koha-community.org/show_bug.cgi?id=7767

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Brendan Gallagher bren...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #36453|0   |1
is obsolete||

--- Comment #63 from Brendan Gallagher bren...@bywatersolutions.com ---
Created attachment 36683
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36683action=edit
BZ7677 [Follow-up]: New areas in subscriptions and new functions when
receiving.

- Fix missing itemtype and previous itemtype when adding a subscription.

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

http://bugs.koha-community.org/show_bug.cgi?id=7767

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Brendan Gallagher bren...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #36452|0   |1
is obsolete||

--- Comment #62 from Brendan Gallagher bren...@bywatersolutions.com ---
Created attachment 36682
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36682action=edit
Bug 7677: Fix tests

They don't pass since bug 12098 has been pushed.

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

http://bugs.koha-community.org/show_bug.cgi?id=7767

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Brendan Gallagher bren...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #52 from Matthias Meusburger matthias.meusbur...@biblibre.com ---
patch rebased for updatedatabase.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger matthias.meusbur...@biblibre.com changed:

   What|Removed |Added

  Attachment #34665|0   |1
is obsolete||

--- Comment #57 from Matthias Meusburger matthias.meusbur...@biblibre.com ---
Created attachment 36452
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36452action=edit
Bug 7677: Fix tests

They don't pass since bug 12098 has been pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger matthias.meusbur...@biblibre.com changed:

   What|Removed |Added

  Attachment #36389|0   |1
is obsolete||

--- Comment #58 from Matthias Meusburger matthias.meusbur...@biblibre.com ---
Created attachment 36453
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36453action=edit
BZ7677 [Follow-up]: New areas in subscriptions and new functions when
receiving.

- Fix missing itemtype and previous itemtype when adding a subscription.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger matthias.meusbur...@biblibre.com changed:

   What|Removed |Added

  Attachment #34221|0   |1
is obsolete||

--- Comment #51 from Matthias Meusburger matthias.meusbur...@biblibre.com ---
Created attachment 36446
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36446action=edit
BZ7677: New areas in subscriptions and new functions when receiving.

When enabling the makePreviousSerialAvailable syspref, the previously
 received serial's itemtype is set as defined in the subscription.
 (Please note that the item-level_itypes syspref must be set to specific item.)
 It is also made available.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger matthias.meusbur...@biblibre.com changed:

   What|Removed |Added

  Attachment #36448|0   |1
is obsolete||

--- Comment #54 from Matthias Meusburger matthias.meusbur...@biblibre.com ---
Created attachment 36449
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36449action=edit
BZ7677: New areas in subscriptions and new functions when receiving.

When enabling the makePreviousSerialAvailable syspref, the previously
 received serial's itemtype is set as defined in the subscription.
 (Please note that the item-level_itypes syspref must be set to specific item.)
 It is also made available.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger matthias.meusbur...@biblibre.com changed:

   What|Removed |Added

  Attachment #34222|0   |1
is obsolete||

--- Comment #56 from Matthias Meusburger matthias.meusbur...@biblibre.com ---
Created attachment 36451
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36451action=edit
Bug 7677: FIX QA issues

FAILC4/Serials.pm
   FAIL  forbidden patterns
forbidden pattern: trailing space char (line 1501)
forbidden pattern: trailing space char (line 921)

 FAILserials/serials-edit.pl
   FAIL  valid
my variable $dbh masks earlier declaration in same scope

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger matthias.meusbur...@biblibre.com changed:

   What|Removed |Added

  Attachment #34220|0   |1
is obsolete||

--- Comment #55 from Matthias Meusburger matthias.meusbur...@biblibre.com ---
Created attachment 36450
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36450action=edit
Bug 7677: UT: add unit tests for GetPreviousSerialid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger matthias.meusbur...@biblibre.com changed:

   What|Removed |Added

  Attachment #36446|0   |1
is obsolete||

--- Comment #53 from Matthias Meusburger matthias.meusbur...@biblibre.com ---
Created attachment 36448
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36448action=edit
BZ7677: New areas in subscriptions and new functions when receiving.

When enabling the makePreviousSerialAvailable syspref, the previously
 received serial's itemtype is set as defined in the subscription.
 (Please note that the item-level_itypes syspref must be set to specific item.)
 It is also made available.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger matthias.meusbur...@biblibre.com changed:

   What|Removed |Added

  Attachment #34223|0   |1
is obsolete||

--- Comment #49 from Matthias Meusburger matthias.meusbur...@biblibre.com ---
Created attachment 36389
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36389action=edit
BZ7677 [Follow-up]: New areas in subscriptions and new functions when
receiving.

  - Fix missing itemtype and previous itemtype when adding a subscription.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger matthias.meusbur...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger matthias.meusbur...@biblibre.com changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #50 from Matthias Meusburger matthias.meusbur...@biblibre.com ---
About the tests, my bad: they are not broken in master, BUT these are
db_dependent tests, and as such, they need to be run with a proper database.

This patch allows to create such a database in your environment : 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337

With this database on master, the tests run fine.

With this database and my patches, the tests also run fine:

 prove t/db_dependent/Serials_2.t
[...]
All tests successful.
Files=1, Tests=40,  2 wallclock secs ( 0.04 usr  0.00 sys +  1.14 cusr  0.08
csys =  1.26 CPU)
Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #48 from Matthias Meusburger matthias.meusbur...@biblibre.com ---
Paola, about your remarks:

the Item type and Previous item type fields were not set to Continuing
Resources anymore! (ERROR)

= fixed in a little patch I will submit.


When I received (Arrived) an issue [in DB: table serial] of the suscription
(the first issue), I saw that the default value of the:
y - Koha item type field
of the new item was set to nothing (why?).

= Is your itemtype field (995$y in your case) using itemtypes authorized
values in the bibliographic framework ? It does not work if authorized values
are not linked.


prove t/db_dependent/Serials_2.t

= The tests also fail from test #3 on master, so my patch may have not broken
the tests (must be fixed on master to be sure, though).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #47 from Matthias Meusburger matthias.meusbur...@biblibre.com ---
Updated test plan:

Enable the makePreviousSerialAvailable syspref. Set the item-level_itypes
syspref to 'specific item'.

Create a subscription, with the 'create an item record when receiving this
serial' option enabled.

Select an item-type (let's say ItemType) and a previous item-type (let's say
OldItemType).

Receive a serial, and then another, then check that:

 - the first received serial's itemtype has been set to the previous item
type value which was set in the subscription (OldItemType in our example).

 - the first received has been made available.

 - the last received serial itemtype has been set to the item type value,
which was set in the subscription (ItemType in our example).

 - enumchron field of the item is automatically prefilled.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Paola Rossi paola.ro...@cineca.it changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #46 from Paola Rossi paola.ro...@cineca.it ---
I've applied the patches against master 3.19.00.003
[it needed a trivial rebase]

I set makePreviousSerialAvailable syspref to Make as required.
I kept the item-level_itypes syspref to specific item.

I created a subscription, which didn't create an item record when it received
the serial. When I received (Arrived) issues, no item was created: so this
bug is not about this case.

So I created another subscription, which created an item record when receiving
the serial, and I set its 2 new fields [Item type and Previous item type]
to Continuing Resources.

Then I Edited the subscription:
the Item type and Previous item type fields were not set to Continuing
Resources anymore! (ERROR)

Anyway I went on:
Was the previously received serial's itemtype set as defined in the
subscription?

When I received (Arrived) an issue [in DB: table serial] of the subscription
(the first issue), I saw that the default value of the:
y - Koha item type field
of the new item was set to nothing (why?).

I didn't change it to Continuing Resources [because koha should
do it for me, shouldn't it?]; then I filled the other fields (barcode, aso),
and I saved the new item.

Then I looked at the biblio:
In the biblio's Holdings tag, the item was Available and its item type is CR
as required (RIGHT).

I received another issue [the 2-nd] for the same subscription.
Now, in the biblio's Holdings, the new (2-nd) item was Available and CR, as
required.
But the previous (1-st) item [still Available] lost its type: it had no type
anymore! (ERROR)

But I could have been wrong: as Katrin wrote in comment 38:
It would be good to add a test plan and description. I think
the feature evolved a bit over time, as this is one of the older bug reports.

Anyway:
prove t/db_dependent/Serials_2.t
t/db_dependent/Serials_2.t .. 3/40
#   Failed test 'With IndependentBranches, superserials can edit a subscription
from his branch'
#   at t/db_dependent/Serials_2.t line 106.
#  got: '0'
# expected: '1'

#   Failed test 'With IndependentBranches, superserials can edit a subscription
from another branch'
#   at t/db_dependent/Serials_2.t line 109.
#  got: '0'
# expected: '1'

#   Failed test 'With IndependentBranches, superserials can show a subscription
from his branch'
#   at t/db_dependent/Serials_2.t line 112.
#  got: '0'
# expected: '1'

#   Failed test 'With IndependentBranches, superserials can show a subscription
from another branch'
#   at t/db_dependent/Serials_2.t line 115.
#  got: '0'
# expected: '1'

#   Failed test 'With IndependentBranches, edit_subscription can edit a
subscription from his branch'
#   at t/db_dependent/Serials_2.t line 121.
#  got: '0'
# expected: '1'

#   Failed test 'With IndependentBranches, show_subscription can show a
subscription from his branch'
#   at t/db_dependent/Serials_2.t line 127.
#  got: '0'
# expected: '1'

#   Failed test 'With IndependentBranches, renew_subscription can show a
subscription from his branch'
#   at t/db_dependent/Serials_2.t line 141.
#  got: '0'
# expected: '1'

#   Failed test 'Without IndependentBranches, superserials can edit a
subscription from his branch'
#   at t/db_dependent/Serials_2.t line 166.
#  got: '0'
# expected: '1'

#   Failed test 'Without IndependentBranches, superserials can edit a
subscription from another branch'
#   at t/db_dependent/Serials_2.t line 169.
#  got: '0'
# expected: '1'

#   Failed test 'Without IndependentBranches, superserials can show a
subscription from his branch'
#   at t/db_dependent/Serials_2.t line 172.
#  got: '0'
# expected: '1'

#   Failed test 'Without IndependentBranches, superserials can show a
subscription from another branch'
#   at t/db_dependent/Serials_2.t line 175.
#  got: '0'
# expected: '1'

#   Failed test 'Without IndependentBranches, edit_subscription can edit a
subscription from his branch'
#   at t/db_dependent/Serials_2.t line 180.
#  got: '0'
# expected: '1'

#   Failed test 'Without IndependentBranches, edit_subscription can edit a
subscription from another branch'
#   at t/db_dependent/Serials_2.t line 183.
#  got: '0'
# expected: '1'

#   Failed test 'Without IndependentBranches, show_subscription can show a
subscription from his branch'
#   at t/db_dependent/Serials_2.t line 186.
#  got: '0'
# expected: '1'

#   Failed test 'Without IndependentBranches, show_subscription can show a
subscription from another branch'
#   at t/db_dependent/Serials_2.t line 189.
#  got: '0'
# expected: '1'

#   Failed 

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Paola Rossi paola.ro...@cineca.it changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #44 from Paola Rossi paola.ro...@cineca.it ---
I've applied the patches against master 3.19.00.002

The first patch requires:

prove t/db_dependent/Serials_2.t 
t/db_dependent/Serials_2.t .. Global symbol $subscriptionid requires explicit
package name at t/db_dependent/Serials_2.t line 208.
Global symbol $subscriptionid requires explicit package name at
t/db_dependent/Serials_2.t line 209.
Global symbol $subscriptionid requires explicit package name at
t/db_dependent/Serials_2.t line 210.
Global symbol $subscriptionid requires explicit package name at
t/db_dependent/Serials_2.t line 212.
Global symbol $subscriptionid requires explicit package name at
t/db_dependent/Serials_2.t line 213.
Global symbol $subscriptionid requires explicit package name at
t/db_dependent/Serials_2.t line 214.
Global symbol $subscriptionid requires explicit package name at
t/db_dependent/Serials_2.t line 215.
Execution of t/db_dependent/Serials_2.t aborted due to compilation errors.
# Looks like your test exited with 255 before it could output anything.
t/db_dependent/Serials_2.t .. Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 36/36 subtests 

Test Summary Report
---
t/db_dependent/Serials_2.t (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 36 tests but ran 0.
Files=1, Tests=0,  1 wallclock secs ( 0.00 usr  0.01 sys +  0.72 cusr  0.05
csys =  0.78 CPU)
Result: FAIL

I pass the patch to Failed QA status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #45 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 34665
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34665action=edit
Bug 7677: Fix tests

They don't pass since bug 12098 has been pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Paola Rossi paola.ro...@cineca.it changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||paola.ro...@cineca.it

--- Comment #39 from Paola Rossi paola.ro...@cineca.it ---
I've tried to apply the patches against master 3.19.00.000

The second patch needed some [almost trivial] rebasing:

Applying: BZ7677: New areas in subscriptions and new functions when receiving.
Using index info to reconstruct a base tree...
stdin:49: trailing whitespace.
ORDER BY serialid DESC LIMIT $nth,1 
stdin:97: trailing whitespace.
$staffdisplaycount, $opacdisplaycount, $graceperiod, $location, $enddate, 
stdin:197: trailing whitespace.
  choices: 
warning: 3 lines add whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merging serials/serials-edit.pl
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/sysprefs.sql
CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql
Auto-merging installer/data/mysql/kohastructure.sql
Auto-merging C4/Serials.pm
Failed to merge in the changes.
Patch failed at 0001 BZ7677: New areas in subscriptions and new functions when
receiving.

I pass the patch to Patch doesn't apply status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #28950|0   |1
is obsolete||
  Attachment #29570|0   |1
is obsolete||
  Attachment #29571|0   |1
is obsolete||
  Attachment #29572|0   |1
is obsolete||

--- Comment #40 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 34220
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34220action=edit
Bug 7677: UT: add unit tests for GetPreviousSerialid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #43 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 34223
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34223action=edit
BZ7677 [Follow-up]: New areas in subscriptions and new functions when
receiving.

- Make the newly received serial gets its default itemtype from the
subscription.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #41 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 34221
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34221action=edit
BZ7677: New areas in subscriptions and new functions when receiving.

When enabling the makePreviousSerialAvailable syspref, the previously
 received serial's itemtype is set as defined in the subscription.
 (Please note that the item-level_itypes syspref must be set to specific item.)
 It is also made available.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #42 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 34222
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34222action=edit
Bug 7677: FIX QA issues

FAILC4/Serials.pm
   FAIL  forbidden patterns
forbidden pattern: trailing space char (line 1501)
forbidden pattern: trailing space char (line 921)

 FAILserials/serials-edit.pl
   FAIL  valid
my variable $dbh masks earlier declaration in same scope

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

Version|3.14|master

--- Comment #38 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I saw this is on the list for the testing day :) It would be good to add a test
plan and description. I think the feature evolved a bit over time, as this is
one of the older bug reports.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 QA Contact|katrin.fisc...@bsz-bw.de|testo...@bugs.koha-communit
   ||y.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #28951|0   |1
is obsolete||

--- Comment #34 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 29570
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29570action=edit
BZ7677: New areas in subscriptions and new functions when receiving.

When enabling the makePreviousSerialAvailable syspref, the previously
 received serial's itemtype is set as defined in the subscription.
 (Please note that the item-level_itypes syspref must be set to specific item.)
 It is also made available.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #28952|0   |1
is obsolete||

--- Comment #35 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 29571
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29571action=edit
Bug 7677: FIX QA issues

FAILC4/Serials.pm
   FAIL  forbidden patterns
forbidden pattern: trailing space char (line 1501)
forbidden pattern: trailing space char (line 921)

 FAILserials/serials-edit.pl
   FAIL  valid
my variable $dbh masks earlier declaration in same scope

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #28953|0   |1
is obsolete||

--- Comment #36 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 29572
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29572action=edit
BZ7677 [Follow-up]: New areas in subscriptions and new functions when
receiving.

- Make the newly received serial gets its default itemtype from the
subscription.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #37 from Jonathan Druart jonathan.dru...@biblibre.com ---
rebased patches (updatedatabase conflict).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||k...@univ-lyon3.fr

--- Comment #29 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
h1Something went wrong !/h1Applying: Bug 7677: UT: add unit tests for
GetPreviousSerialid Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Serials_2.t
Applying: BZ7677: New areas in subscriptions and new functions when receiving.
Using index info to reconstruct a base tree...
stdin:49: trailing whitespace.
ORDER BY serialid DESC LIMIT ,1
stdin:97: trailing whitespace.
, , , , ,
stdin:198: trailing whitespace.
  choices: 
warning: 3 lines add whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merging C4/Serials.pm
Auto-merging installer/data/mysql/kohastructure.sql
Auto-merging installer/data/mysql/sysprefs.sql Auto-merging
installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt
Auto-merging serials/subscription-add.pl Failed to merge in the changes.
Patch failed at 0001 BZ7677: New areas in subscriptions and new functions when
receiving.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #25980|0   |1
is obsolete||
  Attachment #25981|0   |1
is obsolete||
  Attachment #25983|0   |1
is obsolete||
  Attachment #27774|0   |1
is obsolete||

--- Comment #30 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 28950
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28950action=edit
Bug 7677: UT: add unit tests for GetPreviousSerialid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/