[Koha-bugs] [Bug 7889] Use standard style for errors and messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7889 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED --- Comment #14 from Chris Cormack --- Released in 3.10.0 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7889] Use standard style for errors and messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7889 Paul Poulain changed: What|Removed |Added Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7889] Use standard style for errors and messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7889 Paul Poulain changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #13 from Paul Poulain --- Only last patch not applied already. passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7889] Use standard style for errors and messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7889 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7889] Use standard style for errors and messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7889 Jonathan Druart changed: What|Removed |Added Attachment #11085|0 |1 is obsolete|| --- Comment #12 from Jonathan Druart --- Created attachment 11105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11105&action=edit Bug 7889 - Use standard style for errors and messages Correcting the markup of error messages in three places: catalogue merge, CSV profile editing, and opac comments. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7889] Use standard style for errors and messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7889 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7889] Use standard style for errors and messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7889 Owen Leonard changed: What|Removed |Added Status|Pushed to Master|ASSIGNED Version|rel_3_10|master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7889] Use standard style for errors and messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7889 --- Comment #11 from Owen Leonard --- Created attachment 11085 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11085&action=edit Bug 7889 - Use standard style for errors and messages Correcting the markup of error messages in three places: catalogue merge, CSV profile editing, and opac comments. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7889] Use standard style for errors and messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7889 Paul Poulain changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||paul.poul...@biblibre.com Version|master |rel_3_10 --- Comment #10 from Paul Poulain --- could be backported to 3.8, but it's just a display fix, so maybe not worth the risk for a side effect -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7889] Use standard style for errors and messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7889 Jonathan Druart changed: What|Removed |Added QA Contact|koha.sek...@gmail.com |jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7889] Use standard style for errors and messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7889 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #9 from Jonathan Druart --- QA Comments: All patches passed QA. Just one span class "problem" already exists, in serials/serials-collection.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7889] Use standard style for errors and messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7889 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7889] Use standard style for errors and messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7889 Chris Cormack changed: What|Removed |Added Attachment #9632|0 |1 is obsolete|| --- Comment #8 from Chris Cormack --- Created attachment 9661 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9661&action=edit Bug 7889 [Acquisitions] Use standard style for errors and messages Correcting style of the warning on the Acquisitions home page which appears if no budgets have been defined. Also correcting the logic by which the warning appears, as a change to the script inadvertently prevented it. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7889] Use standard style for errors and messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7889 Chris Cormack changed: What|Removed |Added Attachment #9631|0 |1 is obsolete|| --- Comment #7 from Chris Cormack --- Created attachment 9660 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9660&action=edit Bug 7889 [Search errors] Use standard style for errors and messages There are two instances in the templates where markup is defined for displaying search errors. I've never seen these appear and I have no idea what kind of error might trigger it, but now it will display correctly. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7889] Use standard style for errors and messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7889 Chris Cormack changed: What|Removed |Added Attachment #9630|0 |1 is obsolete|| --- Comment #6 from Chris Cormack --- Created attachment 9659 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9659&action=edit Bug 7889 [Authorities duplicates] Use standard style for errors and messages The warning shown in the authorities editor when there is a possible duplicate is styled incorrectly. In addition the design of the warning is inconsistent with that shown in the bibliographic record editor. This patch revises the style and layout of the duplicate error box. It also corrects a problem which appears in the biblio and authority editors where a non-existent JS window function was called. I have added the function to the default JS include and revised the editor pages to use it. To test: - Create a record in both the cataloging and authorities editors which will trigger a duplicate warning. - Click the link to the existing record. A separate window should pop up. - In both editors try each option: - Confirm the duplicate and go to the existing record. - Deny that the record is duplicate and continue to save. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7889] Use standard style for errors and messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7889 Chris Cormack changed: What|Removed |Added Attachment #9629|0 |1 is obsolete|| --- Comment #5 from Chris Cormack --- Created attachment 9658 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9658&action=edit Bug 7889 - Use standard style for errors and messages Styling subscription renew message according to standard style. Also: - Adding direct link to renew from message suggesting renew. - Adding output of expiration date to message. To test open a subscription with an impending expiration. You should see a dialog-styled message, "Subscription will expire XX/XX/. Renew this subscription." Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7889] Use standard style for errors and messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7889 --- Comment #4 from Owen Leonard --- Created attachment 9632 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9632&action=edit Bug 7889 [Acquisitions] Use standard style for errors and messages Correcting style of the warning on the Acquisitions home page which appears if no budgets have been defined. Also correcting the logic by which the warning appears, as a change to the script inadvertently prevented it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7889] Use standard style for errors and messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7889 Owen Leonard changed: What|Removed |Added Attachment #9629|Bug 7889 - Use standard |Bug 7889 [Subscription description|style for errors and|renew] Use standard style |messages|for errors and messages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7889] Use standard style for errors and messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7889 --- Comment #3 from Owen Leonard --- Created attachment 9631 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9631&action=edit Bug 7889 [Search errors] Use standard style for errors and messages There are two instances in the templates where markup is defined for displaying search errors. I've never seen these appear and I have no idea what kind of error might trigger it, but now it will display correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7889] Use standard style for errors and messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7889 --- Comment #2 from Owen Leonard --- Created attachment 9630 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9630&action=edit Bug 7889 [Authorities duplicates] Use standard style for errors and messages The warning shown in the authorities editor when there is a possible duplicate is styled incorrectly. In addition the design of the warning is inconsistent with that shown in the bibliographic record editor. This patch revises the style and layout of the duplicate error box. It also corrects a problem which appears in the biblio and authority editors where a non-existent JS window function was called. I have added the function to the default JS include and revised the editor pages to use it. To test: - Create a record in both the cataloging and authorities editors which will trigger a duplicate warning. - Click the link to the existing record. A separate window should pop up. - In both editors try each option: - Confirm the duplicate and go to the existing record. - Deny that the record is duplicate and continue to save. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7889] Use standard style for errors and messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7889 Owen Leonard changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7889] Use standard style for errors and messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7889 --- Comment #1 from Owen Leonard --- Created attachment 9629 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9629&action=edit Bug 7889 - Use standard style for errors and messages Styling subscription renew message according to standard style. Also: - Adding direct link to renew from message suggesting renew. - Adding output of expiration date to message. To test open a subscription with an impending expiration. You should see a dialog-styled message, "Subscription will expire XX/XX/. Renew this subscription." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
