[Koha-bugs] [Bug 7919] Display of values depending on the connexion librairy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Paul Poulain changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #14 from Paul Poulain --- Extensive testing this patch that has not been QAed yet, signed-off since 1 month and a half. QA Comments 1 Patch applies with a small conflict I've solved 2 Usability comment: If there is a library limit on a given value, there's nothing specific displayed on lists in admin. It would be worth to have a column with applicable branches for each value -when there are-. Not worth failing QA though 3 tested = updated a category only visible to librarians from library B. Being connected as librarian from library A, reaching members pages, and checked I can't see this category. 4 tested = adding a limit to afr authorised_values LANG, connected to 101$a (language in UNIMARC). In addbiblio.pl, all the lists appear as empty !!! switching back to master it work well. Seems it's because of the SQL that is built, that returns nothing: SELECT id,authorised_value, lib FROM authorised_values RIGHT JOIN authorised_values_branches ON ( id = av_id AND ( branchcode = 'BDP' OR branchcode IS NULL ) ) WHERE category = 'LANG' GROUP BY lib ORDER BY lib, lib_opac; 5 perlcritic, valid-templates, translatable-templates OK Without point 4, this would have earned QA, but with point 4, it's failed QA, sorry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7919] Display of values depending on the connexion librairy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Paul Poulain changed: What|Removed |Added Attachment #9973|0 |1 is obsolete|| --- Comment #13 from Paul Poulain --- Comment on attachment 9973 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9973 Bug 7919 : Display of values depending on the connexion librairy Display of values depending on the connexion librairy obsoleted by signed off patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7919] Display of values depending on the connexion librairy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 delaye changed: What|Removed |Added Attachment #9973|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7919] Display of values depending on the connexion librairy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 delaye changed: What|Removed |Added Attachment #9984|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7919] Display of values depending on the connexion librairy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 delaye changed: What|Removed |Added Attachment #10424|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7919] Display of values depending on the connexion librairy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 --- Comment #12 from Paul Poulain --- Created attachment 10424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10424&action=edit Bug 8272 - OPAC : date expiration format Adding TT date filter to output of expiration date on OPAC user page. Signed-off-by: Chris Cormack Signed-off-by: Delaye Stephane Signed-off-by: Paul Poulain Signed-off-by: Delaye Stephane -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7919] Display of values depending on the connexion librairy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Paul Poulain changed: What|Removed |Added Attachment #9984|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7919] Display of values depending on the connexion librairy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 --- Comment #11 from Paul Poulain --- Patch tested with a sandbox, by Delaye Stephane -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7919] Display of values depending on the connexion librairy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 delaye changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7919] Display of values depending on the connexion librairy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Paul Poulain changed: What|Removed |Added Status|In Discussion |Failed QA --- Comment #10 from Paul Poulain --- I agree with Jonathan's comment here : it is as clean as possible with the current code imo. Rewritting it "from scratch" is another thing. Maybe, as we spoke of the Koha:: during the hackfest, that's something that could emerge here. But it's another topic. I propose to Switch back to "signed off" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7919] Display of values depending on the connexion librairy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 --- Comment #9 from Jonathan Druart --- (In reply to comment #8) Hi Ian, Yes you are right, it is not very clean. But... it is Koha and I cannot find 10 days to rewrite completely an Authorised Values module. I don't know how filter authorised values functions of the branch level without adding a join on each SELECT query. The authorised value management is, for me, one of the most dirty part of Koha and it could be difficult to make something clean. Likewise, I do not know how it is possible to filter elements simply (here AV, borrower attributes, categories, what else do you think about ?), with the current code of Koha. > I'd like to see clean, well thought out approach that can handle these use > cases and many others with one approach How do you see this approach ? Thanks for your review :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7919] Display of values depending on the connexion librairy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Ian Walls changed: What|Removed |Added Status|Signed Off |In Discussion CC||r...@bywatersolutions.com --- Comment #8 from Ian Walls --- I'm all for having more granular control of system features on the branch level, but this patch seems to be doing it in a very ad-hoc, bolt-on way for only certain features. There are lots of other things that would be good to control on a per-branch level, and I'd like to see clean, well thought out approach that can handle these use cases and many others with one approach. While it's certainly more work to do it this way, it would lead to more uniform, clean and understandable code, with lower maintenance costs and better extensibility. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7919] Display of values depending on the connexion librairy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 --- Comment #7 from Paul Poulain --- Created attachment 9984 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9984&action=edit Bug 7919 : Display of values depending on the connexion librairy In a librairies network, we would like to declare specific values just for one (or more) librairy. Here we implement the ability to associate categories, patron attributes types and/or authorised_values with librairies (branches). This patch adds 3 new association tables: - categories_branches ( association table between categories and branches ) - authorised_values_branches ( association table between authorised_values and branches ) - borrower_attribute_types_branches (association table between borrower_attribute_types and branches ) Plan test: - Create (or modify) categories, patron attributes and authorised_values and link it with one (or more) library. - Set one of these librairies - Go to one of the multiple pages where this specific value must be displayed and check that it does appear. - Set a librairy not concerned. - Check on the same pages this value is doest not appear. A page list: cataloguing/addbiblio.pl cataloguing/additems.pl members/members-home.pl members/memberentry.pl acqui/neworderempty.pl tools/import_borrowers.pl and others :) Please say me if filters don't work on some pages. Signed-off-by: Delaye Stephane -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7919] Display of values depending on the connexion librairy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Paul Poulain changed: What|Removed |Added Attachment #9973|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7919] Display of values depending on the connexion librairy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Paul Poulain changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||paul.poul...@biblibre.com --- Comment #6 from Paul Poulain --- Patch tested with a sandbox, by Delaye Stephane -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7919] Display of values depending on the connexion librairy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jonathan Druart changed: What|Removed |Added Attachment #9170|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 9973 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9973&action=edit Bug 7919 : Display of values depending on the connexion librairy Display of values depending on the connexion librairy Rebased patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7919] Display of values depending on the connexion librairy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 --- Comment #4 from delaye --- I do not have the 3 tables(categories_branches,authorised_values_branches,borrower_attribute_types_branches) in my database after apply the patch in a sandbox ; so I can not test. Can you give me the script mysql to add the tables in the database? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7919] Display of values depending on the connexion librairy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7919] Display of values depending on the connexion librairy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jonathan Druart changed: What|Removed |Added Attachment #8939|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 9170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9170&action=edit Bug 7919 :Bug 7919 : Display of values depending on the connexion librairy Display of values depending on the connexion librairy Rebased patch Stephane, I don't understand your error. Could you check if your database contains the 3 association tables added by this patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7919] Display of values depending on the connexion librairy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 delaye changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #2 from delaye --- i have this error message when i go in ..cgi-bin/koha/members/members-home.pl Software error: Can't use an undefined value as an ARRAY reference at /home/koha/src/C4/Category.pm line 86. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7919] Display of values depending on the connexion librairy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 delaye changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7919] Display of values depending on the connexion librairy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 --- Comment #1 from Jonathan Druart --- Created attachment 8939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8939&action=edit Bug 7919 : Display of values depending on the connexion librairy In a librairies network, we would like to declare specific values just for one (or more) librairy. Here we implement the ability to associate categories, patron attributes types and/or authorised_values with librairies (branches). This patch adds 3 new association tables: - categories_branches ( association table between categories and branches ) - authorised_values_branches ( association table between authorised_values and branches ) - borrower_attribute_types_branches (association table between borrower_attribute_types and branches ) Plan test: - Create (or modify) categories, patron attributes and authorised_values and link it with one (or more) library. - Set one of these librairies - Go to one of the multiple pages where this specific value must be displayed and check that it does appear. - Set a librairy not concerned. - Check on the same pages this value is doest not appear. A page list: cataloguing/addbiblio.pl cataloguing/additems.pl members/members-home.pl members/memberentry.pl acqui/neworderempty.pl tools/import_borrowers.pl and others ? Please say me if filters don't work on some pages. Take no account of filters on item types. They are not impletemented by this development -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7919] Display of values depending on the connexion librairy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jonathan Druart changed: What|Removed |Added Summary|Display the Codes koha |Display of values depending |according to connexion |on the connexion librairy |libraries | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
