[Koha-bugs] [Bug 8045] Problems on Due date when checking in

2012-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8045

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||paul.poul...@biblibre.com
Version|master  |rel_3_8

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8045] Problems on Due date when checking in

2012-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8045

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #11 from Chris Cormack ch...@bigballofwax.co.nz ---
Bugfix will be in 3.8.1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8045] Problems on Due date when checking in

2012-05-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8045

Ian Walls koha.sek...@gmail.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||koha.sek...@gmail.com

--- Comment #10 from Ian Walls koha.sek...@gmail.com ---
Clones start and end dates, which prevents any leaked modifications to the
object.  Marking as Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8045] Problems on Due date when checking in

2012-05-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8045

--- Comment #4 from Adrien SAURAT adrien.sau...@biblibre.com ---
Looks like the problem comes from the _FixFineDaysOnReturn function in
Circulation.pm

The commit mentionned by Owen is pushed but the bug 5549 is still only signed
off. Are the houly loans partly implemented ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8045] Problems on Due date when checking in

2012-05-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8045

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #5 from Chris Cormack ch...@bigballofwax.co.nz ---
No the patch on there is a further enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8045] Problems on Due date when checking in

2012-05-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8045

--- Comment #6 from Adrien SAURAT adrien.sau...@biblibre.com ---
Ok.

What I see is that after the following line :
my $dt_due =  dt_from_string( $datedue );

the $datedue value is broken, getting the value of today. Is dt_from_string
really supposed to work this way?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8045] Problems on Due date when checking in

2012-05-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8045

--- Comment #7 from Adrien SAURAT adrien.sau...@biblibre.com ---
I misread some logs, the error actually comes from the following line in
_FixFineDaysOnReturn:

my $deltadays = $calendar-days_between( $dt_due, $dt_today );

When calculating the delay for the fine management, the due date is modified.
I'm not familiar with these dates handling and I'm not sure yet of the best
fix. I keep looking at it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8045] Problems on Due date when checking in

2012-05-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8045

--- Comment #8 from Adrien SAURAT adrien.sau...@biblibre.com ---
Created attachment 9428
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9428action=edit
proposed patch #1

The due date was sent as a DateTime object parameter to the method
days_between in Koha/Calendar.pm and was altered in the process.
Added cloning to prevent this behaviour.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8045] Problems on Due date when checking in

2012-05-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8045

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

   Attachment #9428|0   |1
is obsolete||

--- Comment #9 from Nicole C. Engard neng...@gmail.com ---
Created attachment 9429
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9429action=edit
[SIGNED-OFF] Bug 8045: fixes date due when checking in

Added cloning of object parameters in days_between method.

Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com

Checked in items that were overdue, due in the future and not
checked out and all showed the right info in the check in
table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8045] Problems on Due date when checking in

2012-05-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8045

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8045] Problems on Due date when checking in

2012-05-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8045

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8045] Problems on Due date when checking in

2012-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8045

--- Comment #1 from Adrien SAURAT adrien.sau...@biblibre.com ---
CORRECTION:
The bug only appears when the document is late, and the displayed date is then
the date of tomorrow.
Only one problem then. And no question about the solution.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8045] Problems on Due date when checking in

2012-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8045

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 CC||neng...@gmail.com

--- Comment #2 from Owen Leonard oleon...@myacpl.org ---
*** Bug 8046 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8045] Problems on Due date when checking in

2012-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8045

--- Comment #3 from Owen Leonard oleon...@myacpl.org ---
I suspect this commit: 99eccc18ed4a21fa416a3d61fed3f70825dc2203 (Bug 5549), but
it's hard to tell because I can't even open returns.pl under that revision
(Undefined subroutine main::now called at
/home/oleonard/kohaclone/circ/returns.pl line 180.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/