[Koha-bugs] [Bug 8137] Checkout limit for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Thibaud Guillot changed: What|Removed |Added Attachment #169927|0 |1 is obsolete|| --- Comment #122 from Thibaud Guillot --- Created attachment 169928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169928=edit Bug 8137: Add 'global checkout limits' table The aim here is to avoid the accumulation of checkouts possibilities through the rules of the various branches, in order to have a global quota. Test plan: 1) Apply this patch 2) Run updatedatabase script and rebuild schema, restart_all.. 3) On circulation rules page you will find a new table "Global checkout limits". 4) If you enter values, they will overwrite the existing values, creating limits for all branches combined. 5) Test it by set a "current checkouts allowed" to 2 on "standard rules section" and set a "global" maxissueqty to 1. Normally 1 is the new limit for now. 6) You can also add a "current checkouts allowed" on other branches and see that you can't accumulate checkouts (you can also delete "global" values and see that if you have 3 on a branch and 2 on other, you can perform 5 checkouts in total. 7) Note that on specific branch circulation rules page the table cannot be modified, but just shown as a reminder. If main matrix is empty on specific branch the table is hidden by default (cause if none values it's referred to standard rules). Sponsored-by: BibLibre -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 --- Comment #121 from Thibaud Guillot --- Hello Thank you for your very interesting feedback.. Indeed, integrating it directly with get_effective_rule makes it possible to lighten the logic and not touch the TooMany function in the way I did.. So I decided to draw up a new table in the "standard rules" section. He's going to define maxissueqty and maxonsiteissueqty as "priority". These rules take over others less specific I think (but maybe I'm wrong) that there is no need to define patron_maxissueqty and patron_maxonsiteissueqty in this case. The table is displayed as a reminder on the specific pages of each library but hidden if no rules from this library are defined in the main matrix, and displayed but not editable otherwise. I have repeated this dev several times, normally I have not left too much trace of the previous patches but if there is an error of logic forgive me I have had my head upside down in the circulation rules lol. I know that tests should be added but I already prefer to give you an overview of the rendering if we go on this way. Thank you for your feedback to everyone! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Thibaud Guillot changed: What|Removed |Added Attachment #169727|0 |1 is obsolete|| --- Comment #120 from Thibaud Guillot --- Created attachment 169927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169927=edit Bug 8137: Add 'global checkout limits' table The aim here is to avoid the accumulation of checkouts possibilities through the rules of the various branches, in order to have a global quota. Test plan: 1) Apply this patch 2) Run updatedatabase script and rebuild schema, restart_all.. 3) On circulation rules page you will find a new table "Global checkout limits". 4) If you enter values, they will overwrite the existing values, creating limits for all branches combined. 5) Test it by set a "current checkouts allowed" to 2 on "standard rules section" and set a "global" maxissueqty to 1. Normally 1 is the new limit for now. 6) You can also add a "current checkouts allowed" on other branches and see that you can't accumulate checkouts (you can also delete "global" values and see that if you have 3 on a branch and 2 on other, you can perform 5 checkouts in total. 7) Note that on specific branch circulation rules page the table cannot be modified, but just shown as a reminder. If main matrix is empty on specific branch the table is hidden by default (cause if none values it's referred to standard rules). Sponsored-by: BibLibre -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Thibaud Guillot changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 --- Comment #119 from Katrin Fischer --- I agree with Nick about it being a separate thing would be better and apply to more use cases. I think the "all libraries" is a bit confusing as it seems to move into a mix of "fallback when nothing is set" and "global total over all libraries". Making sure we know which is what is important here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Nick Clemens (kidclamp) changed: What|Removed |Added Status|Needs Signoff |In Discussion --- Comment #118 from Nick Clemens (kidclamp) --- I have reservations about adding a new dimension to the circulation rules matrix with the "has priority" option. I almost feel it should be its own section, only on the "Standard rules for all libraries" page - and call "Global checkout limits" if that is what the intended outcome is. I won't necessarily block on the concept, but there are some key things I think need to be addressed if this is going to move forward: 1 - The priority rules should not be determined in "TooMany" - but in 'get_effective_rule'. The name of that routine makes it clear, it should be the routine with all the calculations, and should be the single way of determining the correct rule to apply 2 - 'Default checkout,hold and return policy' has three hold options that are not affected by 'has_priority' and this needs to be visually clear to the user 3 - The rules from this page must be shown on the individual libraries rules page - otherwise they can setup options, but not understand that they are being overridden by a special set of rules -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Thibaud Guillot changed: What|Removed |Added Attachment #169700|0 |1 is obsolete|| --- Comment #117 from Thibaud Guillot --- Created attachment 169727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169727=edit Bug 8137: Add 'global' has_priority rules for checkouts The aim here is to avoid the accumulation of checkouts possibilities through the rules of the various branches, in order to have a global quota. Test plan: 1) - Set for library "A" a max checkouts allowed to 3 for any categorycode on "Default checkout, hold and return policy" - Set for library "B" a max checkouts allowed to 2 for any categorycode on "Default checkout, hold and return policy" 2) Currently you can accumulate on each branch to get 5 checkouts in this test. 3) Apply this patch 4) Run updatedatabase script and rebuild schema, restart_all.. 5) Now you have a "Priority checkouts rule" checkboxes on the main circulation rules table, "Default checkouts[..]" table and the same by categorycode below (only on "Standard rules for all librairies" select option). 6) If checked on save, these rules will override global max checkouts allowed even if you try to check out from different librairy. 7) According to this test plan, if you set a "global" max checkouts to 2 you can only perform 2 checkouts and not more if you try on another lib. Try it on main circulation rules table and 2 defaults... Sponsored-by: BibLibre -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Thibaud Guillot changed: What|Removed |Added Attachment #169696|0 |1 is obsolete|| --- Comment #116 from Thibaud Guillot --- Created attachment 169700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169700=edit Bug 8137: Add 'global' has_priority rules for checkouts The aim here is to avoid the accumulation of checkouts possibilities through the rules of the various branches, in order to have a global quota. Test plan: 1) - Set for library "A" a max checkouts allowed to 3 for any categorycode on "Default checkout, hold and return policy" - Set for library "B" a max checkouts allowed to 2 for any categorycode on "Default checkout, hold and return policy" 2) Currently you can accumulate on each branch to get 5 checkouts in this test. 3) Apply this patch 4) Run updatedatabase script and rebuild schema, restart_all.. 5) Now you have a "Priority checkouts rule" checkboxes on the main circulation rules table, "Default checkouts[..]" table and the same by categorycode below (only on "Standard rules for all librairies" select option). 6) If checked on save, these rules will override global max checkouts allowed even if you try to check out from different librairy. 7) According to this test plan, if you set a "global" max checkouts to 2 you can only perform 2 checkouts and not more if you try on another lib. Try it on main circulation rules table and 2 defaults... Sponsored-by: BibLibre -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Thibaud Guillot changed: What|Removed |Added Attachment #167923|0 |1 is obsolete|| Attachment #168119|0 |1 is obsolete|| Attachment #169084|0 |1 is obsolete|| --- Comment #115 from Thibaud Guillot --- Created attachment 169696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169696=edit Bug 8137: Add 'global' has_priority rules for checkouts The aim here is to avoid the accumulation of checkouts possibilities through the rules of the various branches, in order to have a global quota. Test plan: 1) - Set for library "A" a max checkouts allowed to 3 for any categorycode on "Default checkout, hold and return policy" - Set for library "B" a max checkouts allowed to 2 for any categorycode on "Default checkout, hold and return policy" 2) Currently you can accumulate on each branch to get 5 checkouts in this test. 3) Apply this patch 4) Run updatedatabase script and rebuild schema, restart_all.. 5) Now you have a "Priority checkouts rule" checkboxes on the main circulation rules table, "Default checkouts[..]" table and the same by categorycode below (only on "Standard rules for all librairies" select option). 6) If checked on save, these rules will override global max checkouts allowed even if you try to check out from different librairy. 7) According to this test plan, if you set a "global" max checkouts to 2 you can only perform 2 checkouts and not more if you try on another lib. Try it on main circulation rules table and 2 defaults... Sponsored-by: BibLibre -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 --- Comment #114 from Thibaud Guillot --- Created attachment 169084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169084=edit Bug 8137: Add 'global' has_priority rules for checkouts The aim here is to avoid the accumulation of checkouts possibilities through the rules of the various branches, in order to have a global quota. Test plan: 1) - Set for library "A" a max checkouts allowed to 3 for any categorycode on "Default checkout, hold and return policy" - Set for library "B" a max checkouts allowed to 2 for any categorycode on "Default checkout, hold and return policy" 2) Currently you can accumulate on each branch to get 5 checkouts in this test. 3) Apply this patch 4) Run updatedatabase script and rebuild schema, restart_all.. 5) Now you have a "Priority checkouts rule" checkboxes on "Default checkouts[..]" table and the same by categorycode below (only on "Standard rules for all librairies" section). 6) If checked on save, these rules will override global max checkouts allowed even if you try to check out from different librairy. 7) According to this test plan, if you set a "global" max checkouts to 2 you can only perform 2 checkouts and not more if you try on another lib. Try on the both tables (by defaults and by defaults/categorycode). Sponsored-by: BibLibre -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Thibaud Guillot changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 David Nind changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #113 from David Nind --- Thanks Thibaud! I'm still getting this error for steps 5 and 6: DBIx::Class::Row::store_column(): No such column 'has_priority' on Koha::Schema::Result::CirculationRule at /kohadevbox/koha/Koha/Object.pm line 81 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 I thought that it may be because when running dbic, it ends with this: Dumping manual schema for Koha::Schema to directory ./ ... DBIx::Class::Schema::Loader::make_schema_at(): Checksum mismatch in './/Koha/Schema/Result/CourseItem.pm', the auto-generated part of the file has been modified outside of this loader. Aborting. If you want to overwrite these modifications, set the 'overwrite_modifications' loader option. However, I get that as well running dbic without the patch. So maybe an issue with KTD? I also tried running dbic --force - I no longer got the error at the end when running dbic, however the error for steps 5 and 6 still occurs. Testing notes so far (using KTD): 1. Clone the rules that apply to all libraries to Centerville. 2. Edit the Centerville All All rule to change both "Current checkouts allowed" and "Current on-site checkouts allowed" to 3. 3. For the "Standard rule for all libraries", change both "Current checkouts allowed" and "Current on-site checkouts allowed" to 2. 4. With the library set to Centerville, check out three items to Mary. Try to check out a fourth item - you get a message: Please confirm checkout Too many checked out. 3 checked out, only 3 are allowed. Maximum checkouts calculated from the circulation rule for Item type: All item types Patron category: All patron categories Library: Centerville Yes, check out (Y) No, don't check out (N) 4. Change the library to Midway and try to check out another item - you get this message: Please confirm checkout Too many checked out. 3 checked out, only 2 are allowed. Maximum checkouts calculated from the circulation rule for Item type: All item types Patron category: All patron categories Library: All libraries Yes, check out (Y) No, don't check out (N) 5. Apply the patch 6. Update the database: updatedatabase 7. Run dbic: dbic 8. Clear the cache: flush_memcached 9. Restart everything: restart_all 10. Clear your browser cache. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 --- Comment #112 from Thibaud Guillot --- Created attachment 168119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168119=edit Bug 8137: (follow-up) fix search params on get_effective_rule -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Thibaud Guillot changed: What|Removed |Added Attachment #167208|0 |1 is obsolete|| --- Comment #111 from Thibaud Guillot --- Created attachment 167923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167923=edit Bug 8137: Add 'global' has_priority rules for checkouts I tried to review the desired behavior through this bug. The goal would be to be able to have a general 'override' rule. Currently, if you set a max_checkouts_allowed of 5 (regardless of itemtype) in one library, for example, and do the same in another, it adds up to 10. By giving checkout rules priority, you "overwrite" other local rules per branchcode. Test plan: 1) Set for library "A" a max_checkouts_allowed to 3 for any type of user and item type. 2) On main rules set the same rule to 2 3) Do a few checkouts with a user belonging to library A, normally you'll be able to do 3. 4) Apply this patch and run updatedatabase.pl and also rebuild your schema by updating dbix class files 5) See now the Has priority checkboxes on "Default checkout, hold and return policy" and "Default checkout, hold policy by patron category" 6) You can set here you new rule for "Total current checkouts allowed" to 2 7) Repeat step 3 and normally you won't be able to make the third Sponsored-by: BibLibre -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Thibaud Guillot changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 David Nind changed: What|Removed |Added CC||da...@davidnind.com Status|Needs Signoff |Failed QA --- Comment #110 from David Nind --- I've tested as well, and get the same error. Changing status to Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 --- Comment #109 from Brendan Lawlor --- (In reply to Thibaud Guillot from comment #108) > 4) Apply this patch and run updatedatabase.pl and also rebuild your >schema by updating dbix class files I tried testing this patch but had trouble with this part. Testing in ktd, I applied the patch and ran these commands updatedatabase DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/Bug_8137-add-column-has_priority.pl [13:35:41]: Bug 8137 - Add column has_priority Added column 'has_priority dbic ... lots of output... Dumping manual schema for Koha::Schema to directory ./ ... Schema dump completed Then restart_all But when I tried to check the has priority box and save I got this error: DBIx::Class::Row::store_column(): No such column 'has_priority' on Koha::Schema::Result::CirculationRule at /kohadevbox/koha/Koha/Object.pm line 81 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 I tried clearing my browser cache but got the same error. Am I missing a step? I'd be happy to test this again because it's an important bug fix for our libraries. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Koha collecto changed: What|Removed |Added CC||k...@collecto.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Thibaud Guillot changed: What|Removed |Added Attachment #162367|0 |1 is obsolete|| --- Comment #108 from Thibaud Guillot --- Created attachment 167208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167208=edit Bug 8137: Add 'global' has_priority rules for checkouts I tried to review the desired behavior through this bug. The goal would be to be able to have a general 'override' rule. Currently, if you set a max_checkouts_allowed of 5 (regardless of itemtype) in one library, for example, and do the same in another, it adds up to 10. By giving checkout rules priority, you "overwrite" other local rules per branchcode. Test plan: 1) Set for library "A" a max_checkouts_allowed to 3 for any type of user and item type. 2) On main rules set the same rule to 2 3) Do a few checkouts with a user belonging to library A, normally you'll be able to do 3. 4) Apply this patch and run updatedatabase.pl and also rebuild your schema by updating dbix class files 5) See now the Has priority checkboxes on "Default checkout, hold and return policy" and "Default checkout, hold policy by patron category" 6) You can set here you new rule for "Total current checkouts allowed" to 2 7) Repeat step 3 and normally you won't be able to make the third Sponsored-by: BibLibre -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Thibaud Guillot changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 --- Comment #107 from Lisette Scheer --- I went to test again and patch no longer applies. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 pierre.ge...@biblibre.com changed: What|Removed |Added CC||pierre.ge...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Brendan Lawlor changed: What|Removed |Added CC||blaw...@clamsnet.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Michelle Spinney changed: What|Removed |Added CC||mspin...@clamsnet.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Lisette Scheer changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #106 from Lisette Scheer --- Applying: Bug 8137: Add 'global' has_priority rules for checkouts Using index info to reconstruct a base tree... M C4/Circulation.pm M admin/smart-rules.pl M koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt .git/rebase-apply/patch:315: new blank line at EOF. + warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt Auto-merging admin/smart-rules.pl Auto-merging C4/Circulation.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 8137: Add 'global' has_priority rules for checkouts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 --- Comment #105 from Thibaud Guillot --- (In reply to Lisette Scheer from comment #103) > Template process failed: undef error - The method > Koha::CirculationRule->has_priority is not covered by tests! > > Trace begun at /kohadevbox/koha/Koha/Object.pm line 964 > > Once I try selecting the priority box and saving, my smart-rules.pl > completely breaks. Hi Lisette, Thanks for testing and feedback :) So did you forget to update your schema ? I apply another time and its work great for me. I rebased on master and I took the opportunity to indent some lines. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Thibaud Guillot changed: What|Removed |Added Attachment #159712|0 |1 is obsolete|| --- Comment #104 from Thibaud Guillot --- Created attachment 162367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162367=edit Bug 8137: Add 'global' has_priority rules for checkouts I tried to review the desired behavior through this bug. The goal would be to be able to have a general 'override' rule. Currently, if you set a max_checkouts_allowed of 5 (regardless of itemtype) in one library, for example, and do the same in another, it adds up to 10. By giving checkout rules priority, you "overwrite" other local rules per branchcode. Test plan: 1) Set for library "A" a max_checkouts_allowed to 3 for any type of user and item type. 2) On main rules set the same rule to 2 3) Do a few checkouts with a user belonging to library A, normally you'll be able to do 3. 4) Apply this patch and run updatedatabase.pl and also rebuild your schema by updating dbix class files 5) See now the Has priority checkboxes on "Default checkout, hold and return policy" and "Default checkout, hold policy by patron category" 6) You can set here you new rule for "Total current checkouts allowed" to 2 7) Repeat step 3 and normally you won't be able to make the third Sponsored-by: BibLibre -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Thibaud Guillot changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Lisette Scheer changed: What|Removed |Added CC||lisette.scheer@bywatersolut ||ions.com Status|Needs Signoff |Failed QA --- Comment #103 from Lisette Scheer --- Template process failed: undef error - The method Koha::CirculationRule->has_priority is not covered by tests! Trace begun at /kohadevbox/koha/Koha/Object.pm line 964 Once I try selecting the priority box and saving, my smart-rules.pl completely breaks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 --- Comment #102 from Thibaud Guillot --- During my test, in some use cases I got a "brake foreign key error" without really knowing why, so this is a reworking of the bug in order to bring a different solution and get your feedback so we can move it forward. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Thibaud Guillot changed: What|Removed |Added Summary|Checkout limit by patron|Checkout limit for all |category for all libraries |libraries -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
