[Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly.

2014-02-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220

Galen Charlton  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly.

2013-03-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly.

2013-03-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #28 from Jared Camins-Esakov  ---
This patch has been pushed to master.

I did not test this since I have a Mac and no VMs suitable for testing the KOC
application at the moment, but as it is non-core and has been well-tested by
Katrin and Bob I am pushing it as-is.

A nice follow-up bug might remove the extra variable(s) in the pl file (our
$dbh, possibly others).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly.

2013-03-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220

--- Comment #27 from Katrin Fischer  ---
Created attachment 16232
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16232&action=edit
[PASSED QA] Bug 8220 - QA Followup - Unit Test

Signed-off-by: Katrin Fischer 

All tests and qa script pass.

Tests done:
- created a .koc file with return, issue and fine payments.
- queued that file into Koha
- created some transactions using the Firefox plugin
- queued that into Koha
- processed files and checked outcome was ok

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly.

2013-03-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #16156|0   |1
is obsolete||
  Attachment #16157|0   |1
is obsolete||

--- Comment #26 from Katrin Fischer  ---
Created attachment 16230
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16230&action=edit
[PASSED QA] Bug 8220 - Allow koc uploads to go to process queue instead of
being applied directly.

The primary advantage to the Firefox offline cirulation plugin when compared
to the offline circulation desktop application, is the ability to add offline
circulation actions to a queue so that multiple machines running offline
circ can have their circ actions combined and ordered chronologically before
being executed. This commit adds the ability to put actions from uploaded
KOC files into this queue. In this way, both the FF plugina and the desktop
application can be run side by side with no ill effects.

Signed-off-by: Bob Birchall 
Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly.

2013-03-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly.

2013-03-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220

--- Comment #25 from Katrin Fischer  ---
Attaching rebased patches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly.

2013-03-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220

--- Comment #24 from Katrin Fischer  ---
Created attachment 16157
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16157&action=edit
Bug 8220 - QA Followup - Unit Test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly.

2013-03-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #12310|0   |1
is obsolete||
  Attachment #14014|0   |1
is obsolete||

--- Comment #23 from Katrin Fischer  ---
Created attachment 16156
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16156&action=edit
Bug 8220 - Allow koc uploads to go to process queue instead of being applied
directly.

The primary advantage to the Firefox offline cirulation plugin when compared
to the offline circulation desktop application, is the ability to add offline
circulation actions to a queue so that multiple machines running offline
circ can have their circ actions combined and ordered chronologically before
being executed. This commit adds the ability to put actions from uploaded
KOC files into this queue. In this way, both the FF plugina and the desktop
application can be run side by side with no ill effects.

Signed-off-by: Bob Birchall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly.

2013-03-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220

--- Comment #22 from Katrin Fischer  ---
Comment on attachment 12310
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12310
Bug 8220 - Allow koc uploads to go to process queue instead of being applied
directly.

Review of attachment 12310:
 --> 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=8220&attachment=12310)
-

Hi Kyle,

I started testing with some code review to see what you have done here - I
found some smaller issues. A follow-up resolving them would be good.

::: C4/Circulation.pm
@@ +3334,5 @@
> +my $amount = $operation->{amount};
> +
> +recordpayment( $borrower->{borrowernumber}, $amount );
> +
> +return "Success."

Untranslatable string.

::: installer/data/mysql/updatedatabase.pl
@@ +5830,5 @@
> +$DBversion = "3.09.00.XXX";
> +if (C4::Context->preference("Version") < TransformToNum($DBversion)) {
> +$dbh->do("ALTER TABLE `pending_offline_operations` CHANGE `barcode` 
> `barcode` VARCHAR( 20 ) CHARACTER SET utf8 COLLATE utf8_general_ci NULL 
> DEFAULT NULL");
> +$dbh->do("ALTER TABLE `pending_offline_operations` ADD `amount` DECIMAL( 
> 28, 6 ) NULL DEFAULT NULL");
> +print "Upgrade to $DBversion done (redefine the field branchcode as 
> PRIMARY KEY of branches)\n";

Wrong text in update message.

::: koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/enqueue_koc.tt
@@ +17,5 @@
> +
> +[% FOREACH message IN messages %]
> +  [% IF ( message.message ) %]
> +  [% IF ( message.ERROR_file_version ) %]
> +  Warning: This file is version [% 
> message.upload_version %], but I only know how to import version [% 
> message.current_version %]. I'll try my best.

Missing 

::: offline_circ/enqueue_koc.pl
@@ +18,5 @@
> +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> +#
> +
> +use strict;
> +use warnings;

Maybe better use Modern::Perl?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly.

2013-01-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220

--- Comment #21 from Kyle M Hall  ---
That would be great! I've attached a KOC file that checks out barcodes 1, 2, 3,
4 and 5 to borrower cardnumber 123456789, and returns barcodes 6, 7, 8 and 9.
If you want to change the borrower cardnumber and/or the barcodes, you should
be able to just open the file in any text editor and alter it to your liking.

(In reply to comment #19)
> Kyle, I would be happy to QA this patch, but I need a .koc file to test it,
> could you please attach one ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly.

2013-01-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220

--- Comment #20 from Kyle M Hall  ---
Created attachment 14452
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14452&action=edit
Test KOC File

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly.

2013-01-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220

--- Comment #19 from Paul Poulain  ---
Kyle, I would be happy to QA this patch, but I need a .koc file to test it,
could you please attach one ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly.

2012-12-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220

--- Comment #18 from Katrin Fischer  ---
Thank you for the unit tests, Kyle! :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly.

2012-12-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly.

2012-12-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220

--- Comment #17 from Kyle M Hall  ---
Created attachment 14014
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14014&action=edit
Bug 8220 - QA Followup - Unit Test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly.

2012-12-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220

Paul Poulain  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
   Patch complexity|--- |Medium patch

--- Comment #16 from Paul Poulain  ---
QA comment:
 * passes koha-qa.pl, except for a strange 
valid   FAIL
Subroutine ProcessOfflinePayment redefined 
 * this patch introduces a new sub in C4/Circulation.pm, that has no unit test.
This is a requirement for 3.12

failing QA (I haven't tested the patch yet, the code looks correct)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly.

2012-11-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220

--- Comment #15 from Kyle M Hall  ---
I see no reason to limit libraries to one version or the other. Why put up an
artificial limit?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly.

2012-10-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #14 from Katrin Fischer  ---
Hm, I think the problem is different. As you said, the client version offers
some advanced features, but you run into problems when you use it at more than
one computer. So the patch makes this work (as it does work for the plugin). I
think it fixes a problem people might not be aware of using the client version.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly.

2012-10-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220

--- Comment #13 from Paul Poulain  ---
(In reply to comment #12)
> Are you sure this is an enhancement? It sounds to me like it fixes a bug.
> Without the patch, anyone using both the standalone and FF offline circ
> modules will end up putting their system in an indeterminate state.

I think that's a non-sense to use both systems. Either you want the advanced
features of the standalone, at the price of local install on your system, or
you want the trivial to install & maintain at the price of no local copy of
patrons & other adv features.

So, yes I think it's an ENH

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly.

2012-10-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220

--- Comment #12 from Jared Camins-Esakov  ---
Are you sure this is an enhancement? It sounds to me like it fixes a bug.
Without the patch, anyone using both the standalone and FF offline circ modules
will end up putting their system in an indeterminate state.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly.

2012-09-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly.

2012-09-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #11350|0   |1
is obsolete||

--- Comment #11 from Kyle M Hall  ---
Created attachment 12310
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12310&action=edit
Bug 8220 - Allow koc uploads to go to process queue instead of being applied
directly.

The primary advantage to the Firefox offline cirulation plugin when compared
to the offline circulation desktop application, is the ability to add offline
circulation actions to a queue so that multiple machines running offline
circ can have their circ actions combined and ordered chronologically before
being executed. This commit adds the ability to put actions from uploaded
KOC files into this queue. In this way, both the FF plugina and the desktop
application can be run side by side with no ill effects.

Signed-off-by: Bob Birchall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly.

2012-08-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220

M. de Rooy  changed:

   What|Removed |Added

 QA Contact||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly.

2012-08-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220

M. de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||m.de.r...@rijksmuseum.nl

--- Comment #10 from M. de Rooy  ---
Patch contains merge markers.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly.

2012-08-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220

--- Comment #9 from Bob Birchall  ---
Test 1:  Created two Koc files.  Loaded both to Koha.  Was able to manage the
processing of the files OK.

Test 2:  Used KOC utility to record an issue of an item to a patron.  Saved the
KOC file as file A.  Closed KOC.  Opened KOC again, recorded the return of the
same item.  Saved the KOC file as file B.  Returned to Koha, uploaded file B
first, then file A.  Processed the queue.  Transactions processed in correct
sequence (by timestamp).  All good.

Signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly.

2012-08-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220

--- Comment #8 from Paul Poulain  ---
Created attachment 11350
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11350&action=edit
Bug 8220 - Allow koc uploads to go to process queue instead of being applied
directly.

The primary advantage to the Firefox offline cirulation plugin when compared
to the offline circulation desktop application, is the ability to add offline
circulation actions to a queue so that multiple machines running offline
circ can have their circ actions combined and ordered chronologically before
being executed. This commit adds the ability to put actions from uploaded
KOC files into this queue. In this way, both the FF plugina and the desktop
application can be run side by side with no ill effects.

Signed-off-by: Bob Birchall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly.

2012-08-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220

Paul Poulain  changed:

   What|Removed |Added

  Attachment #10587|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly.

2012-08-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220

Paul Poulain  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||paul.poul...@biblibre.com

--- Comment #7 from Paul Poulain  ---
Patch tested with a sandbox, by Bob Birchall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly.

2012-06-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #6 from Chris Cormack  ---
Patch rebased and merge conflicts fixed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly.

2012-06-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220

Chris Cormack  changed:

   What|Removed |Added

  Attachment #10221|0   |1
is obsolete||

--- Comment #5 from Chris Cormack  ---
Created attachment 10587
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10587&action=edit
Bug 8220 - Allow koc uploads to go to process queue instead of being applied
directly.

The primary advantage to the Firefox offline cirulation plugin when compared
to the offline circulation desktop application, is the ability to add offline
circulation actions to a queue so that multiple machines running offline
circ can have their circ actions combined and ordered chronologically before
being executed. This commit adds the ability to put actions from uploaded
KOC files into this queue. In this way, both the FF plugina and the desktop
application can be run side by side with no ill effects.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly.

2012-06-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220

Bob Birchall  changed:

   What|Removed |Added

 CC||b...@calyx.net.au

--- Comment #4 from Bob Birchall  ---
I ordered a Biblibre sandbox to test this patch.  It appears that the patch did
not apply.  The extra links do not appear on the Circulation page.  The email
from the sandbox creator included the following:

The patches attached to bugzilla 8220 have been applied, and the result is
Something went wrong !Applying: Bug 8220 - Allow koc uploads to go to
process queue instead of being applied directly.
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging C4/Circulation.pm
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in
installer/data/mysql/updatedatabase.pl
Failed to merge in the changes.
Patch failed at 0001 Bug 8220 - Allow koc uploads to go to process queue
instead of being applied directly.
When you have resolved this problem run git am --resolved.
If you would prefer to skip this patch, instead run git am --skip.
To restore the original branch and stop patching run git am --abort.
Bug 8220 - Allow koc uploads to go to process queue instead of being applied
directly.

Bug 8220 - Allow koc uploads to go to process queue instead of being applied
directly.
Apply? [yn] 
Patch left in
/tmp/Bug-8220---Allow-koc-uploads-to-go-to-process-queu-W6oPhU.patch

Unable to sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly.

2012-06-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #10189|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall  ---
Created attachment 10221
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10221&action=edit
Bug 8220 - Allow koc uploads to go to process queue instead of being applied
directly.

The primary advantage to the Firefox offline cirulation plugin when compared
to the offline circulation desktop application, is the ability to add offline
circulation actions to a queue so that multiple machines running offline
circ can have their circ actions combined and ordered chronologically before
being executed. This commit adds the ability to put actions from uploaded
KOC files into this queue. In this way, both the FF plugina and the desktop
application can be run side by side with no ill effects.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly.

2012-06-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly.

2012-06-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #10065|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall  ---
Created attachment 10189
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10189&action=edit
Bug 8220 - Allow koc uploads to go to process queue instead of being applied
directly.

The primary advantage to the Firefox offline cirulation plugin when compared
to the offline circulation desktop application, is the ability to add offline
circulation actions to a queue so that multiple machines running offline
circ can have their circ actions combined and ordered chronologically before
being executed. This commit adds the ability to put actions from uploaded
KOC files into this queue. In this way, both the FF plugina and the desktop
application can be run side by side with no ill effects.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly.

2012-06-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220

--- Comment #1 from Kyle M Hall  ---
Created attachment 10065
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10065&action=edit
Bug 8220 - Allow koc uploads to go to process queue instead of being applied
directly.

The primary advantage to the Firefox offline cirulation plugin when compared
to the offline circulation desktop application, is the ability to add offline
circulation actions to a queue so that multiple machines running offline
circ can have their circ actions combined and ordered chronologically before
being executed. This commit adds the ability to put actions from uploaded
KOC files into this queue. In this way, both the FF plugina and the desktop
application can be run side by side with no ill effects.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly.

2012-06-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |kyle.m.h...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/