subject:"\[Koha\-bugs\] \[Bug 8236\] Prevent renewing if overdue or restriction"

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2017-09-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitai...@ccsr.qc.
   ||ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2015-11-18 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Jenny Dallas  changed:

   What|Removed |Added

 CC||limbo...@gmail.com

--- Comment #96 from Jenny Dallas  ---
I love it! Excellent article. I need help with this too! If you ever need to
fill out a form, here is or http://www.tax.ny.gov/pdf/2003/et/tt86_5_103.pdf; >www.tax.ny.gov a
really useful tool. Very easy to navigate and use.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2015-10-20 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

--- Comment #95 from Tomás Cohen Arazi  ---
Created attachment 43628
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43628=edit
Bug 8236: (QA followup) fix test count error due to bad merge

On rebasing the patchset I introduced a wrong number of tests.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2015-10-19 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #94 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Lyon3 team!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2015-10-18 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

--- Comment #93 from David Cook  ---
Any movement on this one? I'd be keen to see this one go in.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2015-09-14 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Alex Arnaud  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2015-08-27 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Joonas Kylmälä j.kylm...@gmail.com changed:

   What|Removed |Added

  Attachment #41994|0   |1
is obsolete||

--- Comment #92 from Joonas Kylmälä j.kylm...@gmail.com ---
Created attachment 42007
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42007action=edit
Bug 8236 [QA Followup] - Tweak language, fix whitespace error

Changes in the strings look good.

Signed-off-by: Joonas Kylmälä j.kylm...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2015-08-27 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Joonas Kylmälä j.kylm...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2015-08-26 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Alex Arnaud alex.arn...@biblibre.com changed:

   What|Removed |Added

 CC||alex.arn...@biblibre.com
 Status|Patch doesn't apply |Needs Signoff

--- Comment #91 from Alex Arnaud alex.arn...@biblibre.com ---
@Tomás: I've rebased these patches and use atomic updates for the news sysprefs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2015-08-26 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Alex Arnaud alex.arn...@biblibre.com changed:

   What|Removed |Added

  Attachment #37457|0   |1
is obsolete||
  Attachment #37458|0   |1
is obsolete||
  Attachment #37459|0   |1
is obsolete||

--- Comment #88 from Alex Arnaud alex.arn...@biblibre.com ---
Created attachment 41992
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41992action=edit
Bug 8236 Renewing policy in overdue or restriction case

This patch introduces 2 sysprefs :
RestrictionBlockRenewing to allow/block renewal of items when patron is
restricted.
OverduesBlockRenewing to allow, block only the late ones or block all
checked out items
Default is allow in both case.

Signed-off-by: Matthias Meusburger matthias.meusbur...@biblibre.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2015-08-26 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

--- Comment #90 from Alex Arnaud alex.arn...@biblibre.com ---
Created attachment 41994
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41994action=edit
Bug 8236 [QA Followup] - Tweak language, fix whitespace error

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2015-08-26 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

--- Comment #89 from Alex Arnaud alex.arn...@biblibre.com ---
Created attachment 41993
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41993action=edit
Bug 8236: Tests for Renewing policy in overdue or restriction case

- Add tests in t/db_dependent/Circulation.t

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2015-08-11 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Patch doesn't apply
 CC||tomasco...@gmail.com

--- Comment #87 from Tomás Cohen Arazi tomasco...@gmail.com ---
I'm sorry, but can u please rebase it? The updatedatabase.pl issue was trivial
to solve, but such was not the case for the tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2015-04-19 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Tom Misilo misi...@fit.edu changed:

   What|Removed |Added

 CC||misi...@fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2015-04-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

--- Comment #86 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37459
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37459action=edit
Bug 8236 [QA Followup] - Tweak language, fix whitespace error

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2015-04-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

--- Comment #85 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37458
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37458action=edit
[PASSED QA] Bug 8236: Tests for Renewing policy in overdue or restriction case

 - Add tests in t/db_dependent/Circulation.t

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2015-04-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #37407|0   |1
is obsolete||
  Attachment #37418|0   |1
is obsolete||

--- Comment #84 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37457
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37457action=edit
[PASSED QA] Bug 8236 Renewing policy in overdue or restriction case

This patch introduces 2 sysprefs :
RestrictionBlockRenewing to allow/block renewal of items when patron is
restricted.
OverduesBlockRenewing to allow, block only the late ones or block all
checked out items
Default is allow in both case.

Signed-off-by: Matthias Meusburger matthias.meusbur...@biblibre.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2015-04-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2015-04-01 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

--- Comment #83 from Matthias Meusburger matthias.meusbur...@biblibre.com ---
Created attachment 37418
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37418action=edit
Bug 8236: Tests for Renewing policy in overdue or restriction case

 - Add tests in t/db_dependent/Circulation.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2015-03-31 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

--- Comment #82 from Matthias Meusburger matthias.meusbur...@biblibre.com ---
Created attachment 37407
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37407action=edit
[SIGNED-OFF] Bug 8236 Renewing policy in overdue or restriction case

This patch introduces 2 sysprefs :
RestrictionBlockRenewing to allow/block renewal of items when patron is
restricted.
OverduesBlockRenewing to allow, block only the late ones or block all
checked out items
Default is allow in both case.

Signed-off-by: Matthias Meusburger matthias.meusbur...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2015-03-31 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Matthias Meusburger matthias.meusbur...@biblibre.com changed:

   What|Removed |Added

 CC||matthias.meusburger@biblibr
   ||e.com

--- Comment #81 from Matthias Meusburger matthias.meusbur...@biblibre.com ---
I've tested the last version of this patch following the more recent test plan
provided.

Everything works to me.

I'm signing off the patch.

Can someone have a look at the QA? (Should not be much, as most of the problems
were already addressed)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2015-03-31 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Matthias Meusburger matthias.meusbur...@biblibre.com changed:

   What|Removed |Added

  Attachment #36743|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2015-03-31 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Matthias Meusburger matthias.meusbur...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2015-03-09 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

  Attachment #36674|0   |1
is obsolete||

--- Comment #80 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
Created attachment 36743
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36743action=edit
Bug 8236 Renewing policy in overdue or restriction case

grrrmm...  silly error on calling HasOverdues function. patch redone

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2015-03-06 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2015-03-06 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

  Attachment #35372|0   |1
is obsolete||

--- Comment #78 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
Created attachment 36674
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36674action=edit
Bug 8236 Renewing policy in overdue or restriction case

patch rebased

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2015-03-06 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

delaye stephane.del...@biblibre.com changed:

   What|Removed |Added

 CC||stephane.del...@biblibre.co
   ||m

--- Comment #79 from delaye stephane.del...@biblibre.com ---
after apply the patch i can't see the items in the account borrower ; i have
the message loading... so i can't apply the test plan...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2015-03-04 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2015-03-04 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Aurélie Fichot aurelie.fic...@iepg.fr changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #77 from Aurélie Fichot aurelie.fic...@iepg.fr ---
The sandbox you've requested is not ready.
Some problems occurred applying patches from bug 8236:
h1Something went wrong !/h1Applying: Bug 8236 Renewing policy in overdue or
restriction case
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/sysprefs.sql
Auto-merging C4/Circulation.pm
Failed to merge in the changes.
Patch failed at 0001 Bug 8236 Renewing policy in overdue or restriction case

When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Bug 8236 - Prevent renewing if overdue or restriction

35372 - Bug 8236 Renewing policy in overdue or restriction case

Apply? [(y)es, (n)o, (i)nteractive] Patch left in
/tmp/Bug-8236-Renewing-policy-in-overdue-or-restriction-Gwo9FG.patch .

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2015-01-29 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Marjorie Barry-Vila marjorie.barry-v...@ccsr.qc.ca changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2015-01-19 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

  Attachment #34322|0   |1
is obsolete||

--- Comment #76 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
Created attachment 35372
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35372action=edit
Bug 8236 Renewing policy in overdue or restriction case

patch rebased

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2015-01-16 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

--- Comment #75 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
(In reply to Kyle M Hall from comment #74)
 If I choose only this item for OverduesBlockRenewing, all my items are
 blocked from renewal.

I tested again and it's still OK. I can't see why you could have this result.
Could you be more precise ? is it on the personnal file, on the pro interface ?
some other clue ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2014-12-19 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #74 from Kyle M Hall k...@bywatersolutions.com ---
If I choose only this item for OverduesBlockRenewing, all my items are blocked
from renewal.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2014-12-11 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

sandbo...@biblibre.com sandbo...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #71 from sandbo...@biblibre.com sandbo...@biblibre.com ---
Patch tested with a sandbox, by Rémy-Juliette juliette.lev...@iepg.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2014-12-11 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

--- Comment #72 from sandbo...@biblibre.com sandbo...@biblibre.com ---
Created attachment 34322
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34322action=edit
Bug 8236 Renewing policy in overdue or restriction case

This patch introduces 2 sysprefs :
RestrictionBlockRenewing to allow/block renewal of items when patron is
restricted.
OverduesBlockRenewing to allow, block only the late ones or block all
checked out items
Default is allow in both case.

Signed-off-by: R

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2014-12-11 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

sandbo...@biblibre.com sandbo...@biblibre.com changed:

   What|Removed |Added

  Attachment #34234|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2014-12-11 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Levast juliette.lev...@iepg.fr changed:

   What|Removed |Added

 CC||juliette.lev...@iepg.fr

--- Comment #73 from Levast juliette.lev...@iepg.fr ---
This patch works perfectly. He answers all our needs and it is essential for
our users. Hoping it quickly pushed master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2014-12-09 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

  Attachment #22280|0   |1
is obsolete||

--- Comment #70 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
Created attachment 34234
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34234action=edit
Bug 8236 Renewing policy in overdue or restriction case

The patch have been remade again in a slight different way :
It now introduces 2 sysprefs :
RestrictionBlockRenewing to allow/block renewal of items when patron is
restricted.
OverduesBlockRenewing to allow, block only the late ones or block all
checked out items.
Default is allow in both case.

Test Plan :
Apply patch.
The database must then be updated (so it cannot be tested on sandbox unless you
asked the maintainer for doing so).

RestrictionBlockRenewing is set by default to allow renewing of late items :
1) choose a borrowernumber (you also need his login and password) and  2 items
: item1 and item2.
2) check out item1
3) check out item2 with an already passed due date (using the Specify-due-date
box)
4) click on restritions tab and add a manual restriction
You can see that renewal is still possible for both items.
5) Now go to set the syspref to block status and go back to patron's account :
You can see a not renewable : patron restricted warning instead of the
previous checkboxes.
6) check the Override renewal limit checkbox tand verify that renewing is
still possible by this way

OverduesBlockRenewing is set by default to allow renewing of late items :
7)Now remove the restriction, set the OverdueBlockRenewing syspref to Block
renewal only for late items and go back to patron's professionnal page
8) The renewal is possible  for item1 and not allowed for item2 (a Not allowed
: overdue warning is displayed).
9) Set syspref to Block renewal for all items..
10) Both items display the not allowed warning instead of a checkbox.
11) set the syspref to allow renewal
12) Both items can be renewed
13) check the Override renewal limit checkbox and verify that renewing is
still possible by this way.

14) Connect to the patron's personal file and note that both items are
renewable.
15) Redo stages 7 up to 10.

Olivier Crouzet

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2014-12-09 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2014-09-12 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Suzanne Fayle sfa...@roseman.edu changed:

   What|Removed |Added

 CC||sfa...@roseman.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2014-01-17 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

--- Comment #69 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
the HasWhateverRenewalToBeBlocked function makes a first level checking to see
if any renewal must be blocked. The reason why may be one of the followings :
1) the borrower is already restricted 
2) the borrower have late item(s) AND the 'blockall' option  of
OverduesBlockRenew syspref is enabled.
the function gives the result of the checking through the value of first
returned variable $blockallitems and also return in the third variable
$overduesblockrenew the value of option syspref OverduesBlockRenew that will be
passed to CanBookBeReserved if a second level checking is necesary on every
items (if $blockallitems != 1).
May be I could rename this function MustRenewalBeBlocked ?

As for the following lines :
$(input[name='renew_checked']).val('Return checked items') 
cCould you tell me where exactly is the traduction problem since I kept the
preexisting english terms ?

Olivier Crouzet

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-12-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

   Assignee|fridolyn.som...@biblibre.co |k...@univ-lyon3.fr
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-12-26 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

--- Comment #67 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Comment on attachment 22280
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22280
Bug 8236 Block renewing for overdue items

Review of attachment 22280:
 -- 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=8236attachment=22280)
-

Patch doesn't apply with a conflict in C4/Circulation.pm, that I cannot fix as
part of the QA.
I did a code review and found some issues with the code, that should also be
taken care of.
Without testing I am a bit worried that the change in restriction handling
might have side effects on this patch. Fridolin, could you check that when
working on this again?

::: C4/Circulation.pm
@@ +75,4 @@
   push @EXPORT, qw(
   CanBookBeIssued
   CanBookBeRenewed
 +HasWhateverRenewalToBeBlocked

I am not sure about the name for the new sub - I can't really tell what it's
going to do. Maybe try to make it a bit more clear or check with a native
speaker for a better wording?

We will also need some unit tests for it.

@@ +2481,5 @@
  
  my $issuingrule = GetIssuingRule($borrower-{categorycode}, 
 $item-{itype}, $branchcode);
  
  if ( ( $issuingrule-{renewalsallowed}  $itemissue-{renewals} ) || 
 $override_limit ) {
 +$renewokay =  ( $overduesblockrenew eq 'blockitem' and $overdue 
 and !$override_limit ) ? 0 : 1;

These changes should be backed up by some unit tests as well.

::: installer/data/mysql/updatedatabase.pl
@@ +7331,5 @@
  }
  
 +$DBversion = 3.13.00.XXX;
 +if ( CheckVersion($DBversion) ) {
 +$dbh-do(INSERT INTO systempreferences 
 (variable,value,explanation,options,type) VALUES 
 ('OverduesBlockRenew','allow','If any of a patron checked out documents is 
 late, should renewal be allowed, blocked only on overdue items or blocked on 
 whatever checked out document','allow|blockitem|blockall','Choice'));

Maye the options would be more clear as:
block, bockoverdue, allow ?

::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
@@ +72,4 @@
  $( '#override_limit' ).click( function () {
  if ( this.checked ) {
  $( '.renewals-allowed' ).show(); $( '.renewals-disabled' 
 ).hide();
 +$(input[name='renew_checked']).val('Renew or Return 
 checked items');

This looks like a translation problem. There are a few more below I marked with
'T'.

@@ +107,5 @@
 +return;
 +}
 +});
 +if(!valid){
 +$(input[name='renew_checked']).val('Return checked items');

T

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
@@ +86,4 @@
  $( '#override_limit' ).click( function () {
  if ( this.checked ) {
 $( '.renewals-allowed' ).show(); $( '.renewals-disabled' ).hide();
 +   $(input[name='renew_checked']).val('Renew or Return checked 
 items');

T

@@ +154,5 @@
 +return;
 +}
 +});
 +if(!valid){
 +$(input[name='renew_checked']).val('Return checked items');

T

::: koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt
@@ +191,5 @@
  [% IF ( OpacRenewalAllowed ) %]
  td class=renew[% IF ( ISSUE.status ) %][% IF ( 
 canrenew ) %]input type=checkbox name=item value=[% ISSUE.itemnumber 
 %]/ a href=/cgi-bin/koha/opac-renew.pl?from=opac_useramp;item=[% 
 ISSUE.itemnumber %]amp;borrowernumber=[% ISSUE.borrowernumber 
 %]Renew/a[% END %] span class=renewals([% ISSUE.renewsleft %] of [% 
 ISSUE.renewsallowed %] renewals remaining)/span
  [% ELSE %]
 +[% IF ( ISSUE.norenew_overdue ) %]
 +   Renewal not allowed span 
 class=renewals(overdue on a document)/span

I think instead of using 'document' better use 'item' to be consistent with the
language in Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-12-26 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #68 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hm, it looks like the patch is from Koha Team Lyon 3, but the bug is assigned
to Fridolin - got a bit confused here :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-12-26 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-10-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Aurélie Fichot aurelie.fic...@iepg.fr changed:

   What|Removed |Added

 CC||aurelie.fic...@iepg.fr

--- Comment #61 from Aurélie Fichot aurelie.fic...@iepg.fr ---
The sandbox you've requested is not ready.
Some problems occurred applying patches from bug 8236:
h1Something went wrong !/h1Applying: Bug 8236 Block renewing for overdue
items
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging C4/Circulation.pm
Auto-merging circ/circulation.pl
Auto-merging installer/data/mysql/sysprefs.sql
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
Auto-merging members/moremember.pl
Failed to merge in the changes.
Patch failed at 0001 Bug 8236 Block renewing for overdue items
When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Bug 8236 - Prevent renewing if overdue or restriction

21223 - Bug 8236 Block renewing for overdue items

Apply? [(y)es, (n)o, (i)nteractive] Patch left in
/tmp/Bug-8236-Block-renewing-for-overdue-items-RX74cM.patch .

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-10-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

  Attachment #21223|0   |1
is obsolete||

--- Comment #62 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
Created attachment 22264
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22264action=edit
Bug 8236 Block renewing for overdue items

patch rebased

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-10-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

--- Comment #63 from Aurélie Fichot aurelie.fic...@iepg.fr ---
I installed the patch and I receive a message saying to me : sandbox is not
ready! But no text of error in the body of the message

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-10-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

sandbo...@biblibre.com sandbo...@biblibre.com changed:

   What|Removed |Added

  Attachment #22264|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-10-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

sandbo...@biblibre.com sandbo...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||sandbo...@biblibre.com

--- Comment #64 from sandbo...@biblibre.com sandbo...@biblibre.com ---
Patch tested with a sandbox, by Aurélie Fichot aurelie.fic...@iepg.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-10-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

--- Comment #65 from sandbo...@biblibre.com sandbo...@biblibre.com ---
Created attachment 22275
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22275action=edit
Bug 8236 Block renewing for overdue items

If any of patron's document is late, renewal can be allowed, blocked on every
checked out items or only on overdue ones.
The renewal remains nevertheless possible for the librarian checking the
Override renewal limit.

Signed-off-by: Aur

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-10-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #22275|0   |1
is obsolete||

--- Comment #66 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22280
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22280action=edit
Bug 8236 Block renewing for overdue items

Bug 8236 Block renewing for overdue items

If any of patron's document is late, renewal can be allowed, blocked on every
checked out items or only on overdue ones.
The renewal remains nevertheless possible for the librarian checking the
Override renewal limit.

Signed-off-by: Aurélie Fichot aurelie.fic...@iepg.fr



(I reupload the patch in order to fix the encoding issue caused by the sandbox)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-09-23 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

I'm just a bot git...@bugs.koha-community.org changed:

   What|Removed |Added

   When did the bot||2013-09-24
last check this||

--- Comment #60 from I'm just a bot git...@bugs.koha-community.org ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-09-19 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Pierre Angot tredok.pie...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #58 from Pierre Angot tredok.pie...@gmail.com ---
Hello,

Test on sandbox :

Something went wrong !

Applying: Bug 8236 Block renewing for overdue items\nUsing index info to
reconstruct a base tree...\nFalling back to patching base and 3-way
merge...\nAuto-merging C4/Circulation.pm
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt\nFailed to merge in
the changes.\nPatch failed at 0001 Bug 8236 Block renewing for overdue items
When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply
--abort.\nBug 8236 - Prevent renewing if overdue or restriction

21163 - Bug 8236 Block renewing for overdue items

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-09-19 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

  Attachment #21163|0   |1
is obsolete||

--- Comment #59 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Created attachment 21223
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21223action=edit
Bug 8236 Block renewing for overdue items

Rebased master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-09-19 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-09-18 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

I'm just a bot git...@bugs.koha-community.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||git...@bugs.koha-community.
   ||org

--- Comment #56 from I'm just a bot git...@bugs.koha-community.org ---
Applying: Bug 8236 Block renewing for overdue items
Using index info to reconstruct a base tree...
MC4/Circulation.pm
MC4/ILSDI/Services.pm
Minstaller/data/mysql/sysprefs.sql
Minstaller/data/mysql/updatedatabase.pl
Mkoha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
Mkoha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt
Mopac/opac-user.pl
Falling back to patching base and 3-way merge...
Auto-merging opac/opac-user.pl
Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/sysprefs.sql
Auto-merging C4/ILSDI/Services.pm
Auto-merging C4/Circulation.pm
Patch failed at 0001 Bug 8236 Block renewing for overdue items
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run git am --continue.
If you prefer to skip this patch, run git am --skip instead.
To restore the original branch and stop patching, run git am --abort.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-09-18 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

  Attachment #20719|0   |1
is obsolete||

--- Comment #57 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Created attachment 21163
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21163action=edit
Bug 8236 Block renewing for overdue items

Rebased master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-09-18 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-08-29 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #18729|0   |1
is obsolete||

--- Comment #52 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 20716
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20716action=edit
Bug 8236 Block renewing for overdue items

If any of patron's document is late, renewal can be allowed, blocked on every
checked
out items or only on overdue ones.
The renewal remains nevertheless possible for the librarian checking the
Override renewal limit

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-08-29 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-08-29 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

--- Comment #53 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
This patch removes the variable $issue from C4/ILSDI/Services.pm :

--- a/C4/ILSDI/Services.pm
+++ b/C4/ILSDI/Services.pm
@@ -561,11 +561,10 @@ sub RenewLoan {
 return { code = 'RecordNotFound' } unless $$item{itemnumber};

 # Add renewal if possible
-my @renewal = CanBookBeRenewed( $borrowernumber, $itemnumber );
+my ($blockallitems,$reasonwhy,$overduesblockrenew) =
HasAnyRenewalToBeBlocked($borrowernumber,undef);
+my @renewal = $blockallitems ? (0, $reasonwhy) : CanBookBeRenewed(
$borrowernumber, $itemnumber, undef, $overduesblockrenew );
 if ( $renewal[0] ) { AddRenewal( $borrowernumber, $itemnumber ); }

-my $issue = GetItemIssue($itemnumber);
-
 # Hashref building
 my $out;
 $out-{'renewals'} = $issue-{'renewals'};

Is this normal?
This variable is still used in the script.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-08-29 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #54 from Jonathan Druart jonathan.dru...@biblibre.com ---
Fridolyn,

Yes you are right. I just rebased the patch against master, this deletion
existed in the precedent patch.

Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-08-29 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

  Attachment #20716|0   |1
is obsolete||
 Status|Failed QA   |Needs Signoff
   Assignee|k...@univ-lyon3.fr  |fridolyn.som...@biblibre.co
   ||m

--- Comment #55 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Created attachment 20719
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20719action=edit
Bug 8236 - Prevent renewing if overdue or restriction

I revised the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-08-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Campbell Reid-Tait campbellreidt...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||campbellreidt...@gmail.com

--- Comment #51 from Campbell Reid-Tait campbellreidt...@gmail.com ---
Patch does not apply.

Bug 8236 Block renewing for overdue items (25.44 KB, patch)
2013-06-07 10:19 UTC, Koha Team Lyon 3 

Applying: Bug 8236 Block renewing for overdue items
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging reserve/renewscript.pl
Auto-merging opac/opac-user.pl
Auto-merging members/moremember.pl
Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/sysprefs.sql
CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql
Auto-merging circ/circulation.pl
Auto-merging C4/ILSDI/Services.pm
Auto-merging C4/Circulation.pm
Failed to merge in the changes.
Patch failed at 0001 Bug 8236 Block renewing for overdue items

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-08-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #50 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Indeed, this patch does not provide the same behavior.
I set back to Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-08-21 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

--- Comment #48 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
Hello Fridolyn,
I'm not sure that the patch of bug 6739 has the same goal : 
- with this patch we want to prevent renewing if patrons have overdues or
restriction.
- with bug 6739, it wants to prevent renewing if patrons who have a card no
more valid.

It's not the same behaviour. Can you confirm that I have understood well and
switch back this patch need signoff ?
Sonia

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-08-21 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

--- Comment #49 from David Cook dc...@prosentient.com.au ---
(In reply to Koha Team Lyon 3 from comment #48)
 Hello Fridolyn,
 I'm not sure that the patch of bug 6739 has the same goal : 
 - with this patch we want to prevent renewing if patrons have overdues or
 restriction.
 - with bug 6739, it wants to prevent renewing if patrons who have a card no
 more valid.
 
 It's not the same behaviour. Can you confirm that I have understood well and
 switch back this patch need signoff ?
 Sonia

I agree with Sonia's evaluation of the patches, Fridolyn. It seems like they
are doing quite different things.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-07-11 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #47 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
This enhancement is clearly in conflict with Bug 6739 which provides the same
behavior + manages the reserves.
Bug 6739 is already signed-off so we should work on it only.

I set in discussion.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-06-23 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Bob Birchall b...@calyx.net.au changed:

   What|Removed |Added

 CC||b...@calyx.net.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-06-07 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

  Attachment #18507|0   |1
is obsolete||

--- Comment #46 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
Created attachment 18729
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18729action=edit
Bug 8236 Block renewing for overdue items

oups, squeezed some lines that had to be kept; Problem corrected

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-06-07 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-06-06 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Pierre Angot tredok.pie...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||tredok.pie...@gmail.com

--- Comment #43 from Pierre Angot tredok.pie...@gmail.com ---
Sandbox setup by tredok.pie...@gmail.com with database 2 and bug 8236 on Thu
Jun 6 08:57:09 2013

Something went wrong !
Applying: Bug 8236 Block renewing for overdue items
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging C4/Circulation.pm
CONFLICT (content): Merge conflict in C4/Circulation.pm
Auto-merging circ/circulation.pl
Auto-merging installer/data/mysql/sysprefs.sql
CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt
Auto-merging members/moremember.pl
Auto-merging opac/opac-user.pl
Failed to merge in the changes.
Patch failed at 0001 Bug 8236 Block renewing for overdue items
When you have resolved this problem run git am --resolved.
If you would prefer to skip this patch, instead run git am --skip.
To restore the original branch and stop patching run git am --abort.
Bug 8236 - Prevent renewing if overdue or restriction

Bug-8236-Block-renewing-for-overdue-items.patch
Apply? [yn]
Patch left in /tmp/Bug-8236-Block-renewing-for-overdue-itemspatch-qFvBtT.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-06-06 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #44 from Jonathan Druart jonathan.dru...@biblibre.com ---
Works for me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-06-06 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

--- Comment #45 from Pierre Angot tredok.pie...@gmail.com ---
We have tested :

1) Allow renewing all items : ok if overdue or restriction

2) Block renewing all itms : ok if overdue or restriction

3) Block only overdue items : a patron with 2 check out : only one is overdue.
We have a message for this one (Renewal not allowed (overdue)). We can't renew
the other one and we have no message.
If we check Override renewal limit we can't renew the item which is not
overdue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-06-06 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Pierre Angot tredok.pie...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-05-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

  Attachment #18073|0   |1
is obsolete||

--- Comment #42 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
Created attachment 18507
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18507action=edit
Bug-8236-Block-renewing-for-overdue-items.patch

patch rebased

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-05-10 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

  Attachment #17926|0   |1
is obsolete||

--- Comment #40 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
Created attachment 18071
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18071action=edit
Bug 8236 Block renewing for overdue items

Hello David,

About the override_limit question, my patch respects both following necessities
:
1) To renew an item by mistake (clicking on the renew buttons) must be
impossible : 
That is done by a second check in renewscript.pl (the script is called by
the button). So whenever this button is clicked by error the renewal fails if
the member/item is blocked.I also add a function to hide renew buttons when
there are no renewal checkbox available
2) To renew an item knowingly must remains possible through the override_limit
: 
Situations may always happen where a certain flexibility is needed and
where passing over the rule is the more appropriate thing to do.


Olivier Crouzet

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-05-10 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

  Attachment #18071|0   |1
is obsolete||

--- Comment #41 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
Created attachment 18073
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18073action=edit
Bug 8236 Block renewing for overdue items

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-05-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

--- Comment #39 from David Cook dc...@prosentient.com.au ---
(In reply to comment #34)
 Created attachment 17926 [details] [review]
 Bug 8236 Block renewing for overdue items
 
 At the end , I found more convenient to deal with the restriction case in
 same patch.
 I keep what seems to be the existing logic - a patron can't renew when he's
 restricted (his opac file is freezen) -
 making it more consistent. Any renewal for a restricted patron is now also
 blocked from webservice and clearly not possible from the pro interface
 unless by checking 'override_limit'.
 If someone would like to allowed renewal for restricted patrons, I think it
 would be not very complicated to add a syspref ( a line of code in
 HasWhateverRenewalToBeBlocked and some addings in opac-user.tt)
 As for the main object of the patch - blocking for late document - I made
 some ajustements you pointed out and one change in the logic :
 rather than hiding the 'Renew all' button, I move the checking in
 renewscript.pl. So, this button is always available in case of big list of
 checkouts items.

Olivier, I'm not sure that I completely understand what you are saying, but I
think it's quite important to not allow any renewals for restricted patrons at
all and that the button should not be visible for a restricted patron, as Owen
mentioned in bug 10089.

In Comment 33, you mention that we should leave renewals for restricted patrons
up to the discretion of the librarian, but I don't think this is a good idea.
First, we block all check outs for restricted patrons. Renewals really are just
another type of check out, so logically it makes sense to block these too.
Second, even though there is red text saying the patron is blocked, I have
reported cases where library staff have accidentally ignored this and renewed
patrons away (much to the chagrin of their co-workers/supervisors). I think
it's necessary to enforce the prevention of renewals for restricted patrons.

In any case, I think these are still conceptually two different issues that
should probably be handled by different patches. That said, I haven't looked at
your newest code. If you prevent all renewals for restricted patrons in all
cases and hide the renew buttons, as Owen suggested in bug 10089, then I would
have no problem using your patch instead of mine. 

In all honesty, another reason I separated the patches is because I wanted the
prevent renewals for restricted patrons behaviour to be introduced as quickly
as possible. The more atomic the patch, the easier it is to test/QA, and the
faster it gets into the codebase. 

Rant aside, once you rebase this patch, I'd be more than happy to test it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-05-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

  Attachment #14433|0   |1
is obsolete||

--- Comment #34 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
Created attachment 17926
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17926action=edit
Bug 8236 Block renewing for overdue items

At the end , I found more convenient to deal with the restriction case in same
patch.
I keep what seems to be the existing logic - a patron can't renew when he's
restricted (his opac file is freezen) -
making it more consistent. Any renewal for a restricted patron is now also
blocked from webservice and clearly not possible from the pro interface unless
by checking 'override_limit'.
If someone would like to allowed renewal for restricted patrons, I think it
would be not very complicated to add a syspref ( a line of code in
HasWhateverRenewalToBeBlocked and some addings in opac-user.tt)
As for the main object of the patch - blocking for late document - I made some
ajustements you pointed out and one change in the logic :
rather than hiding the 'Renew all' button, I move the checking in
renewscript.pl. So, this button is always available in case of big list of
checkouts items.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-05-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-05-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

--- Comment #35 from Koha Team AMU koha.aixmarsei...@gmail.com ---
So sad. It seems we can't test it on a sandbox :
Something went wrong !
Applying: Bug 8236 Block renewing for overdue items
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging C4/Circulation.pm
Auto-merging circ/circulation.pl
Auto-merging installer/data/mysql/sysprefs.sql
CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt
Auto-merging opac/opac-renew.pl
CONFLICT (content): Merge conflict in opac/opac-renew.pl
Auto-merging opac/opac-user.pl
Auto-merging reserve/renewscript.pl
Failed to merge in the changes.
Patch failed at 0001 Bug 8236 Block renewing for overdue items

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-05-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

--- Comment #36 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
Yes, I think it's not possible, on the sandbox because of the versioning in
updatedatabase.pl file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-05-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

--- Comment #37 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to comment #36)
 Yes, I think it's not possible, on the sandbox because of the versioning in
 updatedatabase.pl file.

Yes it is possible, but you should provide a patch rebased against master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-05-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

--- Comment #38 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
?! I am surely missing something (much indeed) about git, but I did this patch
today on top of master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-04-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

--- Comment #33 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
To tell the truth, there was a confusion in my mind at the beginning between
the two aspects, restriction and delay, of the problem but the last patch
treated only the delay question (the bug might have to be renamed). I added a
checking on restriction only in ILSDI but to make it coherent with what happens
in patron file (renewing is already impossible if a patron is restricted
because the file is freezen). I found unusefull to add a check in moremember.pl
and circulation.pl because as the restriction message appears clearly in the
page, I think we can leave it to the power of the librarian to force the
renewal or not. That said, I agree, it's better to separate into two different
patches.
As to your second remark, I insist that my solution is working for every
options the loop is done in every case, the difference is that when blockall is
choosen, CanBookBeRenewed is not called, which spares some extra sql queries.
I will try to propose a new patch theese days with the necessary corrections
(in renewscript.pl too).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-04-21 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=10089

--- Comment #32 from David Cook dc...@prosentient.com.au ---
Given the complexity of this patch, I think it would be a good idea to split
this into a block renewing for overdue items and prevent renewing for
restricted patrons.

I've created a new bug with a patch for preventing renewing for restricted
patrons: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10089

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-04-19 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Koha Team AMU koha.aixmarsei...@gmail.com changed:

   What|Removed |Added

 CC||koha.aixmarsei...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-04-16 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||dc...@prosentient.com.au

--- Comment #30 from David Cook dc...@prosentient.com.au ---
First of all, I want to say that this patch is quite important and I'm keen to
see it get through ASAP. 

However, I'm failing it for a few reasons...

1) The code isn't applied consistently/doesn't take the system preference into
account across all the different scripts:

The code in ILSDI/Services.pm looks ok:

my $norenewal = 1 if ( $overduesblockrenew eq 'blockall' and $memberblocked ==
-1 ) or ( $overduesblockrenew eq 'blockitem' and $overdue ) or $memberblocked
== 1;# last to check if patron is restricted

- 

However, circulation.pl, moremember.pl, and opac-user.pl all use:

my $norenewal = 1 if $overduesblockrenew eq 'blockall' and $memberblocked ==
-1;

-

They really should all be using the first code snippet, since that correctly
takes the OverduesBlockRenew syspref into account. PLUS, it's important to
check for $memberblocked == 1 to make sure that the patron/borrower isn't
restricted!

--

2) That all said, I agree with JDruart. This code really should be either
factorized into CanBookBeRenewed or into its own sub/function. I understand
what you're saying Oliver about not wanting to call the code for every item,
except...the system preference has the blockitem option, which will need to
be checked for every item in the loop. 


--

3) I haven't tried this patch yet, but I think the templates (at least
circulation.tt) might have some issues too...there are separate checks for
previssue.renew_error_too_many and previssue.renew_error_overdue which
means that you could in theory have a line in the check out window that says
Not renewable Renewal not allowed (overdue).

These should probably be 1 If/ElseIf statement rather than 2 separate If
statements.

--

Ultimately, I think this needs an overhaul, but it's certainly a worthwhile
patch that I hope gets in soon :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-04-16 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

--- Comment #31 from David Cook dc...@prosentient.com.au ---
I think this patch is also missing the opac-renew.pl file...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-04-09 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 CC||fridolyn.som...@biblibre.co
   ||m
   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=6739

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-02-14 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

 CC||k...@univ-lyon3.fr

--- Comment #29 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
(En réponse au commentaire 28)
 Hi Koha Team Lyon 3,
 
 I'm under the impression that some duplicated code could be factorized into
 the CanBookBeRenewed routine. Is there a reason for this code not being in
 it?

As you suggest it, I first considered putting the following block in
CanBookBeRenewed :
# Check if any of patron's documents is late
my ($memberblocked) = C4::Members::IsMemberBlocked($borrowernumber);
# and if renewal is allowed in that case
my $overduesblockrenew = C4::Context-preference('OverduesBlockRenew');
my $norenewal = 1 if $overduesblockrenew eq 'blockall' and $memberblocked ==
-1;

But as this block is there to check if no renewal at all is allowed, one
checking by borrower is enough and it would be redundant checking again for
each item. So I choose to put it outside the @$issueslist loop (sub
build_issue_data) and keep the result in $norenewal variable. So when
$norenewal is true, I have not to call for CanBookBeRenewed, I can straightly
affect the value to $renewokay and $renewerror :
my ( $renewokay, $renewerror ) = $norenewal ? (0, 'overdue') :
CanBookBeRenewed( $borrowernumber, $issue-{itemnumber}...

At the end, I am not sure that it's a great economy but that's the reason why.

May be I could make a function out of this block and put it in Circulation.pm :

sub CanOverduesBlockRenewal {
my $borrowernumber = shift;
# Check if any of patron's documents is late
my ($memberblocked) = C4::Members::IsMemberBlocked($borrowernumber);
# the option selected for the syspref 
my $overduesblockrenew = C4::Context-preference('OverduesBlockRenew');
# and if renewal is blocked for all the patron's documents on loan
my $norenewal = 1 if $overduesblockrenew eq 'blockall' and $memberblocked
== -1;

return ($norenewal,$overduesblockrenew);
}



Olivier Crouzet

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-02-14 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

mathieu saby mathieu.s...@univ-rennes2.fr changed:

   What|Removed |Added

 CC||mathieu.saby@univ-rennes2.f
   ||r

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-02-07 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

--- Comment #28 from Jonathan Druart jonathan.dru...@biblibre.com ---
Hi Koha Team Lyon 3,

I'm under the impression that some duplicated code could be factorized into the
CanBookBeRenewed routine. Is there a reason for this code not being in it?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-01-04 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #13510|0   |1
is obsolete||

--- Comment #27 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 14433
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14433action=edit
Bug 8236 Block renewing for overdue items

If any of patron's document is late, renewal can be allowed, blocked on every
checked
out items or only on overdue ones.
The renewal remains nevertheless possible for the librarian checking the
Override renewal limit

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2013-01-04 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2012-12-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff
   Patch complexity|--- |Small patch

--- Comment #26 from Kyle M Hall k...@bywatersolutions.com ---
Probably an error on my part then. Resetting status to Needs Signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2012-11-23 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

--- Comment #25 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
I don't understand :
I tried today on a brand new master and except as for the updatedatabase.pl
file that blocks as usual when somebody adds a new syspref or something else in
sql, every file is applying cleanly.
I did that on top of today's master :
First apply the tabulations patch :
git am 0001-Bug-9098-Replace-tabulations-by-spaces..
then :
git apply --reject 0001-Bug-8236-Block-renewing-for...
and got this :
Applied patch C4/Circulation.pm cleanly.
Applied patch C4/ILSDI/Services.pm cleanly.
Applied patch circ/circulation.pl cleanly.
Applied patch installer/data/mysql/sysprefs.sql cleanly.
Applying patch installer/data/mysql/updatedatabase.pl with 1 rejects...
Rejected hunk #1.
Applied patch
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
cleanly.
Applied patch koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
cleanly.
Applied patch koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
cleanly.
Applied patch koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt cleanly.
Applied patch members/moremember.pl cleanly.
Applied patch opac/opac-user.pl cleanly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2012-11-21 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #24 from Kyle M Hall k...@bywatersolutions.com ---
Merge conflict in opac/opac-user.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 128 matches

Mail list logo