[Koha-bugs] [Bug 8246] can't delete bibs in big batch delete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8246 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8246] can't delete bibs in big batch delete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8246 Nicole C. Engard changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=6027 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8246] can't delete bibs in big batch delete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8246 --- Comment #1 from Jonathan Druart --- Created attachment 37408 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37408&action=edit Bug 8246: Allow deleting record if no more items The "Delete records if no items remain" was only available if the batch did not contain "too many" items (see MaxItemsForBatch). This limitation does not make any sense. Test plan: 1/ Set MaxItemsForBatch=10 2/ Use the batch item deletion to delete 10+ items 3/ Confirm the checkbox "Delete records if no items remain" is displayed 4/ Check it 5/ Launch the job Verify that the records without items have been deleted also. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8246] can't delete bibs in big batch delete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8246 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8246] can't delete bibs in big batch delete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8246 Jonathan Druart changed: What|Removed |Added Assignee|gmcha...@gmail.com |jonathan.dru...@biblibre.co ||m CC||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8246] can't delete bibs in big batch delete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8246 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8246] can't delete bibs in big batch delete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8246 M. Tompsett changed: What|Removed |Added Attachment #37408|0 |1 is obsolete|| --- Comment #2 from M. Tompsett --- Created attachment 37441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37441&action=edit Bug 8246: Allow deleting record if no more items The "Delete records if no items remain" was only available if the batch did not contain "too many" items (see MaxItemsForBatch). This limitation does not make any sense. Test plan: 1/ Set MaxItemsForBatch=10 2/ Use the batch item deletion to delete 10+ items 3/ Confirm the checkbox "Delete records if no items remain" is displayed 4/ Check it 5/ Launch the job 6/ Run koha qa test tools Verify that the records without items have been deleted also. NOTE: My test db only had two biblios with items, so I set MaxItemsForBatch=1. Before patch, checkbox did not display. After patch, checkbox did display. This patch merely moves one line out of the IF/ELSE/END block, and reindents for more readability. Though, there is a missing if you want to get picky. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8246] can't delete bibs in big batch delete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8246 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8246] can't delete bibs in big batch delete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8246 Kyle M Hall changed: What|Removed |Added Attachment #37441|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall --- Created attachment 37455 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37455&action=edit [PASSED QA] Bug 8246: Allow deleting record if no more items The "Delete records if no items remain" was only available if the batch did not contain "too many" items (see MaxItemsForBatch). This limitation does not make any sense. Test plan: 1/ Set MaxItemsForBatch=10 2/ Use the batch item deletion to delete 10+ items 3/ Confirm the checkbox "Delete records if no items remain" is displayed 4/ Check it 5/ Launch the job 6/ Run koha qa test tools Verify that the records without items have been deleted also. NOTE: My test db only had two biblios with items, so I set MaxItemsForBatch=1. Before patch, checkbox did not display. After patch, checkbox did display. This patch merely moves one line out of the IF/ELSE/END block, and reindents for more readability. Though, there is a missing if you want to get picky. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8246] can't delete bibs in big batch delete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8246 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #4 from Tomás Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8246] can't delete bibs in big batch delete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8246 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8246] can't delete bibs in big batch delete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8246 Jonathan Druart changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11490 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
