[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

--- Comment #32 from Katrin Fischer  ---
Hi,

wondering if I am missing something - but is it possible to add the
longoverdues.pl to the cron files (normal and packages) and have it inactive
until a library chooses to set the system preferences?

It seems that the lost value is mandatory, so I have an error, when I try
running the script without it being set (syspref empty, no param):
ERROR: No --lost (-l) option defined at ./misc/cronjobs/longoverdue.pl line
119.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 Blocks||13589

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

--- Comment #30 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 33802
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33802action=edit
Bug 8337: (RM followup) make sysprefs match case of the .pref file

Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #31 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patches pushed to master.

Thanks Frederik and Maxime!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

--- Comment #24 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to Anthony Laquerre from comment #19)
 In a context of school library systems such preferences are likely to change
 on average 2-3 times per year. 
 Unfortulalty, many library does not have the money available to make
 requests for changes to IT company. 
 
 Unlike Jonathan, I beleive that each cronjob parameter useful for the end
 user should be in the sys pref table.
 This allows the librarian to make his own choix and not always having to go
 through a process of change by the IT provider.

In some command-line scripts preferences are used too (e.g. look at finesMode
in fines.pl). So, an exception can always be made. Still, the principle is that
cronjobs get their parameters on the command line. A lot of people may be able
to access the preferences and change them by incident, the crontab file needs
root privileges. So further away, but safe. If someone occassionally changes
this pref, he may not even realize that a cron job will later use the value.

The fact that you add them as fallback, makes it somewhat better. If you put
them in the crontab, you should not fear the pref values anymore ;) Will look
if the description of the prefs still needs some tweaking..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 QA Contact||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #30639|0   |1
is obsolete||

--- Comment #25 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 32288
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32288action=edit
Bug 8337 - Added the sysprefs to the database scripts. modified:
installer/data/mysql/sysprefs.sql modified:
installer/data/mysql/updatedatabase.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #17393|0   |1
is obsolete||
  Attachment #30944|0   |1
is obsolete||
  Attachment #32288|0   |1
is obsolete||

--- Comment #26 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 32289
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32289action=edit
Bug 8337 System preferences for longoverdue cron

Patch to follow that adds 3 new system preferences to control the
parameters for the longoverdue script.
New prefs are DefaultLongOverdueChargeValue, DefaultLongOverdueLostValue
and DefaultLongOverdueDays.
These preferences are used when you call the longoverdue.pl script without
their parameters.

Sponsored-By: CCSR
Signed-off-by: Leila and Fridos help koha.aixmarsei...@gmail.com
Signed-off-by: Kyle M Hall k...@bywatersolutions.com

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

--- Comment #29 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 32292
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32292action=edit
Bug 8337: Small typo in usage statement for longoverdue.pl

The charge with the replacement price will only be made if the charge
parameter matches the lost value. The given example is faulty (as well
as some of the code, as it appears ;)

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

--- Comment #28 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 32291
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32291action=edit
Bug 8337 - Follow-up to Comment 13

Fixed QA script issues.
Syspref names are now camelcased and sorted correctly in sysprefs.sql.

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

--- Comment #27 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 32290
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32290action=edit
Bug 8337 - Added prefs to sysprefs and updatedatabase

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

--- Comment #23 from Jesse Weaver jwea...@bywatersolutions.com ---
I have some ideas related to this, though implementation is a bit stalled at
the moment. My plans were for a configuration system outside of the system
preferences, which could potentially replace all daily tasks in the crontab
with:

0 1 * * * $KOHA_CRON_PATH/misc/cronjobs/run_daily_tasks.pl

and a matching database structure to hold information on enabled/disabled
cronjobs and all of their selected options (including metadata, somewhere, on
what options were available for each and what values they took). This cronjob
would load up all enabled cronjobs, figure out what dependency order they had
to be executed in, then run them in series. There was also some thought for a
built-in output logging facility.

Note that I don't have any plans to modify the cronjobs in question; they would
still be run as external scripts, just with options built up from the
configuration in the database.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

--- Comment #21 from Jonathan Druart jonathan.dru...@biblibre.com ---
You should sent an email on the mailing list to get other points of view.
In my opinion, this should never be pushed like that. One pref per script
parameter is not conceivable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

--- Comment #22 from Blou philippe.blo...@inlibro.com ---
You extrapolate, here.  We're not talking about every script, nor about every
argument of every script.

Technicaly, there are no constraint on the number of prefs we can handle. 
There were 10, then 200 and there'll be 2000.  Having the right nomenclature to
identify them could be a big plus, but that is true for every pref already in
the DB, imo.

Now, if we go back to the need of the user, configurable cron job is a need. 
Specifically for this cronjob.  And this seems like something other users would
benefit from.  With no impact.

(THere are alternatives, but they do have impact, and it's outside this small
scope)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

simith.dolive...@inlibro.com changed:

   What|Removed |Added

 CC||simith.dolive...@inlibro.co
   ||m
   Assignee|maxime.beaul...@inlibro.com |simith.dolive...@inlibro.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||jwea...@bywatersolutions.co
   ||m

--- Comment #20 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Adding Jesse as I think he had some ideas on how to make the cronjobs
configurable in the staff interface.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

--- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com ---
I don't understand the usefulness of these 3 sysprefs.
I know everybody loves sysprefs but do you have another argument?

The longoverdue script is a cronjob and if you want to call this script with
default parameters you just have to set them in the crontab.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

--- Comment #16 from Blou philippe.blo...@inlibro.com ---
These prefs are the whole objective of this patch: allow the librarian to set
things up without having to rely on IT people.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #17 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to Blou from comment #16)
 These prefs are the whole objective of this patch: allow the librarian to
 set things up without having to rely on IT people.

If we increase the number of sysprefs, we may end up relying even more on IT
people :)
Looking at your argument, I would agree with Jonathan: You only have to put the
correct arguments once (or very incidentally) in your crontab. No need for
extra sysprefs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

--- Comment #18 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Blou from comment #16)
 These prefs are the whole objective of this patch: allow the librarian to
 set things up without having to rely on IT people.

1 new pref for every argument of each script in misc/cronjob, outch :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

Anthony Laquerre anthony.laque...@ccsr.qc.ca changed:

   What|Removed |Added

 CC||anthony.laque...@ccsr.qc.ca

--- Comment #19 from Anthony Laquerre anthony.laque...@ccsr.qc.ca ---
I jump in the conversation since we are the schools consortia that initially
create the ticket.

In a context of school library systems such preferences are likely to change on
average 2-3 times per year. 
Unfortulalty, many library does not have the money available to make requests
for changes to IT company. 

Unlike Jonathan, I beleive that each cronjob parameter useful for the end user
should be in the sys pref table.
This allows the librarian to make his own choix and not always having to go
through a process of change by the IT provider.

I understand that right now there is a lot of parameters but this is also one
the of biggest strenght of Koha !

Hard to start but once you understand how every sys pref work you can do
anything you want.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

Maxime Beaulieu maxime.beaul...@inlibro.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

--- Comment #14 from Maxime Beaulieu maxime.beaul...@inlibro.com ---
Created attachment 30944
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30944action=edit
Bug 8337 - Follow-up to Comment 13

Fixed QA script issues.
Syspref names are now camelcased.
Bug number added in updatedatabase.pl .

If the cronjob is deactivated by default, shouldn't we leave it like that?
Bear in mind that I am not an expert.

modified:   installer/data/mysql/sysprefs.sql
modified:   installer/data/mysql/updatedatabase.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

Maxime Beaulieu maxime.beaul...@inlibro.com changed:

   What|Removed |Added

 CC||francois.charbonnier@inlibr
   ||o.com,
   ||philippe.blo...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||katrin.fisc...@bsz-bw.de,
   ||k...@bywatersolutions.com

--- Comment #13 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Starting with a code review:

1) (trivial) The QA script has some complaints about those patches:
 FAILinstaller/data/mysql/sysprefs.sql
   FAIL  sysprefs_order
Not blocker: Sysprefs defaultlongoverduechargevalue is bad placed (see
bug 10610)

 FAILinstaller/data/mysql/updatedatabase.pl
   OK  critic
   FAIL  pod
*** WARNING: =head2 without preceding higher level  in file
installer/data/mysql/updatedatabase.pl
   OK  valid
   OK  forbidden patterns

2) (trivial) Database update should include the bug number for later reference.

3) (normal) The database update and sysprefs.sql use all lowercaps system
preference names, but the pref file and the longoerdue.pl use camel case. 

4) (just a question) I took a look at our crontab example file and the cronjob
is commented out with parameters and in debian/koha-common.cron.daily the
cronjob is missing. Should we adapt those?

Please provide a follow-up and switch back to Signed-off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

Eric Bégin eric.be...@inlibro.com changed:

   What|Removed |Added

 CC||eric.be...@inlibro.com
   Assignee|gmcha...@gmail.com  |maxime.beaul...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

--- Comment #12 from Maxime Beaulieu maxime.beaul...@inlibro.com ---
Created attachment 30639
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30639action=edit
Bug 8337 - Added the sysprefs to the database scripts. modified:  
installer/data/mysql/sysprefs.sql modified:  
installer/data/mysql/updatedatabase.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

Maxime Beaulieu maxime.beaul...@inlibro.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #11 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA comment:

Didn't test the patch, but the 3 syspref are not added to updatedatabase.pl and
sysprefs.sql

Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #16810|0   |1
is obsolete||

--- Comment #10 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 17393
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17393action=edit
Bug 8337 System preferences for longoverdue cron

Patch to follow that adds 3 new system preferences to control the parameters
for the longoverdue script.
New prefs are DefaultLongOverdueChargeValue, DefaultLongOverdueLostValue and
DefaultLongOverdueDays.
These preferences are used when you call the longoverdue.pl script without
their parameters.

Sponsored-By: CCSR
Signed-off-by: Leila and Fridos help koha.aixmarsei...@gmail.com
Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||paul.poul...@biblibre.com

--- Comment #7 from Paul Poulain paul.poul...@biblibre.com ---
Patch tested with a sandbox, by Leila and Fridos help
koha.aixmarsei...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

  Attachment #16687|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

--- Comment #8 from Paul Poulain paul.poul...@biblibre.com ---
Created attachment 16810
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16810action=edit
Bug 8337 System preferences for longoverdue cron

Patch to follow that adds 3 new system preferences to control the parameters
for the longoverdue script.
New prefs are DefaultLongOverdueChargeValue, DefaultLongOverdueLostValue and
DefaultLongOverdueDays.
These preferences are used when you call the longoverdue.pl script without
their parameters.

Sponsored-By: CCSR
Signed-off-by: Leila and Fridos help koha.aixmarsei...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

Koha Team AMU koha.aixmarsei...@gmail.com changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff
 CC||koha.aixmarsei...@gmail.com

--- Comment #9 from Koha Team AMU koha.aixmarsei...@gmail.com ---
Tested but someone should test it again...

Syspref : DefaultLongOverdueChargeValue 123
 DefaultLongOverdueLostValue 1
DefaultLongOverdueDays 2 days
No finds  charges on a patron with long overdues...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

Maxime Pelletier pelletiermax...@gmail.com changed:

   What|Removed |Added

  Attachment #11389|0   |1
is obsolete||

--- Comment #6 from Maxime Pelletier pelletiermax...@gmail.com ---
Created attachment 16687
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16687action=edit
Bug 8337 System preferences for longoverdue cron

Patch to follow that adds 3 new system preferences to control the parameters
for the longoverdue script.
New prefs are DefaultLongOverdueChargeValue, DefaultLongOverdueLostValue and
DefaultLongOverdueDays.
These preferences are used when you call the longoverdue.pl script without
their parameters.

Sponsored-By: CCSR

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

Maxime Pelletier pelletiermax...@gmail.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #5 from Owen Leonard oleon...@myacpl.org ---
The latest patch doesn't appear to be valid. Git reports Patch format
detection failed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

Maxime Pelletier pelletiermax...@gmail.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
Version|3.8 |master

--- Comment #4 from Maxime Pelletier pelletiermax...@gmail.com ---
This still applies to master, so switched to needs signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

Maxime Pelletier pelletiermax...@gmail.com changed:

   What|Removed |Added

  Attachment #10569|0   |1
is obsolete||

--- Comment #3 from Maxime Pelletier pelletiermax...@gmail.com ---
Created attachment 11389
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11389action=edit
new patch without our po

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

Maxime Pelletier pelletiermax...@gmail.com changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored

--- Comment #1 from Maxime Pelletier pelletiermax...@gmail.com ---
Sponsored by the koha-CCSR community.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

--- Comment #2 from Maxime Pelletier pelletiermax...@gmail.com ---
Created attachment 10569
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10569action=edit
patch to add longoverdue syspref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/