[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Aleisha Amohia  changed:

   What|Removed |Added

 CC||alei...@catalyst.net.nz

--- Comment #53 from Aleisha Amohia  ---
Patches do not apply cleanly on 19.11.x. Please rebase if needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

--- Comment #52 from Lucas Gass  ---
Thanks Jonathan,

I have backported the last patch: "(QA follow-up) Fix test for backdated
return"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

--- Comment #51 from Jonathan Druart  
---
(In reply to Lucas Gass from comment #50)
> backported to 20.05.x for 20.05.03

Lucas, you missed the last patch "(QA follow-up) Fix test for backdated
return", it's not in 20.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|20.11.00|20.11.00, 20.05.03
released in||
 Status|Pushed to master|Pushed to stable
 CC||lu...@bywatersolutions.com

--- Comment #50 from Lucas Gass  ---
backported to 20.05.x for 20.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

--- Comment #49 from Jonathan Druart  
---
Follow-up pushed to master for 20.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

--- Comment #48 from Martin Renvoize  ---
Created attachment 107140
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107140=edit
Bug 8338: (QA follow-up) Fix test for backdated return

A test for CalculateFinesOnBackdate was introduced since this bug was
written and needed updateing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

--- Comment #47 from Jonathan Druart  
---
Pushed to master for 20.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Jonathan Druart  changed:

   What|Removed |Added

 Version(s)||20.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #106209|0   |1
is obsolete||

--- Comment #46 from Katrin Fischer  ---
Created attachment 106527
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106527=edit
Bug 8338: (QA follow-up) Clean up warning

This patch moves the accountline->store call below the FinesLog code
such that we return the same 'thing' from _FixOverduesOnReturn as the
other clauses of the routine.

We also take the oportunity to clean up the warning thrown by an errant
call to the routine such that we output the actual itemnumber rather
than a HASH reference marker.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #106154|0   |1
is obsolete||

--- Comment #44 from Katrin Fischer  ---
Created attachment 106525
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106525=edit
Bug 8338: (follow-up) Fix test

This patch moves the previous test introduced with bug 24075 into the
same block as the rest of the AddReturn tests and updates it to test for
the new 'remove accountline' behaviour as well as the reduce and refund
behaviour.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #106153|0   |1
is obsolete||

--- Comment #43 from Katrin Fischer  ---
Created attachment 106524
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106524=edit
Bug 8338: Remove zero amount overdues on backdated returns where appropriate

This patch removes any overdues which would be reversed on a backdated
return if CalcFineOnBackdate is enabled and the user has not already
attempted to pay off the accruing fine.

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #106155|0   |1
is obsolete||

--- Comment #45 from Katrin Fischer  ---
Created attachment 106526
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106526=edit
Bug 8338: (QA follow-up) Fix perlcritic error

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #106152|0   |1
is obsolete||

--- Comment #42 from Katrin Fischer  ---
Created attachment 106523
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106523=edit
Bug 8338: Unit Tests

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Martin Renvoize  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

--- Comment #41 from Martin Renvoize  ---
Created attachment 106209
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106209=edit
Bug 8338: (QA follow-up) Clean up warning

This patch moves the accountline->store call below the FinesLog code
such that we return the same 'thing' from _FixOverduesOnReturn as the
other clauses of the routine.

We also take the oportunity to clean up the warning thrown by an errant
call to the routine such that we output the actual itemnumber rather
than a HASH reference marker.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

--- Comment #40 from Martin Renvoize  ---
Hmm... not it's not.. we already check for defined in the relevant line.. bit
confused

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

--- Comment #39 from Martin Renvoize  ---
Aha.. it's because with this patch the return of _FixAccountOnReturn is '0' as
opposed to a result object.. but as the note says in the routine that doesn't
signify an error.

I'll add a little followup to clean up the warning.. not really even sure we
need it at all now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

--- Comment #38 from Martin Renvoize  ---
The nasty looking warn is actually introduced with Bug 21206: Replace
C4::Items::GetItem where `->{itemnumber}` is replaced with `->itemnumber`.

You say the warning doesn't appear at all prior to the patch.. that feels odd..
I'll investigate that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #37 from Katrin Fischer  ---
The tests pass, but I am irritated by the output, can you explain?

t/db_dependent/Circulation.t .. 30/47 _FixOverduesOnReturn(137,
Koha::Item=HASH(0x560ff2799448)->itemnumber...) failed! at
/home/vagrant/kohaclone/C4/Circulation.pm line 2056.

It doesn't show without this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Martin Renvoize  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

--- Comment #36 from Martin Renvoize  ---
Created attachment 106155
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106155=edit
Bug 8338: (QA follow-up) Fix perlcritic error

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #105496|0   |1
is obsolete||

--- Comment #33 from Martin Renvoize  ---
Created attachment 106152
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106152=edit
Bug 8338: Unit Tests

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #105497|0   |1
is obsolete||

--- Comment #34 from Martin Renvoize  ---
Created attachment 106153
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106153=edit
Bug 8338: Remove zero amount overdues on backdated returns where appropriate

This patch removes any overdues which would be reversed on a backdated
return if CalcFineOnBackdate is enabled and the user has not already
attempted to pay off the accruing fine.

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #105498|0   |1
is obsolete||

--- Comment #35 from Martin Renvoize  ---
Created attachment 106154
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106154=edit
Bug 8338: (follow-up) Fix test

This patch moves the previous test introduced with bug 24075 into the
same block as the rest of the AddReturn tests and updates it to test for
the new 'remove accountline' behaviour as well as the reduce and refund
behaviour.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

--- Comment #32 from Katrin Fischer  ---
I've filed a new bug for the translation issue noted in comment#25:
Bug 25833 - "Overpayment refund" in charge descriptions is not translatable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25833

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #31 from Katrin Fischer  ---
Requires another little fix:

 FAIL   t/db_dependent/Circulation.t
   OK critic
   OK forbidden patterns
   OK git manipulation
   OK pod
   OK spelling
   FAIL   valid
"my" variable $accountline masks earlier declaration in same
scope

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||Manual

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Martin Renvoize  changed:

   What|Removed |Added

 Depends on|22539   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539
[Bug 22539] Fines charged on back-dated checkin when item has been renewed
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=22539

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|rel_20_11_target|
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Martin Renvoize  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #30 from Martin Renvoize  ---
The failing test is fixed and enhanced to catch more cases in the follow :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

--- Comment #29 from Martin Renvoize  ---
Created attachment 105498
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105498=edit
Bug 8338: (follow-up) Fix test

This patch moves the previous test introduced with bug 24075 into the
same block as the rest of the AddReturn tests and updates it to test for
the new 'remove accountline' behaviour as well as the reduce and refund
behaviour.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #104900|0   |1
is obsolete||

--- Comment #27 from Martin Renvoize  ---
Created attachment 105496
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105496=edit
Bug 8338: Unit Tests

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #104901|0   |1
is obsolete||

--- Comment #28 from Martin Renvoize  ---
Created attachment 105497
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105497=edit
Bug 8338: Remove zero amount overdues on backdated returns where appropriate

This patch removes any overdues which would be reversed on a backdated
return if CalcFineOnBackdate is enabled and the user has not already
attempted to pay off the accruing fine.

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

--- Comment #26 from Katrin Fischer  ---
I was ready to pass QA, but tests fail (pass with master):

kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove
t/db_dependent/Circulation.t
t/db_dependent/Circulation.t .. 29/48 _FixOverduesOnReturn(233,
Koha::Item=HASH(0x55c8b6955450)->itemnumber...) failed! at
/home/vagrant/kohaclone/C4/Circulation.pm line 2056.
t/db_dependent/Circulation.t .. 45/48 # No tests run!

#   Failed test 'No tests run for subtest "Test Backdating of Returns"'
#   at t/db_dependent/Circulation.t line 3930.
Can't call method "amountoutstanding" on an undefined value at
t/db_dependent/Circulation.t line 3928.
# Looks like your test exited with 255 just after 46.
t/db_dependent/Circulation.t .. Dubious, test returned 255 (wstat 65280,
0xff00)
Failed 3/48 subtests 

Test Summary Report
---
t/db_dependent/Circulation.t (Wstat: 65280 Tests: 46 Failed: 1)
  Failed test:  46
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 48 tests but ran 46.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25596

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

--- Comment #25 from Katrin Fischer  ---
I wonder if you have seen bug 13044 - we discussed how to merge the book drop
with the specify return date feature.

Test case 1 makes perfect sense to me: 

|  3 |  NULL |2 | OVERDUE_DECREASE | -0.10 | 2020-05-23
13:09:43

Test case 2 is a bit confusing:

What we see: 
1 Manual debit (something I added for testing)
2 Overdue fine from first test
3 Decrease from returning it with book drop mode

4 Me paying off 4.00 to get over the fine limit (be able to checkout out again)
5 Creating another overdue (same item!)
6 Paying the overdue off
7 Now I see what Andrew means: Manual Credit and OVERDUE_DECREASE seem to be
both the result of me using returning the item with book drop.

I now have a credit of .10 on the account, which matches the amount 'overpaid'.
I think it makes sense to me as it is linked to the accountlines entry
'Overpayment refund'.

++---+--+--+---+-+
| id | credit_id | debit_id | type | amount| created_on
 |
++---+--+--+---+-+
|  1 |  NULL |1 | Manual Debit |  4.00 | 2020-05-22
11:20:08 |
|  2 |  NULL |2 | OVERDUE  |  2.30 | 2020-05-23
13:06:48 |
|  3 |  NULL |2 | OVERDUE_DECREASE | -0.10 | 2020-05-23
13:09:43 |
|  4 | 3 |1 | Payment  | -4.00 | 2020-05-23
13:13:21 |
|  5 |  NULL |4 | OVERDUE  |  0.50 | 2020-05-23
13:13:52 |
|  6 | 5 |4 | Payment  | -0.50 | 2020-05-23
13:14:02 |
|  7 | 6 | NULL | Manual Credit| -0.10 | 2020-05-23
13:14:24 |
|  8 |  NULL |4 | OVERDUE_DECREASE | -0.10 | 2020-05-23
13:14:24 |
++---+--+--+---+-+

NOTE: 
Am I the only one getting confused by our mix of descriptions (with false
capitalization) and codes in these tables?

Also "Overpayment refund" is not translatable :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|RM_priority |rel_20_11_target

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

--- Comment #24 from Andrew Fuerste-Henry  ---
Oh, I should mention that in the course of your test plan I ran into an
unrelated error. Confirmed it happens without your patch, filed bug 25508 for
it. At step 5 of test 2, when you pay off the fine, Koha gets weird about
whether or not it should renew the overdue item.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #104842|0   |1
is obsolete||

--- Comment #23 from Andrew Fuerste-Henry  ---
Created attachment 104901
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104901=edit
Bug 8338: Remove zero amount overdues on backdated returns where appropriate

This patch removes any overdues which would be reversed on a backdated
return if CalcFineOnBackdate is enabled and the user has not already
attempted to pay off the accruing fine.

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #104841|0   |1
is obsolete||

--- Comment #22 from Andrew Fuerste-Henry  ---
Created attachment 104900
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104900=edit
Bug 8338: Unit Tests

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

--- Comment #21 from Andrew Fuerste-Henry  ---
This looks good except for one extremely minor quibble -- the acount_offsets
entry for the credit created in test 2 shows type "Manual credit," which is
misleading on a credit generated automatically by the system. Signing off
anyway, but would love to see that changed to "system-generated credit" or
something more accurate.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||RM_priority

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

--- Comment #20 from Martin Renvoize  ---
Bonus points.. check that the offsets (account details) make sense from each
perspective.. looking at them from the payment, refund credit and overdue fine
perspectives.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

--- Comment #19 from Martin Renvoize  ---
Test Plan.. play with accounts and backdated returns.. report any oddities.

More seriously.
Test One
1 - Checkout an item to a patron and make it overdue (can backdate the
checkout)
2 - Make sure the itemtype has fines that will be charged
3 - Charge the fines:
 Set finesMode = production
 perl misc/cronjobs/fines.pl -v
4 - Check the fine appears on the patrons account
5 - Browse to Circulation->Check in
6 - In 'Checkin settings' backdate to before the due date
7 - Check the fine no longer appears on the patrons account

Test Two
1 - Checkout an item to a patron and make it overdue (can backdate the
checkout)
2 - Make sure the itemtype has fines that will be charged
3 - Charge the fines:
 Set finesMode = production
 perl misc/cronjobs/fines.pl -v
4 - Check the fine appears on the patrons account
5 - Pay off the fine
6 - Browse to Circulation->Check in
7 - In 'Checkin settings' backdate to before the due date
8 - Check the fine still appears on the patrons account (but is now 'zero' and
fixed)
9 - Check that there is a credit on the patrons account for the amount they
originally paid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

--- Comment #17 from Martin Renvoize  ---
Created attachment 104841
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104841=edit
Bug 8338: Unit Tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

--- Comment #18 from Martin Renvoize  ---
Created attachment 104842
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104842=edit
Bug 8338: Remove zero amount overdues on backdated returns where appropriate

This patch removes any overdues which would be reversed on a backdated
return if CalcFineOnBackdate is enabled and the user has not already
attempted to pay off the accruing fine.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Fiona Borthwick  changed:

   What|Removed |Added

 CC||fiona.borthwick@ptfs-europe
   ||.com

--- Comment #16 from Fiona Borthwick  ---
If the user returned the book on time and left it in a bookdrop due to the
library being closed, then that user should not have a fine imposed.
I realise that the fines job will have run and populated the fine before the
library removes the book from the bookdrop.
However when they then set the return date to reflect the 'real' date (e.g.
yesterday), then Koha will know that the book was returned on time and
therefore no fine should have been generated.

Personally I think an audit trail is not required for this purpose. The fine
(whilst it was applied) would not have been if the library had been open and
the user could return the item to the counter.

From a user's perspective they are not going to want evidence of a fine on
their account when it was not needed nor a proper fine.

I would opt for it to be deleted completely.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25417

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||14825


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Katrin Fischer  changed:

   What|Removed |Added

Summary|fines not cleared with  |Fines not cleared with
   |dropbox mode|dropbox mode
 Status|REOPENED|NEW
  Component|Circulation |Fines and fees

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338
Bug 8338 depends on bug 22512, which changed state.

Bug 22512 Summary: accountlines.accountype mixes 'state' and 'type'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||22512


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512
[Bug 22512] accountlines.accountype mixes 'state' and 'type'
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

--- Comment #15 from Kyle M Hall  ---
(In reply to Martin Renvoize from comment #13)
> I think at this point this comes down to the question I asked in comment 11
> bug 22359
> 
> > Question:  This patch uses the existing UpdateFine (and as such
> > Koha::Account->adjust) functionality. It will result in a fine line
> > with an amount of '0'.  Is this actually what we want?
> > 
> > We have a few alternatives we could consider:
> > 
> > 1) We could leave it as is.
> > 1) We could delete the fine entirely so it's as if it never existed
> > 2) We could record a 'Writeoff' or something line against it to show it was
> > removed by dropbox/backdated returns mode.

My personal preference is to leave the 0 fine as part of the 'paper trail' for
Koha's accounting system. I would not be opposed to option 2. We could add new
'states' for 'Dropboxed', 'Backdated return' and 'Fine forgiven' if we build it
on top of bug 22512.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

--- Comment #14 from Martin Renvoize  ---
bug 22539 even.. oops.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

--- Comment #13 from Martin Renvoize  ---
I think at this point this comes down to the question I asked in comment 11 bug
22359

> Question:  This patch uses the existing UpdateFine (and as such
> Koha::Account->adjust) functionality. It will result in a fine line
> with an amount of '0'.  Is this actually what we want?
> 
> We have a few alternatives we could consider:
> 
> 1) We could leave it as is.
> 1) We could delete the fine entirely so it's as if it never existed
> 2) We could record a 'Writeoff' or something line against it to show it was
> removed by dropbox/backdated returns mode.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Depends on||22539


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539
[Bug 22539] Fines charged on back-dated checkin when item has been renewed
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=13044

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Nicole C. Engard  changed:

   What|Removed |Added

 CC|neng...@gmail.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

--- Comment #12 from Kyle M Hall k...@bywatersolutions.com ---
(In reply to Katrin Fischer from comment #10)
 It looks like bug 10694 will fix this:
 
 Sometimes libraries need to backdate returns further back in time than
 Koha's dropbox mode will allow. The returns backdating will check in an item
 as if it had been returned on the specified date, and will reduce any fine
 accordingly.
 
 *** This bug has been marked as a duplicate of bug 10694 ***

Yes, as the author of bug 10694 I believe that it will effectively resolve this
bug. The only difference is that feature will require you to select the return
date rather than having it decided for you automatically.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||katrin.fisc...@bsz-bw.de
Version|3.8 |master
 Resolution|--- |DUPLICATE

--- Comment #10 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
It looks like bug 10694 will fix this:

Sometimes libraries need to backdate returns further back in time than Koha's
dropbox mode will allow. The returns backdating will check in an item as if it
had been returned on the specified date, and will reduce any fine accordingly.

*** This bug has been marked as a duplicate of bug 10694 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|DUPLICATE   |---

--- Comment #11 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hm, on second thought might not be quite the same, please check if the new
feature on bug 10694 is a fix for you.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Aaron Sakovich asakov...@hmcpl.org changed:

   What|Removed |Added

 CC||asakov...@hmcpl.org

--- Comment #7 from Aaron Sakovich asakov...@hmcpl.org ---
As an end-user, I've got to agree with Melia, Nicole, and Kyle. This is totally
unexpected behavior, and I can't quite wrap my head around the business rule
that would have resulted in this program logic. Maybe that's just me, but I
don't think so.

As Chris says, whether you call this a bug or enhancement is really moot; the
functionality is not in there and we *really* need this functionality. Erasing
all fines on an item when we're just trying to compensate for the fact that we
were closed yesterday is not the way we do business.

If there is a use case where all fines should be wiped because a branch was
closed yesterday, then perhaps we should have radio buttons to select either
Forgive all fines vs. Forgive fines while closed, but we at least need the
option at our library.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

--- Comment #8 from Chris Cormack ch...@bigballofwax.co.nz ---
(In reply to Aaron Sakovich from comment #7)
 As an end-user, I've got to agree with Melia, Nicole, and Kyle. This is
 totally unexpected behavior, and I can't quite wrap my head around the
 business rule that would have resulted in this program logic. Maybe that's
 just me, but I don't think so.

One thing you learn with working with libraries, is that assuming that the way
your library does it is the same way others do it is the single biggest mistake
you can make. 
 
 As Chris says, whether you call this a bug or enhancement is really moot;
 the functionality is not in there and we *really* need this functionality.
 Erasing all fines on an item when we're just trying to compensate for the
 fact that we were closed yesterday is not the way we do business.
 
What I actually said is talking about if it's a bug or an enhancement is moot,
until someone either pays someone to, or writes code themselves to change it.

IE without a patch, nothing will change, no matter how we label it.

 If there is a use case where all fines should be wiped because a branch was
 closed yesterday, then perhaps we should have radio buttons to select either
 Forgive all fines vs. Forgive fines while closed, but we at least need
 the option at our library.

Awesome, I assume you will be working on a patch for this? Or paying someone to
do this for you?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

--- Comment #9 from Aaron Sakovich asakov...@hmcpl.org ---
(In reply to Chris Cormack from comment #8)
 One thing you learn with working with libraries, is that assuming that the
 way your library does it is the same way others do it is the single biggest
 mistake you can make. 

Totally agree, which is why I tried to ensure I personalized my comment. But
then, that also goes the other way -- just because (it appears) some libraries
may want to wipe all their fines doesn't mean everyone follows that business
rule.

 What I actually said is talking about if it's a bug or an enhancement is
 moot, until someone either pays someone to, or writes code themselves to
 change it.

If I misled you to thinking I did not understand your point, I apologize, as I
absolutely do -- again, I tried to express my perspective by saying we, as in
HMCPL. I tempered that with questioning if the existing business logic was
indeed a valid use case, which if no one uses it this way, why is it coded
thus? If no one uses a feature because the business logic does not reflect the
real world, is it really a feature, or a bug?

And yes, I would be okay if numLibraries ge 1. I'd even be okay with anecdotal
evidence. Like I said, I (personally, and as a representative of HMCPL) was
just having trouble wrapping my head around this business logic.

 Awesome, I assume you will be working on a patch for this? Or paying someone
 to do this for you?

Indeed, I've been working on this angle for a few weeks since discovering this
feature.

Thanks for your time and consideration.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

--- Comment #3 from Nicole C. Engard neng...@gmail.com ---
What's the point of changing the day ... except to get rid of the fines?  That
at least is the point here in the US.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #4 from Kyle M Hall k...@bywatersolutions.com ---
I tend to agree with Nicole, I had always assumed that dropbox mode was
backdating the return date to yesterday so that fines would be generated as if
it had been returned the day before.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Colin Campbell colin.campb...@ptfs-europe.com changed:

   What|Removed |Added

 CC||colin.campbell@ptfs-europe.
   ||com

--- Comment #5 from Colin Campbell colin.campb...@ptfs-europe.com ---
There does seem to be a common expectation amongst users that dropbox mode
clears fines in some way. And subsequently they find it to be behaving
inconsistently. The behaviour does need documenting as it seems to be adding
confusion.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

--- Comment #6 from Chris Cormack ch...@bigballofwax.co.nz ---
Probably doesn't matter whether it's an enhancement or bug unless a patch to
change it actually exists. But it is working as designed, adding the ability
for it to wipe fines is therefore an enhancement. But yeah without a patch its
moot anyway.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 CC||neng...@gmail.com
   Severity|enhancement |normal

--- Comment #1 from Nicole C. Engard neng...@gmail.com ---
changing from enhancement to bug - since the understanding is that dropbox mode
is used to push the 'returned day' back and as such shouldn't charge fines for
the days past the 'checkin day'

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
   Severity|normal  |enhancement

--- Comment #2 from Chris Cormack ch...@bigballofwax.co.nz ---
Nope the dropbox mode exists only to change the day of return to the previous
day. 

Adding a new feature to remove fines is certainly an enhancement.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Melia Meggs me...@bywatersolutions.com changed:

   What|Removed |Added

 Depends on||5644

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/