[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #14 from Galen Charlton --- Now that somebody has actively called my attention to this: +1 to using Net::Printer. +1 to taking advantage of the existing structure for defining print queues. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What|Removed |Added Attachment #16543|0 |1 is obsolete|| --- Comment #15 from Kyle M Hall --- Created attachment 27127 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27127&action=edit Bug 8352 - Add automatic printing of 'hold to pull' notices Adds the ability to have a notice printed automatically after a hold has been placed. The system has the ability to define a separate printer for each branchcode, so each library can receive a printed notice for any holds placed, assuming they have set up the ability to print over the LAN, WAN, or Internet. Notices are printed to the pickup library. Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #16 from Kyle M Hall --- (In reply to Galen Charlton from comment #14) > +1 to taking advantage of the existing structure for defining print queues. I'm afraid I don't believe this to be as good an idea as it may have seemed at first. It appears that admin/printers.pl has been hidden since 2008, 8 years ago. The schema for this table would need to be completely recreated as the existing one does not fit with the data needed for Net::Printer. Even worse, the code itself is extremely broken and would have to be rewritten from scratch. So, in short, we wouldn't be taking advantage of the existing structure for defining print queues, because it would all need to be completely thrown away and totally rewritten, including the printers table itself. I'm not really seeing what the advantage would be to defining the printers from the web interface either. In fact, it seems even a bit unwanted perhaps. Printer configuration is a system administration task. I don't see a great advantage to allowing librarians to alter the printer data from a web interface. Any thoughts? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Katrin Fischer changed: What|Removed |Added Status|In Discussion |Failed QA --- Comment #17 from Katrin Fischer --- I took only a quick look at the patch and I think if we go the route of adding a new column to reserves, we also need to add the column old_reserves. What happens if a print is not possible? (printer offline, no paper, etc.) is there a way to repeat the prints? Just a thought, but having the date/time of the print might be useful. Failing QA on Kyle's request, because of old_reserves - still waiting for Galen's opionion of course. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #18 from Galen Charlton --- (In reply to Kyle M Hall from comment #16) > (In reply to Galen Charlton from comment #14) > > +1 to taking advantage of the existing structure for defining print queues. > > I'm afraid I don't believe this to be as good an idea as it may have seemed > at first. It appears that admin/printers.pl has been hidden since 2008, 8 > years ago. The schema for this table would need to be completely recreated > as the existing one does not fit with the data needed for Net::Printer. Even > worse, the code itself is extremely broken and would have to be rewritten > from scratch. I've sent Chris a query regarding whether he's got the current print queue stuff working for any of his libraries. > So, in short, we wouldn't be taking advantage of the existing structure for > defining print queues, because it would all need to be completely thrown > away and totally rewritten, including the printers table itself. Agreed there are some changes that would be required. > I'm not really seeing what the advantage would be to defining the printers > from the web interface either. In fact, it seems even a bit unwanted > perhaps. Printer configuration is a system administration task. I don't see > a great advantage to allowing librarians to alter the printer data from a > web interface. Disagree. Particularly since Net::Printer talks to the printer directly, there isn't any server-side configuration of setting up lpr queues as seems to be required for the current printer queue approach. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #19 from Katrin Fischer --- I've got a question unrelated to the implementation :) When an item is returned on the self check, it's not set to waiting, so it should show up on the holds to pull list. Would this also trigger a print? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #20 from Katrin Fischer --- Some notes after talking to Kyle about this feature: - The prints will happen when the hold is places, the printer used is the pickup branch. This means, that will work for single brnach libraries, but might be a problem to multi branch libraries. Also if the item is - The printed flag being on reserves will make it a bit harder to extend this later, I think I would like a separate table with a time queued and a time printed better. We could also extend that later for other automated prints. - If the flag stays on reserves, we might want to make it a datetime instead for the time it was printed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What|Removed |Added Attachment #27127|0 |1 is obsolete|| --- Comment #21 from Kyle M Hall --- Created attachment 28333 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28333&action=edit Bug 8352 - Add automatic printing of 'hold to pull' notices Adds the ability to have a notice printed automatically after a hold has been placed. The system has the ability to define a separate printer for each branchcode, so each library can receive a printed notice for any holds placed, assuming they have set up the ability to print over the LAN, WAN, or Internet. Notices are printed to the pickup library. Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #22 from Kyle M Hall --- Created attachment 28334 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28334&action=edit Bug 8352 - Add printer administration, update script to use Koha defined printers This patch adds the ability to define printers within Koha. The printer CRUD is based on the code for the quote of the day system. This patch extends the existing ability to print via LPR to any network printer with the added ability to print to a CUPS printer configured on the Koha server. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Browse to admin/printers.pl 4) Configure a network printer via LPR ( explained in the printers help ) 5) Create a hold 6) Execute the command "misc/cronjobs/holds/print_holds.pl -v --printer $BRANCHCODE=$PRINTER_ID where branchcode is the pickup branch for the hold, and printer_id is the id number for the printer. 7) See your reserve slip is printer! Bonus points: Repeat the test plan, but for a printer you set up via CUPS on the Koha server -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What|Removed |Added Attachment #28334|0 |1 is obsolete|| --- Comment #23 from Kyle M Hall --- Created attachment 28335 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28335&action=edit Bug 8352 - Add printer administration, update script to use Koha defined printers This patch adds the ability to define printers within Koha. The printer CRUD is based on the code for the quote of the day system. This patch extends the existing ability to print via LPR to any network printer with the added ability to print to a CUPS printer configured on the Koha server. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Browse to admin/printers.pl 4) Configure a network printer via LPR ( explained in the printers help ) 5) Create a hold 6) Execute the command "misc/cronjobs/holds/print_holds.pl -v --printer $BRANCHCODE=$PRINTER_ID where branchcode is the pickup branch for the hold, and printer_id is the id number for the printer. 7) See your reserve slip is printer! Bonus points: Repeat the test plan, but for a printer you set up via CUPS on the Koha server -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #24 from Kyle M Hall --- Test Plan addition: There are several new module dependencies for this feature: HTML::HTMLDoc: Required for both LPR and CUPS printing if printing HTML Net::Printer: Required for LPR printing Printer: Required for CUPS printing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Jacek Ablewicz changed: What|Removed |Added CC||a...@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What|Removed |Added Attachment #28335|0 |1 is obsolete|| --- Comment #25 from Kyle M Hall --- Created attachment 28651 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28651&action=edit Bug 8352 - Add printer administration, update script to use Koha defined printers This patch adds the ability to define printers within Koha. The printer CRUD is based on the code for the quote of the day system. This patch extends the existing ability to print via LPR to any network printer with the added ability to print to a CUPS printer configured on the Koha server. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Browse to admin/printers.pl 4) Configure a network printer via LPR ( explained in the printers help ) 5) Create a hold 6) Execute the command "misc/cronjobs/holds/print_holds.pl -v --printer $BRANCHCODE=$PRINTER_ID where branchcode is the pickup branch for the hold, and printer_id is the id number for the printer. 7) See your reserve slip is printer! Bonus points: Repeat the test plan, but for a printer you set up via CUPS on the Koha server -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What|Removed |Added Attachment #28651|0 |1 is obsolete|| --- Comment #26 from Kyle M Hall --- Created attachment 28652 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28652&action=edit Bug 8352 - Add printer administration, update script to use Koha defined printers This patch adds the ability to define printers within Koha. The printer CRUD is based on the code for the quote of the day system. This patch extends the existing ability to print via LPR to any network printer with the added ability to print to a CUPS printer configured on the Koha server. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Browse to admin/printers.pl 4) Configure a network printer via LPR ( explained in the printers help ) 5) Create a hold 6) Execute the command "misc/cronjobs/holds/print_holds.pl -v --printer $BRANCHCODE=$PRINTER_ID where branchcode is the pickup branch for the hold, and printer_id is the id number for the printer. 7) See your reserve slip is printer! Bonus points: Repeat the test plan, but for a printer you set up via CUPS on the Koha server -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What|Removed |Added Attachment #28652|0 |1 is obsolete|| --- Comment #27 from Kyle M Hall --- Created attachment 28653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28653&action=edit Bug 8352 - Add printer administration, update script to use Koha defined printers This patch adds the ability to define printers within Koha. The printer CRUD is based on the code for the quote of the day system. This patch extends the existing ability to print via LPR to any network printer with the added ability to print to a CUPS printer configured on the Koha server. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Browse to admin/printers.pl 4) Configure a network printer via LPR ( explained in the printers help ) 5) Create a hold 6) Execute the command "misc/cronjobs/holds/print_holds.pl -v --printer $BRANCHCODE=$PRINTER_ID where branchcode is the pickup branch for the hold, and printer_id is the id number for the printer. 7) See your reserve slip is printer! Bonus points: Repeat the test plan, but for a printer you set up via CUPS on the Koha server -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What|Removed |Added Attachment #28653|0 |1 is obsolete|| --- Comment #28 from Kyle M Hall --- Created attachment 28654 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28654&action=edit Bug 8352 - Add printer administration, update script to use Koha defined printers This patch adds the ability to define printers within Koha. The printer CRUD is based on the code for the quote of the day system. This patch extends the existing ability to print via LPR to any network printer with the added ability to print to a CUPS printer configured on the Koha server. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Browse to admin/printers.pl 4) Configure a network printer via LPR ( explained in the printers help ) 5) Create a hold 6) Execute the command "misc/cronjobs/holds/print_holds.pl -v --printer $BRANCHCODE=$PRINTER_ID where branchcode is the pickup branch for the hold, and printer_id is the id number for the printer. 7) See your reserve slip is printer! Bonus points: Repeat the test plan, but for a printer you set up via CUPS on the Koha server -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #13 from Katrin Fischer --- I think I like the idea to have a separate printing queue. Here in Germany we have big libraries with closed stacks with multiple areas and printers. It looks to me like using printers this feature would be easier extendable in the future? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Alex Arnaud changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||alex.arn...@biblibre.com --- Comment #9 from Alex Arnaud --- Patch does not apply on master: error: patch failed: C4/Installer/PerlDependencies.pm:633 error: C4/Installer/PerlDependencies.pm: patch does not apply error: patch failed: installer/data/mysql/en/mandatory/sample_notices.sql:10 error: installer/data/mysql/en/mandatory/sample_notices.sql: patch does not apply error: patch failed: installer/data/mysql/updatedatabase.pl:6339 error: installer/data/mysql/updatedatabase.pl: patch does not apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What|Removed |Added Attachment #14394|0 |1 is obsolete|| --- Comment #10 from Kyle M Hall --- Created attachment 16338 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16338&action=edit Bug 8352 - Add automatic printing of 'hold to pull' notices Adds the ability to have a notice printed automatically after a hold has been placed. The system has the ability to define a separate printer for each branchcode, so each library can receive a printed notice for any holds placed, assuming they have set up the ability to print over the LAN, WAN, or Internet. Notices are printed to the pickup library. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Alex Arnaud changed: What|Removed |Added Attachment #16338|0 |1 is obsolete|| --- Comment #11 from Alex Arnaud --- Created attachment 16543 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16543&action=edit [Signed off] Bug 8352 - Add automatic printing of 'hold to pull' notices Adds the ability to have a notice printed automatically after a hold has been placed. The system has the ability to define a separate printer for each branchcode, so each library can receive a printed notice for any holds placed, assuming they have set up the ability to print over the LAN, WAN, or Internet. Notices are printed to the pickup library. Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Alex Arnaud changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Chris Cormack changed: What|Removed |Added Status|Signed Off |In Discussion --- Comment #12 from Chris Cormack --- I like the idea of use Net::Printer, but did you know there is already a printer queue and a script to set the printer (network one). This could be generalised to use this Check admin/printers.pl And DROP TABLE IF EXISTS `printers`; CREATE TABLE `printers` ( `printername` varchar(40) NOT NULL default '', `printqueue` varchar(20) default NULL, `printtype` varchar(20) default NULL, PRIMARY KEY (`printername`) ) ENGINE=InnoDB DEFAULT CHARSET=utf8; So i'd like to see it use this (extended if nessecary). Will put this to In discussion and will wait for an opinion from Galen, if he is happy with it as it is, I will continue with QA on it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #1 from Kyle M Hall --- Created attachment 10627 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10627&action=edit Bug 8352 - Add automatic printing of 'hold to pull' notices Adds the ability to have 'hold to pull' notices printed out automatically for librarians. These notices will be based on the data in the tmp_holdsqueue table. As each new row is added to tmp_holdsqueue, a notice for that given row is printed. The system will have the ability to define a separate printer for each branchcode, so in theory each library could receive holds to pull notices printed automatically at holding library for that item, assuming they have set up the ability to print over the LAN, WAN, or Internet. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What|Removed |Added Attachment #10627|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall --- Created attachment 10766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10766&action=edit Bug 8352 - Add automatic printing of 'hold to pull' notices Adds the ability to have a notice printed automatically after a hold has been placed. The system has the ability to define a separate printer for each branchcode, so each library can receive a printed notice for any holds placed, assuming they have set up the ability to print over the LAN, WAN, or Internet. Notices are printed to the pickup library. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Nick Clemens changed: What|Removed |Added CC||n...@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||jonathan.dru...@biblibre.co ||m --- Comment #29 from Jonathan Druart --- I fixed the conflict on the first patch bug get fatal: sha1 information is lacking or useless (installer/data/mysql/updatedatabase.pl). on applying the second one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What|Removed |Added Attachment #28333|0 |1 is obsolete|| Attachment #28654|0 |1 is obsolete|| --- Comment #30 from Kyle M Hall --- Created attachment 36833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36833&action=edit Bug 8352 - Add automatic printing of 'hold to pull' notices Adds the ability to have a notice printed automatically after a hold has been placed. The system has the ability to define a separate printer for each branchcode, so each library can receive a printed notice for any holds placed, assuming they have set up the ability to print over the LAN, WAN, or Internet. Notices are printed to the pickup library. Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #31 from Kyle M Hall --- Created attachment 36834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36834&action=edit Bug 8352 - Add printer administration, update script to use Koha defined printers This patch adds the ability to define printers within Koha. The printer CRUD is based on the code for the quote of the day system. This patch extends the existing ability to print via LPR to any network printer with the added ability to print to a CUPS printer configured on the Koha server. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Browse to admin/printers.pl 4) Configure a network printer via LPR ( explained in the printers help ) 5) Create a hold 6) Execute the command "misc/cronjobs/holds/print_holds.pl -v --printer $BRANCHCODE=$PRINTER_ID where branchcode is the pickup branch for the hold, and printer_id is the id number for the printer. 7) See your reserve slip is printer! Bonus points: Repeat the test plan, but for a printer you set up via CUPS on the Koha server -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Tom Misilo changed: What|Removed |Added CC||misi...@fit.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||ch...@bigballofwax.co.nz --- Comment #3 from Chris Cormack --- Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql Auto-merging C4/Installer/PerlDependencies.pm CONFLICT (content): Merge conflict in C4/Installer/PerlDependencies.pm Failed to merge in the changes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What|Removed |Added Attachment #10766|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 12523 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12523&action=edit Bug 8352 - Add automatic printing of 'hold to pull' notices Adds the ability to have a notice printed automatically after a hold has been placed. The system has the ability to define a separate printer for each branchcode, so each library can receive a printed notice for any holds placed, assuming they have set up the ability to print over the LAN, WAN, or Internet. Notices are printed to the pickup library. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff CC||k...@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What|Removed |Added Attachment #12523|0 |1 is obsolete|| --- Comment #5 from Kyle M Hall --- Created attachment 13465 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13465&action=edit Bug 8352 - Add automatic printing of 'hold to pull' notices Adds the ability to have a notice printed automatically after a hold has been placed. The system has the ability to define a separate printer for each branchcode, so each library can receive a printed notice for any holds placed, assuming they have set up the ability to print over the LAN, WAN, or Internet. Notices are printed to the pickup library. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #6 from Owen Leonard --- Please provide a test plan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #7 from Kyle M Hall --- Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Place some holds for two or more branches 4) Run misc/cronjobs/holds/print_holds_to_pull_on_demand.pl --test --printer MPL,lp,printserver,515 --printer CPL,lp2,printserver,516 Each --printer switch is the configuration for a given branch. Each branch can have a separate printer, or multiple branches can use the same printer. The switch value is the branchcode, printer name, server name and server port separated by commas. If a printer is not defined for a given branch, notices for that branch will not be printed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What|Removed |Added Attachment #13465|0 |1 is obsolete|| --- Comment #8 from Kyle M Hall --- Created attachment 14394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14394&action=edit Bug 8352 - Add automatic printing of 'hold to pull' notices Adds the ability to have a notice printed automatically after a hold has been placed. The system has the ability to define a separate printer for each branchcode, so each library can receive a printed notice for any holds placed, assuming they have set up the ability to print over the LAN, WAN, or Internet. Notices are printed to the pickup library. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
CC||bgkrie...@gmail.com
Status|Needs Signoff |Failed QA
--- Comment #32 from Bernardo Gonzalez Kriegel ---
Hi,
on your first patch you add on kohastructure.pl
`printed` tinyint(1) DEFAULT NULL,
for reserves and old_reserves
But on final updatedatabase.pl (needs to be on atomicupdate!), you
"only" alter reserves but using a different type
$dbh->do("ALTER TABLE reserves ADD printed DATETIME NULL AFTER suspend_until");
Both patches have conflicts
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352
--- Comment #33 from Kyle M Hall ---
(In reply to Bernardo Gonzalez Kriegel from comment #32)
> Hi,
> on your first patch you add on kohastructure.pl
> `printed` tinyint(1) DEFAULT NULL,
> for reserves and old_reserves
>
> But on final updatedatabase.pl (needs to be on atomicupdate!), you
> "only" alter reserves but using a different type
>
> $dbh->do("ALTER TABLE reserves ADD printed DATETIME NULL AFTER
> suspend_until");
>
> Both patches have conflicts
Good catch!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What|Removed |Added Attachment #36833|0 |1 is obsolete|| Attachment #36834|0 |1 is obsolete|| --- Comment #34 from Kyle M Hall --- Created attachment 40749 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40749&action=edit Bug 8352 - Add automatic printing of 'hold to pull' notices Adds the ability to have a notice printed automatically after a hold has been placed. The system has the ability to define a separate printer for each branchcode, so each library can receive a printed notice for any holds placed, assuming they have set up the ability to print over the LAN, WAN, or Internet. Notices are printed to the pickup library. Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #35 from Kyle M Hall --- Created attachment 40750 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40750&action=edit Bug 8352 - Add printer administration, update script to use Koha defined printers This patch adds the ability to define printers within Koha. The printer CRUD is based on the code for the quote of the day system. This patch extends the existing ability to print via LPR to any network printer with the added ability to print to a CUPS printer configured on the Koha server. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Browse to admin/printers.pl 4) Configure a network printer via LPR ( explained in the printers help ) 5) Create a hold 6) Execute the command "misc/cronjobs/holds/print_holds.pl -v --printer $BRANCHCODE=$PRINTER_ID where branchcode is the pickup branch for the hold, and printer_id is the id number for the printer. 7) See your reserve slip is printer! Bonus points: Repeat the test plan, but for a printer you set up via CUPS on the Koha server -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #36 from Kyle M Hall --- Created attachment 40751 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40751&action=edit Bug 8352 [QA Followup] - Fix column type in kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #37 from Bernardo Gonzalez Kriegel --- All patches apply, but think you need to add this line to atomicupdate file: ALTER TABLE old_reserves ADD printed DATETIME NULL AFTER suspend_until; Both tables are modified on kohastructure Is 'Signed Off' the right status? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #38 from Jonathan Druart --- Kyle, 1/ You propose a --test option to the script, but I think the test behavior should be the default and --confirm should sent the job to the printer, don't you think? 2/ Please avoid sql queries in pl scripts. 3/ You should also address Bernardo's concern. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What|Removed |Added Attachment #40749|0 |1 is obsolete|| Attachment #40750|0 |1 is obsolete|| Attachment #40751|0 |1 is obsolete|| --- Comment #39 from Kyle M Hall --- Created attachment 41579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41579&action=edit Bug 8352 - Add automatic printing of 'hold to pull' notices Adds the ability to have a notice printed automatically after a hold has been placed. The system has the ability to define a separate printer for each branchcode, so each library can receive a printed notice for any holds placed, assuming they have set up the ability to print over the LAN, WAN, or Internet. Notices are printed to the pickup library. Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #42 from Kyle M Hall --- Created attachment 41582 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41582&action=edit Bug 8352 [QA Followup] * Add --confirm option to print_holds.pl * Modify old_reserves to match reserves -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #40 from Kyle M Hall --- Created attachment 41580 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41580&action=edit Bug 8352 - Add printer administration, update script to use Koha defined printers This patch adds the ability to define printers within Koha. The printer CRUD is based on the code for the quote of the day system. This patch extends the existing ability to print via LPR to any network printer with the added ability to print to a CUPS printer configured on the Koha server. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Browse to admin/printers.pl 4) Configure a network printer via LPR ( explained in the printers help ) 5) Create a hold 6) Execute the command "misc/cronjobs/holds/print_holds.pl -v --printer $BRANCHCODE=$PRINTER_ID where branchcode is the pickup branch for the hold, and printer_id is the id number for the printer. 7) See your reserve slip is printer! Bonus points: Repeat the test plan, but for a printer you set up via CUPS on the Koha server -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #43 from Kyle M Hall --- Created attachment 41583 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41583&action=edit Bug 8352 [QA Followup] - Don't use SQL in pl files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #41 from Kyle M Hall --- Created attachment 41581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41581&action=edit Bug 8352 [QA Followup] - Fix column type in kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Needs Signoff --- Comment #44 from Jonathan Druart --- Only the first patch is signed off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #45 from Jonathan Druart --- svc/printer does not follow the coding guidelines. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #46 from Jonathan Druart --- (In reply to Jonathan Druart from comment #45) > svc/printer does not follow the coding guidelines. forget that, it's done in the last patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Nicole Engard (ByWater) changed: What|Removed |Added CC||nic...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Zeno Tajoli changed: What|Removed |Added CC||z.taj...@cineca.it Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Zeno Tajoli changed: What|Removed |Added CC|z.taj...@cineca.it | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Jonathan Druart changed: What|Removed |Added Attachment #46878|0 |1 is obsolete|| Attachment #46879|0 |1 is obsolete|| Attachment #46880|0 |1 is obsolete|| Attachment #46881|0 |1 is obsolete|| Attachment #46883|0 |1 is obsolete|| Attachment #46884|0 |1 is obsolete|| --- Comment #91 from Jonathan Druart --- Created attachment 48127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48127&action=edit Bug 8352 - Add automatic printing of 'hold to pull' notices Adds the ability to have a notice printed automatically after a hold has been placed. The system has the ability to define a separate printer for each branchcode, so each library can receive a printed notice for any holds placed, assuming they have set up the ability to print over the LAN, WAN, or Internet. Notices are printed to the pickup library. Signed-off-by: Alex Arnaud bsoletes: 46882 - Bug 8352 [QA Followup] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #94 from Jonathan Druart --- Created attachment 48130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48130&action=edit Bug 8352 [QA Followup] - Don't use SQL in pl files Signed-off-by: Jenice Tate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #96 from Jonathan Druart --- Created attachment 48132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48132&action=edit Bug 8352 [QA Followup] - Notices for translation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #93 from Jonathan Druart --- Created attachment 48129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48129&action=edit Bug 8352 [QA Followup] - Fix column type in kohastructure.sql Signed-off-by: Jenice Tate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Jonathan Druart changed: What|Removed |Added Attachment #46882|0 |1 is obsolete|| --- Comment #95 from Jonathan Druart --- Created attachment 48131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48131&action=edit Bug 8352 [QA Followup] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #92 from Jonathan Druart --- Created attachment 48128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48128&action=edit Bug 8352 - Add printer administration, update script to use Koha defined printers This patch adds the ability to define printers within Koha. The printer CRUD is based on the code for the quote of the day system. This patch extends the existing ability to print via LPR to any network printer with the added ability to print to a CUPS printer configured on the Koha server. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Browse to admin/printers.pl 4) Configure a network printer via LPR ( explained in the printers help ) 5) Create a hold 6) Execute the command "misc/cronjobs/holds/print_holds.pl -v --printer $BRANCHCODE=$PRINTER_ID where branchcode is the pickup branch for the hold, and printer_id is the id number for the printer. 7) See your reserve slip is printer! Bonus points: Repeat the test plan, but for a printer you set up via CUPS on the Koha server Signed-off-by: Jenice Tate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #97 from Jonathan Druart --- Created attachment 48133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48133&action=edit Bug 8352 [QA Followup] - Remove use of HTML::HTMLDoc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #98 from Jonathan Druart --- Patches rebased, conflicts in notices sql files fixed! QA comments: 1/ FAIL Koha/Printer.pm FAIL critic "$pdf_data" is declared but not used at line 61, column 9. Unused variables clutter code and make it harder to read. 2/ What's the status of the NET::Printer lib? It's not packaged already. Kyle, did you try to package it? Failing QA for 1. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #100 from Jonathan Druart --- Created attachment 48135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48135&action=edit Bug 8352: Fix type vs _type for bug 15446 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #101 from Jonathan Druart --- (In reply to Jonathan Druart from comment #98) > Patches rebased, conflicts in notices sql files fixed! > > QA comments: > 1/ > FAIL Koha/Printer.pm >FAIL critic > "$pdf_data" is declared but not used at line 61, column 9. > Unused variables clutter code and make it harder to read. Ok fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #99 from Jonathan Druart --- Created attachment 48134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48134&action=edit Bug 8352: Fix perlcritic '$pdf_data' is declared but not used -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Jonathan Druart changed: What|Removed |Added Status|Signed Off |In Discussion --- Comment #102 from Jonathan Druart --- (In reply to Jonathan Druart from comment #98) > 2/ What's the status of the NET::Printer lib? It's not packaged already. > Kyle, did you try to package it? Still waiting for an answer. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #103 from Kyle M Hall --- (In reply to Jonathan Druart from comment #102) > (In reply to Jonathan Druart from comment #98) > > 2/ What's the status of the NET::Printer lib? It's not packaged already. > > Kyle, did you try to package it? > > Still waiting for an answer. I can tell you that dh-make-perl --pkg-perl --build --cpan Net::Printer produced a deb file with no apparent errors. However, without any good documentation on the package submission process, I really don't know where to go from there. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #104 from Chris Cormack --- You've read https://wiki.koha-community.org/wiki/Building_Debian_Dependencies right? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #105 from Kyle M Hall --- (In reply to Chris Cormack from comment #104) > You've read > https://wiki.koha-community.org/wiki/Building_Debian_Dependencies right? Yep. I'm a bit lost on http://pkg-perl.alioth.debian.org/git.html . There is a bit of hand waving there, the section titled "building the package" has the most helpful guidance: Use your favourite way of building the Debian package. This documentation is simply not clear not understandable. I don't claim to be the brightest bulb there is, but I'd like to think I can follow instructions when they are presented in a reasonable way ; ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #106 from Kyle M Hall --- Also, when I try to confirm my account on Alioth, all I get is a "user not found" error. So I can't even push the code to Alioth. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #107 from Chris Cormack --- Weird, working fine for me. You've asked to be added to the group eh? http://pkg-perl.alioth.debian.org/ (Under A note on joining) All the docs are on that page. You could try asking on the #debian-perl channel listed there. They are pretty receptive to helping Or you could try to catch jajm on IRC he's usually closer to your timezone than I am. And has packaged https://tracker.debian.org/pkg/libtemplate-stash-autoescaping-perl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #108 from Kyle M Hall --- (In reply to Chris Cormack from comment #107) > Weird, working fine for me. > > You've asked to be added to the group eh? > http://pkg-perl.alioth.debian.org/ > (Under A note on joining) > > All the docs are on that page. You could try asking on the #debian-perl > channel listed there. They are pretty receptive to helping > > Or you could try to catch jajm on IRC he's usually closer to your timezone > than I am. And has packaged > https://tracker.debian.org/pkg/libtemplate-stash-autoescaping-perl Thanks! I figured out why I couldn't confirm my account ( all new accounts end with -guest and I didn't notice that ). I've requested to be added to the pkg-perl group. I'll check out the docs. Thanks again! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What|Removed |Added Attachment #41579|0 |1 is obsolete|| Attachment #41580|0 |1 is obsolete|| Attachment #41581|0 |1 is obsolete|| Attachment #41582|0 |1 is obsolete|| Attachment #41583|0 |1 is obsolete|| --- Comment #47 from Kyle M Hall --- Created attachment 44359 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44359&action=edit Bug 8352 - Add automatic printing of 'hold to pull' notices Adds the ability to have a notice printed automatically after a hold has been placed. The system has the ability to define a separate printer for each branchcode, so each library can receive a printed notice for any holds placed, assuming they have set up the ability to print over the LAN, WAN, or Internet. Notices are printed to the pickup library. Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #51 from Kyle M Hall --- Created attachment 44363 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44363&action=edit [SIGNED-OFF] Bug 8352 [QA Followup] - Don't use SQL in pl files Signed-off-by: Jenice Tate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #48 from Kyle M Hall --- Created attachment 44360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44360&action=edit [SIGNED-OFF] Bug 8352 - Add printer administration, update script to use Koha defined printers This patch adds the ability to define printers within Koha. The printer CRUD is based on the code for the quote of the day system. This patch extends the existing ability to print via LPR to any network printer with the added ability to print to a CUPS printer configured on the Koha server. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Browse to admin/printers.pl 4) Configure a network printer via LPR ( explained in the printers help ) 5) Create a hold 6) Execute the command "misc/cronjobs/holds/print_holds.pl -v --printer $BRANCHCODE=$PRINTER_ID where branchcode is the pickup branch for the hold, and printer_id is the id number for the printer. 7) See your reserve slip is printer! Bonus points: Repeat the test plan, but for a printer you set up via CUPS on the Koha server Signed-off-by: Jenice Tate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #49 from Kyle M Hall --- Created attachment 44361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44361&action=edit [SIGNED-OFF] Bug 8352 [QA Followup] - Fix column type in kohastructure.sql Signed-off-by: Jenice Tate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #50 from Kyle M Hall --- Created attachment 44362 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44362&action=edit [SIGNED-OFF] Bug 8352 [QA Followup] * Add --confirm option to print_holds.pl * Modify old_reserves to match reserves Signed-off-by: Jenice Tate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #52 from Katrin Fischer --- Please rebase - there are several conflicts. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What|Removed |Added Attachment #44359|0 |1 is obsolete|| Attachment #44360|0 |1 is obsolete|| Attachment #44361|0 |1 is obsolete|| Attachment #44362|0 |1 is obsolete|| Attachment #44363|0 |1 is obsolete|| --- Comment #53 from Kyle M Hall --- Created attachment 45275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45275&action=edit Bug 8352 - Add automatic printing of 'hold to pull' notices Adds the ability to have a notice printed automatically after a hold has been placed. The system has the ability to define a separate printer for each branchcode, so each library can receive a printed notice for any holds placed, assuming they have set up the ability to print over the LAN, WAN, or Internet. Notices are printed to the pickup library. Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #56 from Kyle M Hall --- Created attachment 45278 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45278&action=edit Bug 8352 [QA Followup] * Add --confirm option to print_holds.pl * Modify old_reserves to match reserves Signed-off-by: Jenice Tate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #55 from Kyle M Hall --- Created attachment 45277 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45277&action=edit Bug 8352 [QA Followup] - Fix column type in kohastructure.sql Signed-off-by: Jenice Tate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #57 from Kyle M Hall --- Created attachment 45279 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45279&action=edit Bug 8352 [QA Followup] - Don't use SQL in pl files Signed-off-by: Jenice Tate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #54 from Kyle M Hall --- Created attachment 45276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45276&action=edit Bug 8352 - Add printer administration, update script to use Koha defined printers This patch adds the ability to define printers within Koha. The printer CRUD is based on the code for the quote of the day system. This patch extends the existing ability to print via LPR to any network printer with the added ability to print to a CUPS printer configured on the Koha server. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Browse to admin/printers.pl 4) Configure a network printer via LPR ( explained in the printers help ) 5) Create a hold 6) Execute the command "misc/cronjobs/holds/print_holds.pl -v --printer $BRANCHCODE=$PRINTER_ID where branchcode is the pickup branch for the hold, and printer_id is the id number for the printer. 7) See your reserve slip is printer! Bonus points: Repeat the test plan, but for a printer you set up via CUPS on the Koha server Signed-off-by: Jenice Tate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #58 from Jonathan Druart --- (In reply to Kyle M Hall from comment #24) > Test Plan addition: > There are several new module dependencies for this feature: > HTML::HTMLDoc: Required for both LPR and CUPS printing if printing HTML > Net::Printer: Required for LPR printing > Printer: Required for CUPS printing Did you check how easy/difficult it is to package these 2 modules? They don't seem maintained anymore Printer-0.98 17 Aug 2004 HTML-HTMLDoc-0.11_01 03 Nov 2009 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #59 from Katrin Fischer ---
Is it possible both modules are not packaged for Ubuntu? I couldn't
install/find either via apt-get?
I think the dependency questions need to be resolved first, before we can move
this further through QA!
Starting with a code review anyway:
1) QA script
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/printers.tt
FAIL spelling
recieve ==> receive
FAIL misc/cronjobs/holds/print_holds.pl
FAIL pod
*** ERROR: =over on line 135 without closing =back (at head1)
in file misc/cronjobs/holds/print_holds.pl
2) New notice
a) The insert statements are missing the message_transport_type:
+INSERT INTO `letter`
(`module`,`code`,`branchcode`,`name`,`is_html`,`title`,`content`)
b) HOLD_PLACED_PRINT sounds like there is a connection to the existing
HOLD_PLACED feature. If this is the case, should this be just the 'print'
version of the HOLD_PLACED notice? And if not, should we rename to make the
difference clear?
c) Notice is missing from the translated web installers.
3) Templates
a) Icons need to be switched to Font Awesome. For example:
koha-tmpl/intranet-tmpl/prog/en/includes/printers-toolbar.inc.
b) koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt changes the
heading and description of one of the toolbar items back to the old one, should
be: Z39.50/SRU searvers
c) I think page title/breadcrumbs and the new entry on Administration should
match. Personally I'd prefer the simpler 'Printers' to 'Printer editor' as it's
more in line with our other pages.
d) This would be nicer to translate using the newer syntax and a placeholder:
else if (confirm(_("Are you sure you wish to delete printer(s) ") +
idsToDelete + "?"))
See: Bug 12138 - Use placeholders in translatable javascript strings
4) Terminology
Holds!! :)
koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/printers.tt
print automatic reserve notices
5) Copyright
Is the copyright correct on the new file svc/printer?
+# Copyright 2014 ByWater Solutions
+# Copyright 2012 Foundations Bible College Inc.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #60 from Kyle M Hall --- (In reply to Jonathan Druart from comment #58) > (In reply to Kyle M Hall from comment #24) > > Test Plan addition: > > There are several new module dependencies for this feature: > > HTML::HTMLDoc: Required for both LPR and CUPS printing if printing HTML > > Net::Printer: Required for LPR printing > > Printer: Required for CUPS printing > > Did you check how easy/difficult it is to package these 2 modules? > > They don't seem maintained anymore > Printer-0.98 17 Aug 2004 > HTML-HTMLDoc-0.11_01 03 Nov 2009 I have no experience packaging modules nor do I see any documentation on the Koha wiki. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What|Removed |Added Attachment #45278|0 |1 is obsolete|| --- Comment #61 from Kyle M Hall --- Created attachment 45362 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45362&action=edit Bug 8352 [QA Followup] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Katrin Fischer changed: What|Removed |Added CC||g...@esilibrary.com Keywords||dependency -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #62 from Kyle M Hall --- Created attachment 45365 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45365&action=edit Bug 8352 [QA Followup] - Notices for translation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
