[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Robin Sheat changed: What|Removed |Added Blocks||9919 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Katrin Fischer changed: What|Removed |Added Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Jared Camins-Esakov changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #45 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #44 from Katrin Fischer --- I agree with you - just saying that the inconsistency was not introduced by this patch - it's there already and there is no regression. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #43 from Jared Camins-Esakov --- (In reply to comment #40) > Hi Jared, I can see what you mean, but 0 is the default behaviour for the > other fields (max holds, max renwals) so from this point of view it's > consistent. I think we are inconsistent, because leaving some fields blank results in "unlimited." However, I'll push this as-is if you're comfortable with this and have considered the issue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Passed QA --- Comment #42 from Katrin Fischer --- Hm thinking more about this, it looks to me like it's out of the scope of this bug, because that's just what happens now if you create a completely new rule. And when editing a rule it should not do something unexpected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #41 from Jonathan Druart --- (In reply to comment #40) > Hi Jared, I can see what you mean, but 0 is the default behaviour for the > other fields (max holds, max renwals) so from this point of view it's > consistent. Jared, I confirm too, it is the current default behavior. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #40 from Katrin Fischer --- Hi Jared, I can see what you mean, but 0 is the default behaviour for the other fields (max holds, max renwals) so from this point of view it's consistent. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Jared Camins-Esakov changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #39 from Jared Camins-Esakov --- This looks good except for one thing: if I leave renewal period blank, it gets set to zero when the circ rule is saved. When renewal period is left blank, it should probably be set to the same as the regular issue period, based on the principle of least surprise. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #38 from Katrin Fischer --- Created attachment 16436 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16436&action=edit [PASSED QA] Bug 8365: FIX Return issue values instead of item values Before this patch, the GetItemIssue routine returns items.renewals instead of issues.renewals Signed-off-by: Broust Signed-off-by: Katrin Fischer All tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #37 from Katrin Fischer --- Created attachment 16435 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16435&action=edit [PASSED QA] Bug 8365: Followup Force DateTime type for the datedue variable Signed-off-by: Broust I tested one more time on a sandbox but I confirm the problem: the due date doesn't change when you renew more than one time with syspref renewalperiodbase turned on: "the old due date of the checkout". The due date should change any time. Signed-off-by: Katrin Fischer Added signed-off line and problem description from bugzilla. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #36 from Katrin Fischer --- Created attachment 16434 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16434&action=edit [PASSED QA] Bug 8365: Add unit tests and fix QA issues This patch adds some unit tests for CalcDateDue and GetLoanLength Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer All tests and QA script pass. Tests done: - Checked update works correctly for existing circulation rules. - Adding, deleting and overwriting circulation rules works. - Renewals work for different circulation rules and changes to the holiday calendar. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Katrin Fischer changed: What|Removed |Added Attachment #16213|0 |1 is obsolete|| Attachment #16214|0 |1 is obsolete|| Attachment #16382|0 |1 is obsolete|| Attachment #16396|0 |1 is obsolete|| --- Comment #35 from Katrin Fischer --- Created attachment 16433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16433&action=edit [PASSED QA] Bug 8365: Add a renewal duration in the issuing rules Renew an issue for a number of days (filled in the issuing rules). Test if rules work for any i[item]types and if there is no regression. - new column issuingrules.renewalperiod - remove all occurrences of an already removed syspref (globalDueDate) - remove an unused routine (Overdues::GetIssuingRules) How it works: - On existing installations, the issuingrules.renewalperiod = issuingrules.loanlength. So the behaviour is the same before and after this patch. - when you add a rule, you can choose a renewal period (the unit value is the issuingrules.unit). So you can have a renewal period in hours or days. - The default value for the renewal period is 21 days (same as loanlength) Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Test comments on second patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|Medium patch|Large patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Katrin Fischer changed: What|Removed |Added Attachment #16386|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #34 from Paul Poulain --- Created attachment 16396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16396&action=edit Bug 8365: FIX Return issue values instead of item values Before this patch, the GetItemIssue routine returns items.renewals instead of issues.renewals Signed-off-by: Broust -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Paul Poulain changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #33 from Paul Poulain --- Patch tested with a sandbox, by Broust -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #32 from Jonathan Druart --- Created attachment 16386 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16386&action=edit Bug 8365: FIX Return issue values instead of item values Before this patch, the GetItemIssue routine returns items.renewals instead of issues.renewals -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #31 from Jonathan Druart --- (In reply to comment #29) > I tested one more time on a sandbox but I confirm the problem : the due date > doesn't change when you renew more than one time with syspref > renewalperiodbase turned on : "the old due date of the checkout". The due > date should change any time. Yep, Good catch! Please retest, it should be fixed with this last patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #30 from Jonathan Druart --- Created attachment 16382 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16382&action=edit Bug 8365: Followup Force DateTime type for the datedue variable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #29 from jmbroust --- (En réponse au commentaire 28) > Hi, > I think this might be a configuation issue - could you check the value in > the system preference RenewalPeriodBase? If it's set to calculate from > today's date, the second renewal has the same date as the first and that > would be correct. I tested one more time on a sandbox but I confirm the problem : the due date doesn't change when you renew more than one time with syspref renewalperiodbase turned on : "the old due date of the checkout". The due date should change any time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #28 from Katrin Fischer --- Hi, I think this might be a configuation issue - could you check the value in the system preference RenewalPeriodBase? If it's set to calculate from today's date, the second renewal has the same date as the first and that would be correct. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 jmbroust changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||jean-manuel.broust@univ-lyo ||n2.fr --- Comment #27 from jmbroust --- When allowing 2 renewals for X days, the first renewal due date is ok but when you renew for the second time the due date doesn't change. Tested with System Pref Renewalperiodbase turned to "the old due date of the checkout" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Jonathan Druart changed: What|Removed |Added Attachment #16120|0 |1 is obsolete|| Attachment #16121|0 |1 is obsolete|| --- Comment #25 from Jonathan Druart --- Created attachment 16213 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16213&action=edit Bug 8365: Add a renewal duration in the issuing rules Renew an issue for a number of days (filled in the issuing rules). Test if rules work for any i[item]types and if there is no regression. - new column issuingrules.renewalperiod - remove all occurrences of an already removed syspref (globalDueDate) - remove an unused routine (Overdues::GetIssuingRules) How it works: - On existing installations, the issuingrules.renewalperiod = issuingrules.loanlength. So the behaviour is the same before and after this patch. - when you add a rule, you can choose a renewal period (the unit value is the issuingrules.unit). So you can have a renewal period in hours or days. - The default value for the renewal period is 21 days (same as loanlength) Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Test comments on second patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #26 from Jonathan Druart --- Created attachment 16214 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16214&action=edit Bug 8365: Add unit tests and fix QA issues This patch adds some unit tests for CalcDateDue and GetLoanLength Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer All tests and QA script pass. Tests done: - Checked update works correctly for existing circulation rules. - Adding, deleting and overwriting circulation rules works. - Renewals work for different circulation rules and changes to the holiday calendar. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Jared Camins-Esakov changed: What|Removed |Added Status|Passed QA |Patch doesn't apply --- Comment #24 from Jared Camins-Esakov --- This no longer applies. Please rebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #23 from Katrin Fischer --- Created attachment 16121 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16121&action=edit [PASSED QA] Bug 8365: Add unit tests and fix QA issues This patch adds some unit tests for CalcDateDue and GetLoanLength Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer All tests and QA script pass. Tests done: - Checked update works correctly for existing circulation rules. - Adding, deleting and overwriting circulation rules works. - Renewals work for different circulation rules and changes to the holiday calendar. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Katrin Fischer changed: What|Removed |Added Attachment #15360|0 |1 is obsolete|| Attachment #15361|0 |1 is obsolete|| --- Comment #22 from Katrin Fischer --- Created attachment 16120 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16120&action=edit [PASSED QA] Bug 8365: Add a renewal duration in the issuing rules Renew an issue for a number of days (filled in the issuing rules). Test if rules work for any i[item]types and if there is no regression. - new column issuingrules.renewalperiod - remove all occurrences of an already removed syspref (globalDueDate) - remove an unused routine (Overdues::GetIssuingRules) How it works: - On existing installations, the issuingrules.renewalperiod = issuingrules.loanlength. So the behaviour is the same before and after this patch. - when you add a rule, you can choose a renewal period (the unit value is the issuingrules.unit). So you can have a renewal period in hours or days. - The default value for the renewal period is 21 days (same as loanlength) Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Test comments on second patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #21 from Jonathan Druart --- (In reply to comment #20) > Hi Jonathan, > the new unit tests don't pass the QA script - can you take a look please? > But I will continue testing :) > > * t/db_dependent/Circulation_issuingrules.tFAIL > pod OK > forbidden patterns OK > valid OK > critic FAIL > Code before strictures are enabled at line 11, column 1. See page 429 of PBP. It is caused by the "use Modern::Perl;". You should add to your ~/.perlcriticrc : [TestingAndDebugging::RequireUseWarnings] equivalent_modules = Modern::Perl [TestingAndDebugging::RequireUseStrict] equivalent_modules = Modern::Perl Take a look at the perlcriticrc file present in the qa-tools repository. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #20 from Katrin Fischer --- Hi Jonathan, the new unit tests don't pass the QA script - can you take a look please? But I will continue testing :) * t/db_dependent/Circulation_issuingrules.tFAIL pod OK forbidden patterns OK valid OK critic FAIL Code before strictures are enabled at line 11, column 1. See page 429 of PBP. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #19 from Kyle M Hall --- Created attachment 15361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15361&action=edit Bug 8365: Add unit tests and fix QA issues This patch adds some unit tests for CalcDateDue and GetLoanLength Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Kyle M Hall changed: What|Removed |Added Attachment #15301|0 |1 is obsolete|| Attachment #15303|0 |1 is obsolete|| --- Comment #18 from Kyle M Hall --- Created attachment 15360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15360&action=edit Bug 8365: Add a renewal duration in the issuing rules Renew an issue for a number of days (filled in the issuing rules). Test if rules work for any i[item]types and if there is no regression. - new column issuingrules.renewalperiod - remove all occurrences of an already removed syspref (globalDueDate) - remove an unused routine (Overdues::GetIssuingRules) How it works: - On existing installations, the issuingrules.renewalperiod = issuingrules.loanlength. So the behaviour is the same before and after this patch. - when you add a rule, you can choose a renewal period (the unit value is the issuingrules.unit). So you can have a renewal period in hours or days. - The default value for the renewal period is 21 days (same as loanlength) Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #17 from Jonathan Druart --- (In reply to comment #15) > Hi Jonathan, thx for taking my comments into account! The follow up looks > good to me, but I think the commit message belongs to another patch? Hi Katrin, In fact I forgot to add the new file :-/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Jonathan Druart changed: What|Removed |Added Attachment #15302|0 |1 is obsolete|| --- Comment #16 from Jonathan Druart --- Created attachment 15303 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15303&action=edit Bug 8365: Add unit tests and fix QA issues This patch adds some unit tests for CalcDateDue and GetLoanLength -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #15 from Katrin Fischer --- Hi Jonathan, thx for taking my comments into account! The follow up looks good to me, but I think the commit message belongs to another patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Needs Signoff --- Comment #14 from Jonathan Druart --- I switch back to needs signoff, I made some modifications into the CalcDateDue routine (in my second patch). The main modification is I removed the return statement (return $dt) when the syspref useDaysMode eq 'Days'. I think we want to check the ReturnBeforeExpiry syspref value in all cases. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #13 from Jonathan Druart --- Created attachment 15302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15302&action=edit Bug 8365: Add unit tests This patch adds some unit tests for CalcDateDue and GetLoanLength -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Jonathan Druart changed: What|Removed |Added Attachment #15300|0 |1 is obsolete|| --- Comment #12 from Jonathan Druart --- Created attachment 15301 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15301&action=edit Bug 8365: Add a renewal duration in the issuing rules Renew an issue for a number of days (filled in the issuing rules). Test if rules work for any i[item]types and if there is no regression. - new column issuingrules.renewalperiod - remove all occurrences of an already removed syspref (globalDueDate) - remove an unused routine (Overdues::GetIssuingRules) How it works: - On existing installations, the issuingrules.renewalperiod = issuingrules.loanlength. So the behaviour is the same before and after this patch. - when you add a rule, you can choose a renewal period (the unit value is the issuingrules.unit). So you can have a renewal period in hours or days. - The default value for the renewal period is 21 days (same as loanlength) Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Jonathan Druart changed: What|Removed |Added Attachment #14142|0 |1 is obsolete|| --- Comment #11 from Jonathan Druart --- Created attachment 15300 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15300&action=edit Bug 8365: Add unit tests This patch adds some unit tests for CalcDateDue and GetLoanLength -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #10 from Katrin Fischer --- I learned that iff is not a typo, so ignore that :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #9 from Katrin Fischer --- Hi Jonathan, I read through your code and have some questions, mostly about documentation: 1) I was wondering if this line in the POD for CanBookBeRenewed makes sense: C<$dbh> is a DBI handle to the Koha database. Just a note, little typo a few lines below: C<$CanBookBeRenewed> returns a true value _iff_ the item may be renewed. The ... 2) POD for CalcDateDue misses $isrenewal 3) In the circulation matrix the new field is named "Renewals period" - "Renewal period" looks a bit better to me, but we are both not native speakers, so I will leave that to someone else. :) I also ran the test suite - so far it looks good. I will continue with testing the interface next. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de QA Contact||katrin.fisc...@bsz-bw.de --- Comment #8 from Katrin Fischer --- Hi Jonathan, I have started testing this - could you please add some unit tests in a follow up for the changed routines? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Kyle M Hall changed: What|Removed |Added Attachment #13972|0 |1 is obsolete|| --- Comment #7 from Kyle M Hall --- Created attachment 14142 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14142&action=edit [SIGNED-OFF] Bug 8365: Add a renewal duration in the issuing rules Renew an issue for a number of days (filled in the issuing rules). Test if rules work for any i[item]types and if there is no regression. - new column issuingrules.renewalperiod - remove all occurrences of an already removed syspref (globalDueDate) - remove an unused routine (Overdues::GetIssuingRules) How it works: - On existing installations, the issuingrules.renewalperiod = issuingrules.loanlength. So the behaviour is the same before and after this patch. - when you add a rule, you can choose a renewal period (the unit value is the issuingrules.unit). So you can have a renewal period in hours or days. - The default value for the renewal period is 21 days (same as loanlength) Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Jonathan Druart changed: What|Removed |Added Attachment #12374|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart --- Created attachment 13972 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13972&action=edit Bug 8365: Add a renewal duration in the issuing rules Renew an issue for a number of days (filled in the issuing rules). Test if rules work for any i[item]types and if there is no regression. - new column issuingrules.renewalperiod - remove all occurrences of an already removed syspref (globalDueDate) - remove an unused routine (Overdues::GetIssuingRules) How it works: - On existing installations, the issuingrules.renewalperiod = issuingrules.loanlength. So the behaviour is the same before and after this patch. - when you add a rule, you can choose a renewal period (the unit value is the issuingrules.unit). So you can have a renewal period in hours or days. - The default value for the renewal period is 21 days (same as loanlength) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||k...@bywatersolutions.com Patch complexity|--- |Medium patch --- Comment #5 from Kyle M Hall --- Large merge conflict in C4/Circulation.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #4 from Jonathan Druart --- (In reply to comment #2) Hello Owen, Thanks for your question. It permits me to improve this patch :) > How is the renewal date calculated if the renewals period is set to zero (as > it will be when the feature is added on top of an existing installation) ? A new query is added to the updatedatabase. It set the renewalperiod field with the issuelength value. > Shouldn't this feature accommodate renewal periods in hours or days? How can > a library set a renewal period if their loan period is in hours? Now it is possible, the renewalperiod unit is based on the unit value (days or hours) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Jonathan Druart changed: What|Removed |Added Attachment #12054|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 12374 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12374&action=edit Bug 8365: Add a renewal duration in the issuing rules Renew an issue for a number of days (filled in the issuing rules). Test if rules work for any i[item]types and if there is no regression. - new column issuingrules.renewalperiod - remove all occurrences of an already removed syspref (globalDueDate) - remove an unused routine (Overdues::GetIssuingRules) How it works: - On existing installations, the issuingrules.renewalperiod = issuingrules.loanlength. So the behaviour is the same before and after this patch. - when you add a rule, you can choose a renewal period (the unit value is the issuingrules.unit). So you can have a renewal period in hours or days. - The default value for the renewal period is 21 days (same as loanlength) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #2 from Owen Leonard --- How is the renewal date calculated if the renewals period is set to zero (as it will be when the feature is added on top of an existing installation) ? Shouldn't this feature accommodate renewal periods in hours or days? How can a library set a renewal period if their loan period is in hours? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff CC||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #1 from Jonathan Druart --- Created attachment 12054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12054&action=edit Bug 8365: Add a renewal duration in the issuing rules Renew an issue for a number of days (filled in the issuing rules). Test if rules work for any i[item]types and if there is no regression. - new column issuingrules.renewalperiod - remove all occurrences of an already removed syspref (globalDueDate) - remove an unused routine (Overdues::GetIssuingRules) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 claire.hernan...@biblibre.com changed: What|Removed |Added CC||claire.hernandez@biblibre.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Paul Poulain changed: What|Removed |Added Blocks||8362 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
