[Koha-bugs] [Bug 8379] Encoding problem under Plack

2012-07-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8379

--- Comment #1 from Dobrica Pavlinusic  ---
Reloading plack shouldn't make a difference, but I'm wondering did you made
Z39.50 search before encoding got confused? Or anything which touches C
libraries?

We are doing way too much encoding magic as seen in

Bug 6554 - added session CGI queries and all ZebraPAR utf8_decode

I would love to have reproducible problem, so we can track it down.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8379] Encoding problem under Plack

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8379

--- Comment #2 from Paul Poulain  ---
(In reply to comment #1)
> Reloading plack shouldn't make a difference, but I'm wondering did you made
> Z39.50 search before encoding got confused? Or anything which touches C
> libraries?
I don't remember.

I just tried to reproduce the error by searching z3950, playing with addbiblio
again, and could not reproduce the issue :(

I'll add a comment if I have the problem again.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8379] Encoding problem under Plack

2012-08-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8379

--- Comment #3 from Paul Poulain  ---
I got the problem twice today. There was something common to both problems : I
was playing with cataloguing framework.
The 1st time I created a framework by duplicating a default one, then tried to
edit item subfields

The 2nd time, I was just editing item (995 for UNIMARC) for default framework
(to test bug 8524)

Maybe that's a step that should be investigated...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8379] Encoding problem under Plack

2012-08-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8379

--- Comment #4 from Paul Poulain  ---
Additionnal comment : plack logs says:
DBD::mysql::db selectall_arrayref failed: MySQL server has gone away at
/home/paul/koha.dev/koha-community/C4/VirtualShelves.pm line 210.

When it becomes broken. And my changes in the framework aren't visible plack is
restarted. Maybe that's related to caching ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8379] Encoding problem under Plack

2012-09-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8379

Paul Poulain  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

--- Comment #5 from Paul Poulain  ---
OK, i've found where the problem comes from = $dbh connection is closed by
marc_subfield_structure.pl, and that's where the problem comes from.
attaching a patch that fixes the problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8379] Encoding problem under Plack

2012-09-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8379

--- Comment #6 from Paul Poulain  ---
Created attachment 12488
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12488&action=edit
Bug 8379 don't close dbh

don't close the DBH handler, because under plack this cause a lot of problem
and in CGI mode, closing the dbh handler is useless

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8379] Encoding problem under Plack

2012-09-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8379

--- Comment #7 from Paul Poulain  ---
OK, i've found where the problem comes from = $dbh connection is closed by
marc_subfield_structure.pl, and that's where the problem comes from.
attaching a patch that fixes the problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8379] Encoding problem under Plack

2012-09-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8379

--- Comment #8 from Paul Poulain  ---
how to test:
 * define a library and/or an itemtype with a diacritic in the name
 * before the patch = if you search/edit a marc subfield structure, you'll get
diacritic badly broken. and a "mysql has gone away" in plack logs
 * after the patch = no more problem

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8379] Encoding problem under Plack

2012-09-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8379

--- Comment #9 from Paul Poulain  ---
Created attachment 12489
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12489&action=edit
Bug 8379 removing another useless ->disconnect line

and s/tab/spaces/

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8379] Encoding problem under Plack

2012-09-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8379

--- Comment #10 from Paul Poulain  ---
I've grepped for disconnect, and found another one. There's no more, except in
some misc/cronjob scripts. Plack is not concerned by those, so no need to fix
anything

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8379] Encoding problem under Plack

2012-09-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8379

Paul Poulain  changed:

   What|Removed |Added

   Priority|P5 - low|P1 - high
   Severity|enhancement |critical

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8379] Encoding problem under Plack

2012-09-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8379

--- Comment #11 from Dobrica Pavlinusic  ---
Created attachment 12495
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12495&action=edit
Bug 8379 removing another useless ->disconnect line

and s/tab/spaces/

Signed-off-by: Dobrica Pavlinusic 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8379] Encoding problem under Plack

2012-09-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8379

Dobrica Pavlinusic  changed:

   What|Removed |Added

  Attachment #12488|0   |1
is obsolete||
  Attachment #12489|0   |1
is obsolete||

--- Comment #12 from Dobrica Pavlinusic  ---
Created attachment 12496
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12496&action=edit
Bug 8379 don't close dbh

don't close the DBH handler, because under plack this cause a lot of problem
and in CGI mode, closing the dbh handler is useless

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8379] Encoding problem under Plack

2012-09-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8379

Dobrica Pavlinusic  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #13 from Dobrica Pavlinusic  ---
This is great news, good work Paul!

I attached signed-off patches in reverse order, but it shouldn't matter because
they are independent.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8379] Encoding problem under Plack

2012-09-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8379

Dobrica Pavlinusic  changed:

   What|Removed |Added

  Attachment #12496|0   |1
is obsolete||

--- Comment #14 from Dobrica Pavlinusic  ---
Created attachment 12497
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12497&action=edit
Bug 8379 don't close dbh

don't close the DBH handler, because under plack this cause a lot of problem
and in CGI mode, closing the dbh handler is useless

Signed-off-by: Dobrica Pavlinusic 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8379] Encoding problem under Plack

2012-10-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8379

Mason James  changed:

   What|Removed |Added

 Blocks||8866

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8379] Encoding problem under Plack

2012-10-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8379

Mason James  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||m...@kohaaloha.com

--- Comment #15 from Mason James  ---
> Signed-off-by: Dobrica Pavlinusic 

passing QA on 2 patches, good spotting!

$ koha-qa.pl -c 2

testing 2 commit(s) (applied to commit 0a35b26)
 * 268f89b Bug 8379 don't close dbh
  admin/marc_subfields_structure.pl

 * fcc89e7 Bug 8379 removing another useless ->disconnect line
  admin/z3950servers.pl

* admin/marc_subfields_structure.plOK
* admin/z3950servers.plOK
mason@xen1:~/g/head$

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8379] Encoding problem under Plack

2012-10-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8379

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
Version|master  |rel_3_8

--- Comment #16 from Paul Poulain  ---
Patch pushed to master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8379] Encoding problem under Plack

2012-10-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8379

Chris Cormack  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||ch...@bigballofwax.co.nz

--- Comment #17 from Chris Cormack  ---
Pushed to 3.8.x, will be in 3.8.6

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/